91065 2012-07-12 02:54:56 -0700 [EFL][WK2] Browser crashes running BatteryStatus tests. 2012-07-12 06:44:44 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis cdumez gyuyoung.kim lucas.de.marchi webkit.review.bot oldest_to_newest 667573 0 naginenis 2012-07-12 02:54:56 -0700 Here is the backtrace: #0 0x00007f27acbfdd2e in WebCore::BatteryStatus::level (this=0x48535441e5894855) at WebKit/Source/WebCore/Modules/battery/BatteryStatus.h:38 38 double level() const { return m_level; } (gdb) bt #0 0x00007f27acbfdd2e in WebCore::BatteryStatus::level (this=0x48535441e5894855) at WebKit/Source/WebCore/Modules/battery/BatteryStatus.h:38 #1 0x00007f27acbfdbe5 in BatteryProvider::didChangeBatteryStatus (this=0x1030cd0, eventType="䡕荈წ襈譈譈꼕⻙䠀劍䠐ႉ譈荈ダ襈≸￦譈荈ダ襈≸￦譈荈⣀襈≸￦譈荈\340\243\200襈≸￦¸\000茀Ǡ삄\340\261\264譈襈≰￦쏉䡕荈წ襈譈襈≦￦譈襈≊￦쏉䡕䡓䠘綉䣨疉뿠\302\220\000䷨䣿쎉譈襈䣆�䯨䣿䖋䣨�襈≌￦譈荈\341\243\204嵛郃䡕荈レ襈�襈큵譈�荈\340\243\200襈∰￦譈�襈∴￦譈�譈ꤕ⻘䠀劍䠐ႉ譈�赈⡐譈큅襈䣆힉\341\257\250䣿䖋䣘喋䣘슃䠰욉襈∔￦荈큽甀䠻ඍʡ\034赈꼕ᰃ븀C\000赈ꌽᰂ黎￡�黤￡궾잻\000\000렀\000\000"..., status=...) at WebKit/Source/WebKit2/UIProcess/API/efl/BatteryProvider.cpp:90 #2 0x00007f27acbfd95b in startUpdatingCallback (batteryManager=0x102ff60, clientInfo=0x1030cd0) at WebKit/Source/WebKit2/UIProcess/API/efl/BatteryProvider.cpp:45 #3 0x00007f27acac4655 in WebKit::WebBatteryProvider::startUpdating (this=0x102ff78, batteryManager=0x102ff60) at WebKit/Source/WebKit2/UIProcess/WebBatteryProvider.cpp:41 #4 0x00007f27acac3ec5 in WebKit::WebBatteryManagerProxy::startUpdating (this=0x102ff60) at WebKit/Source/WebKit2/UIProcess/WebBatteryManagerProxy.cpp:71 #5 0x00007f27acc1731f in CoreIPC::callMemberFunction<WebKit::WebBatteryManagerProxy, void (WebKit::WebBatteryManagerProxy::*)()> (object=0x102ff60, function= (void (WebKit::WebBatteryManagerProxy::*)(WebKit::WebBatteryManagerProxy * const)) 0x7f27acac3e96 <WebKit::WebBatteryManagerProxy::startUpdating()>) at WebKit/Source/WebKit2/Platform/CoreIPC/HandleMessage.h:13 #6 0x00007f27acc17276 in CoreIPC::handleMessage<Messages::WebBatteryManagerProxy::StartUpdating, WebKit::WebBatteryManagerProxy, void (WebKit::WebBatteryManagerProxy::*)()> (argumentDecoder= 0x7f2748000970, object=0x102ff60, function=(void (WebKit::WebBatteryManagerProxy::*)(WebKit::WebBatteryManagerProxy * const)) 0x7f27acac3e96 <WebKit::WebBatteryManagerProxy::startUpdating()>) at WebKit/Source/WebKit2/Platform/CoreIPC/HandleMessage.h:302 #7 0x00007f27acc17155 in WebKit::WebBatteryManagerProxy::didReceiveWebBatteryManagerProxyMessage (this=0x102ff60, messageID=..., arguments=0x7f2748000970) at WebKit/WebKitBuild/Debug/DerivedSources/WebKit2/WebBatteryManagerProxyMessageReceiver.cpp:41 #8 0x00007f27acac3e94 in WebKit::WebBatteryManagerProxy::didReceiveMessage (this=0x102ff60, connection=0x100b060, messageID=..., arguments=0x7f2748000970) at WebKit/Source/WebKit2/UIProcess/WebBatteryManagerProxy.cpp:63 #9 0x00007f27acacc73c in WebKit::WebContext::didReceiveMessage (this=0x102f3d0, connection=0x100b060, messageID=..., arguments=0x7f2748000970) at WebKit/Source/WebKit2/UIProcess/WebContext.cpp:766 #10 0x00007f27acb37224 in WebKit::WebProcessProxy::didReceiveMessage (this=0x1033390, connection=0x100b060, messageID=..., arguments=0x7f2748000970) at WebKit/Source/WebKit2/UIProcess/WebProcessProxy.cpp:327 #11 0x00007f27acac4acf in WebKit::WebConnectionToWebProcess::didReceiveMessage (this=0x100b010, connection=0x100b060, messageID=..., arguments=0x7f2748000970) at WebKit/Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:92 #12 0x00007f27aca703ab in CoreIPC::Connection::dispatchMessage (this=0x100b060, message=...) at WebKit/Source/WebKit2/Platform/CoreIPC/Connection.cpp:691 #13 0x00007f27aca70549 in CoreIPC::Connection::dispatchOneMessage (this=0x100b060) at WebKit/Source/WebKit2/Platform/CoreIPC/Connection.cpp:717 #14 0x00007f27aca7a43c in WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>::operator() (this=0x7f2748000b10, c=0x100b060) at WebKit/Source/WTF/wtf/Functional.h:173 #15 0x00007f27aca7a242 in WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>, void (CoreIPC::Connection*)>::operator()() (this=0x7f2748000b00) at WebKit/Source/WTF/wtf/Functional.h:405 #16 0x00007f27acbcac12 in WTF::Function<void ()>::operator()() const (this=0x7fff97ec9080) at WebKit/Source/WTF/wtf/Functional.h:613 #17 0x00007f27a7b44f63 in WebCore::RunLoop::performWork (this=0x1012120) at WebKit/Source/WebCore/platform/RunLoop.cpp:87 #18 0x00007f27a853368f in WebCore::RunLoop::wakeUpEvent (data=0x1012120) at WebKit/Source/WebCore/platform/efl/RunLoopEfl.cpp:100 #19 0x00007f27acff1061 in _ecore_pipe_read (data=0xfc3750, fd_handler=<optimized out>) at ecore_pipe.c:625 #20 0x00007f27acff0131 in _ecore_call_fd_cb (data=<optimized out>, func=<optimized out>, fd_handler=0xfc3e50) at ecore_private.h:343 #21 _ecore_main_fd_handlers_call () at ecore_main.c:1562 #22 _ecore_main_loop_iterate_internal (once_only=0) at ecore_main.c:1809 #23 0x00007f27acff0677 in ecore_main_loop_begin () at ecore_main.c:931 #24 0x0000000000401db3 in main (argc=2, argv=0x7fff97ec92c8) at WebKit/Tools/MiniBrowser/efl/main.c:201 667640 1 151915 naginenis 2012-07-12 05:09:48 -0700 Created attachment 151915 Patch Patch fixes incorrect casting of clientInfo to BatteryProviderEfl. 667650 2 cdumez 2012-07-12 05:18:26 -0700 LGTM. Thanks for the fix, this is high priority. Let's land it ASAP. 667689 3 151915 haraken 2012-07-12 06:03:54 -0700 Comment on attachment 151915 Patch LGTM, mainly relying on Christophe's LGTM. 667729 4 151915 webkit.review.bot 2012-07-12 06:44:39 -0700 Comment on attachment 151915 Patch Clearing flags on attachment: 151915 Committed r122453: <http://trac.webkit.org/changeset/122453> 667730 5 webkit.review.bot 2012-07-12 06:44:44 -0700 All reviewed patches have been landed. Closing bug. 151915 2012-07-12 05:09:48 -0700 2012-07-12 06:44:39 -0700 Patch 91065.patch text/plain 1508 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlOTFiOTg5Li5hNTEyNzYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDctMTIgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBCcm93c2VyIGNyYXNoZXMgcnVu bmluZyBCYXR0ZXJ5U3RhdHVzIHRlc3RzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTEwNjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBjbGllbnRJbmZvIHdhcyBpbmNvcnJlY3RseSBjYXN0ZWQgdG8gQmF0 dGVyeVByb3ZpZGVyRWZsIGluIGhlbHBlcgorICAgICAgICBmdW5jdGlvbi4gVGhpcyBwYXRjaCBm aXhlcyB0aGUgaXNzdWUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9CYXR0ZXJ5UHJv dmlkZXIuY3BwOgorICAgICAgICAodG9CYXR0ZXJ5UHJvdmlkZXIpOgorCiAyMDEyLTA3LTExICBB bmRyYXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAbm9raWEuY29tPgogCiAgICAgICAgIFtRdF1bV0sy XSBBU1NFUlQ6ICIhbV92aWV3cG9ydEl0ZW0tPmlzTW92aW5nKCkiIGluIFF0Vmlld3BvcnRIYW5k bGVyOjpmbGlja01vdmVFbmRlZCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9CYXR0ZXJ5UHJvdmlkZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvQmF0dGVyeVByb3ZpZGVyLmNwcAppbmRleCAyYmQ1NWUyLi4xOGM5ZTE0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9CYXR0ZXJ5UHJvdmlkZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0JhdHRlcnlQcm92aWRl ci5jcHAKQEAgLTM1LDkgKzM1LDkgQEAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogdXNpbmcg bmFtZXNwYWNlIFdlYktpdDsKIAotc3RhdGljIGlubGluZSBCYXR0ZXJ5UHJvdmlkZXJFZmwqIHRv QmF0dGVyeVByb3ZpZGVyKGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCitzdGF0aWMgaW5saW5lIEJh dHRlcnlQcm92aWRlciogdG9CYXR0ZXJ5UHJvdmlkZXIoY29uc3Qgdm9pZCogY2xpZW50SW5mbykK IHsKLSAgICByZXR1cm4gc3RhdGljX2Nhc3Q8QmF0dGVyeVByb3ZpZGVyRWZsKj4oY29uc3RfY2Fz dDx2b2lkKj4oY2xpZW50SW5mbykpOworICAgIHJldHVybiBzdGF0aWNfY2FzdDxCYXR0ZXJ5UHJv dmlkZXIqPihjb25zdF9jYXN0PHZvaWQqPihjbGllbnRJbmZvKSk7CiB9CiAKIHN0YXRpYyB2b2lk IHN0YXJ0VXBkYXRpbmdDYWxsYmFjayhXS0JhdHRlcnlNYW5hZ2VyUmVmIGJhdHRlcnlNYW5hZ2Vy LCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQo=