91055 2012-07-12 00:58:24 -0700 [Shadow DOM] <video> with <shadow> crashes 2012-07-12 17:39:33 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 morrita morrita dglazkov eric.carlson feature-media-reviews tkent webkit.review.bot oldest_to_newest 667482 0 morrita 2012-07-12 00:58:24 -0700 This is upstream of http://code.google.com/p/chromium/issues/detail?id=136952 667488 1 151878 morrita 2012-07-12 01:07:38 -0700 Created attachment 151878 Patch 667490 2 morrita 2012-07-12 01:08:08 -0700 Kent-san, could you take a look? 667520 3 151878 tkent 2012-07-12 01:38:45 -0700 Comment on attachment 151878 Patch Looks ok. 667545 4 151878 webkit.review.bot 2012-07-12 02:11:35 -0700 Comment on attachment 151878 Patch Clearing flags on attachment: 151878 Committed r122432: <http://trac.webkit.org/changeset/122432> 667546 5 webkit.review.bot 2012-07-12 02:11:40 -0700 All reviewed patches have been landed. Closing bug. 667756 6 151878 eric.carlson 2012-07-12 07:42:44 -0700 Comment on attachment 151878 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151878&action=review > Source/WebCore/ChangeLog:11 > + This change adds a guard for such case by cheking whether the Typo: "cheking" should be "checking". > Source/WebCore/html/HTMLMediaElement.cpp:495 > + // Only allows nodes from the controls shadow subtree. > + return (mediaControls()->treeScope() == childContext.node()->treeScope() > + && childContext.isOnUpperEncapsulationBoundary() && HTMLElement::childShouldCreateRenderer(childContext)); "Only allows nodes from the controls shadow subtree" tells me what the code does but now why. Why are non-shadow child nodes not allowed to create a renderer? 668448 7 morrita 2012-07-12 17:39:33 -0700 (In reply to comment #6) > (From update of attachment 151878 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151878&action=review > > > Source/WebCore/ChangeLog:11 > > + This change adds a guard for such case by cheking whether the > > Typo: "cheking" should be "checking". > > > Source/WebCore/html/HTMLMediaElement.cpp:495 > > + // Only allows nodes from the controls shadow subtree. > > + return (mediaControls()->treeScope() == childContext.node()->treeScope() > > + && childContext.isOnUpperEncapsulationBoundary() && HTMLElement::childShouldCreateRenderer(childContext)); > > "Only allows nodes from the controls shadow subtree" tells me what the code does but now why. > > Why are non-shadow child nodes not allowed to create a renderer? Good point. I'll (In reply to comment #6) > (From update of attachment 151878 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151878&action=review > > > Source/WebCore/ChangeLog:11 > > + This change adds a guard for such case by cheking whether the > > Typo: "cheking" should be "checking". > > > Source/WebCore/html/HTMLMediaElement.cpp:495 > > + // Only allows nodes from the controls shadow subtree. > > + return (mediaControls()->treeScope() == childContext.node()->treeScope() > > + && childContext.isOnUpperEncapsulationBoundary() && HTMLElement::childShouldCreateRenderer(childContext)); > > "Only allows nodes from the controls shadow subtree" tells me what the code does but now why. > > Why are non-shadow child nodes not allowed to create a renderer? Good point. I'll clarify it on Bug 91174. 151878 2012-07-12 01:07:38 -0700 2012-07-12 07:42:44 -0700 Patch bug-91055-20120712170737.patch text/plain 5761 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzZiNjA2YmJkMmFiZTk2 YzkzMjI1NmU1YjNkNDhmNjNlZDkxMTg5Yy4uYzNmOGU2M2NjNmZlOWNmMWViZjQxZWE5NDZkODJk NzIyMjEwZDE0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA3LTEyICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIFtTaGFkb3cgRE9NXSA8 dmlkZW8+IHdpdGggPHNoYWRvdz4gY3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTEwNTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIHNpbWlsYXIgdG8gQnVnIDkwNDgwLCB3aGVyZSBh biB1bmRlc2lyZWQgcmVuZGVyZXIgaXMgY3JlYXRlZCBieQorICAgICAgICBsb2NhdGluZyBhbiBp bnNlcnRpb24gcG9pbnQgb24gdGhlIHNoYWRvdyBib3VuZGFyeS4KKworICAgICAgICBUaGlzIGNo YW5nZSBhZGRzIGEgZ3VhcmQgZm9yIHN1Y2ggY2FzZSBieSBjaGVraW5nIHdoZXRoZXIgdGhlCisg ICAgICAgIHNvdXJjZSBub2RlIG9mIGVhY2ggdG8tYmUtY3JlYXRlZCByZW5kZXJlciBjb21lcyBm cm9tIHRoZSBVQSBzaGFkb3cKKyAgICAgICAgdHJlZSwgd2hpY2ggaXMgYWxsb3dlZCB0byBoYXZl IGEgcmVuZGVyZXIuCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vc2hhZG93L2luc2VydGlvbi1w b2ludC12aWRlby1jcmFzaC5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6Y2hpbGRTaG91bGRDcmVh dGVSZW5kZXJlcik6IEFkZGVkIGEgY2hlY2suCisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFF bGVtZW50OjptZWRpYUNvbnRyb2xzKTogQWRkZWQgY29uc3QuCisgICAgICAgIChXZWJDb3JlOjpI VE1MTWVkaWFFbGVtZW50OjpoYXNNZWRpYUNvbnRyb2xzKTogQWRkZWQgY29uc3QuCisgICAgICAg ICogaHRtbC9IVE1MTWVkaWFFbGVtZW50Lmg6CisgICAgICAgIChIVE1MTWVkaWFFbGVtZW50KToK KwogMjAxMi0wNy0xMSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgRG8gbm90IHNhdmUgc3RhdGUgb2Ygc3RhdGVsZXNzIGZvcm0gY29udHJvbHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCmluZGV4IGZkZGM0Mjg5M2ViZDAwM2UwYTU1 ZGRiN2YyYzg3NTg2NWU3YTk0N2YuLmJjMWE5ZTYyZWQ3ZGI1ZGFmOTAyMTI0Mzg5NjQwMTdiYWJm MDAwZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcApAQCAtNDg4 LDcgKzQ4OCwxMSBAQCBSZW5kZXJPYmplY3QqIEhUTUxNZWRpYUVsZW1lbnQ6OmNyZWF0ZVJlbmRl cmVyKFJlbmRlckFyZW5hKiBhcmVuYSwgUmVuZGVyU3R5bGUqKQogCiBib29sIEhUTUxNZWRpYUVs ZW1lbnQ6OmNoaWxkU2hvdWxkQ3JlYXRlUmVuZGVyZXIoY29uc3QgTm9kZVJlbmRlcmluZ0NvbnRl eHQmIGNoaWxkQ29udGV4dCkgY29uc3QKIHsKLSAgICByZXR1cm4gY2hpbGRDb250ZXh0LmlzT25V cHBlckVuY2Fwc3VsYXRpb25Cb3VuZGFyeSgpICYmIEhUTUxFbGVtZW50OjpjaGlsZFNob3VsZENy ZWF0ZVJlbmRlcmVyKGNoaWxkQ29udGV4dCk7CisgICAgaWYgKCFoYXNNZWRpYUNvbnRyb2xzKCkp CisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAvLyBPbmx5IGFsbG93cyBub2RlcyBmcm9tIHRo ZSBjb250cm9scyBzaGFkb3cgc3VidHJlZS4KKyAgICByZXR1cm4gKG1lZGlhQ29udHJvbHMoKS0+ dHJlZVNjb3BlKCkgPT0gY2hpbGRDb250ZXh0Lm5vZGUoKS0+dHJlZVNjb3BlKCkKKyAgICAgICAg ICAgICYmIGNoaWxkQ29udGV4dC5pc09uVXBwZXJFbmNhcHN1bGF0aW9uQm91bmRhcnkoKSAmJiBI VE1MRWxlbWVudDo6Y2hpbGRTaG91bGRDcmVhdGVSZW5kZXJlcihjaGlsZENvbnRleHQpKTsKIH0K IAogTm9kZTo6SW5zZXJ0aW9uTm90aWZpY2F0aW9uUmVxdWVzdCBIVE1MTWVkaWFFbGVtZW50Ojpp bnNlcnRlZEludG8oQ29udGFpbmVyTm9kZSogaW5zZXJ0aW9uUG9pbnQpCkBAIC00MTQyLDEyICs0 MTQ2LDEyIEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6cHJpdmF0ZUJyb3dzaW5nU3RhdGVEaWRD aGFuZ2UoKQogICAgIG1fcGxheWVyLT5zZXRQcml2YXRlQnJvd3NpbmdNb2RlKHByaXZhdGVNb2Rl KTsKIH0KIAotTWVkaWFDb250cm9scyogSFRNTE1lZGlhRWxlbWVudDo6bWVkaWFDb250cm9scygp CitNZWRpYUNvbnRyb2xzKiBIVE1MTWVkaWFFbGVtZW50OjptZWRpYUNvbnRyb2xzKCkgY29uc3QK IHsKICAgICByZXR1cm4gdG9NZWRpYUNvbnRyb2xzKHNoYWRvdygpLT5vbGRlc3RTaGFkb3dSb290 KCktPmZpcnN0Q2hpbGQoKSk7CiB9CiAKLWJvb2wgSFRNTE1lZGlhRWxlbWVudDo6aGFzTWVkaWFD b250cm9scygpCitib29sIEhUTUxNZWRpYUVsZW1lbnQ6Omhhc01lZGlhQ29udHJvbHMoKSBjb25z dAogewogICAgIEVsZW1lbnRTaGFkb3cqIGVsZW1lbnRTaGFkb3cgPSBzaGFkb3coKTsKICAgICBp ZiAoIWVsZW1lbnRTaGFkb3cpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxN ZWRpYUVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCmlu ZGV4IDQwMTVhMmY4NmYwNTk1NmU2ZTYzNmQxYTg2NjlhMmI4Yjg4MTgyMjcuLjgyZjZiNzViZDU2 ZDQyYTQ3N2NkZDM5MDM3MTRiZmNjYzZkYmZhN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1l ZGlhRWxlbWVudC5oCkBAIC0yOTEsNyArMjkxLDcgQEAgcHVibGljOgogICAgIGJvb2wgY2xvc2Vk Q2FwdGlvbnNWaXNpYmxlKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRDbG9zZWRDYXB0aW9uc1Zpc2li bGUoYm9vbCk7CiAKLSAgICBNZWRpYUNvbnRyb2xzKiBtZWRpYUNvbnRyb2xzKCk7CisgICAgTWVk aWFDb250cm9scyogbWVkaWFDb250cm9scygpIGNvbnN0OwogCiAgICAgdm9pZCBzb3VyY2VXYXNS ZW1vdmVkKEhUTUxTb3VyY2VFbGVtZW50Kik7CiAgICAgdm9pZCBzb3VyY2VXYXNBZGRlZChIVE1M U291cmNlRWxlbWVudCopOwpAQCAtNTA4LDcgKzUwOCw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBp bnZhbGlkYXRlQ2FjaGVkVGltZSgpOwogICAgIHZvaWQgcmVmcmVzaENhY2hlZFRpbWUoKSBjb25z dDsKIAotICAgIGJvb2wgaGFzTWVkaWFDb250cm9scygpOworICAgIGJvb2wgaGFzTWVkaWFDb250 cm9scygpIGNvbnN0OwogICAgIGJvb2wgY3JlYXRlTWVkaWFDb250cm9scygpOwogICAgIHZvaWQg Y29uZmlndXJlTWVkaWFDb250cm9scygpOwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGQyNTY2MDcwZjY1ZThmNDBlYjg2 ZTc5MjVlYjAzYjE5MzMzZDU0Zi4uMDkzM2Q1NDM5NDVkMjAxNTcxZTQ3OGU1YzViZjRkNzRkY2M1 YzBlMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA3LTEyICBNT1JJVEEgSGFqaW1lICA8 bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIFtTaGFkb3cgRE9NXSA8dmlkZW8+IHdpdGgg PHNoYWRvdz4gY3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTEwNTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGZhc3QvZG9tL3NoYWRvdy9pbnNlcnRpb24tcG9pbnQtdmlkZW8tY3Jhc2gtZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9zaGFkb3cvaW5zZXJ0aW9uLXBv aW50LXZpZGVvLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA3LTExICBIYXlhdG8gSXRvICA8 aGF5YXRvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGdhcmRlbmluZy4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9pbnNlcnRpb24tcG9pbnQtdmlk ZW8tY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L2luc2Vy dGlvbi1wb2ludC12aWRlby1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDVlNzA2NzJh MmYwMDc1YjJlNzBjODE4NDcxMDgxYmJlY2Q4NGU2NwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9pbnNlcnRpb24tcG9pbnQtdmlkZW8tY3Jhc2gtZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEsMiBAQAorUEFTUyB1bmxlc3MgY3Jhc2gKKwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L2luc2VydGlvbi1wb2ludC12aWRlby1jcmFzaC5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L2luc2VydGlvbi1wb2ludC12aWRlby1j cmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLmFmMTIzZGI5YTM2OTE1NDRhMTczMDA5OTk4MzA2Zjk4OWI2 OWUwOWMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvaW5z ZXJ0aW9uLXBvaW50LXZpZGVvLWNyYXNoLmh0bWwKQEAgLTAsMCArMSwzMSBAQAorPCFET0NUWVBF IGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9q cy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3JpcHQ+Citqc1Rl c3RJc0FzeW5jID0gdHJ1ZTsKK2Z1bmN0aW9uIGJvb20oKSB7CisgICAgZGl2Tm9kZSA9IGRvY3Vt ZW50LmNyZWF0ZUVsZW1lbnQoJ2RpdicpOworICAgIGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5h cHBlbmRDaGlsZChkaXZOb2RlKTsKKyAgICBkaXZTaGFkb3cxID0gbmV3IFdlYktpdFNoYWRvd1Jv b3QoZGl2Tm9kZSk7CisgICAgZGl2U2hhZG93MiA9IG5ldyBXZWJLaXRTaGFkb3dSb290KGRpdk5v ZGUpOworICAgIAorICAgIHZpZGVvTm9kZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3ZpZGVv Jyk7CisgICAgZGl2U2hhZG93Mi5hcHBlbmRDaGlsZCh2aWRlb05vZGUpOworICAgIAorICAgIHNo YWRvd05vZGUgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdzaGFkb3cnKTsKKyAgICB2aWRlb05v ZGUuYXBwZW5kQ2hpbGQoc2hhZG93Tm9kZSk7CisgICAgCisgICAgdGV4dCA9IGRvY3VtZW50LmNy ZWF0ZVRleHROb2RlKCdIZWxsbycpOworICAgIGRpdlNoYWRvdzEuYXBwZW5kQ2hpbGQodGV4dCk7 CisKKyAgICB0ZXN0UGFzc2VkKCJ1bmxlc3MgY3Jhc2giKTsKKyAgICBmaW5pc2hKU1Rlc3QoKTsg ICAgCit9CisKK3dpbmRvdy5vbmxvYWQgPSBib29tOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0 bWw+Cg==