91049 2012-07-11 22:34:30 -0700 Remove dead code after r122392 2012-07-12 00:53:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P1 Blocker --- 90924 1 ossy ossy barraclough fpizlo ossy webkit.review.bot zherczeg oldest_to_newest 667405 0 ossy 2012-07-11 22:34:30 -0700 There are some dead code after http://trac.webkit.org/changeset/122392 causes build error with too strict GCC on Qt perf bots: /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp: In member function ‘void JSC::DFG::SpeculativeJIT::emitCall(JSC::DFG::Node&)’: /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:956:22: error: variable ‘slowCallFunction’ set but not used [-Werror=unused-but-set-variable] Patch is coming soon. 667409 1 151860 ossy 2012-07-11 22:38:54 -0700 Created attachment 151860 Patch 64 bit analogue of https://trac.webkit.org/changeset/122409/trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp 667476 2 151860 webkit.review.bot 2012-07-12 00:53:27 -0700 Comment on attachment 151860 Patch Clearing flags on attachment: 151860 Committed r122423: <http://trac.webkit.org/changeset/122423> 667477 3 webkit.review.bot 2012-07-12 00:53:31 -0700 All reviewed patches have been landed. Closing bug. 151860 2012-07-11 22:38:54 -0700 2012-07-12 00:53:27 -0700 Patch bug-91049-20120712073852.patch text/plain 1505 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi MjQ3NWZlYjlhZGE0NWU3MDQwZDQzN2Q2YmU0ZTc4OTVjZjc5ZmRjLi5lODFkOGM0M2FmNWFhMWUx MzUxMzNjZGVlYTA0NzcwOTljODlkNDA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMi0wNy0xMSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFJlbW92ZSBkZWFkIGNvZGUgYWZ0ZXIgcjEyMjM5Mi4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMDQ5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRp dmVKSVQ2NC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmVtaXRDYWxs KToKKwogMjAxMi0wNy0xMSAgQWRlbmlsc29uIENhdmFsY2FudGkgIDxjYXZhbGNhbnRpaUBnbWFp bC5jb20+CiAKICAgICAgICAgQnVpbGQgZml4ICsgcmVtb3ZlIGRlYWQgY29kZQpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAKaW5kZXggMGUw NDBmYjc0ZjdmMTMzNTE2MGNjNmU3NjczYzhhYmQ3M2U1MGQ2NC4uN2E5YzVjNWNkYzczMTFiNWNm ZWM2YTQzNWYzNDMwZjM1MThiZTBlOSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwCkBAIC05NTMsMTQgKzk1Myw4IEBAIHZvaWQgU3Bl Y3VsYXRpdmVKSVQ6Om5vblNwZWN1bGF0aXZlTm9uUGVlcGhvbGVTdHJpY3RFcShOb2RlJiBub2Rl LCBib29sIGludmVydCkKIAogdm9pZCBTcGVjdWxhdGl2ZUpJVDo6ZW1pdENhbGwoTm9kZSYgbm9k ZSkKIHsKLSAgICBQX0RGR09wZXJhdGlvbl9FIHNsb3dDYWxsRnVuY3Rpb247Ci0KLSAgICBpZiAo bm9kZS5vcCgpID09IENhbGwpCi0gICAgICAgIHNsb3dDYWxsRnVuY3Rpb24gPSBvcGVyYXRpb25M aW5rQ2FsbDsKLSAgICBlbHNlIHsKKyAgICBpZiAobm9kZS5vcCgpICE9IENhbGwpCiAgICAgICAg IEFTU0VSVChub2RlLm9wKCkgPT0gQ29uc3RydWN0KTsKLSAgICAgICAgc2xvd0NhbGxGdW5jdGlv biA9IG9wZXJhdGlvbkxpbmtDb25zdHJ1Y3Q7Ci0gICAgfQogCiAgICAgLy8gRm9yIGNvbnN0cnVj dG9ycywgdGhlIHRoaXMgYXJndW1lbnQgaXMgbm90IHBhc3NlZCBidXQgd2UgaGF2ZSB0byBtYWtl IHNwYWNlCiAgICAgLy8gZm9yIGl0Lgo=