91047 2012-07-11 21:27:05 -0700 Regression (r122359) Layout Test html5lib/runner.html is failing 2012-07-12 14:41:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hayato abarth abarth tony oldest_to_newest 667384 0 hayato 2012-07-11 21:27:05 -0700 The following layout test is failing (CRASH) on WebKit Win (dbg), Linux (dbg) and Mac (dbg) on canary. html5lib/runner.html Dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=html5lib%2Frunner.html Build Log: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%20(dbg)/builds/8961 Stack Trace: crash log for DumpRenderTree (pid 3913): STDOUT: <empty> STDERR: ASSERTION FAILED: m_viewportArguments.type == ViewportArguments::Implicit STDERR: third_party/WebKit/Source/WebCore/dom/Document.cpp(807) : void WebCore::Document::setDocType(WTF::PassRefPtr<WebCore::DocumentType>) STDERR: 1 0x7fa657c1be8b STDERR: 2 0x7fa657c6d604 STDERR: 3 0x7fa657c0389b STDERR: 4 0x7fa657c03a96 STDERR: 5 0x7fa657c0101a STDERR: 6 0x7fa657fb6092 STDERR: 7 0x7fa657fb637d STDERR: 8 0x7fa657fb6d53 STDERR: 9 0x7fa657fda300 STDERR: 10 0x7fa657fda1df STDERR: 11 0x7fa657fda03e STDERR: 12 0x7fa657fd9f65 STDERR: 13 0x7fa657fbbb9c STDERR: 14 0x7fa657fbb5e4 STDERR: 15 0x7fa657fbbf4c STDERR: 16 0x7fa657c2320e STDERR: 17 0x7fa657c23271 STDERR: 18 0x7fa65847435e STDERR: 19 0x23614543a1f3 STDERR: [3913:3913:9529023387827:ERROR:process_util_posix.cc(143)] Received signal 11 STDERR: base::debug::StackTrace::StackTrace() [0x7fa653f68332] STDERR: base::(anonymous namespace)::StackDumpSignalHandler() [0x7fa653fca471] STDERR: 0x7fa64dc15af0 STDERR: WebCore::Document::setDocType() [0x7fa657c1be95] STDERR: WebCore::DocumentType::insertedInto() [0x7fa657c6d604] STDERR: WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument() [0x7fa657c0389b] STDERR: WebCore::ChildNodeInsertionNotifier::notify() [0x7fa657c03a96] STDERR: WebCore::ContainerNode::parserAddChild() [0x7fa657c0101a] STDERR: WebCore::executeTask() [0x7fa657fb6092] STDERR: WebCore::HTMLConstructionSite::executeQueuedTasks() [0x7fa657fb637d] STDERR: WebCore::HTMLConstructionSite::insertDoctype() [0x7fa657fb6d53] STDERR: WebCore::HTMLTreeBuilder::processDoctypeToken() [0x7fa657fda300] STDERR: WebCore::HTMLTreeBuilder::processToken() [0x7fa657fda1df] STDERR: WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken() [0x7fa657fda03e] STDERR: WebCore::HTMLTreeBuilder::constructTreeFromToken() [0x7fa657fd9f65] STDERR: WebCore::HTMLDocumentParser::pumpTokenizer() [0x7fa657fbbb9c] STDERR: WebCore::HTMLDocumentParser::pumpTokenizerIfPossible() [0x7fa657fbb5e4] STDERR: WebCore::HTMLDocumentParser::insert() [0x7fa657fbbf4c] STDERR: WebCore::Document::write() [0x7fa657c2320e] STDERR: WebCore::Document::write() [0x7fa657c23271] STDERR: WebCore::V8HTMLDocument::writeCallback() [0x7fa65847435e] STDERR: 0x23614543a1f3 Probable cause: Woud be r122359 since it touched VIEWPORT. 667385 1 hayato 2012-07-11 21:35:54 -0700 Marked it CRASH. http://trac.webkit.org/changeset/122415 668185 2 152050 abarth 2012-07-12 13:59:26 -0700 Created attachment 152050 Patch 668209 3 152050 tony 2012-07-12 14:22:18 -0700 Comment on attachment 152050 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152050&action=review > LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add-expected.txt:2 > +ALERT: viewport size 320x480 scale 1 with limits [1, 5] and userScalable true > +ALERT: viewport size 320x480 scale 1 with limits [1, 5] and userScalable true Nit: It would be nicer if the test said PASS/FAIL rather than ALERT. Maybe use js-test-pre? > LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html:8 > + XHTML-MP is used for mobile documents which are assumed to be designed for > + handheld devices, hence using the viewport size as the initial containing Nit: Since this is a dumpAsText test, should we just put this in a <p>? 668219 4 abarth 2012-07-12 14:28:53 -0700 These are the style of all the tests in this directory. I agree that the style is kind of goofy. I'm not sure whether it's worth making this one test different from the rest. 668222 5 tony 2012-07-12 14:31:14 -0700 I don't feel strongly about this one way or another. Feel free to only resolve conflicts and land. 668234 6 abarth 2012-07-12 14:36:57 -0700 I've filed https://bugs.webkit.org/show_bug.cgi?id=91150 about improving these tests as a whole. 668244 7 abarth 2012-07-12 14:41:25 -0700 Committed r122509: <http://trac.webkit.org/changeset/122509> 152050 2012-07-12 13:59:26 -0700 2012-07-12 14:22:18 -0700 Patch bug-91047-20120712135933.patch text/plain 5566 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTk1NDdiMDQ4ZDlhM2E2 M2NhMmNkNTVjYjJlNGI1ZjljMDUzZWRkYS4uNTgxNTllOWI5OGY4ZjI0NzdjY2FlOWU5MmQxYmM4 OWJhMTNlMGRhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA3LTEyICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVncmVzc2lvbiAocjEyMjM1 OSkgTGF5b3V0IFRlc3QgaHRtbDVsaWIvcnVubmVyLmh0bWwgaXMgZmFpbGluZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTEwNDcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIEFTU0VSVCBpcyBib2d1 cyBiZWNhdXNlIGRvY3R5cGVzIGNhbiBiZSByZW1vdmVkIGZyb20gdGhlIERPTSBhbmQKKyAgICAg ICAgdGhlbiByZS1hZGRlZC4KKworICAgICAgICBUZXN0OiBmYXN0L3ZpZXdwb3J0L3ZpZXdwb3J0 LWxlZ2FjeS14aHRtbG1wLXJlbW92ZS1hbmQtYWRkLmh0bWwKKworICAgICAgICAqIGRvbS9Eb2N1 bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6c2V0RG9jVHlwZSk6CisKIDIw MTItMDctMTIgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgVW5yZXZpZXdlZCByMTIyNDYwIGluc3BlY3RvciBjbG9zdXJlIGNvbXBpbGF0aW9uIGZpeCBm b2xsb3cgdXAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCBiYzVlYWJiZGE2MWI4ZTgyYWEy ZjQxNDE4OTE1MzMyNzJjYmRlZjNhLi41ZWM4ZDJmMGJiNDkwY2Q5ZWJjOTYzNDUyOTQyNjFhZWQz Mzg2YzllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTgwNCw3ICs4MDQsNiBAQCB2b2lk IERvY3VtZW50OjpzZXREb2NUeXBlKFBhc3NSZWZQdHI8RG9jdW1lbnRUeXBlPiBkb2NUeXBlKQog ICAgIGlmIChtX2RvY1R5cGUpIHsKICAgICAgICAgdGhpcy0+YWRvcHRJZk5lZWRlZChtX2RvY1R5 cGUuZ2V0KCkpOwogI2lmIEVOQUJMRShMRUdBQ1lfVklFV1BPUlRfQURBUFRJT04pCi0gICAgICAg IEFTU0VSVChtX3ZpZXdwb3J0QXJndW1lbnRzLnR5cGUgPT0gVmlld3BvcnRBcmd1bWVudHM6Oklt cGxpY2l0KTsKICAgICAgICAgaWYgKG1fZG9jVHlwZS0+cHVibGljSWQoKS5zdGFydHNXaXRoKCIt Ly93YXBmb3J1bS8vZHRkIHhodG1sIG1vYmlsZSAxLiIsIC8qIGNhc2VTZW5zaXRpdmUgKi8gZmFs c2UpKQogICAgICAgICAgICAgcHJvY2Vzc1ZpZXdwb3J0KCJ3aWR0aD1kZXZpY2Utd2lkdGgsIGhl aWdodD1kZXZpY2UtaGVpZ2h0IiwgVmlld3BvcnRBcmd1bWVudHM6OlhIVE1MTW9iaWxlUHJvZmls ZSk7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCA5ODg3NDg4YjllNzAzZWVlODE4ZTYyMzRiOTExMzE4NzRkNmVi YWYzLi4wOTc1ZTJjOTA0Njc2ZTYzZDE4NTQ5NmQ2MWEwZTRiNmJjMGZiNGNjIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTItMDctMTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K KworICAgICAgICBSZWdyZXNzaW9uIChyMTIyMzU5KSBMYXlvdXQgVGVzdCBodG1sNWxpYi9ydW5u ZXIuaHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MTA0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZCBhIHRlc3QgdGhhdCBzaG93cyB3aGF0IGhhcHBlbnMgd2hlbiBhIGRvY3R5 cGUgZ2V0cyBhZGRlZCBhbmQKKyAgICAgICAgcmVtb3ZlZC4KKworICAgICAgICAqIGZhc3Qvdmll d3BvcnQvdmlld3BvcnQtbGVnYWN5LXhodG1sbXAtcmVtb3ZlLWFuZC1hZGQtZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3ZpZXdwb3J0L3ZpZXdwb3J0LWxlZ2FjeS14aHRtbG1w LXJlbW92ZS1hbmQtYWRkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVt L1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTItMDctMTIgIEFybmF1ZCBSZW5ldmllciAgPGFybm9A cmVuZXZpZXIubmV0PgogCiAgICAgICAgIFtHVEtdIEltcGxlbWVudCBkaXNhYmxlSW1hZ2VMb2Fk aW5nIGluIERSVApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC92aWV3cG9ydC92aWV3cG9y dC1sZWdhY3kteGh0bWxtcC1yZW1vdmUtYW5kLWFkZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9mYXN0L3ZpZXdwb3J0L3ZpZXdwb3J0LWxlZ2FjeS14aHRtbG1wLXJlbW92ZS1hbmQtYWRkLWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hNzIxNGE0MjFhZTJhMjBiOTc0MWFhYjc4Nzk5ZTA3Y2I2 ZDA1NGExCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC92aWV3cG9ydC92aWV3 cG9ydC1sZWdhY3kteGh0bWxtcC1yZW1vdmUtYW5kLWFkZC1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSw0IEBACitBTEVSVDogdmlld3BvcnQgc2l6ZSAzMjB4NDgwIHNjYWxlIDEgd2l0aCBsaW1pdHMg WzEsIDVdIGFuZCB1c2VyU2NhbGFibGUgdHJ1ZQorQUxFUlQ6IHZpZXdwb3J0IHNpemUgMzIweDQ4 MCBzY2FsZSAxIHdpdGggbGltaXRzIFsxLCA1XSBhbmQgdXNlclNjYWxhYmxlIHRydWUKK0FMRVJU OiB2aWV3cG9ydCBzaXplIDMyMHg0ODAgc2NhbGUgMSB3aXRoIGxpbWl0cyBbMSwgNV0gYW5kIHVz ZXJTY2FsYWJsZSB0cnVlCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvdmlld3BvcnQv dmlld3BvcnQtbGVnYWN5LXhodG1sbXAtcmVtb3ZlLWFuZC1hZGQuaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3Qvdmlld3BvcnQvdmlld3BvcnQtbGVnYWN5LXhodG1sbXAtcmVtb3ZlLWFuZC1hZGQuaHRt bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi5kNThmYzE2NGM3NzAwYzJkMzI0ODE4N2U1ZTkyNzE1NzU3NDMxMmFmCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC92aWV3cG9ydC92aWV3cG9ydC1sZWdh Y3kteGh0bWxtcC1yZW1vdmUtYW5kLWFkZC5odG1sCkBAIC0wLDAgKzEsMzcgQEAKKzw/eG1sIHZl cnNpb249IjEuMCIgZW5jb2Rpbmc9InV0Zi04Ij8+Cis8IURPQ1RZUEUgaHRtbCBQVUJMSUMgIi0v L1dBUEZPUlVNLy9EVEQgWEhUTUwgTW9iaWxlIDEuMC8vRU4iICJodHRwOi8vd3d3LndhcGZvcnVt Lm9yZy9EVEQveGh0bWwtbW9iaWxlMTAuZHRkIj4KKzxoZWFkPgorICAgIDwhLS0KKyAgICBSZWxh dGVkIHNwZWM6IGh0dHA6Ly93d3cudzMub3JnL1RSL2Nzcy1kZXZpY2UtYWRhcHQvCisKKyAgICBY SFRNTC1NUCBpcyB1c2VkIGZvciBtb2JpbGUgZG9jdW1lbnRzIHdoaWNoIGFyZSBhc3N1bWVkIHRv IGJlIGRlc2lnbmVkIGZvcgorICAgIGhhbmRoZWxkIGRldmljZXMsIGhlbmNlIHVzaW5nIHRoZSB2 aWV3cG9ydCBzaXplIGFzIHRoZSBpbml0aWFsIGNvbnRhaW5pbmcKKyAgICBibG9jayBzaXplLCBz byB1c2luZyBYSFRNTC1NUCB3aWxsIGdpdmUgdGhlIHNhbWUgcmVzdWx0IGFzIGEgdmlld3BvcnQK KyAgICBtZXRhIHRhZyB3aXRoIHRoZSBmb2xsb3dpbmcgcGFyYW1ldGVyczoKKworICAgIHdpZHRo PWRldmljZS13aWR0aCwgaGVpZ2h0PWRldmljZS1oZWlnaHQsIGluaXRpYWwtc2NhbGU9MQorCisg ICAgLS0+CisgICAgPHRpdGxlPkRlZmF1bHQgdmlld3BvcnQgdmFsdWUgY2hhbmdlZCBieSBYSFRN TC1NUDwvdGl0bGU+CisgICAgPHNjcmlwdD4KKyAgICAgICAgZnVuY3Rpb24gdGVzdCgpIHsKKyAg ICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICAg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgICAgICAgICBpZiAo d2luZG93LmludGVybmFscykKKyAgICAgICAgICAgICAgICBhbGVydChpbnRlcm5hbHMuY29uZmln dXJhdGlvbkZvclZpZXdwb3J0KGRvY3VtZW50LCAxLCAzMjAsIDQ4MCwgMzIwLCAzNTIpKTsKKwor ICAgICAgICAgICAgdmFyIG9yaWdpbmFsRG9jdHlwZSA9IGRvY3VtZW50LmRvY3R5cGU7CisgICAg ICAgICAgICBkb2N1bWVudC5yZW1vdmVDaGlsZChvcmlnaW5hbERvY3R5cGUpOworCisgICAgICAg ICAgICBpZiAod2luZG93LmludGVybmFscykKKyAgICAgICAgICAgICAgICBhbGVydChpbnRlcm5h bHMuY29uZmlndXJhdGlvbkZvclZpZXdwb3J0KGRvY3VtZW50LCAxLCAzMjAsIDQ4MCwgMzIwLCAz NTIpKTsKKworICAgICAgICAgICAgZG9jdW1lbnQuaW5zZXJ0QmVmb3JlKG9yaWdpbmFsRG9jdHlw ZSwgZG9jdW1lbnQuZmlyc3RDaGlsZCk7CisKKyAgICAgICAgICAgIGlmICh3aW5kb3cuaW50ZXJu YWxzKQorICAgICAgICAgICAgICAgIGFsZXJ0KGludGVybmFscy5jb25maWd1cmF0aW9uRm9yVmll d3BvcnQoZG9jdW1lbnQsIDEsIDMyMCwgNDgwLCAzMjAsIDM1MikpOworICAgICAgICB9CisgICAg PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InRlc3QoKTsiIC8+CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucwppbmRleCBkNTJjN2U4MzIz YTE0MTZmNzk5ZjVlNzE1YTcwM2RkNmVmNjRjYzIzLi44MmI4ZDY5MmVkYWNjZTE1MjJmYzY1Njhj MmU0ODg0NjUyNDE1ODVjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1 bS9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rl c3RFeHBlY3RhdGlvbnMKQEAgLTM3NDMsNiArMzc0MywzIEBAIEJVR1dLOTA5MDAgTUFDIDogdGFi bGVzL21vemlsbGFfZXhwZWN0ZWRfZmFpbHVyZXMvb3RoZXIvZW1wdHlfY2VsbHMuaHRtbCA9IFBB U1MKIAogQlVHV0s5MDk4MCBMSU5VWCBNQUMgREVCVUcgOiBmYXN0L2Zvcm1zL3RleHRhcmVhL3Rl eHRhcmVhLXN0YXRlLXJlc3RvcmUuaHRtbCA9IFBBU1MgVElNRU9VVAogQlVHV0s5MDk4MCBXSU4g OiBmYXN0L2Zvcm1zL3RleHRhcmVhL3RleHRhcmVhLXN0YXRlLXJlc3RvcmUuaHRtbCA9IFBBU1Mg VElNRU9VVAotCi0vLyBTdGFydGVkIGNyYXNoaW5nIGFmdGVyIHIxMjIzNTkKLUJVR1dLOTEwNDcg REVCVUcgOiBodG1sNWxpYi9ydW5uZXIuaHRtbCA9IENSQVNICg==