91043 2012-07-11 19:19:23 -0700 When a table row height grows because of pagination, not all cells’ heights are adjusted 2012-07-11 21:53:00 -0700 1 1 1 Unclassified WebKit Tables 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 91048 1 mitz webkit-unassigned eric webkit.review.bot oldest_to_newest 667327 0 mitz 2012-07-11 19:19:23 -0700 <rdar://problem/11794104> The fix for in bug 83595 in <http://trac.webkit.org/r113738> made table rows grow as necessary to fit cells that grow as a result of pagination. But it had two bad side effects: earlier cells on the row would not grow by the same amount, and later cells on the row would factor the existing growth into their intrinsic padding. 667332 1 151846 mitz 2012-07-11 19:25:37 -0700 Created attachment 151846 Grow the row and all cells occurring in it as needed only after laying out all cells on the row 667339 2 151846 sam 2012-07-11 19:34:54 -0700 Comment on attachment 151846 Grow the row and all cells occurring in it as needed only after laying out all cells on the row View in context: https://bugs.webkit.org/attachment.cgi?id=151846&action=review > LayoutTests/fast/multicol/table-row-height-increase-expected.html:1 > +<meta name=viewport content="width=device-width"> Seems unnecessary. > LayoutTests/fast/multicol/table-row-height-increase.html:1 > +<meta name=viewport content="width=device-width"> Same here. 667340 3 mitz 2012-07-11 19:39:13 -0700 Fixed in <http://trac.webkit.org/r122408>. 151846 2012-07-11 19:25:37 -0700 2012-07-11 19:34:54 -0700 Grow the row and all cells occurring in it as needed only after laying out all cells on the row 91043_r1.diff text/plain 6780 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMjQwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA3LTExICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgV2hlbiBhIHRhYmxlIHJvdyBoZWln aHQgZ3Jvd3MgYmVjYXVzZSBvZiBwYWdpbmF0aW9uLCBub3QgYWxsIGNlbGxz4oCZIGhlaWdodHMg YXJlIGFkanVzdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05MTA0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSBmaXggZm9yIGluIGJ1ZyA8aHR0cDovL3dlYmtpdC5vcmcvYi84MzU5NT4gaW4gPGh0 dHA6Ly90cmFjLndlYmtpdC5vcmcvcjExMzczOD4gbWFkZSB0YWJsZQorICAgICAgICByb3dzIGdy b3cgYXMgbmVjZXNzYXJ5IHRvIGZpdCBjZWxscyB0aGF0IGdyb3cgYXMgYSByZXN1bHQgb2YgcGFn aW5hdGlvbi4gQnV0IGl0IGhhZCB0d28gYmFkCisgICAgICAgIHNpZGUgZWZmZWN0czogZWFybGll ciBjZWxscyBvbiB0aGUgcm93IHdvdWxkIG5vdCBncm93IGJ5IHRoZSBzYW1lIGFtb3VudCwgYW5k IGxhdGVyIGNlbGxzIG9uCisgICAgICAgIHRoZSByb3cgd291bGQgZmFjdG9yIHRoZSBleGlzdGlu ZyBncm93dGggaW50byB0aGVpciBpbnRyaW5zaWMgcGFkZGluZy4KKworICAgICAgICBUZXN0OiBm YXN0L211bHRpY29sL3RhYmxlLXJvdy1oZWlnaHQtaW5jcmVhc2UuaHRtbAorCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlclRhYmxlU2VjdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJUYWJsZVNlY3Rpb246OmxheW91dFJvd3MpOiBOb3cgd2hlbiBhIGNlbGwgYmVjb21lcyB0YWxs ZXIgdGhhbiB0aGUgcm93IGhlaWdodCwKKyAgICAgICAgdGhlIGFkZGl0aW9uYWwgaGVpZ2h0IG5l ZWRlZCBpcyByZWNvcmRlZCwgYW5kIHRoZSBjZWxsIGlzIHNocnVuayBiYWNrIHRvIHJvdyBoZWln aHQuIFRoZW4KKyAgICAgICAgYWZ0ZXIgZmluaXNoaW5nIHRoZSByb3csIGFsbCBjZWxscyBvY2N1 cnJpbmcgb24gdGhlIHJvdyAoaW5jbHVkaW5nIGNlbGxzIHNwYW5uaW5nIGl0IGJ1dCBub3QKKyAg ICAgICAgc3RhcnRpbmcgb24gaXQpIGFyZSBncm93biBieSB0aGUgc2FtZSBhbW91bnQuCisKIDIw MTItMDctMTEgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICA8aHR0cDov L3dlYmtpdC5vcmcvYi85MTAyND4gQnVpbGQgYWdhaW5zdCB0aGUgbGF0ZXN0IFNESyB3aGVuIHRh cmdldGluZyBvbGRlciBPUyBYIHZlcnNpb25zLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRhYmxlU2VjdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRhYmxlU2VjdGlvbi5jcHAJKHJldmlzaW9uIDEyMjM5OSkKKysrIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCSh3b3JraW5nIGNv cHkpCkBAIC01NDcsNiArNTQ3LDggQEAgdm9pZCBSZW5kZXJUYWJsZVNlY3Rpb246OmxheW91dFJv d3MoKQogICAgICAgICAgICAgcm93UmVuZGVyZXItPnVwZGF0ZUxheWVyVHJhbnNmb3JtKCk7CiAg ICAgICAgIH0KIAorICAgICAgICBpbnQgcm93SGVpZ2h0SW5jcmVhc2VGb3JQYWdpbmF0aW9uID0g MDsKKwogICAgICAgICBmb3IgKHVuc2lnbmVkIGMgPSAwOyBjIDwgbkVmZkNvbHM7IGMrKykgewog ICAgICAgICAgICAgQ2VsbFN0cnVjdCYgY3MgPSBjZWxsQXQociwgYyk7CiAgICAgICAgICAgICBS ZW5kZXJUYWJsZUNlbGwqIGNlbGwgPSBjcy5wcmltYXJ5Q2VsbCgpOwpAQCAtNjcxLDEzICs2NzMs OSBAQCB2b2lkIFJlbmRlclRhYmxlU2VjdGlvbjo6bGF5b3V0Um93cygpCiAgICAgICAgICAgICAg ICAgLy8gRklYTUU6IFBhZ2luYXRpb24gbWlnaHQgaGF2ZSBtYWRlIHVzIGNoYW5nZSBzaXplLiBG b3Igbm93IGp1c3Qgc2hyaW5rIG9yIGdyb3cgdGhlIGNlbGwgdG8gZml0IHdpdGhvdXQgZG9pbmcg YSByZWxheW91dC4KICAgICAgICAgICAgICAgICAvLyBXZSdsbCBhbHNvIGRvIGEgYmFzaWMgaW5j cmVhc2Ugb2YgdGhlIHJvdyBoZWlnaHQgdG8gYWNjb21tb2RhdGUgdGhlIGNlbGwgaWYgaXQncyBi aWdnZXIsIGJ1dCB0aGlzIGlzbid0IHF1aXRlIHJpZ2h0CiAgICAgICAgICAgICAgICAgLy8gZWl0 aGVyLiBJdCdzIGF0IGxlYXN0IHN0YWJsZSB0aG91Z2ggYW5kIHdvbid0IHJlc3VsdCBpbiBhbiBp bmZpbml0ZSAjIG9mIHJlbGF5b3V0cyB0aGF0IG1heSBuZXZlciBzdGFiaWxpemUuCi0gICAgICAg ICAgICAgICAgaWYgKGNlbGwtPmxvZ2ljYWxIZWlnaHQoKSA+IHJIZWlnaHQpIHsKLSAgICAgICAg ICAgICAgICAgICAgdW5zaWduZWQgZGVsdGEgPSBjZWxsLT5sb2dpY2FsSGVpZ2h0KCkgLSBySGVp Z2h0OwotICAgICAgICAgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIHJvd0luZGV4ID0gcmluZHgg KyBjZWxsLT5yb3dTcGFuKCk7IHJvd0luZGV4IDw9IHRvdGFsUm93czsgcm93SW5kZXgrKykKLSAg ICAgICAgICAgICAgICAgICAgICAgIG1fcm93UG9zW3Jvd0luZGV4XSArPSBkZWx0YTsKLSAgICAg ICAgICAgICAgICAgICAgckhlaWdodCA9IGNlbGwtPmxvZ2ljYWxIZWlnaHQoKTsKLSAgICAgICAg ICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgICAgICAgICAgY2VsbC0+c2V0TG9naWNhbEhlaWdo dChySGVpZ2h0KTsKKyAgICAgICAgICAgICAgICBpZiAoY2VsbC0+bG9naWNhbEhlaWdodCgpID4g ckhlaWdodCkKKyAgICAgICAgICAgICAgICAgICAgcm93SGVpZ2h0SW5jcmVhc2VGb3JQYWdpbmF0 aW9uID0gbWF4PGludD4ocm93SGVpZ2h0SW5jcmVhc2VGb3JQYWdpbmF0aW9uLCBjZWxsLT5sb2dp Y2FsSGVpZ2h0KCkgLSBySGVpZ2h0KTsKKyAgICAgICAgICAgICAgICBjZWxsLT5zZXRMb2dpY2Fs SGVpZ2h0KHJIZWlnaHQpOwogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBMYXlvdXRTaXpl IGNoaWxkT2Zmc2V0KGNlbGwtPmxvY2F0aW9uKCkgLSBvbGRDZWxsUmVjdC5sb2NhdGlvbigpKTsK QEAgLTY5MSw2ICs2ODksMTUgQEAgdm9pZCBSZW5kZXJUYWJsZVNlY3Rpb246OmxheW91dFJvd3Mo KQogICAgICAgICAgICAgICAgICAgICBjZWxsLT5yZXBhaW50RHVyaW5nTGF5b3V0SWZNb3ZlZChv bGRDZWxsUmVjdCk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KKyAgICAgICAgaWYgKHJvd0hl aWdodEluY3JlYXNlRm9yUGFnaW5hdGlvbikgeworICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBy b3dJbmRleCA9IHIgKyAxOyByb3dJbmRleCA8PSB0b3RhbFJvd3M7IHJvd0luZGV4KyspCisgICAg ICAgICAgICAgICAgbV9yb3dQb3Nbcm93SW5kZXhdICs9IHJvd0hlaWdodEluY3JlYXNlRm9yUGFn aW5hdGlvbjsKKyAgICAgICAgICAgIGZvciAodW5zaWduZWQgYyA9IDA7IGMgPCBuRWZmQ29sczsg KytjKSB7CisgICAgICAgICAgICAgICAgVmVjdG9yPFJlbmRlclRhYmxlQ2VsbCosIDE+JiBjZWxs cyA9IGNlbGxBdChyLCBjKS5jZWxsczsKKyAgICAgICAgICAgICAgICBmb3IgKHNpemVfdCBpID0g MDsgaSA8IGNlbGxzLnNpemUoKTsgKytpKQorICAgICAgICAgICAgICAgICAgICBjZWxsc1tpXS0+ c2V0TG9naWNhbEhlaWdodChjZWxsc1tpXS0+bG9naWNhbEhlaWdodCgpICsgcm93SGVpZ2h0SW5j cmVhc2VGb3JQYWdpbmF0aW9uKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQogICAgIH0KIAog I2lmbmRlZiBOREVCVUcKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMjQwNSkKKysrIExheW91dFRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA3LTExICBE YW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgV2hlbiBhIHRhYmxlIHJv dyBoZWlnaHQgZ3Jvd3MgYmVjYXVzZSBvZiBwYWdpbmF0aW9uLCBub3QgYWxsIGNlbGxz4oCZIGhl aWdodHMgYXJlIGFkanVzdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MTA0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogZmFzdC9tdWx0aWNvbC90YWJsZS1yb3ctaGVpZ2h0LWluY3JlYXNlLWV4cGVj dGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvbXVsdGljb2wvdGFibGUtcm93LWhlaWdo dC1pbmNyZWFzZS5odG1sOiBBZGRlZC4KKwogMjAxMi0wNy0xMSAgSGF5YXRvIEl0byAgPGhheWF0 b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBnYXJkZW5pbmcuCkluZGV4OiBM YXlvdXRUZXN0cy9mYXN0L211bHRpY29sL3RhYmxlLXJvdy1oZWlnaHQtaW5jcmVhc2UtZXhwZWN0 ZWQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL3RhYmxlLXJv dy1oZWlnaHQtaW5jcmVhc2UtZXhwZWN0ZWQuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2Zhc3QvbXVsdGljb2wvdGFibGUtcm93LWhlaWdodC1pbmNyZWFzZS1leHBlY3RlZC5odG1s CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI2IEBACis8bWV0YSBuYW1lPXZpZXdwb3J0IGNvbnRl bnQ9IndpZHRoPWRldmljZS13aWR0aCI+DQorPHN0eWxlPg0KK3RkIHsNCisgICAgYmFja2dyb3Vu ZC1jb2xvcjogZ3JlZW47DQorICAgIHZlcnRpY2FsLWFsaWduOiB0b3A7DQorICAgIGZvbnQtZmFt aWx5OiBhaGVtOw0KKyAgICBmb250LXNpemU6IDIwcHg7DQorICAgIGNvbG9yOiByZ2JhKDAsIDAs IDAsIC41KTsNCit9DQorDQorPC9zdHlsZT4NCis8ZGl2IHN0eWxlPSJ3aWR0aDogNDgwcHg7IC13 ZWJraXQtY29sdW1uLWNvdW50OiAyOyAtd2Via2l0LWNvbHVtbi1nYXA6IDA7IGhlaWdodDogNjBw eDsiPg0KKyAgICA8dGFibGUgY2VsbHBhZGRpbmc9MCBjZWxsc3BhY2luZz0wIHN0eWxlPSJiYWNr Z3JvdW5kLWNvbG9yOiBncmVlbjsiPg0KKyAgICAgICAgPHRyIHN0eWxlPSJoZWlnaHQ6IDMwcHg7 Ij4NCisgICAgICAgICAgICA8dGQgc3R5bGU9IndpZHRoOiA2MHB4OyIgcm93c3Bhbj0yPjwvdGQ+ DQorICAgICAgICAgICAgPHRkPjwvdGQ+DQorICAgICAgICAgICAgPHRkPjwvdGQ+DQorICAgICAg ICAgICAgPHRkPjwvdGQ+DQorICAgICAgICA8L3RyPg0KKyAgICAgICAgPHRyPg0KKyAgICAgICAg ICAgIDx0ZCBzdHlsZT0id2lkdGg6IDYwcHg7Ij48L3RkPg0KKyAgICAgICAgICAgIDx0ZCBzdHls ZT0id2lkdGg6IDYwcHg7Ij5hYmMgZGVmPC90ZD4NCisgICAgICAgICAgICA8dGQgc3R5bGU9Indp ZHRoOiA2MHB4OyI+YWJjIGRlZjwvdGQ+DQorICAgICAgICA8L3RyPg0KKyAgICA8L3RhYmxlPg0K KzwvZGl2Pg0KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvdGFibGUtcm93LWhlaWdo dC1pbmNyZWFzZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wv dGFibGUtcm93LWhlaWdodC1pbmNyZWFzZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvZmFzdC9tdWx0aWNvbC90YWJsZS1yb3ctaGVpZ2h0LWluY3JlYXNlLmh0bWwJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsMjYgQEAKKzxtZXRhIG5hbWU9dmlld3BvcnQgY29udGVudD0id2lkdGg9 ZGV2aWNlLXdpZHRoIj4NCis8c3R5bGU+DQordGQgew0KKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiBn cmVlbjsNCisgICAgdmVydGljYWwtYWxpZ246IHRvcDsNCisgICAgZm9udC1mYW1pbHk6IGFoZW07 DQorICAgIGZvbnQtc2l6ZTogMjBweDsNCisgICAgY29sb3I6IHJnYmEoMCwgMCwgMCwgLjUpOw0K K30NCisNCis8L3N0eWxlPg0KKzxkaXYgc3R5bGU9IndpZHRoOiA0ODBweDsgLXdlYmtpdC1jb2x1 bW4tY291bnQ6IDI7IC13ZWJraXQtY29sdW1uLWdhcDogMDsgaGVpZ2h0OiA2MHB4OyI+DQorICAg IDx0YWJsZSBjZWxscGFkZGluZz0wIGNlbGxzcGFjaW5nPTAgc3R5bGU9ImJhY2tncm91bmQtY29s b3I6IHJlZDsiPg0KKyAgICAgICAgPHRyIHN0eWxlPSJoZWlnaHQ6IDMwcHg7Ij4NCisgICAgICAg ICAgICA8dGQgc3R5bGU9IndpZHRoOiA2MHB4OyIgcm93c3Bhbj0yPjwvdGQ+DQorICAgICAgICAg ICAgPHRkPjwvdGQ+DQorICAgICAgICAgICAgPHRkPjwvdGQ+DQorICAgICAgICAgICAgPHRkPjwv dGQ+DQorICAgICAgICA8L3RyPg0KKyAgICAgICAgPHRyPg0KKyAgICAgICAgICAgIDx0ZCBzdHls ZT0id2lkdGg6IDYwcHg7Ij48L3RkPg0KKyAgICAgICAgICAgIDx0ZCBzdHlsZT0id2lkdGg6IDYw cHg7Ij5hYmMgZGVmPC90ZD4NCisgICAgICAgICAgICA8dGQgc3R5bGU9IndpZHRoOiA2MHB4OyI+ YWJjIGRlZjwvdGQ+DQorICAgICAgICA8L3RyPg0KKyAgICA8L3RhYmxlPg0KKzwvZGl2Pg0K