91038 2012-07-11 17:59:45 -0700 When in paginated mode, the layout timer fires continually 2012-08-10 12:40:11 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser mitz mitz rasasi78 simon.fraser webkit-bug-importer oldest_to_newest 667267 0 simon.fraser 2012-07-11 17:59:45 -0700 When I put MIniBrowser into paginated mode and load a simple page like http://www.smfr.org, FrameView::layout() is called over and over again; the layout timer keeps firing and never stops. The WebProcess eats over 100% cpu permanently. mainFrameDidLayout() ends up calling pageCount(): frame #0: 0x0000000103da1820 WebCore`WebCore::Page::pageCount() const + 16 at Page.cpp:706 frame #1: 0x0000000101231b9d WebKit2`WebKit::WebPage::mainFrameDidLayout() + 45 at WebPage.cpp:2537 frame #2: 0x00000001011db93d WebKit2`WebKit::WebFrameLoaderClient::dispatchDidLayout() + 189 at WebFrameLoaderClient.cpp:612 frame #3: 0x00000001033d9183 WebCore`WebCore::FrameView::performPostLayoutTasks() + 627 at FrameView.cpp:2382 frame #4: 0x00000001033d89c4 WebCore`WebCore::FrameView::layout(bool) + 4020 at FrameView.cpp:1176 frame #5: 0x00000001033e1785 WebCore`WebCore::FrameView::forceLayout(bool) + 37 at FrameView.cpp:3241 frame #6: 0x0000000103da1890 WebCore`WebCore::Page::pageCount() const + 128 at Page.cpp:713 frame #7: 0x0000000101231b9d WebKit2`WebKit::WebPage::mainFrameDidLayout() + 45 at WebPage.cpp:2537 frame #8: 0x00000001011db93d WebKit2`WebKit::WebFrameLoaderClient::dispatchDidLayout() + 189 at WebFrameLoaderClient.cpp:612 frame #9: 0x00000001033d9183 WebCore`WebCore::FrameView::performPostLayoutTasks() + 627 at FrameView.cpp:2382 frame #10: 0x00000001033d47b9 WebCore`WebCore::FrameView::postLayoutTimerFired(WebCore::Timer<WebCore::FrameView>*) + 25 at FrameView.cpp:2436 frame #11: 0x00000001033ef043 WebCore`WebCore::Timer<WebCore::FrameView>::fired() + 115 at Timer.h:100 frame #12: 0x000000010445b4fd WebCore`WebCore::ThreadTimers::sharedTimerFiredInternal() + 285 at ThreadTimers.cpp:115 frame #13: 0x000000010445b299 WebCore`WebCore::ThreadTimers::sharedTimerFired() + 25 at ThreadTimers.cpp:93 frame #14: 0x00000001041af8b3 WebCore`timerFired + 67 at SharedTimerMac.mm:166 frame #15: 0x00007fff95dd44b4 CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20 frame #16: 0x00007fff95dd3fcd CoreFoundation`__CFRunLoopDoTimer + 557 frame #17: 0x00007fff95db97b9 CoreFoundation`__CFRunLoopRun + 1513 frame #18: 0x00007fff95db8dd2 CoreFoundation`CFRunLoopRunSpecific + 290 frame #19: 0x00007fff950f2774 HIToolbox`RunCurrentEventLoopInMode + 209 frame #20: 0x00007fff950f2512 HIToolbox`ReceiveNextEventCommon + 356 frame #21: 0x00007fff950f23a3 HIToolbox`BlockUntilNextEventMatchingListInMode + 62 frame #22: 0x00007fff90687f73 AppKit`_DPSNextEvent + 685 frame #23: 0x00007fff90687832 AppKit`-[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 128 frame #24: 0x00007fff9067ebd3 AppKit`-[NSApplication run] + 517 frame #25: 0x00000001040fd64c WebCore`WebCore::RunLoop::run() + 92 at RunLoopMac.mm:36 frame #26: 0x00000001012fbcd8 WebKit2`WebKit::WebProcessMain(WebKit::CommandLine const&) + 3368 at WebProcessMainMac.mm:183 frame #27: 0x000000010120f7a8 WebKit2`WebKitMain + 200 at WebKitMain.cpp:50 frame #28: 0x000000010120f6c4 WebKit2`WebKitMain + 148 at WebKitMain.cpp:74 frame #29: 0x0000000100000da2 WebProcess`main + 274 at MainMac.cpp:68 and Page::pageCount() calls mainFrame()->view()->forceLayout(); which seems to be the cause. 667269 1 webkit-bug-importer 2012-07-11 18:00:34 -0700 <rdar://problem/11855229> 667272 2 mitz 2012-07-11 18:09:41 -0700 This is a WebKit2 bug. 692737 3 mitz 2012-08-10 11:38:58 -0700 It can be addressed in WebCore. 692752 4 157777 mitz 2012-08-10 11:44:30 -0700 Created attachment 157777 Change Page::pageCount to only trigger layout if needed 692815 5 mitz 2012-08-10 12:40:11 -0700 Fixed in <http://trac.webkit.org/r125314>. 157777 2012-08-10 11:44:30 -0700 2012-08-10 11:49:15 -0700 Change Page::pageCount to only trigger layout if needed bug-91038-20120810114407.patch text/plain 1447 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTMwNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA4LTEwICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzExODU1 MjI5PiBXaGVuIGluIHBhZ2luYXRlZCBtb2RlLCB0aGUgbGF5b3V0IHRpbWVyIGZpcmVzIGNvbnRp bnVhbGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MTAzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cGFnZS9QYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OnBhZ2VDb3VudCk6IENoYW5n ZWQgdG8gb25seSB0cmlnZ2VyIGxheW91dCBpZiBuZWVkZWQuCisKIDIwMTItMDgtMTAgIFRha2Fz aGkgU2FrYW1vdG8gIDx0YXNha0Bnb29nbGUuY29tPgogCiAgICAgICAgIGJveC1zaGFkb3cgY3Jl YXRlcyBpbmNvcnJlY3Qgc2hhZG93IHdoZW4gYm9yZGVyLXJhZGl1cyBpcyB0b28gbGFyZ2UKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcGFnZS9QYWdlLmNwcAkocmV2aXNpb24gMTI1Mjk3KQorKysgU291cmNlL1dlYkNvcmUv cGFnZS9QYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzA5LDEzICs3MDksMTEgQEAgdW5zaWdu ZWQgUGFnZTo6cGFnZUNvdW50KCkgY29uc3QKICAgICAgICAgcmV0dXJuIDA7CiAKICAgICBGcmFt ZVZpZXcqIGZyYW1lVmlldyA9IG1haW5GcmFtZSgpLT52aWV3KCk7Ci0gICAgaWYgKCFmcmFtZVZp ZXctPmRpZEZpcnN0TGF5b3V0KCkpCi0gICAgICAgIHJldHVybiAwOwotCi0gICAgbWFpbkZyYW1l KCktPnZpZXcoKS0+Zm9yY2VMYXlvdXQoKTsKKyAgICBpZiAoZnJhbWVWaWV3LT5uZWVkc0xheW91 dCgpKQorICAgICAgICBmcmFtZVZpZXctPmxheW91dCgpOwogCiAgICAgUmVuZGVyVmlldyogY29u dGVudFJlbmRlcmVyID0gbWFpbkZyYW1lKCktPmNvbnRlbnRSZW5kZXJlcigpOwotICAgIHJldHVy biBjb250ZW50UmVuZGVyZXItPmNvbHVtbkNvdW50KGNvbnRlbnRSZW5kZXJlci0+Y29sdW1uSW5m bygpKTsKKyAgICByZXR1cm4gY29udGVudFJlbmRlcmVyID8gY29udGVudFJlbmRlcmVyLT5jb2x1 bW5Db3VudChjb250ZW50UmVuZGVyZXItPmNvbHVtbkluZm8oKSkgOiAwOwogfQogCiB2b2lkIFBh Z2U6OmRpZE1vdmVPbnNjcmVlbigpCg==