91003 2012-07-11 13:00:14 -0700 ASSERT(genChild->isListMarker() || genChild->style()->styleType() == FIRST_LETTER) triggered on flex-box content 2012-07-12 13:54:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jchaffraix jchaffraix eric inferno webkit.review.bot oldest_to_newest 666979 0 jchaffraix 2012-07-11 13:00:14 -0700 The ASSERT can be hit pretty easily when a flex box (deprecated or not) is involved (see test case). It seems that the code is confused in RenderObjectChildList::updateBeforeAfterStyle. My analysis is that the parent |beforeAfterParent| is wrongly chosen which makes us not update the right children. 666981 1 151755 jchaffraix 2012-07-11 13:00:44 -0700 Created attachment 151755 Reproduction: should hit the ASSERT in Debug 666995 2 151757 jchaffraix 2012-07-11 13:14:06 -0700 Created attachment 151757 Proposed change 1: Do not return the flex box wrapper but search for the proper generated content parent. 667241 3 151757 inferno 2012-07-11 17:34:45 -0700 Comment on attachment 151757 Proposed change 1: Do not return the flex box wrapper but search for the proper generated content parent. View in context: https://bugs.webkit.org/attachment.cgi?id=151757&action=review > Source/WebCore/rendering/RenderObjectChildList.cpp:292 > // Only table parts need to search for the :before or :after parent Please fix this comment since we now include flexboxes. Probably add a FIXME that we should instead use isAnonymous to cover any anonymous containers. > LayoutTests/fast/flexbox/assert-generated-deprecated-flexbox.html:5 > + content: 'Generated content wrapped in a flex-box.'; nit: this should be indented right. same for the other test. 667943 4 151990 jchaffraix 2012-07-12 10:27:28 -0700 Created attachment 151990 Patch for landing 667945 5 151757 jchaffraix 2012-07-12 10:28:34 -0700 Comment on attachment 151757 Proposed change 1: Do not return the flex box wrapper but search for the proper generated content parent. View in context: https://bugs.webkit.org/attachment.cgi?id=151757&action=review >> Source/WebCore/rendering/RenderObjectChildList.cpp:292 >> // Only table parts need to search for the :before or :after parent > > Please fix this comment since we now include flexboxes. Probably add a FIXME that we should instead use isAnonymous to cover any anonymous containers. Done, also added a FIXME that we could probably get away without the check for future reference. >> LayoutTests/fast/flexbox/assert-generated-deprecated-flexbox.html:5 >> + content: 'Generated content wrapped in a flex-box.'; > > nit: this should be indented right. same for the other test. Done. 668181 6 151990 webkit.review.bot 2012-07-12 13:54:17 -0700 Comment on attachment 151990 Patch for landing Clearing flags on attachment: 151990 Committed r122502: <http://trac.webkit.org/changeset/122502> 668182 7 webkit.review.bot 2012-07-12 13:54:29 -0700 All reviewed patches have been landed. Closing bug. 151755 2012-07-11 13:00:44 -0700 2012-07-11 13:00:44 -0700 Reproduction: should hit the ASSERT in Debug assert.html text/html 157 jchaffraix PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+CiAgICBkaXY6 YWZ0ZXIgewogICAgICBjb250ZW50OiAnRm9vYmFyJzsKICAgICAgZGlzcGxheTogLXdlYmtpdC1i b3g7CiAgICB9CiAgPC9zdHlsZT4KICA8ZGl2PjwvZGl2Pgo8L2h0bWw+Cg== 151757 2012-07-11 13:14:06 -0700 2012-07-12 10:28:34 -0700 Proposed change 1: Do not return the flex box wrapper but search for the proper generated content parent. bug-91003-20120711131405.patch text/plain 5947 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDEzYWRlNTk0OTg1MmVl NDk5YTFjMDdjOThiZTZjNTZjODJhNGU1Yy4uMjJiZGVmMGU3MWEyMWQxNzI0MTIzZDYyZTMwMmI3 ZmVhMmUxNTk0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTExICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIEFTU0VSVChn ZW5DaGlsZC0+aXNMaXN0TWFya2VyKCkgfHwgZ2VuQ2hpbGQtPnN0eWxlKCktPnN0eWxlVHlwZSgp ID09IEZJUlNUX0xFVFRFUikgdHJpZ2dlcmVkIG9uIGZsZXgtYm94IGNvbnRlbnQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMDAzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdHM6IGZhc3QvZmxleGJv eC9hc3NlcnQtZ2VuZXJhdGVkLWRlcHJlY2F0ZWQtZmxleGJveC5odG1sCisgICAgICAgICAgICAg ICBmYXN0L2ZsZXhib3gvYXNzZXJ0LWdlbmVyYXRlZC1uZXctZmxleGJveC5odG1sCisKKyAgICAg ICAgVGhlIGlzc3VlIHdhcyB0aGF0IGZpbmRCZWZvcmVBZnRlclBhcmVudCBkaWRuJ3QgcmV0dXJu IHRoZSByaWdodCBwYXJlbnQgZm9yIHRoZSBmbGV4LWJveCBjYXNlLiBUaGlzIHdvdWxkCisgICAg ICAgIG1ha2UgdXMgdXBkYXRlIHRoZSB3cm9uZyBjaGlsZHJlbiAoYW5kIG5vdCBwcm9wYWdhdGUg dGhlIHN0eWxlIHVwZGF0ZXMgcHJvcGVybHkpLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ck9iamVjdENoaWxkTGlzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpmaW5kQmVmb3JlQWZ0ZXJQ YXJlbnQpOgorICAgICAgICBBZGRlZCBhIGNoZWNrIGZvciBmbGV4IGJveGVzIChib3RoIGRlcHJl Y2F0ZWQgYW5kIG5ldykuCisKIDIwMTItMDctMTEgIEpvc2h1YSBOZXR0ZXJmaWVsZCAgPGpuZXR0 ZXJmaWVsZEByaW0uY29tPgogCiAgICAgICAgIFtRdF0gUkVHUkVTU0lPTihyMTIyMjUwKTogSXQg YnJva2UgVVNFKDNEX0dSQVBISUNTKT0xIGFuZCBFTkFCTEUoV0VCR0wpPTAgYnVpbGRzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0Q2hpbGRMaXN0LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3RDaGlsZExpc3QuY3BwCmlu ZGV4IDQyMjUwNGU2YmMxZGJjMjY3NTkzZjhiMjA5OTFiMTkzMzI1N2MxYmIuLjkzOTQ3ZTBiMzBm NjdhYWM1YTUxYWVlMmU2ZmUzYzA4NGQzMzQ4OTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJPYmplY3RDaGlsZExpc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJPYmplY3RDaGlsZExpc3QuY3BwCkBAIC0yOTAsNyArMjkwLDcgQEAg dm9pZCBSZW5kZXJPYmplY3RDaGlsZExpc3Q6Omluc2VydENoaWxkTm9kZShSZW5kZXJPYmplY3Qq IG93bmVyLCBSZW5kZXJPYmplY3QqIGMKIHN0YXRpYyBSZW5kZXJPYmplY3QqIGZpbmRCZWZvcmVB ZnRlclBhcmVudChSZW5kZXJPYmplY3QqIG9iamVjdCkKIHsKICAgICAvLyBPbmx5IHRhYmxlIHBh cnRzIG5lZWQgdG8gc2VhcmNoIGZvciB0aGUgOmJlZm9yZSBvciA6YWZ0ZXIgcGFyZW50Ci0gICAg aWYgKCEob2JqZWN0LT5pc1RhYmxlKCkgfHwgb2JqZWN0LT5pc1RhYmxlU2VjdGlvbigpIHx8IG9i amVjdC0+aXNUYWJsZVJvdygpKSkKKyAgICBpZiAoIShvYmplY3QtPmlzVGFibGUoKSB8fCBvYmpl Y3QtPmlzVGFibGVTZWN0aW9uKCkgfHwgb2JqZWN0LT5pc1RhYmxlUm93KCkgfHwgb2JqZWN0LT5p c0ZsZXhpYmxlQm94SW5jbHVkaW5nRGVwcmVjYXRlZCgpKSkKICAgICAgICAgcmV0dXJuIG9iamVj dDsKIAogICAgIC8vIElmIHRoZXJlIGlzIGEgOmZpcnN0LWxldHRlciBzdHlsZSBhcHBsaWVkIG9u IHRoZSA6YmVmb3JlIG9yIDphZnRlciBjb250ZW50LApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDM5NzdmZTMzYjgwMDJmZTA2 OTdhNjEzODYzNjE0YzA3ZmZmNWU0YTEuLjI5Y2MxZDA1OTY1ODliOTE0YjhlODRhZjlkZjQzNmE2 NGUyMDdiNzkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNy0xMSAgSnVsaWVuIENoYWZm cmFpeCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KKworICAgICAgICBBU1NFUlQoZ2VuQ2hpbGQt PmlzTGlzdE1hcmtlcigpIHx8IGdlbkNoaWxkLT5zdHlsZSgpLT5zdHlsZVR5cGUoKSA9PSBGSVJT VF9MRVRURVIpIHRyaWdnZXJlZCBvbiBmbGV4LWJveCBjb250ZW50CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTAwMworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9mbGV4Ym94L2Fzc2VydC1nZW5l cmF0ZWQtZGVwcmVjYXRlZC1mbGV4Ym94LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog ZmFzdC9mbGV4Ym94L2Fzc2VydC1nZW5lcmF0ZWQtZGVwcmVjYXRlZC1mbGV4Ym94Lmh0bWw6IEFk ZGVkLgorICAgICAgICAqIGZhc3QvZmxleGJveC9hc3NlcnQtZ2VuZXJhdGVkLW5ldy1mbGV4Ym94 LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mbGV4Ym94L2Fzc2VydC1nZW5l cmF0ZWQtbmV3LWZsZXhib3guaHRtbDogQWRkZWQuCisKIDIwMTItMDctMTEgIFN0ZWZmZW4gSW1o b2YgIDxzdGVmZmVuLmltaG9mQGJhc3lza29tLmNvbT4KIAogICAgICAgICBbUXRdIE1pZGRsZSBj bGlja2luZyBhIHNjcm9sbGJhciBjYXVzZXMgdGV4dCB0byBiZSBwYXN0ZWQuCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2ZsZXhib3gvYXNzZXJ0LWdlbmVyYXRlZC1kZXByZWNhdGVkLWZs ZXhib3gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mbGV4Ym94L2Fzc2VydC1nZW5l cmF0ZWQtZGVwcmVjYXRlZC1mbGV4Ym94LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43NGJmNTJh NGU1ZTM2MTg5ZWZlZmVmOTliOTA1ZTViODJmMThiYjU3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9mbGV4Ym94L2Fzc2VydC1nZW5lcmF0ZWQtZGVwcmVjYXRlZC1mbGV4Ym94 LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDUgQEAKK0J1ZyA5MTAwMzogQVNTRVJUKGdlbkNoaWxk LT5pc0xpc3RNYXJrZXIoKSB8fCBnZW5DaGlsZC0+c3R5bGUoKS0+c3R5bGVUeXBlKCkgPT0gRklS U1RfTEVUVEVSKSB0cmlnZ2VyZWQgb24gZmxleC1ib3ggY29udGVudAorCitUaGlzIHRlc3QgaGFz IHBhc3NlZCBpZiBpdCBkb2Vzbid0IGNyYXNoIG9yIEFTU0VSVC4KKworCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2ZsZXhib3gvYXNzZXJ0LWdlbmVyYXRlZC1kZXByZWNhdGVkLWZsZXhi b3guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZmxleGJveC9hc3NlcnQtZ2VuZXJhdGVkLWRlcHJl Y2F0ZWQtZmxleGJveC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmEzNWYwMjU1MTcxZGNmZTllYzcwNjM0YmNh MDAzMzAxMmZlZjgwMmIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2ZsZXhi b3gvYXNzZXJ0LWdlbmVyYXRlZC1kZXByZWNhdGVkLWZsZXhib3guaHRtbApAQCAtMCwwICsxLDE2 IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorICAgIDxzdHlsZT4KKyAgICAgICAgZGl2OmFm dGVyIHsKKyAgICAgICAgY29udGVudDogJ0dlbmVyYXRlZCBjb250ZW50IHdyYXBwZWQgaW4gYSBm bGV4LWJveC4nOworICAgICAgICBkaXNwbGF5OiAtd2Via2l0LWJveDsKKyAgICAgICAgfQorICAg IDwvc3R5bGU+CisgICAgPHNjcmlwdD4KKyAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQor ICAgICAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgPC9zY3JpcHQ+CisgICAg PHA+QnVnIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MTAwMyI+OTEwMDM8L2E+OiBBU1NFUlQoZ2VuQ2hpbGQtPmlzTGlzdE1hcmtlcigpIHx8IGdlbkNo aWxkLT5zdHlsZSgpLT5zdHlsZVR5cGUoKSA9PSBGSVJTVF9MRVRURVIpIHRyaWdnZXJlZCBvbiBm bGV4LWJveCBjb250ZW50PC9wPgorICAgIDxwPlRoaXMgdGVzdCBoYXMgcGFzc2VkIGlmIGl0IGRv ZXNuJ3QgY3Jhc2ggb3IgQVNTRVJULjwvcD4KKyAgICA8ZGl2PjwvZGl2PgorPC9odG1sPgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mbGV4Ym94L2Fzc2VydC1nZW5lcmF0ZWQtbmV3LWZs ZXhib3gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mbGV4Ym94L2Fzc2VydC1nZW5l cmF0ZWQtbmV3LWZsZXhib3gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjc0YmY1MmE0ZTVlMzYx ODllZmVmZWY5OWI5MDVlNWI4MmYxOGJiNTcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2ZsZXhib3gvYXNzZXJ0LWdlbmVyYXRlZC1uZXctZmxleGJveC1leHBlY3RlZC50eHQK QEAgLTAsMCArMSw1IEBACitCdWcgOTEwMDM6IEFTU0VSVChnZW5DaGlsZC0+aXNMaXN0TWFya2Vy KCkgfHwgZ2VuQ2hpbGQtPnN0eWxlKCktPnN0eWxlVHlwZSgpID09IEZJUlNUX0xFVFRFUikgdHJp Z2dlcmVkIG9uIGZsZXgtYm94IGNvbnRlbnQKKworVGhpcyB0ZXN0IGhhcyBwYXNzZWQgaWYgaXQg ZG9lc24ndCBjcmFzaCBvciBBU1NFUlQuCisKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9mbGV4Ym94L2Fzc2VydC1nZW5lcmF0ZWQtbmV3LWZsZXhib3guaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvZmxleGJveC9hc3NlcnQtZ2VuZXJhdGVkLW5ldy1mbGV4Ym94Lmh0bWwKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uYzU5NmJiYzBmMWMxODM1ZmI5Mzc1NjQ0ZGFiYjQ0MDJiMWE5YjViMQotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZmxleGJveC9hc3NlcnQtZ2VuZXJhdGVkLW5ldy1mbGV4 Ym94Lmh0bWwKQEAgLTAsMCArMSwxNiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgICA8 c3R5bGU+CisgICAgICAgIGRpdjphZnRlciB7CisgICAgICAgIGNvbnRlbnQ6ICdHZW5lcmF0ZWQg Y29udGVudCB3cmFwcGVkIGluIGEgZmxleC1ib3guJzsKKyAgICAgICAgZGlzcGxheTogLXdlYmtp dC1mbGV4OworICAgICAgICB9CisgICAgPC9zdHlsZT4KKyAgICA8c2NyaXB0PgorICAgICAgICBp ZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQo KTsKKyAgICA8L3NjcmlwdD4KKyAgICA8cD5CdWcgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMDAzIj45MTAwMzwvYT46IEFTU0VSVChnZW5DaGlsZC0+ aXNMaXN0TWFya2VyKCkgfHwgZ2VuQ2hpbGQtPnN0eWxlKCktPnN0eWxlVHlwZSgpID09IEZJUlNU X0xFVFRFUikgdHJpZ2dlcmVkIG9uIGZsZXgtYm94IGNvbnRlbnQ8L3A+CisgICAgPHA+VGhpcyB0 ZXN0IGhhcyBwYXNzZWQgaWYgaXQgZG9lc24ndCBjcmFzaCBvciBBU1NFUlQuPC9wPgorICAgIDxk aXY+PC9kaXY+Cis8L2h0bWw+Cg== 151990 2012-07-12 10:27:28 -0700 2012-07-12 13:54:16 -0700 Patch for landing bug-91003-20120712102726.patch text/plain 6100 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjZkNDc1MjJmZGI0NWJk MmRkNmQyNGEwMDUzY2VlMWFiOTljNThkYy4uNzQxOTZlZWU2NDMwNWU4YzE1MGNhODYyNzE2YzAx ZjZhNjIxYjU4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTEyICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIEFTU0VSVChn ZW5DaGlsZC0+aXNMaXN0TWFya2VyKCkgfHwgZ2VuQ2hpbGQtPnN0eWxlKCktPnN0eWxlVHlwZSgp ID09IEZJUlNUX0xFVFRFUikgdHJpZ2dlcmVkIG9uIGZsZXgtYm94IGNvbnRlbnQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMDAzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgQWJoaXNoZWsgQXJ5YS4KKworICAgICAgICBUZXN0czogZmFzdC9mbGV4Ym94 L2Fzc2VydC1nZW5lcmF0ZWQtZGVwcmVjYXRlZC1mbGV4Ym94Lmh0bWwKKyAgICAgICAgICAgICAg IGZhc3QvZmxleGJveC9hc3NlcnQtZ2VuZXJhdGVkLW5ldy1mbGV4Ym94Lmh0bWwKKworICAgICAg ICBUaGUgaXNzdWUgd2FzIHRoYXQgZmluZEJlZm9yZUFmdGVyUGFyZW50IGRpZG4ndCByZXR1cm4g dGhlIHJpZ2h0IHBhcmVudCBmb3IgdGhlIGZsZXgtYm94IGNhc2UuIFRoaXMgd291bGQKKyAgICAg ICAgbWFrZSB1cyB1cGRhdGUgdGhlIHdyb25nIGNoaWxkcmVuIChhbmQgbm90IHByb3BhZ2F0ZSB0 aGUgc3R5bGUgdXBkYXRlcyBwcm9wZXJseSkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy T2JqZWN0Q2hpbGRMaXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmZpbmRCZWZvcmVBZnRlclBh cmVudCk6CisgICAgICAgIEFkZGVkIGEgY2hlY2sgZm9yIGZsZXggYm94ZXMgKGJvdGggZGVwcmVj YXRlZCBhbmQgbmV3KS4KKwogMjAxMi0wNy0xMiAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxs YW4uamVuc2VuQG5va2lhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBCdWlsZCBmaXggZm9y IHIxMjI0NjIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2Jq ZWN0Q2hpbGRMaXN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3RD aGlsZExpc3QuY3BwCmluZGV4IDQyMjUwNGU2YmMxZGJjMjY3NTkzZjhiMjA5OTFiMTkzMzI1N2Mx YmIuLjdlYmFkNmZjZjJjY2IwZDE1ZDE4NGY5MzNlNjA4YjFlZjEwMDk1ZWEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3RDaGlsZExpc3QuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3RDaGlsZExpc3QuY3BwCkBAIC0y ODksOCArMjg5LDkgQEAgdm9pZCBSZW5kZXJPYmplY3RDaGlsZExpc3Q6Omluc2VydENoaWxkTm9k ZShSZW5kZXJPYmplY3QqIG93bmVyLCBSZW5kZXJPYmplY3QqIGMKIAogc3RhdGljIFJlbmRlck9i amVjdCogZmluZEJlZm9yZUFmdGVyUGFyZW50KFJlbmRlck9iamVjdCogb2JqZWN0KQogewotICAg IC8vIE9ubHkgdGFibGUgcGFydHMgbmVlZCB0byBzZWFyY2ggZm9yIHRoZSA6YmVmb3JlIG9yIDph ZnRlciBwYXJlbnQKLSAgICBpZiAoIShvYmplY3QtPmlzVGFibGUoKSB8fCBvYmplY3QtPmlzVGFi bGVTZWN0aW9uKCkgfHwgb2JqZWN0LT5pc1RhYmxlUm93KCkpKQorICAgIC8vIE9ubHkgdGFibGUg cGFydHMgYW5kIGZsZXgtYm94ZXMgbmVlZCB0byBzZWFyY2ggZm9yIHRoZSA6YmVmb3JlIG9yIDph ZnRlciBwYXJlbnQKKyAgICAvLyBGSVhNRTogV2UgY291bGQgbGlrZWx5IGdldCBhd2F5IHdpdGhv dXQgdGhpcyBjaGVjayBhbmQgYWx3YXlzIGxvb2sgZm9yIHRoZSByaWdodCBwYXJlbnQuCisgICAg aWYgKCEob2JqZWN0LT5pc1RhYmxlKCkgfHwgb2JqZWN0LT5pc1RhYmxlU2VjdGlvbigpIHx8IG9i amVjdC0+aXNUYWJsZVJvdygpIHx8IG9iamVjdC0+aXNGbGV4aWJsZUJveEluY2x1ZGluZ0RlcHJl Y2F0ZWQoKSkpCiAgICAgICAgIHJldHVybiBvYmplY3Q7CiAKICAgICAvLyBJZiB0aGVyZSBpcyBh IDpmaXJzdC1sZXR0ZXIgc3R5bGUgYXBwbGllZCBvbiB0aGUgOmJlZm9yZSBvciA6YWZ0ZXIgY29u dGVudCwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwppbmRleCBiNDEzNjRlNzVjZmNkZjgyYmVkMjM3NzRhNGU1NjU1ZTIwYzkwOGUwLi4x MGUwM2JlM2RmYWUyMjhlYTIzMzIzZjMzMzQ4OGQwYTkyYTIzN2RhIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTUgQEAKKzIwMTItMDctMTIgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5v cmc+CisKKyAgICAgICAgQVNTRVJUKGdlbkNoaWxkLT5pc0xpc3RNYXJrZXIoKSB8fCBnZW5DaGls ZC0+c3R5bGUoKS0+c3R5bGVUeXBlKCkgPT0gRklSU1RfTEVUVEVSKSB0cmlnZ2VyZWQgb24gZmxl eC1ib3ggY29udGVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTEwMDMKKworICAgICAgICBSZXZpZXdlZCBieSBBYmhpc2hlayBBcnlhLgorCisgICAg ICAgICogZmFzdC9mbGV4Ym94L2Fzc2VydC1nZW5lcmF0ZWQtZGVwcmVjYXRlZC1mbGV4Ym94LWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mbGV4Ym94L2Fzc2VydC1nZW5lcmF0 ZWQtZGVwcmVjYXRlZC1mbGV4Ym94Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZmxleGJv eC9hc3NlcnQtZ2VuZXJhdGVkLW5ldy1mbGV4Ym94LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogZmFzdC9mbGV4Ym94L2Fzc2VydC1nZW5lcmF0ZWQtbmV3LWZsZXhib3guaHRtbDogQWRk ZWQuCisKIDIwMTItMDctMTIgIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBJbmRleGVkREI6IFZlcmlmeSBpbnRlcm5hbCAiZGVsZXRlIHBlbmRpbmciIGZsYWcg b24gZGF0YWJhc2UKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZmxleGJveC9hc3NlcnQt Z2VuZXJhdGVkLWRlcHJlY2F0ZWQtZmxleGJveC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9m YXN0L2ZsZXhib3gvYXNzZXJ0LWdlbmVyYXRlZC1kZXByZWNhdGVkLWZsZXhib3gtZXhwZWN0ZWQu dHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLjc0YmY1MmE0ZTVlMzYxODllZmVmZWY5OWI5MDVlNWI4MmYxOGJiNTcK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2ZsZXhib3gvYXNzZXJ0LWdlbmVy YXRlZC1kZXByZWNhdGVkLWZsZXhib3gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAorQnVn IDkxMDAzOiBBU1NFUlQoZ2VuQ2hpbGQtPmlzTGlzdE1hcmtlcigpIHx8IGdlbkNoaWxkLT5zdHls ZSgpLT5zdHlsZVR5cGUoKSA9PSBGSVJTVF9MRVRURVIpIHRyaWdnZXJlZCBvbiBmbGV4LWJveCBj b250ZW50CisKK1RoaXMgdGVzdCBoYXMgcGFzc2VkIGlmIGl0IGRvZXNuJ3QgY3Jhc2ggb3IgQVNT RVJULgorCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZmxleGJveC9hc3NlcnQtZ2Vu ZXJhdGVkLWRlcHJlY2F0ZWQtZmxleGJveC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mbGV4Ym94 L2Fzc2VydC1nZW5lcmF0ZWQtZGVwcmVjYXRlZC1mbGV4Ym94Lmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMzZk OGZiMTllNTQ3YjlmOWJhMmE5MDRlMTFjY2U2Y2U0ZWQ2YmZkZQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvZmxleGJveC9hc3NlcnQtZ2VuZXJhdGVkLWRlcHJlY2F0ZWQtZmxl eGJveC5odG1sCkBAIC0wLDAgKzEsMTYgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+CisgICAg PHN0eWxlPgorICAgICAgICBkaXY6YWZ0ZXIgeworICAgICAgICAgICAgY29udGVudDogJ0dlbmVy YXRlZCBjb250ZW50IHdyYXBwZWQgaW4gYSBmbGV4LWJveC4nOworICAgICAgICAgICAgZGlzcGxh eTogLXdlYmtpdC1ib3g7CisgICAgICAgIH0KKyAgICA8L3N0eWxlPgorICAgIDxzY3JpcHQ+Cisg ICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgICAgIHRlc3RSdW5uZXIuZHVt cEFzVGV4dCgpOworICAgIDwvc2NyaXB0PgorICAgIDxwPkJ1ZyA8YSBocmVmPSJodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTEwMDMiPjkxMDAzPC9hPjogQVNTRVJUKGdl bkNoaWxkLT5pc0xpc3RNYXJrZXIoKSB8fCBnZW5DaGlsZC0+c3R5bGUoKS0+c3R5bGVUeXBlKCkg PT0gRklSU1RfTEVUVEVSKSB0cmlnZ2VyZWQgb24gZmxleC1ib3ggY29udGVudDwvcD4KKyAgICA8 cD5UaGlzIHRlc3QgaGFzIHBhc3NlZCBpZiBpdCBkb2Vzbid0IGNyYXNoIG9yIEFTU0VSVC48L3A+ CisgICAgPGRpdj48L2Rpdj4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv ZmxleGJveC9hc3NlcnQtZ2VuZXJhdGVkLW5ldy1mbGV4Ym94LWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2Zhc3QvZmxleGJveC9hc3NlcnQtZ2VuZXJhdGVkLW5ldy1mbGV4Ym94LWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi43NGJmNTJhNGU1ZTM2MTg5ZWZlZmVmOTliOTA1ZTViODJmMThiYjU3 Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mbGV4Ym94L2Fzc2VydC1nZW5l cmF0ZWQtbmV3LWZsZXhib3gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAorQnVnIDkxMDAz OiBBU1NFUlQoZ2VuQ2hpbGQtPmlzTGlzdE1hcmtlcigpIHx8IGdlbkNoaWxkLT5zdHlsZSgpLT5z dHlsZVR5cGUoKSA9PSBGSVJTVF9MRVRURVIpIHRyaWdnZXJlZCBvbiBmbGV4LWJveCBjb250ZW50 CisKK1RoaXMgdGVzdCBoYXMgcGFzc2VkIGlmIGl0IGRvZXNuJ3QgY3Jhc2ggb3IgQVNTRVJULgor CisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZmxleGJveC9hc3NlcnQtZ2VuZXJhdGVk LW5ldy1mbGV4Ym94Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2ZsZXhib3gvYXNzZXJ0LWdlbmVy YXRlZC1uZXctZmxleGJveC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmU2ZDhlZDE2N2MyM2E5YWIyNzE3ZGRl MjM3MTViNGQwYWNlZThjYTAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zs ZXhib3gvYXNzZXJ0LWdlbmVyYXRlZC1uZXctZmxleGJveC5odG1sCkBAIC0wLDAgKzEsMTYgQEAK KzwhRE9DVFlQRSBodG1sPgorPGh0bWw+CisgICAgPHN0eWxlPgorICAgICAgICBkaXY6YWZ0ZXIg eworICAgICAgICAgICAgY29udGVudDogJ0dlbmVyYXRlZCBjb250ZW50IHdyYXBwZWQgaW4gYSBm bGV4LWJveC4nOworICAgICAgICAgICAgZGlzcGxheTogLXdlYmtpdC1mbGV4OworICAgICAgICB9 CisgICAgPC9zdHlsZT4KKyAgICA8c2NyaXB0PgorICAgICAgICBpZiAod2luZG93LnRlc3RSdW5u ZXIpCisgICAgICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICA8L3NjcmlwdD4K KyAgICA8cD5CdWcgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTkxMDAzIj45MTAwMzwvYT46IEFTU0VSVChnZW5DaGlsZC0+aXNMaXN0TWFya2VyKCkgfHwg Z2VuQ2hpbGQtPnN0eWxlKCktPnN0eWxlVHlwZSgpID09IEZJUlNUX0xFVFRFUikgdHJpZ2dlcmVk IG9uIGZsZXgtYm94IGNvbnRlbnQ8L3A+CisgICAgPHA+VGhpcyB0ZXN0IGhhcyBwYXNzZWQgaWYg aXQgZG9lc24ndCBjcmFzaCBvciBBU1NFUlQuPC9wPgorICAgIDxkaXY+PC9kaXY+Cis8L2h0bWw+ Cg==