90991 2012-07-11 10:33:10 -0700 [Chromium] Enable LEGACY_VIEWPORT_ADAPTION 2012-07-11 13:02:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 abarth abarth danakj japhet johnme peter tony webkit.review.bot oldest_to_newest 666855 0 abarth 2012-07-11 10:33:10 -0700 [Chromium] Enable LEGACY_VIEWPORT_ADAPTION 666856 1 151730 abarth 2012-07-11 10:34:28 -0700 Created attachment 151730 Patch 666859 2 danakj 2012-07-11 10:40:03 -0700 Is there a nice summary of what this flag is meant to do? First time I heard of it :) What is this mobileoptimized business meant to be? 666864 3 peter 2012-07-11 10:43:50 -0700 LGTM from Android's side, good catch. This will also enable the feature on Desktop when viewports themselves are enabled. 666865 4 abarth 2012-07-11 10:45:24 -0700 If you look at the tests that this patch "fixes", you can get a good sense of what the feature does. Basically, it causes us to recognize a bunch of old ways of indicating content for mobile phones and then scaling the viewport appropriately. We ship this feature on chromium-android (it's enabled in the branch). We could just enable it there, but we generally like to minimize the differences between Chromium on various platforms, so I thought we should enable it everywhere that supports the viewport tag. 666866 5 danakj 2012-07-11 10:50:04 -0700 I see, thanks for the info. 666985 6 151730 webkit.review.bot 2012-07-11 13:02:27 -0700 Comment on attachment 151730 Patch Clearing flags on attachment: 151730 Committed r122359: <http://trac.webkit.org/changeset/122359> 666986 7 webkit.review.bot 2012-07-11 13:02:34 -0700 All reviewed patches have been landed. Closing bug. 151730 2012-07-11 10:34:28 -0700 2012-07-11 13:02:27 -0700 Patch bug-90991-20120711103427.patch text/plain 3358 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDJhMjUzZDVlYzVlYWUwODE4MjY5NjhkYWY5ZTc4ZDNhMzU3ZWU1YTguLjU5YjQxY2YzOGM2OTZi OTVmMmZhZmFmNjQxNDY4ZjVhNGI4ZTFlOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDctMTEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBbQ2hyb21pdW1dIEVuYWJsZSBMRUdBQ1lfVklFV1BPUlRfQURBUFRJT04K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwOTkxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hyb21pdW0g d2lzaGVzIHRvIHN1cHBvcnQgTEVHQUNZX1ZJRVdQT1JUX0FEQVBUSU9OLiBJIGFjdHVhbGx5IHRo b3VnaHQKKyAgICAgICAgdGhpcyB3YXMgZW5hYmxlZCBiZWZvcmUsIGJ1dCB0aGUgZW5hYmxlIGJp dCBnb3QgbG9zdCBpbiB0aGUgc2h1ZmZsZS4KKworICAgICAgICAqIGZlYXR1cmVzLmd5cGk6CisK IDIwMTItMDctMTAgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogbWlncmF0ZSBmcm9tIGJhY2tncm91bmQgaW1hZ2VzIHRvIENT UyBmb3Igc3RhdHVzYmFyIHJlbmRlcmluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vZmVhdHVyZXMuZ3lwaSBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lw aQppbmRleCA3YzAyYTAxMjczOTQ2Mjk3YjhjOTZmOWM3MTg2MWZiMTVhNDk0M2Q3Li4zNWY4NmNm MjQxMWFjODhmNTEwYTY5NTkzOTBlNTg2ZTE1MTdhN2QwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9m ZWF0dXJlcy5neXBpCkBAIC02OSw2ICs2OSw3IEBACiAgICAgICAnRU5BQkxFX0lOUFVUX1RZUEVf REFURT0xJywKICAgICAgICdFTkFCTEVfSkFWQVNDUklQVF9ERUJVR0dFUj0xJywKICAgICAgICdF TkFCTEVfTEVHQUNZX0NTU19WRU5ET1JfUFJFRklYRVM9MCcsCisgICAgICAnRU5BQkxFX0xFR0FD WV9WSUVXUE9SVF9BREFQVElPTj0xJywKICAgICAgICdFTkFCTEVfTEVHQUNZX1dFQktJVF9CTE9C X0JVSUxERVI9MScsCiAgICAgICAnRU5BQkxFX0xJTktfUFJFRkVUQ0g9MScsCiAgICAgICAnRU5B QkxFX0xJTktfUFJFUkVOREVSPTEnLApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDkyNGQ4YTM4Y2YyYjlhOWNhOGYwMjRmZDM0 YjNiYWU5Y2IyYTExMTYuLjAxNzhmYmExNmJmNmU2MTY2NmIyOTQ0OTQwOGQ2Nzg5YTRkODM2Y2Eg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wNy0xMSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3 ZWJraXQub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gRW5hYmxlIExFR0FDWV9WSUVXUE9SVF9B REFQVElPTgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTA5OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGVzZSB0ZXN0cyBwYXNzIG5vdyB0aGF0IHdlJ3ZlIGVuYWJsZWQgdGhpcyBmZWF0dXJlLgorCisg ICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxMi0wNy0x MSAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQG5va2lhLmNvbT4KIAogICAg ICAgICBOb2Rlc0Zyb21SZWN0IGRvZXNuJ3Qgd29yayBvbiBTVkcgcm9vdCBlbGVtZW50cy4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDlj NzZmNjJjYzllNGJiZDlmMDNiNDdkMTk5Y2Q0NDNkYjBiZmZkNjcuLjgyYjhkNjkyZWRhY2NlMTUy MmZjNjU2OGMyZTQ4ODQ2NTI0MTU4NWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hy b21pdW0vVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTEyOSwxNSArMTEyOSw2IEBAIFdPTlRGSVggU0tJ UCA6IG1lZGlhL21lZGlhLWZ1bGxzY3JlZW4tbm90LWluLWRvY3VtZW50Lmh0bWwgPSBUSU1FT1VU CiAvLyBXZSBkb24ndCBleHBvc2UgYSBzdGVwIGJ1dHRvbi4KIFdPTlRGSVggU0tJUCA6IG1lZGlh L2F1ZGlvLWRlbGV0ZS13aGlsZS1zdGVwLWJ1dHRvbi1jbGlja2VkLmh0bWwgPSBUSU1FT1VUCiAK LS8vIEZlYXR1cmUgZGlzYWJsZWQgb24gY2hyb21pdW0gYnVpbGQsIHNlZTogaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1NDI1Ci1XT05URklYIFNLSVAgOiBmYXN0L3Zp ZXdwb3J0L3ZpZXdwb3J0LWxlZ2FjeS14aHRtbG1wLmh0bWwgPSBURVhUCi1XT05URklYIFNLSVAg OiBmYXN0L3ZpZXdwb3J0L3ZpZXdwb3J0LWxlZ2FjeS1oYW5kaGVsZGZyaWVuZGx5Lmh0bWwgPSBU RVhUCi1XT05URklYIFNLSVAgOiBmYXN0L3ZpZXdwb3J0L3ZpZXdwb3J0LWxlZ2FjeS1tb2JpbGVv cHRpbWl6ZWQtMi5odG1sID0gVEVYVAotV09OVEZJWCBTS0lQIDogZmFzdC92aWV3cG9ydC92aWV3 cG9ydC1sZWdhY3ktbW9iaWxlb3B0aW1pemVkLTMuaHRtbCA9IFRFWFQKLVdPTlRGSVggU0tJUCA6 IGZhc3Qvdmlld3BvcnQvdmlld3BvcnQtbGVnYWN5LW1vYmlsZW9wdGltaXplZC5odG1sID0gVEVY VAotV09OVEZJWCBTS0lQIDogZmFzdC92aWV3cG9ydC92aWV3cG9ydC1sZWdhY3ktb3JkZXJpbmct NS5odG1sID0gVEVYVAotV09OVEZJWCBTS0lQIDogZmFzdC92aWV3cG9ydC92aWV3cG9ydC1sZWdh Y3ktb3JkZXJpbmctNi5odG1sID0gVEVYVAotCiAvLyBXZSBoYXZlbid0IGltcGxlbWVudGVkIHJl dmVyc2UgYXVkaW8vdmlkZW8gcGxheWJhY2suCiBCVUdDUjMzMDk5IFNLSVAgOiBtZWRpYS92aWRl by1yZXZlcnNlLXBsYXktZHVyYXRpb24uaHRtbCA9IFRJTUVPVVQKIEJVR0NSMzMwOTkgU0tJUCA6 IG1lZGlhL3ZpZGVvLXRpbWV1cGRhdGUtcmV2ZXJzZS1wbGF5Lmh0bWwgPSBUSU1FT1VUCg==