90962 2012-07-11 03:56:04 -0700 [BlackBerry] We shouldn't call didFinishLoading for the old request when a new request has been sent by notifyAuthReceived. 2012-07-15 19:53:38 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 jasonliuwebkit webkit-unassigned joenotcharles mifenton rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 666623 0 jasonliuwebkit 2012-07-11 03:56:04 -0700 We should do like 301's handling. 666626 1 jasonliuwebkit 2012-07-11 04:01:01 -0700 A patch is coming tomorrow. 667439 2 151868 jasonliuwebkit 2012-07-11 23:45:55 -0700 Created attachment 151868 Patch 668166 3 151868 rwlbuis 2012-07-12 13:45:05 -0700 Comment on attachment 151868 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151868&action=review > Source/WebCore/ChangeLog:11 > + We should do as 3XX. Any PR? Internal review? > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:-507 > - return true; Why was this part removed? 668484 4 jasonliuwebkit 2012-07-12 18:35:00 -0700 (In reply to comment #3) > (From update of attachment 151868 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151868&action=review > > > Source/WebCore/ChangeLog:11 > > + We should do as 3XX. > > Any PR? Internal review? > There is no PR for this. I just find this problem when fixing another pr. > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:-507 > > - return true; > > Why was this part removed? I moved "if (m_redirectCount >= s_redirectMaximum)" to handleRedirect(). 669015 5 151868 joenotcharles 2012-07-13 07:33:53 -0700 Comment on attachment 151868 Patch LGTM. Nice catch! 669018 6 151868 rwlbuis 2012-07-13 07:36:51 -0700 Comment on attachment 151868 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151868&action=review Looks good. >>> Source/WebCore/ChangeLog:11 >>> + We should do as 3XX. >> >> There is no PR for this. I just find this problem when fixing another pr. > > Any PR? Internal review? Ok, you could add Joe Mason as internal reviewer before landing, up to you. 670052 7 151868 webkit.review.bot 2012-07-15 19:53:32 -0700 Comment on attachment 151868 Patch Clearing flags on attachment: 151868 Committed r122692: <http://trac.webkit.org/changeset/122692> 670053 8 webkit.review.bot 2012-07-15 19:53:38 -0700 All reviewed patches have been landed. Closing bug. 151868 2012-07-11 23:45:55 -0700 2012-07-15 19:53:32 -0700 Patch bug-90962-20120712144551.patch text/plain 3961 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWMzYWZhYjk3OTk3ZTE1 OTZkYjBiZTI5MmVlNWFmMGRlYjhjNzkyNC4uNTlmZTgxMmZmYmVjZDA4NjY5YmQzZTRhYWRiZmQ5 NTcwYWUyMTkxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA3LTExICBKYXNv biBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XSBXZSBzaG91bGRuJ3QgY2FsbCBkaWRGaW5pc2hMb2FkaW5nIGZvciB0aGUgb2xkIHJlcXVl c3Qgd2hlbiBhIG5ldyByZXF1ZXN0IGhhcyBiZWVuIHNlbnQgYnkgbm90aWZ5QXV0aFJlY2VpdmVk LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA5NjIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBzdGFy dCBhIG5ldyBOZXR3b3JrSm9iIHdpdGggY3JlZGVudGlhbHMgYWZ0ZXIgcmVjZWl2aW5nIDQwMS80 MDcgc3RhdHVzLgorICAgICAgICBXZSBzaG91bGQgbm90IHJlbGVhc2UgcmVzb3VyY2VzIGluIHdl YmNvcmUgd2hlbiB0aGUgb2xkIGpvYiBpcyBjbG9zZWQgYmVjYXVzZQorICAgICAgICB0aGV5IGFy ZSBuZWVkZWQgYnkgdGhlIG5ldyBvbmUuCisgICAgICAgIFdlIHNob3VsZCBkbyBhcyAzWFguCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3VyLgorCisgICAgICAg ICogcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TmV0d29ya0pvYjo6TmV0d29ya0pvYik6CisgICAgICAgIChXZWJDb3JlOjpOZXR3 b3JrSm9iOjpub3RpZnlBdXRoUmVjZWl2ZWQpOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pv Yjo6c2hvdWxkUmVsZWFzZUNsaWVudFJlc291cmNlKToKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdv cmtKb2I6OmhhbmRsZVJlZGlyZWN0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2JsYWNr YmVycnkvTmV0d29ya0pvYi5oOgorICAgICAgICAoTmV0d29ya0pvYik6CisKIDIwMTItMDctMTEg IE1hdHQgRmFsa2VuaGFnZW4gIDxmYWxrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBk aWFsb2cgZWxlbWVudCBmZWF0dXJlIHRvZ2dsZSB0byBJbnRlcm5hbFNldHRpbmdzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pv Yi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29y a0pvYi5jcHAKaW5kZXggYzY0ZmRjOGFhY2M3MjA1MzdhN2E1NmVhOTg1YTA3YTMzOGFhZmZiZS4u OGU1YjNhODliYTdhMjczMTIwN2I0YTU0MjMwNDdlNTE4MjllZDU1MCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9i LmNwcApAQCAtODIsNiArODIsNyBAQCBOZXR3b3JrSm9iOjpOZXR3b3JrSm9iKCkKICAgICAsIG1f Y2FsbGluZ0NsaWVudChmYWxzZSkKICAgICAsIG1fbmVlZHNSZXRyeUFzRlRQRGlyZWN0b3J5KGZh bHNlKQogICAgICwgbV9pc092ZXJyaWRlQ29udGVudFR5cGUoZmFsc2UpCisgICAgLCBtX25ld0pv YldpdGhDcmVkZW50aWFsc1N0YXJ0ZWQoZmFsc2UpCiAgICAgLCBtX2V4dGVuZGVkU3RhdHVzQ29k ZSgwKQogICAgICwgbV9yZWRpcmVjdENvdW50KDApCiAgICAgLCBtX2RlZmVycmVkRGF0YSgqdGhp cykKQEAgLTI4MSw3ICsyODIsNyBAQCB2b2lkIE5ldHdvcmtKb2I6Om5vdGlmeUF1dGhSZWNlaXZl ZChCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6TmV0d29ya1JlcXVlc3Q6OkF1dGhUeQogICAgICAgICBy ZXR1cm47CiAgICAgfQogCi0gICAgc2VuZFJlcXVlc3RXaXRoQ3JlZGVudGlhbHMoc2VydmVyVHlw ZSwgc2NoZW1lLCByZWFsbSk7CisgICAgbV9uZXdKb2JXaXRoQ3JlZGVudGlhbHNTdGFydGVkID0g c2VuZFJlcXVlc3RXaXRoQ3JlZGVudGlhbHMoc2VydmVyVHlwZSwgc2NoZW1lLCByZWFsbSk7CiB9 CiAKIHZvaWQgTmV0d29ya0pvYjo6bm90aWZ5U3RyaW5nSGVhZGVyUmVjZWl2ZWQoY29uc3QgU3Ry aW5nJiBrZXksIGNvbnN0IFN0cmluZyYgdmFsdWUpCkBAIC01MDMsMTUgKzUwNCw4IEBAIHZvaWQg TmV0d29ya0pvYjo6aGFuZGxlTm90aWZ5Q2xvc2UoaW50IHN0YXR1cykKIAogYm9vbCBOZXR3b3Jr Sm9iOjpzaG91bGRSZWxlYXNlQ2xpZW50UmVzb3VyY2UoKQogewotICAgIGlmIChtX3JlZGlyZWN0 Q291bnQgPj0gc19yZWRpcmVjdE1heGltdW0pCi0gICAgICAgIHJldHVybiB0cnVlOwotCi0gICAg aWYgKG1fbmVlZHNSZXRyeUFzRlRQRGlyZWN0b3J5ICYmIHJldHJ5QXNGVFBEaXJlY3RvcnkoKSkK LSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgaWYgKGlzUmVkaXJlY3QobV9leHRlbmRlZFN0 YXR1c0NvZGUpICYmIGhhbmRsZVJlZGlyZWN0KCkpCisgICAgaWYgKChtX25lZWRzUmV0cnlBc0ZU UERpcmVjdG9yeSAmJiByZXRyeUFzRlRQRGlyZWN0b3J5KCkpIHx8IChpc1JlZGlyZWN0KG1fZXh0 ZW5kZWRTdGF0dXNDb2RlKSAmJiBoYW5kbGVSZWRpcmVjdCgpKSB8fCBtX25ld0pvYldpdGhDcmVk ZW50aWFsc1N0YXJ0ZWQpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLQogICAgIHJldHVybiB0cnVl OwogfQogCkBAIC01NzQsNyArNTY4LDcgQEAgYm9vbCBOZXR3b3JrSm9iOjpzdGFydE5ld0pvYldp dGhSZXF1ZXN0KFJlc291cmNlUmVxdWVzdCYgbmV3UmVxdWVzdCwgYm9vbCBpbmNyZWEKIGJvb2wg TmV0d29ya0pvYjo6aGFuZGxlUmVkaXJlY3QoKQogewogICAgIEFTU0VSVChtX2hhbmRsZSk7Ci0g ICAgaWYgKCFtX2hhbmRsZSkKKyAgICBpZiAoIW1faGFuZGxlIHx8IG1fcmVkaXJlY3RDb3VudCA+ PSBzX3JlZGlyZWN0TWF4aW11bSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgU3RyaW5n IGxvY2F0aW9uID0gbV9yZXNwb25zZS5odHRwSGVhZGVyRmllbGQoIkxvY2F0aW9uIik7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29y a0pvYi5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdv cmtKb2IuaAppbmRleCBhOWE3Yjg4MWJmNDQ3NWVlNzBlYWNhYzYxYmJlZDU0NDE4ODc5ZDliLi5k MjMxM2ZkNDk1OGQ5NzQ4ZjRiOGM3ZjU2YjRiZmRlYmY3YzgxNjMzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmgK QEAgLTE2NCw2ICsxNjQsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9jYWxsaW5nQ2xpZW50Owog ICAgIGJvb2wgbV9uZWVkc1JldHJ5QXNGVFBEaXJlY3Rvcnk7CiAgICAgYm9vbCBtX2lzT3ZlcnJp ZGVDb250ZW50VHlwZTsKKyAgICBib29sIG1fbmV3Sm9iV2l0aENyZWRlbnRpYWxzU3RhcnRlZDsK IAogICAgIC8vIElmIGFuIEhUVFAgc3RhdHVzIGNvZGUgaXMgcmVjZWl2ZWQsIG1fZXh0ZW5kZWRT dGF0dXNDb2RlIGFuZCBtX3Jlc3BvbnNlLmh0dHBTdGF0dXNDb2RlIHdpbGwgYm90aCBiZSBzZXQg dG8gaXQuCiAgICAgLy8gSWYgYSBwbGF0Zm9ybSBlcnJvciBjb2RlIGlzIHJlY2VpdmVkLCBtX2V4 dGVuZGVkU3RhdHVzQ29kZSB3aWxsIGJlIHNldCB0byBpdCBhbmQgbV9yZXNwb25zZS5odHRwU3Rh dHVzQ29kZSB3aWxsIGJlIHNldCB0byA0MDQuCg==