90943 2012-07-10 23:23:56 -0700 [Qt] REGRESSION(r122250): It broke USE(3D_GRAPHICS)=1 and ENABLE(WEBGL)=0 builds 2012-07-11 08:08:30 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 90567 1 ossy webkit-unassigned jnetterfield ossy rwlbuis oldest_to_newest 666397 0 ossy 2012-07-10 23:23:56 -0700 /usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(Extensions3DOpenGL.o): in function WebCore::Extensions3DOpenGL::~Extensions3DOpenGL():Extensions3DOpenGL.cpp(.text._ZN7WebCore18Extensions3DOpenGLD1Ev+0x24): error: undefined reference to 'WebCore::Extensions3DOpenGLCommon::~Extensions3DOpenGLCommon()' /usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(Extensions3DOpenGL.o): in function WebCore::Extensions3DOpenGL::~Extensions3DOpenGL():Extensions3DOpenGL.cpp(.text._ZN7WebCore18Extensions3DOpenGLD2Ev+0x24): error: undefined reference to 'WebCore::Extensions3DOpenGLCommon::~Extensions3DOpenGLCommon()' /usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(Extensions3DOpenGL.o): in function WebCore::Extensions3DOpenGL::~Extensions3DOpenGL():Extensions3DOpenGL.cpp(.text._ZN7WebCore18Extensions3DOpenGLD0Ev+0x25): error: undefined reference to 'WebCore::Extensions3DOpenGLCommon::~Extensions3DOpenGLCommon()' /usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(Extensions3DOpenGL.o): in function WebCore::Extensions3DOpenGL::Extensions3DOpenGL(WebCore::GraphicsContext3D*):Extensions3DOpenGL.cpp(.text._ZN7WebCore18Extensions3DOpenGLC1EPNS_17GraphicsContext3DE+0x21): error: undefined reference to 'WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon(WebCore::GraphicsContext3D*)' /usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(Extensions3DOpenGL.o): in function WebCore::Extensions3DOpenGL::Extensions3DOpenGL(WebCore::GraphicsContext3D*):Extensions3DOpenGL.cpp(.text._ZN7WebCore18Extensions3DOpenGLC2EPNS_17GraphicsContext3DE+0x21): error: undefined reference to 'WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon(WebCore::GraphicsContext3D*)' /usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(Extensions3DOpenGL.o): in function vtable for WebCore::Extensions3DOpenGL:Extensions3DOpenGL.cpp(.data.rel.ro._ZTVN7WebCore18Extensions3DOpenGLE+0x10): error: undefined reference to 'WebCore::Extensions3DOpenGLCommon::supports(WTF::String const&)' /usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(Extensions3DOpenGL.o): in function vtable for WebCore::Extensions3DOpenGL:Extensions3DOpenGL.cpp(.data.rel.ro._ZTVN7WebCore18Extensions3DOpenGLE+0x14): error: undefined reference to 'WebCore::Extensions3DOpenGLCommon::ensureEnabled(WTF::String const&)' /usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(Extensions3DOpenGL.o): in function vtable for WebCore::Extensions3DOpenGL:Extensions3DOpenGL.cpp(.data.rel.ro._ZTVN7WebCore18Extensions3DOpenGLE+0x18): error: undefined reference to 'WebCore::Extensions3DOpenGLCommon::isEnabled(WTF::String const&)' /usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(Extensions3DOpenGL.o): in function vtable for WebCore::Extensions3DOpenGL:Extensions3DOpenGL.cpp(.data.rel.ro._ZTVN7WebCore18Extensions3DOpenGLE+0x1c): error: undefined reference to 'WebCore::Extensions3DOpenGLCommon::getGraphicsResetStatusARB()' /usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(Extensions3DOpenGL.o): in function vtable for WebCore::Extensions3DOpenGL:Extensions3DOpenGL.cpp(.data.rel.ro._ZTVN7WebCore18Extensions3DOpenGLE+0x38): error: undefined reference to 'WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE(unsigned int)' /usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(Extensions3DOpenGL.o): in function vtable for WebCore::Extensions3DOpenGL:Extensions3DOpenGL.cpp(.data.rel.ro._ZTVN7WebCore18Extensions3DOpenGLE+0x48): error: undefined reference to 'WebCore::Extensions3DOpenGLCommon::initializeAvailableExtensions()' /usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(Extensions3DOpenGL.o): in function typeinfo for WebCore::Extensions3DOpenGL:Extensions3DOpenGL.cpp(.data.rel.ro._ZTIN7WebCore18Extensions3DOpenGLE+0x8): error: undefined reference to 'typeinfo for WebCore::Extensions3DOpenGLCommon' 666400 1 ossy 2012-07-10 23:28:06 -0700 I think the root of the problem is that USE(3D_GRAPHICS)=1 and ENABLE(WEBGL)=0 for the --minimal build. But Extensions3DOpenGLCommon.cpp is ENABLE(WEBGL)guarded and Extensions3DOpenGL.cpp is USE(3D_GRAPHICS) guarded. 666739 2 151703 jnetterfield 2012-07-11 07:22:41 -0700 Created attachment 151703 Patch 666764 3 151703 ossy 2012-07-11 08:06:40 -0700 Comment on attachment 151703 Patch LGTM, r=me. 666765 4 151703 ossy 2012-07-11 08:08:21 -0700 Comment on attachment 151703 Patch Clearing flags on attachment: 151703 Committed r122334: <http://trac.webkit.org/changeset/122334> 666766 5 ossy 2012-07-11 08:08:30 -0700 All reviewed patches have been landed. Closing bug. 151703 2012-07-11 07:22:41 -0700 2012-07-11 08:08:21 -0700 Patch bug-90943-20120711102213.patch text/plain 2410 jnetterfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2NjMjQ4MzhhZjQ2NDBm YmVhNjIzZjFjNzFiZThhYWQ3YmI0NmUwYS4uNGE1YmIzZThlODcwZTNiMzAwYTEyNDkxM2MxZjEx YWE5MzY0N2JmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTExICBKb3No dWEgTmV0dGVyZmllbGQgIDxqbmV0dGVyZmllbGRAcmltLmNvbT4KKworICAgICAgICBbUXRdIFJF R1JFU1NJT04ocjEyMjI1MCk6IEl0IGJyb2tlIFVTRSgzRF9HUkFQSElDUyk9MSBhbmQgRU5BQkxF KFdFQkdMKT0wIGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTA5NDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBVc2VzIHByb3BlciBndWFyZGluZyBpbiBFeHRlbnNpb25zM0RPcGVuR0xDb21tb24g YW5kIEV4dGVuc2lvbnMzRE9wZW5HTEVTIGFzIHBlciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTA1MDYuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBiZWNhc3VlIHRo ZXJlIGlzIG5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTENvbW1vbi5jcHA6IFVzZSBwcm9wZXIgZ3VhcmRp bmcuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5H TEVTLmNwcDogVXNlIHByb3BlciBndWFyZGluZy4KKwogMjAxMi0wNy0xMSAgVnNldm9sb2QgVmxh c292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBNb3Zl IHJldmlzaW9ucyBzdXBwb3J0IHRvIFVJU291cmNlQ29kZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xDb21tb24u Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMz RE9wZW5HTENvbW1vbi5jcHAKaW5kZXggNTc3MjM1NjBjOTZhZmIwMTRiZDg1MzM1Nzg1ZDZmNWE0 ODMyNjQ2Ny4uNWE2Mjg4MTBkZmQxMjc2NzA2MGVhMGY0ZTYyMTgwMmM2OWEzYThlYiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMz RE9wZW5HTENvbW1vbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv b3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTENvbW1vbi5jcHAKQEAgLTI2LDcgKzI2LDcgQEAKIAog I2luY2x1ZGUgImNvbmZpZy5oIgogCi0jaWYgRU5BQkxFKFdFQkdMKQorI2lmIFVTRSgzRF9HUkFQ SElDUykKICNpbmNsdWRlICJFeHRlbnNpb25zM0RPcGVuR0xDb21tb24uaCIKIAogI2luY2x1ZGUg IkFOR0xFV2ViS2l0QnJpZGdlLmgiCkBAIC0xNDUsNCArMTQ1LDQgQEAgdm9pZCBFeHRlbnNpb25z M0RPcGVuR0xDb21tb246OmluaXRpYWxpemVBdmFpbGFibGVFeHRlbnNpb25zKCkKIAogfSAvLyBu YW1lc3BhY2UgV2ViQ29yZQogCi0jZW5kaWYgLy8gRU5BQkxFKFdFQkdMKQorI2VuZGlmIC8vIFVT RSgzRF9HUkFQSElDUykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xFUy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMRVMuY3BwCmluZGV4IGUyMWY1 NTlhZGRmZDQzNWZlNjhkZDA5MGIxMzg1NmY0NjVjMzRmNTIuLmQ0ODZjNTA0NDA5NGJjOGZkODYz NDA2NzE2NmYwN2Q5MTkxNmE3ODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xFUy5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTEVTLmNwcApA QCAtMjUsNyArMjUsNyBAQAogICovCiAKICNpbmNsdWRlICJjb25maWcuaCIKLSNpZiBFTkFCTEUo V0VCR0wpCisjaWYgVVNFKDNEX0dSQVBISUNTKQogI2luY2x1ZGUgIkV4dGVuc2lvbnMzRE9wZW5H TEVTLmgiCiAKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQzRC5oIgpAQCAtMTQ2LDQgKzE0Niw0 IEBAIFN0cmluZyBFeHRlbnNpb25zM0RPcGVuR0xFUzo6Z2V0RXh0ZW5zaW9ucygpCiAKIH0gLy8g bmFtZXNwYWNlIFdlYkNvcmUKIAotI2VuZGlmIC8vIEVOQUJMRShXRUJHTCkKKyNlbmRpZiAvLyBV U0UoM0RfR1JBUEhJQ1MpCg==