90937 2012-07-10 21:47:34 -0700 Improve BiquadFilterNode test case 2012-07-22 19:12:16 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 li.yin li.yin crogers eric.carlson feature-media-reviews haraken kbr webkit.review.bot oldest_to_newest 666333 0 li.yin 2012-07-10 21:47:34 -0700 Improve BiquadFilterNode test to cover constant value and number of inputs and outputs. 666335 1 151592 li.yin 2012-07-10 21:51:10 -0700 Created attachment 151592 Patch 673641 2 151592 rtoy 2012-07-19 10:31:02 -0700 Comment on attachment 151592 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151592&action=review Except for the couple of nits, this looks fine. > LayoutTests/webaudio/biquadfilternode-basic.html:31 > + shouldBeTrue("filter.numberOfOutputs === 1"); I think it reads better if the text said something like "Number of inputs to Biquad filter = 1" "Number of outputs of Biquad filter = 1" > LayoutTests/webaudio/biquadfilternode-basic.html:38 > + var typeArray = [filter.LOWPASS, Rename typeArray to filterTypeArray? 675141 3 153639 li.yin 2012-07-20 18:56:03 -0700 Created attachment 153639 Patch 675144 4 li.yin 2012-07-20 19:02:36 -0700 (In reply to comment #2) > (From update of attachment 151592 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151592&action=review > > Except for the couple of nits, this looks fine. > > > LayoutTests/webaudio/biquadfilternode-basic.html:31 > > + shouldBeTrue("filter.numberOfOutputs === 1"); > > I think it reads better if the text said something like > > "Number of inputs to Biquad filter = 1" > "Number of outputs of Biquad filter = 1" > Most of other models like using shouleBe(), such as FileAPI, it looks more simple, and also decreases the code lines. Anyway, fixed. > > LayoutTests/webaudio/biquadfilternode-basic.html:38 > > + var typeArray = [filter.LOWPASS, > > Rename typeArray to filterTypeArray? Done. Thanks for your comments. 675230 5 153639 haraken 2012-07-21 04:09:09 -0700 Comment on attachment 153639 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153639&action=review LGTM > LayoutTests/webaudio/biquadfilternode-basic.html:-38 > - // FIXME: use last defined filter constant (ALLPASS) instead of hard-coded 7 once it's defined in the IDL. Let's add the link to the spec (http://www.w3.org/TR/webaudio/#BiquadFilterNode) to ChangeLog. 675383 6 153714 li.yin 2012-07-22 18:10:21 -0700 Created attachment 153714 Patch 675384 7 153714 haraken 2012-07-22 18:13:50 -0700 Comment on attachment 153714 Patch LGTM. rtoy@ is LGTMing too. Let me r+ it. 675398 8 153714 webkit.review.bot 2012-07-22 19:12:12 -0700 Comment on attachment 153714 Patch Clearing flags on attachment: 153714 Committed r123306: <http://trac.webkit.org/changeset/123306> 675399 9 webkit.review.bot 2012-07-22 19:12:16 -0700 All reviewed patches have been landed. Closing bug. 151592 2012-07-10 21:51:10 -0700 2012-07-20 18:55:57 -0700 Patch bug-90937-20120712125526.patch text/plain 3633 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjgyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjIzY2NkOTBhNTAzYmZiNjYyNzA3 YzcxZDg5MWI1YjcwMWM5NTc5Zi4uYzc0NDVmYjNlYTEwMWEzNmFjOTZkZTMyMmRlM2NkNzgxZTM3 MjY2MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTExICBMaSBZaW4gIDxsaS55aW5A aW50ZWwuY29tPgorCisgICAgICAgIEltcHJvdmUgQmlxdWFkRmlsdGVyTm9kZSB0ZXN0IGNhc2UK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwOTM3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wcm92ZSBC aXF1YWRGaWx0ZXJOb2RlIHRlc3QgdG8gY292ZXIgY29uc3RhbnQgdmFsdWUgYW5kIG51bWJlciBv ZiBpbnB1dHMgYW5kIG91dHB1dHMuCisKKyAgICAgICAgKiB3ZWJhdWRpby9iaXF1YWRmaWx0ZXJu b2RlLWJhc2ljLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiB3ZWJhdWRpby9iaXF1YWRmaWx0ZXJu b2RlLWJhc2ljLmh0bWw6CisKIDIwMTItMDctMTAgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29n bGUuY29tPgogCiAgICAgICAgIExpbmUgZGlyZWN0aXZlIHRlc3QgaW4gZmFzdC9jYW52YXMvd2Vi Z2wvZ2xzbC1jb25mb3JtYW5jZS5odG1sIGlzIGluY29ycmVjdApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvd2ViYXVkaW8vYmlxdWFkZmlsdGVybm9kZS1iYXNpYy1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy93ZWJhdWRpby9iaXF1YWRmaWx0ZXJub2RlLWJhc2ljLWV4cGVjdGVkLnR4dAppbmRl eCBhOTkyMTA0NTIyZTM3MjRiMzQ4ZjJiYjFiMzU1Y2FjYTQ2OGNmZWVlLi5jOWUzMWE4MzA2MmZh ODg4YWY4NTI0YjgyOWI1NDhiZDVlZjNmZWJmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy93ZWJh dWRpby9iaXF1YWRmaWx0ZXJub2RlLWJhc2ljLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0 cy93ZWJhdWRpby9iaXF1YWRmaWx0ZXJub2RlLWJhc2ljLWV4cGVjdGVkLnR4dApAQCAtMiw2ICsy LDggQEAgQmFzaWMgdGVzdHMgZm9yIEJpcXVhZEZpbHRlck5vZGUuCiAKIE9uIHN1Y2Nlc3MsIHlv dSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNU IENPTVBMRVRFIi4KIAorUEFTUyBmaWx0ZXIubnVtYmVyT2ZJbnB1dHMgPT09IDEgaXMgdHJ1ZQor UEFTUyBmaWx0ZXIubnVtYmVyT2ZPdXRwdXRzID09PSAxIGlzIHRydWUKIFBBU1MgQmlxdWFkIGZp bHRlciBkZWZhdWx0cyB0byBsb3ctcGFzcyBmaWx0ZXIuCiBQQVNTIEJpcXVhZCBmaWx0ZXIgdHlw ZSAwIGlzIHNldHRhYmxlLgogUEFTUyBCaXF1YWQgZmlsdGVyIHR5cGUgMSBpcyBzZXR0YWJsZS4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3dlYmF1ZGlvL2JpcXVhZGZpbHRlcm5vZGUtYmFzaWMu aHRtbCBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL2JpcXVhZGZpbHRlcm5vZGUtYmFzaWMuaHRtbApp bmRleCBmMWM5ZTUwMGM5NDJkMDE1NWNiYjhlMjc0M2ExMDljMjY5ZTJiNTYxLi5jZjYxNzc1ZmYy NWMxM2E1YzZlODhjZDA0MjkxMzhmZDJhYzJhNWMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy93 ZWJhdWRpby9iaXF1YWRmaWx0ZXJub2RlLWJhc2ljLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvd2Vi YXVkaW8vYmlxdWFkZmlsdGVybm9kZS1iYXNpYy5odG1sCkBAIC0yNiwyMSArMjYsMjggQEAgZnVu Y3Rpb24gcnVuVGVzdCgpIHsKICAgICBjb250ZXh0ID0gbmV3IHdlYmtpdEF1ZGlvQ29udGV4dCgp OwogICAgIHZhciBmaWx0ZXIgPSBjb250ZXh0LmNyZWF0ZUJpcXVhZEZpbHRlcigpOwogICAgIAot ICAgIC8vIEZJWE1FOiB3ZSBuZWVkIHRvIGV4cG9zZSB0aGUgYWN0dWFsIGZpbHRlciB0eXBlIGNv bnN0YW50cyBpbiB0aGUgSURMCi0gICAgCi0gICAgLy8gQ2hlY2sgdGhlIGZpbHRlciB0eXBlLgot ICAgIGlmIChmaWx0ZXIudHlwZSA9PSAwKQorICAgIHdpbmRvdy5maWx0ZXIgPSBmaWx0ZXI7Cisg ICAgc2hvdWxkQmVUcnVlKCJmaWx0ZXIubnVtYmVyT2ZJbnB1dHMgPT09IDEiKTsKKyAgICBzaG91 bGRCZVRydWUoImZpbHRlci5udW1iZXJPZk91dHB1dHMgPT09IDEiKTsKKyAgICBpZiAoZmlsdGVy LnR5cGUgPT09IGZpbHRlci5MT1dQQVNTKQogICAgICAgICB0ZXN0UGFzc2VkKCJCaXF1YWQgZmls dGVyIGRlZmF1bHRzIHRvIGxvdy1wYXNzIGZpbHRlci4iKTsKICAgICBlbHNlCiAgICAgICAgIHRl c3RGYWlsZWQoIkJpcXVhZCBmaWx0ZXIgc2hvdWxkIGRlZmF1bHQgdG8gbG93LXBhc3MgZmlsdGVy LiIpOwogCiAgICAgLy8gQ2hlY2sgdGhhdCBhbGwgbGVnYWwgZmlsdGVyIHR5cGVzIGNhbiBiZSBz ZXQuCi0gICAgLy8gRklYTUU6IHVzZSBsYXN0IGRlZmluZWQgZmlsdGVyIGNvbnN0YW50IChBTExQ QVNTKSBpbnN0ZWFkIG9mIGhhcmQtY29kZWQgNyBvbmNlIGl0J3MgZGVmaW5lZCBpbiB0aGUgSURM LgotICAgIGZvciAodmFyIGkgPSAwOyBpIDw9IDc7ICsraSkgeworICAgIHZhciB0eXBlQXJyYXkg PSBbZmlsdGVyLkxPV1BBU1MsCisgICAgICAgICAgICAgICAgICAgICBmaWx0ZXIuSElHSFBBU1Ms CisgICAgICAgICAgICAgICAgICAgICBmaWx0ZXIuQkFORFBBU1MsCisgICAgICAgICAgICAgICAg ICAgICBmaWx0ZXIuTE9XU0hFTEYsCisgICAgICAgICAgICAgICAgICAgICBmaWx0ZXIuSElHSFNI RUxGLAorICAgICAgICAgICAgICAgICAgICAgZmlsdGVyLlBFQUtJTkcsCisgICAgICAgICAgICAg ICAgICAgICBmaWx0ZXIuTk9UQ0gsCisgICAgICAgICAgICAgICAgICAgICBmaWx0ZXIuQUxMUEFT U107CisKKyAgICBmb3IgKHZhciBpID0gMDsgaSA8IHR5cGVBcnJheS5sZW5ndGg7ICsraSkgewog ICAgICAgICB0cnkgewotICAgICAgICAgICAgZmlsdGVyLnR5cGUgPSBpOwotICAgICAgICAgICAg Ci0gICAgICAgICAgICBpZiAoZmlsdGVyLnR5cGUgPT0gaSkgeworICAgICAgICAgICAgZmlsdGVy LnR5cGUgPSB0eXBlQXJyYXlbaV07CisgICAgICAgICAgICBpZiAoZmlsdGVyLnR5cGUgPT09IHR5 cGVBcnJheVtpXSAmJiB0eXBlQXJyYXlbaV0gPT09IGkpIHsKICAgICAgICAgICAgICAgICB2YXIg bWVzc2FnZSA9ICJCaXF1YWQgZmlsdGVyIHR5cGUgIiArIGkgKyAiIGlzIHNldHRhYmxlLiI7CiAg ICAgICAgICAgICAgICAgdGVzdFBhc3NlZChtZXNzYWdlKTsKICAgICAgICAgICAgIH0gZWxzZSB7 CkBAIC01NSw3ICs2Miw3IEBAIGZ1bmN0aW9uIHJ1blRlc3QoKSB7CiAKICAgICAvLyBDaGVjayB0 aGF0IGlsbGVnYWwgZmlsdGVyIHR5cGUgdGhyb3dzLgogICAgIHRyeSB7Ci0gICAgICAgIGZpbHRl ci50eXBlID0gODsKKyAgICAgICAgZmlsdGVyLnR5cGUgPSBmaWx0ZXIuQUxMUEFTUyArIDE7CiAg ICAgICAgIHRlc3RGYWlsZWQoIklsbGVnYWwgZmlsdGVyIHR5cGUgc2hvdWxkIHRocm93IGV4Y2Vw dGlvbi4iKTsKICAgICB9IGNhdGNoKGUpIHsKICAgICAgICAgdGVzdFBhc3NlZCgiSWxsZWdhbCBm aWx0ZXIgdHlwZSBjb3JyZWN0bHkgdGhyb3dzIGV4Y2VwdGlvbi4iKTsK 153639 2012-07-20 18:56:03 -0700 2012-07-22 18:10:15 -0700 Patch bug-90937-20120722100031.patch text/plain 4030 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjgyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjIzY2NkOTBhNTAzYmZiNjYyNzA3 YzcxZDg5MWI1YjcwMWM5NTc5Zi4uYzc0NDVmYjNlYTEwMWEzNmFjOTZkZTMyMmRlM2NkNzgxZTM3 MjY2MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTExICBMaSBZaW4gIDxsaS55aW5A aW50ZWwuY29tPgorCisgICAgICAgIEltcHJvdmUgQmlxdWFkRmlsdGVyTm9kZSB0ZXN0IGNhc2UK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwOTM3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wcm92ZSBC aXF1YWRGaWx0ZXJOb2RlIHRlc3QgdG8gY292ZXIgY29uc3RhbnQgdmFsdWUgYW5kIG51bWJlciBv ZiBpbnB1dHMgYW5kIG91dHB1dHMuCisKKyAgICAgICAgKiB3ZWJhdWRpby9iaXF1YWRmaWx0ZXJu b2RlLWJhc2ljLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiB3ZWJhdWRpby9iaXF1YWRmaWx0ZXJu b2RlLWJhc2ljLmh0bWw6CisKIDIwMTItMDctMTAgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29n bGUuY29tPgogCiAgICAgICAgIExpbmUgZGlyZWN0aXZlIHRlc3QgaW4gZmFzdC9jYW52YXMvd2Vi Z2wvZ2xzbC1jb25mb3JtYW5jZS5odG1sIGlzIGluY29ycmVjdApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvd2ViYXVkaW8vYmlxdWFkZmlsdGVybm9kZS1iYXNpYy1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy93ZWJhdWRpby9iaXF1YWRmaWx0ZXJub2RlLWJhc2ljLWV4cGVjdGVkLnR4dAppbmRl eCBhOTkyMTA0NTIyZTM3MjRiMzQ4ZjJiYjFiMzU1Y2FjYTQ2OGNmZWVlLi43MDFmZWNmZDg1ZDY3 ZjhjNTU3NWRhY2I4NGM1MWQyODVjNDM5N2FmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy93ZWJh dWRpby9iaXF1YWRmaWx0ZXJub2RlLWJhc2ljLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0 cy93ZWJhdWRpby9iaXF1YWRmaWx0ZXJub2RlLWJhc2ljLWV4cGVjdGVkLnR4dApAQCAtMiw2ICsy LDggQEAgQmFzaWMgdGVzdHMgZm9yIEJpcXVhZEZpbHRlck5vZGUuCiAKIE9uIHN1Y2Nlc3MsIHlv dSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNU IENPTVBMRVRFIi4KIAorUEFTUyBCaXF1YWRGaWx0ZXJOb2RlIGhhcyBvbmUgaXV0cHV0LgorUEFT UyBCaXF1YWRGaWx0ZXJOb2RlIGhhcyBvbmUgb3V0cHV0LgogUEFTUyBCaXF1YWQgZmlsdGVyIGRl ZmF1bHRzIHRvIGxvdy1wYXNzIGZpbHRlci4KIFBBU1MgQmlxdWFkIGZpbHRlciB0eXBlIDAgaXMg c2V0dGFibGUuCiBQQVNTIEJpcXVhZCBmaWx0ZXIgdHlwZSAxIGlzIHNldHRhYmxlLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8vYmlxdWFkZmlsdGVybm9kZS1iYXNpYy5odG1sIGIv TGF5b3V0VGVzdHMvd2ViYXVkaW8vYmlxdWFkZmlsdGVybm9kZS1iYXNpYy5odG1sCmluZGV4IGYx YzllNTAwYzk0MmQwMTU1Y2JiOGUyNzQzYTEwOWMyNjllMmI1NjEuLjYwZTNjMTQ2MDMxNTMwODM5 OTc1N2VhMjMwYWE2ZGNjZTc4MDFhZjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYmF1ZGlv L2JpcXVhZGZpbHRlcm5vZGUtYmFzaWMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy93ZWJhdWRpby9i aXF1YWRmaWx0ZXJub2RlLWJhc2ljLmh0bWwKQEAgLTEsNSArMSw0IEBACiA8IURPQ1RZUEUgaHRt bD4KLQogPGh0bWw+CiA8aGVhZD4KIDxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9q cy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CkBAIC0yNSwyMiArMjQsMzYgQEAgZnVuY3Rpb24gcnVu VGVzdCgpIHsKIAogICAgIGNvbnRleHQgPSBuZXcgd2Via2l0QXVkaW9Db250ZXh0KCk7CiAgICAg dmFyIGZpbHRlciA9IGNvbnRleHQuY3JlYXRlQmlxdWFkRmlsdGVyKCk7CisgICAKKyAgICBpZiAo ZmlsdGVyLm51bWJlck9mSW5wdXRzID09PSAxKSAKKyAgICAgICAgdGVzdFBhc3NlZCgiQmlxdWFk RmlsdGVyTm9kZSBoYXMgb25lIGl1dHB1dC4iKTsKKyAgICBlbHNlCisgICAgICAgIHRlc3RGYWls ZWQoIkJpcXVhZEZpbHRlck5vZGUgc2hvdWxkIGhhdmUgb25lIGl1dHB1dC4iKTsKICAgICAKLSAg ICAvLyBGSVhNRTogd2UgbmVlZCB0byBleHBvc2UgdGhlIGFjdHVhbCBmaWx0ZXIgdHlwZSBjb25z dGFudHMgaW4gdGhlIElETAorICAgIGlmIChmaWx0ZXIubnVtYmVyT2ZPdXRwdXRzID09PSAxKSAK KyAgICAgICAgdGVzdFBhc3NlZCgiQmlxdWFkRmlsdGVyTm9kZSBoYXMgb25lIG91dHB1dC4iKTsK KyAgICBlbHNlCisgICAgICAgIHRlc3RGYWlsZWQoIkJpcXVhZEZpbHRlck5vZGUgc2hvdWxkIGhh dmUgb25lIG91dHB1dC4iKTsKICAgICAKLSAgICAvLyBDaGVjayB0aGUgZmlsdGVyIHR5cGUuCi0g ICAgaWYgKGZpbHRlci50eXBlID09IDApCisgICAgaWYgKGZpbHRlci50eXBlID09PSBmaWx0ZXIu TE9XUEFTUykKICAgICAgICAgdGVzdFBhc3NlZCgiQmlxdWFkIGZpbHRlciBkZWZhdWx0cyB0byBs b3ctcGFzcyBmaWx0ZXIuIik7CiAgICAgZWxzZQogICAgICAgICB0ZXN0RmFpbGVkKCJCaXF1YWQg ZmlsdGVyIHNob3VsZCBkZWZhdWx0IHRvIGxvdy1wYXNzIGZpbHRlci4iKTsKIAogICAgIC8vIENo ZWNrIHRoYXQgYWxsIGxlZ2FsIGZpbHRlciB0eXBlcyBjYW4gYmUgc2V0LgotICAgIC8vIEZJWE1F OiB1c2UgbGFzdCBkZWZpbmVkIGZpbHRlciBjb25zdGFudCAoQUxMUEFTUykgaW5zdGVhZCBvZiBo YXJkLWNvZGVkIDcgb25jZSBpdCdzIGRlZmluZWQgaW4gdGhlIElETC4KLSAgICBmb3IgKHZhciBp ID0gMDsgaSA8PSA3OyArK2kpIHsKKyAgICB2YXIgZmlsdGVyVHlwZUFycmF5ID0gW2ZpbHRlci5M T1dQQVNTLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgZmlsdGVyLkhJR0hQQVNTLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgZmlsdGVyLkJBTkRQQVNTLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgZmlsdGVyLkxPV1NIRUxGLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ZmlsdGVyLkhJR0hTSEVMRiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIGZpbHRlci5QRUFL SU5HLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgZmlsdGVyLk5PVENILAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgZmlsdGVyLkFMTFBBU1NdOworCisgICAgZm9yICh2YXIgaSA9IDA7 IGkgPCBmaWx0ZXJUeXBlQXJyYXkubGVuZ3RoOyArK2kpIHsKICAgICAgICAgdHJ5IHsKLSAgICAg ICAgICAgIGZpbHRlci50eXBlID0gaTsKLSAgICAgICAgICAgIAotICAgICAgICAgICAgaWYgKGZp bHRlci50eXBlID09IGkpIHsKKyAgICAgICAgICAgIGZpbHRlci50eXBlID0gZmlsdGVyVHlwZUFy cmF5W2ldOworICAgICAgICAgICAgaWYgKGZpbHRlci50eXBlID09PSBmaWx0ZXJUeXBlQXJyYXlb aV0gJiYgZmlsdGVyVHlwZUFycmF5W2ldID09PSBpKSB7CiAgICAgICAgICAgICAgICAgdmFyIG1l c3NhZ2UgPSAiQmlxdWFkIGZpbHRlciB0eXBlICIgKyBpICsgIiBpcyBzZXR0YWJsZS4iOwogICAg ICAgICAgICAgICAgIHRlc3RQYXNzZWQobWVzc2FnZSk7CiAgICAgICAgICAgICB9IGVsc2UgewpA QCAtNTUsNyArNjgsNyBAQCBmdW5jdGlvbiBydW5UZXN0KCkgewogCiAgICAgLy8gQ2hlY2sgdGhh dCBpbGxlZ2FsIGZpbHRlciB0eXBlIHRocm93cy4KICAgICB0cnkgewotICAgICAgICBmaWx0ZXIu dHlwZSA9IDg7CisgICAgICAgIGZpbHRlci50eXBlID0gZmlsdGVyLkFMTFBBU1MgKyAxOwogICAg ICAgICB0ZXN0RmFpbGVkKCJJbGxlZ2FsIGZpbHRlciB0eXBlIHNob3VsZCB0aHJvdyBleGNlcHRp b24uIik7CiAgICAgfSBjYXRjaChlKSB7CiAgICAgICAgIHRlc3RQYXNzZWQoIklsbGVnYWwgZmls dGVyIHR5cGUgY29ycmVjdGx5IHRocm93cyBleGNlcHRpb24uIik7Cg== 153714 2012-07-22 18:10:21 -0700 2012-07-22 19:12:12 -0700 Patch bug-90937-20120724091450.patch text/plain 4093 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjgyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjIzY2NkOTBhNTAzYmZiNjYyNzA3 YzcxZDg5MWI1YjcwMWM5NTc5Zi4uMGIwMzU0NWY3ZDc3ODIxMGU1OGQ4MTdlMWZiZWFhMGQ4YzE4 YzIwMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTExICBMaSBZaW4gIDxsaS55aW5A aW50ZWwuY29tPgorCisgICAgICAgIEltcHJvdmUgQmlxdWFkRmlsdGVyTm9kZSB0ZXN0IGNhc2UK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwOTM3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3BlYzogaHR0 cDovL3d3dy53My5vcmcvVFIvd2ViYXVkaW8vI0JpcXVhZEZpbHRlck5vZGUKKyAgICAgICAgSW1w cm92ZSBCaXF1YWRGaWx0ZXJOb2RlIHRlc3QgdG8gY292ZXIgY29uc3RhbnQgdmFsdWUgYW5kIG51 bWJlciBvZiBpbnB1dHMgYW5kIG91dHB1dHMuCisKKyAgICAgICAgKiB3ZWJhdWRpby9iaXF1YWRm aWx0ZXJub2RlLWJhc2ljLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiB3ZWJhdWRpby9iaXF1YWRm aWx0ZXJub2RlLWJhc2ljLmh0bWw6CisKIDIwMTItMDctMTAgIEtlbm5ldGggUnVzc2VsbCAgPGti ckBnb29nbGUuY29tPgogCiAgICAgICAgIExpbmUgZGlyZWN0aXZlIHRlc3QgaW4gZmFzdC9jYW52 YXMvd2ViZ2wvZ2xzbC1jb25mb3JtYW5jZS5odG1sIGlzIGluY29ycmVjdApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvd2ViYXVkaW8vYmlxdWFkZmlsdGVybm9kZS1iYXNpYy1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy93ZWJhdWRpby9iaXF1YWRmaWx0ZXJub2RlLWJhc2ljLWV4cGVjdGVkLnR4 dAppbmRleCBhOTkyMTA0NTIyZTM3MjRiMzQ4ZjJiYjFiMzU1Y2FjYTQ2OGNmZWVlLi43MDFmZWNm ZDg1ZDY3ZjhjNTU3NWRhY2I4NGM1MWQyODVjNDM5N2FmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy93ZWJhdWRpby9iaXF1YWRmaWx0ZXJub2RlLWJhc2ljLWV4cGVjdGVkLnR4dAorKysgYi9MYXlv dXRUZXN0cy93ZWJhdWRpby9iaXF1YWRmaWx0ZXJub2RlLWJhc2ljLWV4cGVjdGVkLnR4dApAQCAt Miw2ICsyLDggQEAgQmFzaWMgdGVzdHMgZm9yIEJpcXVhZEZpbHRlck5vZGUuCiAKIE9uIHN1Y2Nl c3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5 ICJURVNUIENPTVBMRVRFIi4KIAorUEFTUyBCaXF1YWRGaWx0ZXJOb2RlIGhhcyBvbmUgaXV0cHV0 LgorUEFTUyBCaXF1YWRGaWx0ZXJOb2RlIGhhcyBvbmUgb3V0cHV0LgogUEFTUyBCaXF1YWQgZmls dGVyIGRlZmF1bHRzIHRvIGxvdy1wYXNzIGZpbHRlci4KIFBBU1MgQmlxdWFkIGZpbHRlciB0eXBl IDAgaXMgc2V0dGFibGUuCiBQQVNTIEJpcXVhZCBmaWx0ZXIgdHlwZSAxIGlzIHNldHRhYmxlLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8vYmlxdWFkZmlsdGVybm9kZS1iYXNpYy5o dG1sIGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8vYmlxdWFkZmlsdGVybm9kZS1iYXNpYy5odG1sCmlu ZGV4IGYxYzllNTAwYzk0MmQwMTU1Y2JiOGUyNzQzYTEwOWMyNjllMmI1NjEuLjYwZTNjMTQ2MDMx NTMwODM5OTc1N2VhMjMwYWE2ZGNjZTc4MDFhZjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dl YmF1ZGlvL2JpcXVhZGZpbHRlcm5vZGUtYmFzaWMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy93ZWJh dWRpby9iaXF1YWRmaWx0ZXJub2RlLWJhc2ljLmh0bWwKQEAgLTEsNSArMSw0IEBACiA8IURPQ1RZ UEUgaHRtbD4KLQogPGh0bWw+CiA8aGVhZD4KIDxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291 cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CkBAIC0yNSwyMiArMjQsMzYgQEAgZnVuY3Rp b24gcnVuVGVzdCgpIHsKIAogICAgIGNvbnRleHQgPSBuZXcgd2Via2l0QXVkaW9Db250ZXh0KCk7 CiAgICAgdmFyIGZpbHRlciA9IGNvbnRleHQuY3JlYXRlQmlxdWFkRmlsdGVyKCk7CisgICAKKyAg ICBpZiAoZmlsdGVyLm51bWJlck9mSW5wdXRzID09PSAxKSAKKyAgICAgICAgdGVzdFBhc3NlZCgi QmlxdWFkRmlsdGVyTm9kZSBoYXMgb25lIGl1dHB1dC4iKTsKKyAgICBlbHNlCisgICAgICAgIHRl c3RGYWlsZWQoIkJpcXVhZEZpbHRlck5vZGUgc2hvdWxkIGhhdmUgb25lIGl1dHB1dC4iKTsKICAg ICAKLSAgICAvLyBGSVhNRTogd2UgbmVlZCB0byBleHBvc2UgdGhlIGFjdHVhbCBmaWx0ZXIgdHlw ZSBjb25zdGFudHMgaW4gdGhlIElETAorICAgIGlmIChmaWx0ZXIubnVtYmVyT2ZPdXRwdXRzID09 PSAxKSAKKyAgICAgICAgdGVzdFBhc3NlZCgiQmlxdWFkRmlsdGVyTm9kZSBoYXMgb25lIG91dHB1 dC4iKTsKKyAgICBlbHNlCisgICAgICAgIHRlc3RGYWlsZWQoIkJpcXVhZEZpbHRlck5vZGUgc2hv dWxkIGhhdmUgb25lIG91dHB1dC4iKTsKICAgICAKLSAgICAvLyBDaGVjayB0aGUgZmlsdGVyIHR5 cGUuCi0gICAgaWYgKGZpbHRlci50eXBlID09IDApCisgICAgaWYgKGZpbHRlci50eXBlID09PSBm aWx0ZXIuTE9XUEFTUykKICAgICAgICAgdGVzdFBhc3NlZCgiQmlxdWFkIGZpbHRlciBkZWZhdWx0 cyB0byBsb3ctcGFzcyBmaWx0ZXIuIik7CiAgICAgZWxzZQogICAgICAgICB0ZXN0RmFpbGVkKCJC aXF1YWQgZmlsdGVyIHNob3VsZCBkZWZhdWx0IHRvIGxvdy1wYXNzIGZpbHRlci4iKTsKIAogICAg IC8vIENoZWNrIHRoYXQgYWxsIGxlZ2FsIGZpbHRlciB0eXBlcyBjYW4gYmUgc2V0LgotICAgIC8v IEZJWE1FOiB1c2UgbGFzdCBkZWZpbmVkIGZpbHRlciBjb25zdGFudCAoQUxMUEFTUykgaW5zdGVh ZCBvZiBoYXJkLWNvZGVkIDcgb25jZSBpdCdzIGRlZmluZWQgaW4gdGhlIElETC4KLSAgICBmb3Ig KHZhciBpID0gMDsgaSA8PSA3OyArK2kpIHsKKyAgICB2YXIgZmlsdGVyVHlwZUFycmF5ID0gW2Zp bHRlci5MT1dQQVNTLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgZmlsdGVyLkhJR0hQQVNT LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgZmlsdGVyLkJBTkRQQVNTLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgZmlsdGVyLkxPV1NIRUxGLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgZmlsdGVyLkhJR0hTSEVMRiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIGZpbHRl ci5QRUFLSU5HLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgZmlsdGVyLk5PVENILAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgZmlsdGVyLkFMTFBBU1NdOworCisgICAgZm9yICh2YXIg aSA9IDA7IGkgPCBmaWx0ZXJUeXBlQXJyYXkubGVuZ3RoOyArK2kpIHsKICAgICAgICAgdHJ5IHsK LSAgICAgICAgICAgIGZpbHRlci50eXBlID0gaTsKLSAgICAgICAgICAgIAotICAgICAgICAgICAg aWYgKGZpbHRlci50eXBlID09IGkpIHsKKyAgICAgICAgICAgIGZpbHRlci50eXBlID0gZmlsdGVy VHlwZUFycmF5W2ldOworICAgICAgICAgICAgaWYgKGZpbHRlci50eXBlID09PSBmaWx0ZXJUeXBl QXJyYXlbaV0gJiYgZmlsdGVyVHlwZUFycmF5W2ldID09PSBpKSB7CiAgICAgICAgICAgICAgICAg dmFyIG1lc3NhZ2UgPSAiQmlxdWFkIGZpbHRlciB0eXBlICIgKyBpICsgIiBpcyBzZXR0YWJsZS4i OwogICAgICAgICAgICAgICAgIHRlc3RQYXNzZWQobWVzc2FnZSk7CiAgICAgICAgICAgICB9IGVs c2UgewpAQCAtNTUsNyArNjgsNyBAQCBmdW5jdGlvbiBydW5UZXN0KCkgewogCiAgICAgLy8gQ2hl Y2sgdGhhdCBpbGxlZ2FsIGZpbHRlciB0eXBlIHRocm93cy4KICAgICB0cnkgewotICAgICAgICBm aWx0ZXIudHlwZSA9IDg7CisgICAgICAgIGZpbHRlci50eXBlID0gZmlsdGVyLkFMTFBBU1MgKyAx OwogICAgICAgICB0ZXN0RmFpbGVkKCJJbGxlZ2FsIGZpbHRlciB0eXBlIHNob3VsZCB0aHJvdyBl eGNlcHRpb24uIik7CiAgICAgfSBjYXRjaChlKSB7CiAgICAgICAgIHRlc3RQYXNzZWQoIklsbGVn YWwgZmlsdGVyIHR5cGUgY29ycmVjdGx5IHRocm93cyBleGNlcHRpb24uIik7Cg==