90930 2012-07-10 19:41:19 -0700 Simplify the copying of JSC ARMv7's LinkRecord 2012-07-11 11:15:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 benjamin benjamin barraclough ddkilzer fpizlo ggaren oliver zwarich oldest_to_newest 666272 0 benjamin 2012-07-10 19:41:19 -0700 Simplify the copying of JSC ARMv7's LinkRecord. 666276 1 151581 benjamin 2012-07-10 19:54:45 -0700 Created attachment 151581 Patch 666290 2 151581 fpizlo 2012-07-10 20:23:35 -0700 Comment on attachment 151581 Patch Fascinating! R=me. 666813 3 ddkilzer 2012-07-11 09:51:54 -0700 <rdar://problem/11850045> 666817 4 oliver 2012-07-11 09:55:42 -0700 Can we file a bug on the compiler being extraordinarily stupid here? 666894 5 benjamin 2012-07-11 11:15:55 -0700 Committed r122347: <http://trac.webkit.org/changeset/122347> 151581 2012-07-10 19:54:45 -0700 2012-07-10 20:23:35 -0700 Patch bug-90930-20120710195444.patch text/plain 4498 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh MWNiZWZhMzY5ZGIyNDBjNWEyZDk4ZGQwZDYxYWMyZjBjMTUyMGZhLi43Y2U0N2U5NDE3ODFhN2Uy YTkzNGVmYmM5NWQwOTJlZDRiOGFjNTMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAxMi0wNy0xMCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBTaW1wbGlmeSB0aGUgY29weWluZyBvZiBKU0MgQVJNdjcncyBMaW5r UmVjb3JkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MDkzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBjbGFzcyBMaW5rUmVjb3JkIGlzIHVzZWQgYnkgdmFsdWUgZXZlcnl3aGVyZSBpbiBBUk12N0Fz c2VtYmxlci4gVGhlIGNvbXBpbGVyIHVzZXMKKyAgICAgICAgbWVtbW92ZSgpIHRvIG1vdmUgdGhl IG9iamVjdHMuCisKKyAgICAgICAgVGhlIHByb2JsZW0gaXMgbWVtbW92ZSgpIGlzIG92ZXJraWxs IGZvciB0aGlzIG9iamVjdCwgbW92aW5nIHRoZSB2YWx1ZSBjYW4gYmUgZG9uZSB3aXRoCisgICAg ICAgIDMgbG9hZC1zdG9yZS4gVGhpcyBwYXRjaCBhZGRzIGFuIG9wZXJhdG9yPSB0byB0aGUgY2xh c3MgZG9pbmcgbW9yZSBlZmZpY2llbnQgY29weWluZy4KKyAgICAgICAgVGhpcyByZWR1Y2VzIHRo ZSBsaW5rIHRpbWUgYnkgMTklLgorCisgICAgICAgICogYXNzZW1ibGVyL0FSTXY3QXNzZW1ibGVy Lmg6CisgICAgICAgIChKU0M6OkFSTXY3QXNzZW1ibGVyOjpMaW5rUmVjb3JkOjpMaW5rUmVjb3Jk KToKKyAgICAgICAgKEpTQzo6QVJNdjdBc3NlbWJsZXI6OkxpbmtSZWNvcmQ6Om9wZXJhdG9yPSk6 CisgICAgICAgIChKU0M6OkFSTXY3QXNzZW1ibGVyOjpMaW5rUmVjb3JkOjpmcm9tKToKKyAgICAg ICAgKEpTQzo6QVJNdjdBc3NlbWJsZXI6OkxpbmtSZWNvcmQ6OnNldEZyb20pOgorICAgICAgICAo SlNDOjpBUk12N0Fzc2VtYmxlcjo6TGlua1JlY29yZDo6dG8pOgorICAgICAgICAoSlNDOjpBUk12 N0Fzc2VtYmxlcjo6TGlua1JlY29yZDo6dHlwZSk6CisgICAgICAgIChKU0M6OkFSTXY3QXNzZW1i bGVyOjpMaW5rUmVjb3JkOjpsaW5rVHlwZSk6CisgICAgICAgIChKU0M6OkFSTXY3QXNzZW1ibGVy OjpMaW5rUmVjb3JkOjpzZXRMaW5rVHlwZSk6CisgICAgICAgIChKU0M6OkFSTXY3QXNzZW1ibGVy OjpMaW5rUmVjb3JkOjpjb25kaXRpb24pOgorCiAyMDEyLTA3LTEwICBGaWxpcCBQaXpsbyAgPGZw aXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTIyMTY2KTogSXQgbWFkZSAx NzAgdGVzdHMgY3Jhc2ggb24gMzIgYml0IHBsYXRmb3JtcwpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5oIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5oCmluZGV4IGVlZjBiYThhNzRjM2RkZTQ3 ZjRmMjU3NTEzZTkyNTJiZjI1ODZiMjQuLjk2YzRmMDk2Y2Q3NGI5ZTg2ZjA2NWIzMGQzMjk2NDAy ZjlmODQ5MDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJN djdBc3NlbWJsZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTXY3 QXNzZW1ibGVyLmgKQEAgLTQ2MiwyOCArNDYyLDQyIEBAIHB1YmxpYzoKICAgICBjbGFzcyBMaW5r UmVjb3JkIHsKICAgICBwdWJsaWM6CiAgICAgICAgIExpbmtSZWNvcmQoaW50cHRyX3QgZnJvbSwg aW50cHRyX3QgdG8sIEp1bXBUeXBlIHR5cGUsIENvbmRpdGlvbiBjb25kaXRpb24pCi0gICAgICAg ICAgICA6IG1fZnJvbShmcm9tKQotICAgICAgICAgICAgLCBtX3RvKHRvKQotICAgICAgICAgICAg LCBtX3R5cGUodHlwZSkKLSAgICAgICAgICAgICwgbV9saW5rVHlwZShMaW5rSW52YWxpZCkKLSAg ICAgICAgICAgICwgbV9jb25kaXRpb24oY29uZGl0aW9uKQogICAgICAgICB7CisgICAgICAgICAg ICBkYXRhLnJlYWxUeXBlcy5tX2Zyb20gPSBmcm9tOworICAgICAgICAgICAgZGF0YS5yZWFsVHlw ZXMubV90byA9IHRvOworICAgICAgICAgICAgZGF0YS5yZWFsVHlwZXMubV90eXBlID0gdHlwZTsK KyAgICAgICAgICAgIGRhdGEucmVhbFR5cGVzLm1fbGlua1R5cGUgPSBMaW5rSW52YWxpZDsKKyAg ICAgICAgICAgIGRhdGEucmVhbFR5cGVzLm1fY29uZGl0aW9uID0gY29uZGl0aW9uOwogICAgICAg ICB9Ci0gICAgICAgIGludHB0cl90IGZyb20oKSBjb25zdCB7IHJldHVybiBtX2Zyb207IH0KLSAg ICAgICAgdm9pZCBzZXRGcm9tKGludHB0cl90IGZyb20pIHsgbV9mcm9tID0gZnJvbTsgfQotICAg ICAgICBpbnRwdHJfdCB0bygpIGNvbnN0IHsgcmV0dXJuIG1fdG87IH0KLSAgICAgICAgSnVtcFR5 cGUgdHlwZSgpIGNvbnN0IHsgcmV0dXJuIG1fdHlwZTsgfQotICAgICAgICBKdW1wTGlua1R5cGUg bGlua1R5cGUoKSBjb25zdCB7IHJldHVybiBtX2xpbmtUeXBlOyB9Ci0gICAgICAgIHZvaWQgc2V0 TGlua1R5cGUoSnVtcExpbmtUeXBlIGxpbmtUeXBlKSB7IEFTU0VSVChtX2xpbmtUeXBlID09IExp bmtJbnZhbGlkKTsgbV9saW5rVHlwZSA9IGxpbmtUeXBlOyB9Ci0gICAgICAgIENvbmRpdGlvbiBj b25kaXRpb24oKSBjb25zdCB7IHJldHVybiBtX2NvbmRpdGlvbjsgfQorICAgICAgICB2b2lkIG9w ZXJhdG9yPShjb25zdCBMaW5rUmVjb3JkJiBvdGhlcikKKyAgICAgICAgeworICAgICAgICAgICAg ZGF0YS5jb3B5VHlwZXMuY29udGVudFswXSA9IG90aGVyLmRhdGEuY29weVR5cGVzLmNvbnRlbnRb MF07CisgICAgICAgICAgICBkYXRhLmNvcHlUeXBlcy5jb250ZW50WzFdID0gb3RoZXIuZGF0YS5j b3B5VHlwZXMuY29udGVudFsxXTsKKyAgICAgICAgICAgIGRhdGEuY29weVR5cGVzLmNvbnRlbnRb Ml0gPSBvdGhlci5kYXRhLmNvcHlUeXBlcy5jb250ZW50WzJdOworICAgICAgICB9CisgICAgICAg IGludHB0cl90IGZyb20oKSBjb25zdCB7IHJldHVybiBkYXRhLnJlYWxUeXBlcy5tX2Zyb207IH0K KyAgICAgICAgdm9pZCBzZXRGcm9tKGludHB0cl90IGZyb20pIHsgZGF0YS5yZWFsVHlwZXMubV9m cm9tID0gZnJvbTsgfQorICAgICAgICBpbnRwdHJfdCB0bygpIGNvbnN0IHsgcmV0dXJuIGRhdGEu cmVhbFR5cGVzLm1fdG87IH0KKyAgICAgICAgSnVtcFR5cGUgdHlwZSgpIGNvbnN0IHsgcmV0dXJu IGRhdGEucmVhbFR5cGVzLm1fdHlwZTsgfQorICAgICAgICBKdW1wTGlua1R5cGUgbGlua1R5cGUo KSBjb25zdCB7IHJldHVybiBkYXRhLnJlYWxUeXBlcy5tX2xpbmtUeXBlOyB9CisgICAgICAgIHZv aWQgc2V0TGlua1R5cGUoSnVtcExpbmtUeXBlIGxpbmtUeXBlKSB7IEFTU0VSVChkYXRhLnJlYWxU eXBlcy5tX2xpbmtUeXBlID09IExpbmtJbnZhbGlkKTsgZGF0YS5yZWFsVHlwZXMubV9saW5rVHlw ZSA9IGxpbmtUeXBlOyB9CisgICAgICAgIENvbmRpdGlvbiBjb25kaXRpb24oKSBjb25zdCB7IHJl dHVybiBkYXRhLnJlYWxUeXBlcy5tX2NvbmRpdGlvbjsgfQogICAgIHByaXZhdGU6Ci0gICAgICAg IGludHB0cl90IG1fZnJvbSA6IDMxOwotICAgICAgICBpbnRwdHJfdCBtX3RvIDogMzE7Ci0gICAg ICAgIEp1bXBUeXBlIG1fdHlwZSA6IDg7Ci0gICAgICAgIEp1bXBMaW5rVHlwZSBtX2xpbmtUeXBl IDogODsKLSAgICAgICAgQ29uZGl0aW9uIG1fY29uZGl0aW9uIDogMTY7CisgICAgICAgIHVuaW9u IHsKKyAgICAgICAgICAgIHN0cnVjdCBSZWFsVHlwZXMgeworICAgICAgICAgICAgICAgIGludHB0 cl90IG1fZnJvbSA6IDMxOworICAgICAgICAgICAgICAgIGludHB0cl90IG1fdG8gOiAzMTsKKyAg ICAgICAgICAgICAgICBKdW1wVHlwZSBtX3R5cGUgOiA4OworICAgICAgICAgICAgICAgIEp1bXBM aW5rVHlwZSBtX2xpbmtUeXBlIDogODsKKyAgICAgICAgICAgICAgICBDb25kaXRpb24gbV9jb25k aXRpb24gOiAxNjsKKyAgICAgICAgICAgIH0gcmVhbFR5cGVzOworICAgICAgICAgICAgc3RydWN0 IENvcHlUeXBlcyB7CisgICAgICAgICAgICAgICAgdWludDMyX3QgY29udGVudFszXTsKKyAgICAg ICAgICAgIH0gY29weVR5cGVzOworICAgICAgICAgICAgQ09NUElMRV9BU1NFUlQoc2l6ZW9mKFJl YWxUeXBlcykgPT0gc2l6ZW9mKENvcHlUeXBlcyksIExpbmtSZWNvcmRDb3B5U3RydWN0U2l6ZUVx dWFsc1JlYWxTdHJ1Y3QpOworICAgICAgICB9IGRhdGE7CiAgICAgfTsKLSAgICAKKwogICAgIEFS TXY3QXNzZW1ibGVyKCkKICAgICAgICAgOiBtX2luZGV4T2ZMYXN0V2F0Y2hwb2ludChJTlRfTUlO KQogICAgICAgICAsIG1faW5kZXhPZlRhaWxPZkxhc3RXYXRjaHBvaW50KElOVF9NSU4pCg==