90921 2012-07-10 17:05:04 -0700 [Chromium] Adjust DumpRenderTree ifdefs for Android 2012-07-11 09:35:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 66687 1 abarth abarth japhet peter tkent tony wangxianzhu webkit.review.bot oldest_to_newest 666176 0 abarth 2012-07-10 17:05:04 -0700 [Chromium] Adjust DumpRenderTree ifdefs for Android 666180 1 151558 abarth 2012-07-10 17:12:04 -0700 Created attachment 151558 Patch 666190 2 151558 tkent 2012-07-10 17:18:26 -0700 Comment on attachment 151558 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151558&action=review > Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h:-30 > -#if ENABLE(INPUT_SPEECH) > - Why do you remove it? Android port doesn't have INPUT_SPEECH, and this class shouldn't be needed, right? 666350 3 abarth 2012-07-10 22:22:50 -0700 (In reply to comment #2) > (From update of attachment 151558 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151558&action=review > > > Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h:-30 > > -#if ENABLE(INPUT_SPEECH) > > - > > Why do you remove it? Android port doesn't have INPUT_SPEECH, and this class shouldn't be needed, right? I suspect it's referenced outside the ENABLE(INPUT_SPEECH) ifdef. We can try reverting it on the chromium-android branch, but it seemed easier to just upstream the change. 666745 4 151558 peter 2012-07-11 07:39:07 -0700 Comment on attachment 151558 Patch There is no reason for these changes to live upstream, as they seem to be merge errors in our downstream branch. We should abandon this and remove the differences downstream instead, for which I've uploaded this patch: https://gerrit-int.chromium.org/#change,21574 Removing r? and cq? so it's clear to reviewers. 666805 5 abarth 2012-07-11 09:35:33 -0700 Ok. 151558 2012-07-10 17:12:04 -0700 2012-07-11 07:39:07 -0700 Patch bug-90921-20120710171203.patch text/plain 3446 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjc5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDgzNGE0YmRlNTNmMjlkMTM0M2Y3ZTMxMDU4OTQzNmEw ZmU4YTA3YS4uMWQ5YjRkZjU5YWU4MTk3MWY0Nzg4MWJhNGFjYWJhMWI4ZDFhYTE4OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEyLTA3LTEwICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW0Nocm9taXVtXSBBZGp1c3QgRHVtcFJlbmRlclRyZWUgaWZkZWZzIGZvciBBbmRyb2lkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDkyMQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2gg YWRqdXN0cyBzb21lIGlmZGVmcyBpbiBEdW1wUmVuZGVyVHJlZSB0byBtYXRjaCB0aGVpcgorICAg ICAgICBjb3VudGVycGFydHMgaW4gdGhlIGNocm9taXVtLWFuZHJvaWQgYnJhbmNoLgorCisgICAg ICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTW9ja1dlYlNwZWVjaElucHV0Q29udHJvbGxl ci5oOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbEFuZHJvaWQu Y3BwOgorICAgICAgICAgICAgLSBUaGlzIGJsYW5rIGxpbmUgZXhpc3RzIGluIHRoZSBjaHJvbWl1 bS1hbmRyb2lkIGJyYW5jaC4gV2UgY291bGQKKyAgICAgICAgICAgICAgcmVtb3ZlIGl0IGZyb20g dGhlIGJyYW5jaCwgYnV0IHRoZSBibGFuayBsaW5lIGxvb2tzIHByZXR0eSwgc28gd2UKKyAgICAg ICAgICAgICAgbWlnaHQgYXMgd2VsbCB1cHN0cmVhbSBpdC4KKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHA6CisKIDIwMTItMDctMTAgIEFsZWMgRmxldHQg IDxhbGVjZmxldHRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBhbGVjZmxldHQgdG8gdGhl IGxpc3Qgb2YgY29tbWl0dGVycwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hy b21pdW0vTW9ja1dlYlNwZWVjaElucHV0Q29udHJvbGxlci5oIGIvVG9vbHMvRHVtcFJlbmRlclRy ZWUvY2hyb21pdW0vTW9ja1dlYlNwZWVjaElucHV0Q29udHJvbGxlci5oCmluZGV4IDhkNzUxOTYw MzkzZWIyZGYzOTc2YzAyMjUwZDFjN2M5MjhlMGFkZjIuLjBkYzQ4ZDEwYmM1ZDQ5ZGZjYTI3MmM4 MWIzN2EzN2RmZDcyYjRlOTUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9t aXVtL01vY2tXZWJTcGVlY2hJbnB1dENvbnRyb2xsZXIuaAorKysgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9jaHJvbWl1bS9Nb2NrV2ViU3BlZWNoSW5wdXRDb250cm9sbGVyLmgKQEAgLTI2LDggKzI2 LDYgQEAKICNpZm5kZWYgTW9ja1dlYlNwZWVjaElucHV0Q29udHJvbGxlcl9oCiAjZGVmaW5lIE1v Y2tXZWJTcGVlY2hJbnB1dENvbnRyb2xsZXJfaAogCi0jaWYgRU5BQkxFKElOUFVUX1NQRUVDSCkK LQogI2luY2x1ZGUgIlRhc2suaCIKICNpbmNsdWRlICJwbGF0Zm9ybS9XZWJSZWN0LmgiCiAjaW5j bHVkZSAiV2ViU3BlZWNoSW5wdXRDb250cm9sbGVyLmgiCkBAIC04OCw2ICs4Niw0IEBAIHByaXZh dGU6CiAgICAgYm9vbCBtX2R1bXBSZWN0OwogfTsKIAotI2VuZGlmIC8vIEVOQUJMRShJTlBVVF9T UEVFQ0gpCi0KICNlbmRpZiAvLyBNb2NrV2ViU3BlZWNoSW5wdXRDb250cm9sbGVyX2gKZGlmZiAt LWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbEFuZHJvaWQuY3Bw IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsQW5kcm9pZC5jcHAKaW5k ZXggYmMwYWNhYWQ5MWJlNTRiZjYzMTNiMTIzMDQyYmJiMGE1M2VjYWI2NS4uODY2NzFlNGViMTQ3 NDhiMGIyY2ZkMmUwYzdjZTNiZmYzMjA5ODYxYSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vVGVzdFNoZWxsQW5kcm9pZC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vVGVzdFNoZWxsQW5kcm9pZC5jcHAKQEAgLTMzLDYgKzMzLDcgQEAKIAog I2luY2x1ZGUgImxpbnV4L1dlYkZvbnRSZW5kZXJpbmcuaCIKICNpbmNsdWRlICJ0aGlyZF9wYXJ0 eS9za2lhL2luY2x1ZGUvcG9ydHMvU2tUeXBlZmFjZV9hbmRyb2lkLmgiCisKICNpbmNsdWRlIDxh bmRyb2lkL2xvZy5oPgogI2luY2x1ZGUgPGVycm5vLmg+CiAjaW5jbHVkZSA8ZmNudGwuaD4KZGlm ZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcCBi L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcAppbmRleCA4OGUw NzM3OGY0NTdkOWU1ODIwYTVkNTk2MmJkMGZjM2MxZDhiYzRmLi4xMWY2NmIzMzI1NDlmMmUzYjEx ZDM2MzQ5ZTJmZmI0NzczYWE3MzU1IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21p dW0vV2ViVmlld0hvc3QuY3BwCkBAIC02Niw3ICs2Niw5IEBACiAjaW5jbHVkZSAiV2ViU3RvcmFn ZU5hbWVzcGFjZS5oIgogI2luY2x1ZGUgIldlYlRleHRDaGVja2luZ0NvbXBsZXRpb24uaCIKICNp bmNsdWRlICJXZWJUZXh0Q2hlY2tpbmdSZXN1bHQuaCIKKyNpZiBFTkFCTEUoTUVESUFfU1RSRUFN KQogI2luY2x1ZGUgIldlYlVzZXJNZWRpYUNsaWVudE1vY2suaCIKKyNlbmRpZgogI2luY2x1ZGUg InBsYXRmb3JtL1dlYlRocmVhZC5oIgogI2luY2x1ZGUgInBsYXRmb3JtL1dlYlVSTFJlcXVlc3Qu aCIKICNpbmNsdWRlICJwbGF0Zm9ybS9XZWJVUkxSZXNwb25zZS5oIgpkaWZmIC0tZ2l0IGEvVG9v bHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuaCBiL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmgKaW5kZXggY2UxODlkOTE1NGNiNDkwZWExMzRi MzNmZDQ5YzA2MjNlNjI5N2Y5Yi4uNmVmYWE3NDI3MGNhYTg4OWVlYmM2MzA4Zjk0ZTgzNmZhMTQ5 YTFmOSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hv c3QuaAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5oCkBA IC02NSw3ICs2NSw5IEBAIGNsYXNzIFdlYlNoYXJlZFdvcmtlckNsaWVudDsKIGNsYXNzIFdlYlNw ZWVjaElucHV0Q29udHJvbGxlcjsKIGNsYXNzIFdlYlNwZWVjaElucHV0TGlzdGVuZXI7CiBjbGFz cyBXZWJVUkw7CisjaWYgRU5BQkxFKE1FRElBX1NUUkVBTSkKIGNsYXNzIFdlYlVzZXJNZWRpYUNs aWVudE1vY2s7CisjZW5kaWYKIHN0cnVjdCBXZWJSZWN0Owogc3RydWN0IFdlYlVSTEVycm9yOwog c3RydWN0IFdlYldpbmRvd0ZlYXR1cmVzOwo=