90920 2012-07-10 16:57:21 -0700 [Chromium] Merge final nits to DumpRenderTree.gyp for Android 2012-08-02 09:31:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 90947 92858 92865 66687 1 abarth abarth japhet peter tony wangxianzhu webkit.review.bot oldest_to_newest 666169 0 abarth 2012-07-10 16:57:21 -0700 [Chromium] Merge final nits to DumpRenderTree.gyp for Android 666170 1 151554 abarth 2012-07-10 16:58:23 -0700 Created attachment 151554 Patch 666172 2 peter 2012-07-10 16:59:12 -0700 LGTM 666174 3 151554 peter 2012-07-10 17:00:49 -0700 Comment on attachment 151554 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151554&action=review > Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:256 > + ['exclude', 'WebUserMediaClientMock\\.cpp'], nit: This whole file is guarded with ENABLE(MEDIA_STREAM), which isn't the case for Android. Could probably revert this downstream instead. 666287 4 abarth 2012-07-10 20:14:19 -0700 OK. Will do. 666352 5 151598 abarth 2012-07-10 22:25:09 -0700 Created attachment 151598 Patch for landing 666392 6 151598 webkit.review.bot 2012-07-10 23:19:28 -0700 Comment on attachment 151598 Patch for landing Clearing flags on attachment: 151598 Committed r122301: <http://trac.webkit.org/changeset/122301> 666393 7 webkit.review.bot 2012-07-10 23:19:33 -0700 All reviewed patches have been landed. Closing bug. 666438 8 webkit.review.bot 2012-07-11 00:23:17 -0700 Re-opened since this is blocked by 90947 666752 9 peter 2012-07-11 07:47:57 -0700 This relies on some not-yet-upstreamed Chromium code. I've e-mailed the author with some questions, so we can hopefully get this in tomorrow. For reference: https://gerrit-int.chromium.org/#change,19828 681538 10 abarth 2012-07-29 02:47:29 -0700 > This relies on some not-yet-upstreamed Chromium code. I've e-mailed the author with some questions, so we can hopefully get this in tomorrow. @Peter: Are we ready to land this patch yet? 681546 11 peter 2012-07-29 05:03:41 -0700 Per http://crrev.com/148790 the sdk_build variable will be pushed to gyp, but I'm not sure if it's propagated properly yet. I had to revert the revision last week as it unintentionally switched the WebKit cr-android builder to using ninja. That has been fixed in the re-land, so we can go forth, roll WebKit Chromium DEPS and, if needed, fix propagation of the variable (though that'd be easy). Tomorrow -finally- is reasonable. IIRC a similar one-line diff exists for TestWebKitAPI and webkit_unit_test. 681570 12 abarth 2012-07-29 10:30:06 -0700 Ok. Thanks. There isn't really a rush. We'll just need to get this off our plate eventually. After https://gerrit-int.chromium.org/22653 lands, this one-line change will be the last thing keeping us from having DumpRenderTree fully unforked. 683097 13 peter 2012-07-31 08:24:22 -0700 Once a new Chromium DEPS roll happens in WebKit (only blocked on getting a Chromium LKGR > 149181), it's fine to land this. Should be today :-). 684040 14 151598 peter 2012-08-01 03:11:25 -0700 Comment on attachment 151598 Patch for landing Boldly setting cq+. 684082 15 151598 webkit.review.bot 2012-08-01 04:51:59 -0700 Comment on attachment 151598 Patch for landing Clearing flags on attachment: 151598 Committed r124325: <http://trac.webkit.org/changeset/124325> 684083 16 webkit.review.bot 2012-08-01 04:52:03 -0700 All reviewed patches have been landed. Closing bug. 684089 17 webkit.review.bot 2012-08-01 05:10:39 -0700 Re-opened since this is blocked by 92865 685328 18 151598 peter 2012-08-02 07:00:32 -0700 Comment on attachment 151598 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=151598&action=review > Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:454 > + '--ant-compile=<(sdk_build)', "--sdk-build=<(sdk_build)", then LGTM again.. Thanks! 685430 19 156095 abarth 2012-08-02 08:37:07 -0700 Created attachment 156095 Patch for landing 685484 20 156095 webkit.review.bot 2012-08-02 09:30:59 -0700 Comment on attachment 156095 Patch for landing Clearing flags on attachment: 156095 Committed r124467: <http://trac.webkit.org/changeset/124467> 685485 21 webkit.review.bot 2012-08-02 09:31:04 -0700 All reviewed patches have been landed. Closing bug. 151554 2012-07-10 16:58:23 -0700 2012-07-10 22:24:56 -0700 Patch bug-90920-20120710165822.patch text/plain 1976 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjc5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDgzNGE0YmRlNTNmMjlkMTM0M2Y3ZTMxMDU4OTQzNmEw ZmU4YTA3YS4uMzIzNDViOGVhMDg3MWVjYTZjYTJkNmIxMzhiZjM0Y2UzNDAzZjk0ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA3LTEwICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW0Nocm9taXVtXSBNZXJnZSBmaW5hbCBuaXRzIHRvIER1bXBSZW5kZXJUcmVlLmd5cCBmb3Ig QW5kcm9pZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTA5MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHBhdGNoIGNvbnRhaW5zIHRoZSBsYXN0IGZldyBzbWFsbCBjaGFuZ2VzIHRvIER1bXBSZW5k ZXJUcmVlLmd5cAorICAgICAgICBmcm9tIHRoZSBjaHJvbWl1bS1hbmRyb2lkIGJyYW5jaC4gQWZ0 ZXIgdGhpcyBjaGFuZ2UsIHRoaXMgZmlsZSB3aWxsIGJlCisgICAgICAgIGZ1bGx5IG1lcmdlZC4K KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVy VHJlZS5neXA6CisKIDIwMTItMDctMTAgIEFsZWMgRmxldHQgIDxhbGVjZmxldHRAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIEFkZCBhbGVjZmxldHQgdG8gdGhlIGxpc3Qgb2YgY29tbWl0dGVycwpk aWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBS ZW5kZXJUcmVlLmd5cCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9E dW1wUmVuZGVyVHJlZS5neXAKaW5kZXggMmYyOWYwNThjZDk0ZmVlNGJkY2VkZWY1OTY2MmViNTA0 OTNiODUxNC4uNDEzZjc1ZDAzYTAxYWY2OThhNTcxNzZiZGFmY2UyOTcxMDczYjcxOCAxMDA2NDQK LS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJU cmVlLmd5cAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVt cFJlbmRlclRyZWUuZ3lwCkBAIC0yNTIsNiArMjUyLDkgQEAKICAgICAgICAgICAgICAgICAgICAg ICAgICdjb3B5X1Rlc3ROZXRzY2FwZVBsdWdJbicsCiAgICAgICAgICAgICAgICAgICAgICAgICAn PChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9tZXNhL21lc2EuZ3lwOm9zbWVzYScsCiAg ICAgICAgICAgICAgICAgICAgIF0sCisgICAgICAgICAgICAgICAgICAgICdzb3VyY2VzLyc6IFsK KyAgICAgICAgICAgICAgICAgICAgICAgIFsnZXhjbHVkZScsICdXZWJVc2VyTWVkaWFDbGllbnRN b2NrXFwuY3BwJ10sCisgICAgICAgICAgICAgICAgICAgIF0sCiAgICAgICAgICAgICAgICAgICAg ICdjb3BpZXMnOiBbewogICAgICAgICAgICAgICAgICAgICAgICAgJ2Rlc3RpbmF0aW9uJzogJzwo UFJPRFVDVF9ESVIpJywKICAgICAgICAgICAgICAgICAgICAgICAgICdmaWxlcyc6IFsKQEAgLTQ1 MSw3ICs0NTQsNyBAQAogICAgICAgICAgICAgICAgICAgICAgICAgJzwoUFJPRFVDVF9ESVIpL0R1 bXBSZW5kZXJUcmVlX2FwaycsCiAgICAgICAgICAgICAgICAgICAgICAgICAnLS1hbnQtYXJncycs CiAgICAgICAgICAgICAgICAgICAgICAgICAnLURQUk9EVUNUX0RJUj08KGFudF9idWlsZF9vdXQp JywKLSAgICAgICAgICAgICAgICAgICAgICAgICctLWFudC1jb21waWxlJywKKyAgICAgICAgICAg ICAgICAgICAgICAgICctLWFudC1jb21waWxlPTwoc2RrX2J1aWxkKScsCiAgICAgICAgICAgICAg ICAgICAgICAgICAnLS1hcHBfYWJpJywKICAgICAgICAgICAgICAgICAgICAgICAgICc8KGFuZHJv aWRfYXBwX2FiaSknLAogICAgICAgICAgICAgICAgICAgICBdLAo= 151598 2012-07-10 22:25:09 -0700 2012-08-02 08:37:02 -0700 Patch for landing bug-90920-20120710222508.patch text/plain 1630 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjk2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTcwNDg1NmY0NzE5YTdiODkwODQ5ZDNmYjdhYjk5MjQ5 ZTBlMTAxOC4uM2U2MDQ0OGI5Y2VlZjcxNWJiYmNmNThiNWVmZmRkYWM5MTJmMDIxZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDEyLTA3LTEwICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAg ICAgW0Nocm9taXVtXSBNZXJnZSBmaW5hbCBuaXRzIHRvIER1bXBSZW5kZXJUcmVlLmd5cCBmb3Ig QW5kcm9pZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTA5MjAKKworICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgorCisgICAgICAgIFRoaXMg cGF0Y2ggY29udGFpbnMgdGhlIGxhc3QgZmV3IHNtYWxsIGNoYW5nZXMgdG8gRHVtcFJlbmRlclRy ZWUuZ3lwCisgICAgICAgIGZyb20gdGhlIGNocm9taXVtLWFuZHJvaWQgYnJhbmNoLiBBZnRlciB0 aGlzIGNoYW5nZSwgdGhpcyBmaWxlIHdpbGwgYmUKKyAgICAgICAgZnVsbHkgbWVyZ2VkLgorCisg ICAgICAgICogRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVl Lmd5cDoKKworMjAxMi0wNy0xMCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCiAg ICAgICAgIFtDaHJvbWl1bS1BbmRyb2lkXSBBZGQgYXBrIHRlc3QgdGFyZ2V0cyBmb3Igd2Via2l0 X3VuaXRfdGVzdHMgYW5kIFRlc3RXZWJLaXRBUEkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkwOTE4CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5neXAgYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwCmluZGV4IDJm MjlmMDU4Y2Q5NGZlZTRiZGNlZGVmNTk2NjJlYjUwNDkzYjg1MTQuLmFmYTQwOTFjMTkxNzEwZDc0 NWU2MGYyNmViYWNmYjZiNzg3ZjMzZGMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5neXAKKysrIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cApAQCAtNDUxLDcg KzQ1MSw3IEBACiAgICAgICAgICAgICAgICAgICAgICAgICAnPChQUk9EVUNUX0RJUikvRHVtcFJl bmRlclRyZWVfYXBrJywKICAgICAgICAgICAgICAgICAgICAgICAgICctLWFudC1hcmdzJywKICAg ICAgICAgICAgICAgICAgICAgICAgICctRFBST0RVQ1RfRElSPTwoYW50X2J1aWxkX291dCknLAot ICAgICAgICAgICAgICAgICAgICAgICAgJy0tYW50LWNvbXBpbGUnLAorICAgICAgICAgICAgICAg ICAgICAgICAgJy0tYW50LWNvbXBpbGU9PChzZGtfYnVpbGQpJywKICAgICAgICAgICAgICAgICAg ICAgICAgICctLWFwcF9hYmknLAogICAgICAgICAgICAgICAgICAgICAgICAgJzwoYW5kcm9pZF9h cHBfYWJpKScsCiAgICAgICAgICAgICAgICAgICAgIF0sCg== 156095 2012-08-02 08:37:07 -0700 2012-08-02 09:30:59 -0700 Patch for landing bug-90920-20120802083648.patch text/plain 1461 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyNDQ1OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEyLTA4LTAyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0Nocm9taXVtXSBNZXJnZSBmaW5hbCBuaXRzIHRvIER1bXBSZW5kZXJUcmVlLmd5 cCBmb3IgQW5kcm9pZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTA5MjAKKworICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgorCisgICAgICAg IFRoaXMgcGF0Y2ggY29udGFpbnMgdGhlIGxhc3QgZmV3IHNtYWxsIGNoYW5nZXMgdG8gRHVtcFJl bmRlclRyZWUuZ3lwCisgICAgICAgIGZyb20gdGhlIGNocm9taXVtLWFuZHJvaWQgYnJhbmNoLiBB ZnRlciB0aGlzIGNoYW5nZSwgdGhpcyBmaWxlIHdpbGwgYmUKKyAgICAgICAgZnVsbHkgbWVyZ2Vk LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5k ZXJUcmVlLmd5cDoKKwogMjAxMi0wOC0wMiAgUGV0ZXIgQmV2ZXJsb28gIDxwZXRlckBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBUb2dnbGUgdGhlIHR5cGUgb2YgYW50IGNvbXBp bGUgZm9yIHdlYmtpdF91bml0X3Rlc3RzIGFuZCBUZXN0V2ViS2l0QVBJCkluZGV4OiBUb29scy9E dW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVu ZGVyVHJlZS5neXAJKHJldmlzaW9uIDEyNDQ1OCkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL0R1 bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5neXAJKHdvcmtpbmcgY29weSkKQEAgLTQ4 OCw3ICs0ODgsNyBAQAogICAgICAgICAgICAgICAgICAgICAgICAgJzwoUFJPRFVDVF9ESVIpL0R1 bXBSZW5kZXJUcmVlX2FwaycsCiAgICAgICAgICAgICAgICAgICAgICAgICAnLS1hbnQtYXJncycs CiAgICAgICAgICAgICAgICAgICAgICAgICAnLURQUk9EVUNUX0RJUj08KGFudF9idWlsZF9vdXQp JywKLSAgICAgICAgICAgICAgICAgICAgICAgICctLWFudC1jb21waWxlJywKKyAgICAgICAgICAg ICAgICAgICAgICAgICctLXNkay1idWlsZD08KHNka19idWlsZCknLAogICAgICAgICAgICAgICAg ICAgICAgICAgJy0tYXBwX2FiaScsCiAgICAgICAgICAgICAgICAgICAgICAgICAnPChhbmRyb2lk X2FwcF9hYmkpJywKICAgICAgICAgICAgICAgICAgICAgXSwK