90914 2012-07-10 15:40:37 -0700 [Chromium] REGRESSION(r121909): m_currentInputEvent never set 2012-07-10 18:13:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 adamk adamk inferno scheib oldest_to_newest 666108 0 adamk 2012-07-10 15:40:37 -0700 [Chromium] REGRESSION(r121909): m_currentInputEvent never set 666111 1 151539 adamk 2012-07-10 15:42:25 -0700 Created attachment 151539 Patch 666115 2 151541 adamk 2012-07-10 15:47:01 -0700 Created attachment 151541 Patch 666120 3 scheib 2012-07-10 15:49:20 -0700 Can we manufacture a test verifying the correct behavior of window.open? 666121 4 adamk 2012-07-10 15:52:22 -0700 (In reply to comment #3) > Can we manufacture a test verifying the correct behavior of window.open? That would be great, but I'm not sure this can be done as a layout test. Does DRT expose anything regarding "background" vs "foreground" "tabs"? 666124 5 adamk 2012-07-10 15:54:51 -0700 Landing for now, as the code it's fixing is brand new and clearly wrong. Will poke around to see about adding a test in the meantime. 666137 6 scheib 2012-07-10 16:10:07 -0700 Thx for catching & fixing. Chat w/ Darin indicates that this is a painful bit of code to test in webkit, as DRT likely doesn't have concepts such as tabs, or logic to have it be foreground or background. Easiest test coverage may be via a browser test. I've created a chrome issue for that, since we don't know where the test should be implemented yet. https://code.google.com/p/chromium/issues/detail?id=136614 666228 7 adamk 2012-07-10 18:13:24 -0700 Committed r122284: <http://trac.webkit.org/changeset/122284> 151539 2012-07-10 15:42:25 -0700 2012-07-10 15:46:58 -0700 Patch bug-90914-20120710154224.patch text/plain 1690 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGI5OGUwZDhiYTk2ODMzM2U5MThjOWI0N2QxMmIwMmIzYzM4N2YyNjQuLmI4ZWQ3N2M0Y2QwYzhk MmUyMzNhZDM5N2E2NjgwYjQ0OWYzZGVlMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDctMTAgIEFkYW0gS2xlaW4gIDxhZGFta0BjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBSRUdSRVNTSU9OKHIxMjE5MDkpOiBtX2N1cnJlbnRJ bnB1dEV2ZW50IG5ldmVyIHNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTA5MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBGaXggdXNhZ2Ugb2YgVGVtcG9yYXJ5Q2hhbmdlIHRvIHNwZWNpZnkgYSBsb2Nh bCB2YXJpYWJsZSBuYW1lIHNvIHRoYXQKKyAgICAgICAgbV9jdXJyZW50SW5wdXRFdmVudCBpcyBh Y3R1YWxseSBzZXQgZm9yIHRoZSBkdXJhdGlvbiBvZiBoYW5kbGVJbnB1dEV2ZW50LgorCisgICAg ICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6 OmhhbmRsZUlucHV0RXZlbnQpOiBOYW1lIHRoZSBUZW1wb3JhcnlDaGFuZ2UgaW5zdGFuY2UuCisK IDIwMTItMDctMTAgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBbQ2hyb21pdW0tQW5kcm9pZF0gVXNlIGRlZmF1bHQgZm9udCByZW5kZXJpbmcgc3R5 bGVzIGluIEZvbnRQbGF0Zm9ybURhdGE6OnF1ZXJ5U3lzdGVtRm9yUmVuZGVyU3R5bGUoKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IDgzNjhkMWMyNmUz ODFhMDZhYzE4YTVjYTNiMTY1NDk3MTFkYWI2ZGYuLmRkMzMxNWZmOTBhMGQ0YjNjMzU3M2E3NWU5 ZDNhNDAxNjFmMDE4MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1w bC5jcHAKQEAgLTE3NjEsNyArMTc2MSw3IEBAIGJvb2wgV2ViVmlld0ltcGw6OmhhbmRsZUlucHV0 RXZlbnQoY29uc3QgV2ViSW5wdXRFdmVudCYgaW5wdXRFdmVudCkKICAgICBpZiAobV9pZ25vcmVJ bnB1dEV2ZW50cykKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgVGVtcG9yYXJ5Q2hhbmdl PGNvbnN0IFdlYklucHV0RXZlbnQqPihtX2N1cnJlbnRJbnB1dEV2ZW50LCAmaW5wdXRFdmVudCk7 CisgICAgVGVtcG9yYXJ5Q2hhbmdlPGNvbnN0IFdlYklucHV0RXZlbnQqPiBjdXJyZW50RXZlbnRD aGFuZ2UobV9jdXJyZW50SW5wdXRFdmVudCwgJmlucHV0RXZlbnQpOwogCiAjaWYgRU5BQkxFKFBP SU5URVJfTE9DSykKICAgICBpZiAoaXNQb2ludGVyTG9ja2VkKCkgJiYgV2ViSW5wdXRFdmVudDo6 aXNNb3VzZUV2ZW50VHlwZShpbnB1dEV2ZW50LnR5cGUpKSB7Cg== 151541 2012-07-10 15:47:01 -0700 2012-07-10 18:13:33 -0700 Patch bug-90914-20120710154700.patch text/plain 1991 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGI5OGUwZDhiYTk2ODMzM2U5MThjOWI0N2QxMmIwMmIzYzM4N2YyNjQuLjQ0NzgxODQ2OWNkNTk4 ZmFkZTcyOGY4MTM1MjI1M2RlZjA2Zjk2MTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDctMTAgIEFkYW0gS2xlaW4gIDxhZGFta0BjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBSRUdSRVNTSU9OKHIxMjE5MDkpOiBtX2N1cnJlbnRJ bnB1dEV2ZW50IG5ldmVyIHNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTA5MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgYWx3YXlzLW51bGwgbV9jdXJyZW50SW5wdXRFdmVudCBjYXVzZXMgYSBy ZWdyZXNzaW9uIHdoZW4KKyAgICAgICAgbWlkZGxlLWNsaWNraW5nIG9uIGEgbGluayB0aGF0IGNh bGxzIHdpbmRvdy5vcGVuKCcuLi4nLCAnX2JsYW5rJyk7CisgICAgICAgIHRoYXQgbmV3IHRhYiBz aG91bGQgb3BlbiBpbiB0aGUgYmFja2dyb3VuZCwgYnV0IGluc3RlYWQgb3BlbnMgaW4gdGhlCisg ICAgICAgIGZvcmVncm91bmQgKHNlZSBjb2RlIGluIENocm9tZUNsaWVudEltcGw6OmdldE5hdmln YXRpb25Qb2xpY3koKSkuCisKKyAgICAgICAgRml4IHVzYWdlIG9mIFRlbXBvcmFyeUNoYW5nZSB0 byBzcGVjaWZ5IGEgbG9jYWwgdmFyaWFibGUgbmFtZSBzbyB0aGF0CisgICAgICAgIG1fY3VycmVu dElucHV0RXZlbnQgaXMgYWN0dWFsbHkgc2V0IGZvciB0aGUgZHVyYXRpb24gb2YgaGFuZGxlSW5w dXRFdmVudC4KKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJL aXQ6OldlYlZpZXdJbXBsOjpoYW5kbGVJbnB1dEV2ZW50KTogTmFtZSB0aGUgVGVtcG9yYXJ5Q2hh bmdlIGluc3RhbmNlLgorCiAyMDEyLTA3LTEwICBYaWFuemh1IFdhbmcgIDx3YW5neGlhbnpodUBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtLUFuZHJvaWRdIFVzZSBkZWZhdWx0IGZv bnQgcmVuZGVyaW5nIHN0eWxlcyBpbiBGb250UGxhdGZvcm1EYXRhOjpxdWVyeVN5c3RlbUZvclJl bmRlclN0eWxlKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZp ZXdJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcApp bmRleCA4MzY4ZDFjMjZlMzgxYTA2YWMxOGE1Y2EzYjE2NTQ5NzExZGFiNmRmLi5kZDMzMTVmZjkw YTBkNGIzYzM1NzNhNzVlOWQzYTQwMTYxZjAxODIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViVmlld0ltcGwuY3BwCkBAIC0xNzYxLDcgKzE3NjEsNyBAQCBib29sIFdlYlZpZXdJ bXBsOjpoYW5kbGVJbnB1dEV2ZW50KGNvbnN0IFdlYklucHV0RXZlbnQmIGlucHV0RXZlbnQpCiAg ICAgaWYgKG1faWdub3JlSW5wdXRFdmVudHMpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAg IFRlbXBvcmFyeUNoYW5nZTxjb25zdCBXZWJJbnB1dEV2ZW50Kj4obV9jdXJyZW50SW5wdXRFdmVu dCwgJmlucHV0RXZlbnQpOworICAgIFRlbXBvcmFyeUNoYW5nZTxjb25zdCBXZWJJbnB1dEV2ZW50 Kj4gY3VycmVudEV2ZW50Q2hhbmdlKG1fY3VycmVudElucHV0RXZlbnQsICZpbnB1dEV2ZW50KTsK IAogI2lmIEVOQUJMRShQT0lOVEVSX0xPQ0spCiAgICAgaWYgKGlzUG9pbnRlckxvY2tlZCgpICYm IFdlYklucHV0RXZlbnQ6OmlzTW91c2VFdmVudFR5cGUoaW5wdXRFdmVudC50eXBlKSkgewo=