90908 2012-07-10 13:49:20 -0700 [Gtk] allow building with css-filters 2012-07-11 11:15:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 a.renevier a.renevier eric gustavo mrobinson webkit.review.bot zan oldest_to_newest 666019 0 a.renevier 2012-07-10 13:49:20 -0700 WebKit supports optionnaly css3 filters. But currenly, autoconf and automake do not support the flag. 666026 1 151517 a.renevier 2012-07-10 13:54:34 -0700 Created attachment 151517 patch proposal with this patch, it's possible to build gtk port with css filters support: build-webkit --gtk --css-filters 666066 2 151517 eric 2012-07-10 14:30:04 -0700 Comment on attachment 151517 patch proposal rs=me. 666077 3 mrobinson 2012-07-10 14:47:11 -0700 Just going to cancel the commit queue for the moment, so that Zan can double-check this patch. 666078 4 mrobinson 2012-07-10 14:47:51 -0700 Zan, do you mind doing an informal review of this patch. I'm not certain if we can skip the addition of the new configuration option or not. 666436 5 zan 2012-07-11 00:22:55 -0700 (In reply to comment #4) > Zan, do you mind doing an informal review of this patch. I'm not certain if we can skip the addition of the new configuration option or not. I think it's OK to add a configuration flag since it's currently the only way to enable the feature. Later, with GNUmakefile.features.am, it should be determined whether the feature can be enabled by default (at least in developer builds). 666888 6 151517 webkit.review.bot 2012-07-11 11:15:03 -0700 Comment on attachment 151517 patch proposal Clearing flags on attachment: 151517 Committed r122346: <http://trac.webkit.org/changeset/122346> 666890 7 webkit.review.bot 2012-07-11 11:15:09 -0700 All reviewed patches have been landed. Closing bug. 151517 2012-07-10 13:54:34 -0700 2012-07-11 11:15:03 -0700 patch proposal bug-90908-20120710135433.patch text/plain 3838 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxOTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDUyOTAzZTZkMzMyODgw OGIyMDk1NjgzZjkyMWYzNTdmZGFlYTdhNC4uNzI0MjdlMTRhZTI4MjVhZjJmZTM3NzcwMjE3OGIx MDQ2ZDU0OTk1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTA3LTEwICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgW0d0 a10gYWxsb3cgYnVpbGRpbmcgd2l0aCBjc3MtZmlsdGVycworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA5MDgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc3VwcG9ydCBmb3IgY3NzLWZpbHRlcnMgaW4g U291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KKyAgICAgICAgY29uZmlndXJlLmFjCisKKyAg ICAgICAgTm8gZnVuY3Rpb25hbCBjaGFuZ2UsIHNvIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAq IEdOVW1ha2VmaWxlLmFtOgorCisyMDEyLTA3LTEwICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2 aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKICAgICAgICAgY29uc3RydWN0aW5nIFR5cGVkQXJyYXkg ZnJvbSBhbm90aGVyIFR5cGVkQXJyYXkgaXMgc2xvdwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA4MzgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvR05VbWFrZWZpbGUuYW0gYi9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQppbmRleCBi ODI1ZjBiN2E3YjZjMjQ2YzI0ZTZlMTRiZWM0YmRkNTc3ZmUxYTI3Li5kOTdiODViZGI3OGYyMTZl M2VmMDU3NDQ5YTYzNDYxZWQwNTc3ZTMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9HTlVt YWtlZmlsZS5hbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQpAQCAtNDg3LDYg KzQ4NywxNSBAQCB3ZWJjb3JlX2NwcGZsYWdzICs9IC1ERU5BQkxFX0NTU19SRUdJT05TPTEKIGVu ZGlmICMgRU5EIEVOQUJMRV9DU1NfUkVHSU9OUwogCiAjIC0tLS0KKyMgRmlsdGVycworIyAtLS0t CitpZiBFTkFCTEVfQ1NTX0ZJTFRFUlMKK0ZFQVRVUkVfREVGSU5FUyArPSBFTkFCTEVfQ1NTX0ZJ TFRFUlM9MQord2ViY29yZV9jcHBmbGFncyArPSAtREVOQUJMRV9DU1NfRklMVEVSUz0xCisKK2Vu ZGlmICMgRU5EIEVOQUJMRV9DU1NfRklMVEVSUworCisjIC0tLS0KICMgRXhjbHVzaW9ucwogIyAt LS0tCiBpZiBFTkFCTEVfQ1NTX0VYQ0xVU0lPTlMKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0No YW5nZUxvZwppbmRleCA2NGU3ZDkxYmRjZjY3N2I2OTY4ZmIyMGVjMjI3OGQ5ODhlM2VlNWE3Li4x Njg1YWViZDRlOGVhYWM2Nzk4NDA4OWI4ZTE5ZmM0ZmE4NmYxOWIyIDEwMDY0NAotLS0gYS9DaGFu Z2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDctMTAgIEFybmF1 ZCBSZW5ldmllciAgPGEucmVuZXZpZXJAc2lzYS5zYW1zdW5nLmNvbT4KKworICAgICAgICBbR3Rr XSBhbGxvdyBidWlsZGluZyB3aXRoIGNzcy1maWx0ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDkwOAorCisgICAgICAgIEFkZCBzdXBwb3J0IGZv ciBjc3MtZmlsdGVycyBpbiBTb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQorICAgICAgICBj b25maWd1cmUuYWMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGNvbmZpZ3VyZS5hYzoKKwogMjAxMi0wNy0wNSAgUm9iIEJ1aXMgIDxyYnVpc0ByaW0u Y29tPgogCiAgICAgICAgIFtDTWFrZV0gRml4IHNvbWUgQ01ha2Ugd2FybmluZ3MKZGlmZiAtLWdp dCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCBmZjJiM2U0ODhhMDMxMGM3ODdj MDg2ZDMwYmJiNzg3YjFlYjg4M2FhLi5mZTVmNDRmYmMzZDJiNWVlZGQ0ZWI3ZWE1MDA1NGQxYjVm OTYwYjlmIDEwMDY0NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC0x MTE3LDYgKzExMTcsMTQgQEAgQUNfQVJHX0VOQUJMRShjc3NfcmVnaW9ucywKICAgICAgICAgICAg ICAgW10sW2VuYWJsZV9jc3NfcmVnaW9ucz0ieWVzIl0pCiBBQ19NU0dfUkVTVUxUKFskZW5hYmxl X2Nzc19yZWdpb25zXSkKIAorIyBjaGVjayB3aGV0aGVyIHRvIGVuYWJsZSBDU1MgRmlsdGVycyBz dXBwb3J0CitBQ19NU0dfQ0hFQ0tJTkcoW3doZXRoZXIgdG8gZW5hYmxlIENTUyBGaWx0ZXJzXSkK K0FDX0FSR19FTkFCTEUoY3NzX2ZpbHRlcnMsCisgICAgICAgICAgICAgIEFDX0hFTFBfU1RSSU5H KFstLWVuYWJsZS1jc3MtZmlsdGVyc10sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFtl bmFibGUgc3VwcG9ydCBmb3IgQ1NTIEZpbHRlcnMgW2RlZmF1bHQ9bm9dXSksCisgICAgICAgICAg ICAgIFtdLFtlbmFibGVfY3NzX2ZpbHRlcnM9Im5vIl0pCitBQ19NU0dfUkVTVUxUKFskZW5hYmxl X2Nzc19maWx0ZXJzXSkKKwogR19JUl9TQ0FOTkVSPQogR19JUl9DT01QSUxFUj0KIEdfSVJfR0VO RVJBVEU9CkBAIC0xNDU2LDYgKzE0NjQsNyBAQCBBTV9DT05ESVRJT05BTChbRU5BQkxFX0lGUkFN RV9TRUFNTEVTU10sW3Rlc3QgIiRlbmFibGVfaWZyYW1lX3NlYW1sZXNzIiA9ICJ5ZXMiXQogQU1f Q09ORElUSU9OQUwoW0VOQUJMRV9URVhUX0FVVE9TSVpJTkddLFt0ZXN0ICIkZW5hYmxlX3RleHRf YXV0b3NpemluZyIgPSAieWVzIl0pCiBBTV9DT05ESVRJT05BTChbRU5BQkxFX0NTU19FWENMVVNJ T05TXSxbdGVzdCAiJGVuYWJsZV9jc3NfZXhjbHVzaW9ucyIgPSAieWVzIl0pCiBBTV9DT05ESVRJ T05BTChbRU5BQkxFX0NTU19SRUdJT05TXSxbdGVzdCAiJGVuYWJsZV9jc3NfcmVnaW9ucyIgPSAi eWVzIl0pCitBTV9DT05ESVRJT05BTChbRU5BQkxFX0NTU19GSUxURVJTXSxbdGVzdCAiJGVuYWJs ZV9jc3NfZmlsdGVycyIgPSAieWVzIl0pCiAKICMgR3RrIGNvbmRpdGlvbmFscwogQU1fQ09ORElU SU9OQUwoW0VOQUJMRV9JTlRST1NQRUNUSU9OXSxbdGVzdCAiJGVuYWJsZV9pbnRyb3NwZWN0aW9u IiA9ICJ5ZXMiXSkKQEAgLTE1MTcsNiArMTUyNiw3IEBAIEZlYXR1cmVzOgogIENTUyBib3gtZGVj b3JhdGlvbi1icmVhayBzdXBwb3J0ICAgICAgICAgICAgICAgICAgICAgICAgIDogJGVuYWJsZV9j c3NfYm94X2RlY29yYXRpb25fYnJlYWsKICBDU1MgRXhjbHVzaW9ucyBzdXBwb3J0ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICA6ICRlbmFibGVfY3NzX2V4Y2x1c2lvbnMKICBDU1Mg UmVnaW9ucyBzdXBwb3J0ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6ICRl bmFibGVfY3NzX3JlZ2lvbnMKKyBDU1MgRmlsdGVycyBzdXBwb3J0ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICA6ICRlbmFibGVfY3NzX2ZpbHRlcnMKICBEZXZpY2VPcmllbnRh dGlvbiBzdXBwb3J0ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6ICRlbmFibGVfZGV2 aWNlX29yaWVudGF0aW9uCiAgRGlyZWN0b3J5IHVwbG9hZCAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgOiAkZW5hYmxlX2RpcmVjdG9yeV91cGxvYWQKICBET00gbXV0YXRp b24gb2JzZXJ2ZXIgc3VwcG9ydCAgICAgICAgICAgICAgICAgICAgICAgICAgICA6ICRlbmFibGVf bXV0YXRpb25fb2JzZXJ2ZXJzCg==