90904 2012-07-10 13:37:43 -0700 [Chromium-Android] Fix typos in chromium_android.py in r151492 2012-07-10 16:06:11 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 90894 1 wangxianzhu wangxianzhu abarth dpranke james.wei ojan peter tmpsantos webkit.review.bot zhenghao oldest_to_newest 665998 0 wangxianzhu 2012-07-10 13:37:43 -0700 Sorry, I uploaded a wrong version of patch in bug 90894 which contains some typos. Will fix in this one. 666006 1 151511 wangxianzhu 2012-07-10 13:43:56 -0700 Created attachment 151511 Patch 666050 2 151511 wangxianzhu 2012-07-10 14:10:28 -0700 Comment on attachment 151511 Patch I'll submit it manually. 666056 3 wangxianzhu 2012-07-10 14:13:55 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M Tools/ChangeLog M Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py Committed r122261 M Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py M Tools/ChangeLog r122261 = 213610f62c21101498758f42dcd5ab11851bf576 (refs/remotes/origin/master) No changes between current HEAD and refs/remotes/origin/master Resetting to the latest refs/remotes/origin/master 666093 4 tmpsantos 2012-07-10 15:04:18 -0700 It still doesn't solve all the problems: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/2613/steps/webkitpy-test/logs/stdio ./Tools/Scripts/test-webkitpy is still failing. 666129 5 wangxianzhu 2012-07-10 16:06:11 -0700 (In reply to comment #4) > It still doesn't solve all the problems: > > http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/2613/steps/webkitpy-test/logs/stdio > > ./Tools/Scripts/test-webkitpy is still failing. Thanks for report. Fixed in r122273. Apology for making so many mistakes (and again the bad commit message). 151511 2012-07-10 13:43:56 -0700 2012-07-10 14:10:28 -0700 Patch bug-90904-20120710134355.patch text/plain 2154 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjU1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjc4N2Y3NDc1OTE4ZTMwNWQyZjZjYTA1ZWNkOWQ3MDQ2 N2ZmYWY5Yy4uMDc4NmI5MjhjMGU3NzRiMjc3MWNhMmMyMmU1MDk1MGU5OWQ1ZDY5YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1 IEBACiAyMDEyLTA3LTEwICBYaWFuemh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+ CiAKKyAgICAgICAgW0Nocm9taXVtLUFuZHJvaWRdIEZpeCB0eXBvcyBpbiBjaHJvbWl1bV9hbmRy b2lkLnB5IGluIHIxNTE0OTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkwOTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2Fu ZHJvaWQucHk6CisgICAgICAgIChDaHJvbWl1bUFuZHJvaWRQb3J0LnNldHVwX3Rlc3RfcnVuKToK KworMjAxMi0wNy0xMCAgWGlhbnpodSBXYW5nICA8d2FuZ3hpYW56aHVAY2hyb21pdW0ub3JnPgor CiAgICAgICAgIFtDaHJvbWl1bS1BbmRyb2lkXSBVc2Ugc2V0dXBfdGVzdF9ydW5uZXIoKSBpbnN0 ZWFkIG9mIHN0YXJ0X2hlbHBlcigpIHRvIHNldHVwIHRlc3QgZW52aXJvbm1lbnQKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwODk0CiAKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5k cm9pZC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21p dW1fYW5kcm9pZC5weQppbmRleCBkNWI3YzFhMDBjYWViYjUxZDFjYzczOWQyNmY1MzQ2ZTM0YjBm ZTRmLi4yYTE4Nzc0MDc4YWQzMzU4ZWYwYTNiZmQ4NjdiZTUzMDUxYmEwYTFhIDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJv aWQucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJv bWl1bV9hbmRyb2lkLnB5CkBAIC01OSw3ICs1OSw3IEBAIERSVF9BUFBfUEFDS0FHRSA9ICdvcmcu Y2hyb21pdW0ubmF0aXZlX3Rlc3QnCiBEUlRfQUNUSVZJVFlfRlVMTF9OQU1FID0gRFJUX0FQUF9Q QUNLQUdFICsgJy8uQ2hyb21lTmF0aXZlVGVzdEFjdGl2aXR5JwogRFJUX0FQUF9ESVIgPSAnL2Rh dGEvdXNlci8wLycgKyBEUlRfQVBQX1BBQ0tBR0UgKyAnLycKIERSVF9BUFBfRklMRVNfRElSID0g RFJUX0FQUF9ESVIgKyAnZmlsZXMvJwotRFJUX0FQUF9DQUNIRV9ESVIgPSBESVJfQVBQX0RJUiAr ICdjYWNoZS8nCitEUlRfQVBQX0NBQ0hFX0RJUiA9IERSVF9BUFBfRElSICsgJ2NhY2hlLycKIAog IyBUaGlzIG9ubHkgd29ya3MgZm9yIHNpbmdsZSBjb3JlIGRldmljZXMgc28gZmFyLgogIyBGSVhN RTogRmluZCBhIHNvbHV0aW9uIGZvciBtdWx0aS1jb3JlIGRldmljZXMuCkBAIC0yNTMsNyArMjUz LDcgQEAgY2xhc3MgQ2hyb21pdW1BbmRyb2lkUG9ydChjaHJvbWl1bS5DaHJvbWl1bVBvcnQpOgog CiAgICAgICAgICMgRGVsZXRlIHRoZSBkaXNrIGNhY2hlIGlmIGFueSB0byBlbnN1cmUgYSBjbGVh biB0ZXN0IHJ1bi4KICAgICAgICAgIyBUaGlzIGlzIGxpa2Ugd2hhdCdzIGRvbmUgaW4gQ2hyb21p dW1Qb3J0LnNldHVwX3Rlc3RfcnVuIGJ1dCBvbiB0aGUgZGV2aWNlLgotICAgICAgICBzZWxmLl9y dW5fYWRiX2NvbW1hbmQoWydzaGVsbCcsICdybScsICctcicsIERFVklDRV9BUFBfQ0FDSEVfRElS XSkKKyAgICAgICAgc2VsZi5fcnVuX2FkYl9jb21tYW5kKFsnc2hlbGwnLCAncm0nLCAnLXInLCBE UlRfQVBQX0NBQ0hFX0RJUl0pCiAKICAgICAgICAgIyBTdGFydCB0aGUgSFRUUCBzZXJ2ZXIgc28g dGhhdCB0aGUgZGV2aWNlIGNhbiBhY2Nlc3MgdGhlIHRlc3QgY2FzZXMuCiAgICAgICAgIGNocm9t aXVtLkNocm9taXVtUG9ydC5zdGFydF9odHRwX3NlcnZlcihzZWxmLCBhZGRpdGlvbmFsX2RpcnM9 e1RFU1RfUEFUSF9QUkVGSVg6IHNlbGYubGF5b3V0X3Rlc3RzX2RpcigpfSkK