90895 2012-07-10 10:47:48 -0700 [Qt] Make GraphicsSurface::create function platform specific. 2012-07-10 11:08:27 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 90881 1 zeno zeno noam oldest_to_newest 665875 0 zeno 2012-07-10 10:47:48 -0700 In order to implement platform specific create behavior this function should be platform specific. We need this to be able to do platform specific initialization based on the provided flags, when implementing GraphicsSurfaceGLX. 665881 1 151487 zeno 2012-07-10 10:54:56 -0700 Created attachment 151487 patch for review. 665882 2 151487 noam 2012-07-10 10:58:29 -0700 Comment on attachment 151487 patch for review. Maybe we should combine this with the GLX patch? Otherwise it's hard to see the whole picture. 665887 3 151487 zeno 2012-07-10 11:06:43 -0700 Comment on attachment 151487 patch for review. As discussed on IRC I will instead make the functions platformCreate / platformImport static and return the instance back from there. 665890 4 zeno 2012-07-10 11:08:27 -0700 no separate patch needed. 151487 2012-07-10 10:54:56 -0700 2012-07-10 11:06:42 -0700 patch for review. 90895_20120710-195410.patch text/plain 3105 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMTI2NjQwLi4zNDExODZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDctMTAgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW1F0XSBNYWtlIEdyYXBoaWNzU3VyZmFjZTo6Y3JlYXRlIGZ1bmN0aW9uIHBsYXRmb3JtIHNw ZWNpZmljCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MDg5NQorCisgICAgICAgIE1vdmUgR3JhcGhpY3NTdXJmYWNlOjpjcmVhdGUgZnVuY3Rpb24gZnJv bSBHcmFwaGljc1N1cmZhY2UuY3BwCisgICAgICAgIGludG8gdGhlIHBsYXRmb3JtIHNwZWNpZmlj IGZpbGUgR3JhcGhpY3NTdXJmYWNlTWFjLmNwcC4KKyAgICAgICAgVGhpcyB3aWxsIGFsbG93IGZ1 dHVyZSBpbXBsZW1lbnRhdGlvbiBmb3IgR3JhcGhpY3NTdXJmYWNlR0xYLgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv c3VyZmFjZXMvR3JhcGhpY3NTdXJmYWNlLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9zdXJmYWNlcy9tYWMvR3JhcGhpY3NTdXJmYWNlTWFjLmNwcDoKKyAgICAgICAgKFdlYkNvcmUp OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NTdXJmYWNlOjpjcmVhdGUpOgorCiAyMDEyLTA3 LTA5ICBaZW5vIEFsYmlzc2VyICA8emVub0B3ZWJraXQub3JnPgogCiAgICAgICAgIHJlcXVlc3RB bmltYXRpb25GcmFtZSBzaG91bGQgb25seSB0cmlnZ2VyIHdoZW4gYSBuZXcgZnJhbWUgY2FuIGJl IGRpc3BsYXllZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3N1cmZhY2VzL0dyYXBoaWNzU3VyZmFjZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9zdXJmYWNlcy9HcmFwaGljc1N1cmZhY2UuY3BwCmluZGV4IDAxOGE4OWMuLjY3NGYw OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2Vz L0dyYXBoaWNzU3VyZmFjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvc3VyZmFjZXMvR3JhcGhpY3NTdXJmYWNlLmNwcApAQCAtMjUsMjIgKzI1LDYgQEAKICNpZiBV U0UoR1JBUEhJQ1NfU1VSRkFDRSkKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotUGFzc1JlZlB0cjxH cmFwaGljc1N1cmZhY2U+IEdyYXBoaWNzU3VyZmFjZTo6Y3JlYXRlKGNvbnN0IEludFNpemUmIHNp emUsIEZsYWdzIGZsYWdzLCB1aW50MzJfdCB0b2tlbikKLXsKLSAgICBSZWZQdHI8R3JhcGhpY3NT dXJmYWNlPiBzdXJmYWNlID0gYWRvcHRSZWYobmV3IEdyYXBoaWNzU3VyZmFjZShzaXplLCBmbGFn cykpOwotICAgIGlmICghc3VyZmFjZS0+cGxhdGZvcm1JbXBvcnQodG9rZW4pKQotICAgICAgICBy ZXR1cm4gUGFzc1JlZlB0cjxHcmFwaGljc1N1cmZhY2U+KCk7Ci0gICAgcmV0dXJuIHN1cmZhY2U7 Ci19Ci0KLVBhc3NSZWZQdHI8R3JhcGhpY3NTdXJmYWNlPiBHcmFwaGljc1N1cmZhY2U6OmNyZWF0 ZShjb25zdCBJbnRTaXplJiBzaXplLCBHcmFwaGljc1N1cmZhY2U6OkZsYWdzIGZsYWdzKQotewot ICAgIFJlZlB0cjxHcmFwaGljc1N1cmZhY2U+IHN1cmZhY2UgPSBhZG9wdFJlZihuZXcgR3JhcGhp Y3NTdXJmYWNlKHNpemUsIGZsYWdzKSk7Ci0gICAgaWYgKCFzdXJmYWNlLT5wbGF0Zm9ybUNyZWF0 ZShzaXplLCBmbGFncykpCi0gICAgICAgIHJldHVybiBQYXNzUmVmUHRyPEdyYXBoaWNzU3VyZmFj ZT4oKTsKLSAgICByZXR1cm4gc3VyZmFjZTsKLX0KLQogdWludDMyX3QgR3JhcGhpY3NTdXJmYWNl OjpleHBvcnRUb2tlbigpCiB7CiAgICAgcmV0dXJuIHBsYXRmb3JtRXhwb3J0KCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9tYWMvR3JhcGhp Y3NTdXJmYWNlTWFjLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZh Y2VzL21hYy9HcmFwaGljc1N1cmZhY2VNYWMuY3BwCmluZGV4IDg0MzEyZGUuLmQ0ZjgxMjUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL21hYy9H cmFwaGljc1N1cmZhY2VNYWMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3N1cmZhY2VzL21hYy9HcmFwaGljc1N1cmZhY2VNYWMuY3BwCkBAIC02NCw2ICs2NCwyMiBA QCBzdGF0aWMgdWludDMyX3QgY3JlYXRlVGV4dHVyZShJT1N1cmZhY2VSZWYgaGFuZGxlKQogICAg IHJldHVybiB0ZXh0dXJlOwogfQogCitQYXNzUmVmUHRyPEdyYXBoaWNzU3VyZmFjZT4gR3JhcGhp Y3NTdXJmYWNlOjpjcmVhdGUoY29uc3QgSW50U2l6ZSYgc2l6ZSwgRmxhZ3MgZmxhZ3MsIHVpbnQz Ml90IHRva2VuKQoreworICAgIFJlZlB0cjxHcmFwaGljc1N1cmZhY2U+IHN1cmZhY2UgPSBhZG9w dFJlZihuZXcgR3JhcGhpY3NTdXJmYWNlKHNpemUsIGZsYWdzKSk7CisgICAgaWYgKCFzdXJmYWNl LT5wbGF0Zm9ybUltcG9ydCh0b2tlbikpCisgICAgICAgIHJldHVybiBQYXNzUmVmUHRyPEdyYXBo aWNzU3VyZmFjZT4oKTsKKyAgICByZXR1cm4gc3VyZmFjZTsKK30KKworUGFzc1JlZlB0cjxHcmFw aGljc1N1cmZhY2U+IEdyYXBoaWNzU3VyZmFjZTo6Y3JlYXRlKGNvbnN0IEludFNpemUmIHNpemUs IEdyYXBoaWNzU3VyZmFjZTo6RmxhZ3MgZmxhZ3MpCit7CisgICAgUmVmUHRyPEdyYXBoaWNzU3Vy ZmFjZT4gc3VyZmFjZSA9IGFkb3B0UmVmKG5ldyBHcmFwaGljc1N1cmZhY2Uoc2l6ZSwgZmxhZ3Mp KTsKKyAgICBpZiAoIXN1cmZhY2UtPnBsYXRmb3JtQ3JlYXRlKHNpemUsIGZsYWdzKSkKKyAgICAg ICAgcmV0dXJuIFBhc3NSZWZQdHI8R3JhcGhpY3NTdXJmYWNlPigpOworICAgIHJldHVybiBzdXJm YWNlOworfQorCiB1aW50MzJfdCBHcmFwaGljc1N1cmZhY2U6OnBsYXRmb3JtR2V0VGV4dHVyZUlE KCkKIHsKICAgICBpZiAoIW1fdGV4dHVyZSkK