90894 2012-07-10 10:33:43 -0700 [Chromium-Android] Use setup_test_runner() instead of start_helper() to setup test environment 2012-07-10 13:59:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Android Unspecified RESOLVED FIXED P2 Normal --- 90904 1 wangxianzhu wangxianzhu abarth dpranke james.wei mitz ojan peter tmpsantos webkit.review.bot zhenghao oldest_to_newest 665866 0 wangxianzhu 2012-07-10 10:33:43 -0700 start_helper() is actually start_pixel_test_helper() since http://trac.webkit.org/changeset/115601 (bug 81729). Should use setup_test_runner() to setup test environment for chromium-android. 665895 1 151492 wangxianzhu 2012-07-10 11:16:24 -0700 Created attachment 151492 Patch 665969 2 151492 webkit.review.bot 2012-07-10 12:56:54 -0700 Comment on attachment 151492 Patch Clearing flags on attachment: 151492 Committed r122251: <http://trac.webkit.org/changeset/122251> 665970 3 webkit.review.bot 2012-07-10 12:56:59 -0700 All reviewed patches have been landed. Closing bug. 666029 4 tmpsantos 2012-07-10 13:55:02 -0700 This patch broke EFL test runner: Traceback (most recent call last): File "./Tools/Scripts/test-webkitpy", line 64, in <module> sys.exit(not tester.run()) File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/test/main.py", line 146, in run return self._run_tests(names) File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/test/main.py", line 177, in _run_tests suites.append(loader.loadTestsFromName(name, None)) File "/usr/lib/python2.7/unittest/loader.py", line 103, in loadTestsFromName return self.loadTestsFromModule(obj) File "/usr/lib/python2.7/unittest/loader.py", line 65, in loadTestsFromModule tests.append(self.loadTestsFromTestCase(obj)) File "/usr/lib/python2.7/unittest/loader.py", line 56, in loadTestsFromTestCase loaded_suite = self.suiteClass(map(testCaseClass, testCaseNames)) File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py", line 74, in __init__ self.test_port = host.port_factory.get('test-win-xp', None) File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 110, in get module = __import__(module_name, globals(), locals(), [], -1) File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 62, in <module> DRT_APP_CACHE_DIR = DIR_APP_DIR + 'cache/' NameError: name 'DIR_APP_DIR' is not defined 666032 5 wangxianzhu 2012-07-10 13:57:04 -0700 Sorry for the break. The patch (bug 90904) has been in CQ. 666034 6 tmpsantos 2012-07-10 13:59:17 -0700 (In reply to comment #5) > Sorry for the break. The patch (bug 90904) has been in CQ. No problem. Thanks for fixing. 151492 2012-07-10 11:16:24 -0700 2012-07-10 12:56:54 -0700 Patch bug-90894-20120710111624.patch text/plain 5729 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMTEyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTJhYzYxOGQ4NWFmMDM4ZjU5NmNkOTg2ZWIwOTI3MTk5 Y2IwMjcwNi4uNTRlZTFhN2ZlNjdiNDA1ODdlMDk1YjA2M2U1ODI3MWVlNGM3M2Y4ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDEyLTA3LTEwICBYaWFuemh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgW0Nocm9taXVtLUFuZHJvaWRdIFVzZSBzZXR1cF90ZXN0X3J1bm5lcigpIGlu c3RlYWQgb2Ygc3RhcnRfaGVscGVyKCkgdG8gc2V0dXAgdGVzdCBlbnZpcm9ubWVudAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA4OTQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBzdGFydF9oZWxwZXIoKSBp cyBhY3R1YWxseSBzdGFydF9waXhlbF90ZXN0X2hlbHBlcigpIHNpbmNlIHIxMTU2MDEgKGJ1ZyA4 MTcyOSkuCisgICAgICAgIFNob3VsZCB1c2Ugc2V0dXBfdGVzdF9ydW5uZXIoKSB0byBzZXR1cCB0 ZXN0IGVudmlyb25tZW50IGZvciBjaHJvbWl1bS1hbmRyb2lkLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lkLnB5OgorICAgICAg ICAoQ2hyb21pdW1BbmRyb2lkUG9ydC5zZXR1cF90ZXN0X3J1bik6IFJlbmFtZWQgZnJvbSBzdGFy dF9oZWxwZXIoKS4gQWRkZWQgY2FjaGUgY2xlYW51cCBjb2RlLgorICAgICAgICAoQ2hyb21pdW1B bmRyb2lkUG9ydC5jbGVhbl91cF90ZXN0X3J1bik6IFJlbmFtZWQgZnJvbSBzdG9wX2hlbHBlcigp LgorICAgICAgICAoQ2hyb21pdW1BbmRyb2lkUG9ydC5fcGF0aF90b19oZWxwZXIpOiBSZXR1cm5z IE5vbmUgYXMgd2UgZG9uJ3QgaGF2ZSBhIGhlbHBlciBub3cuCisgICAgICAgIChDaHJvbWl1bUFu ZHJvaWRQb3J0KToKKyAgICAgICAgKENocm9taXVtQW5kcm9pZFBvcnQuX3BhdGhfdG9fZm9yd2Fy ZGVyKTogT3JpZ2luYWwgX3BhdGhfdG9faGVscGVyKCkuCisgICAgICAgIChDaHJvbWl1bUFuZHJv aWRQb3J0Ll9wdXNoX2V4ZWN1dGFibGUpOgorICAgICAgICAoQ2hyb21pdW1BbmRyb2lkRHJpdmVy Ll9faW5pdF9fKToKKyAgICAgICAgKENocm9taXVtQW5kcm9pZERyaXZlci5jbWRfbGluZSk6CisK IDIwMTItMDctMDkgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KIAogICAg ICAgICBbR3RrXSBVbnNraXAgdGhlIENTUyBSZWdpb25zIGxheW91dCB0ZXN0cwpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRy b2lkLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1 bV9hbmRyb2lkLnB5CmluZGV4IDM2MmY0ODU4Yzg5YjhiYjdhMDZhOTFiNzk4MzM1MjAyYTE4NzI3 YzAuLmQ1YjdjMWEwMGNhZWJiNTFkMWNjNzM5ZDI2ZjUzNDZlMzRiMGZlNGYgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5kcm9p ZC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9t aXVtX2FuZHJvaWQucHkKQEAgLTU3LDcgKzU3LDkgQEAgREVWSUNFX0RSVF9TVEFNUF9QQVRIID0g REVWSUNFX0RSVF9ESVIgKyAnRHVtcFJlbmRlclRyZWUuc3RhbXAnCiAKIERSVF9BUFBfUEFDS0FH RSA9ICdvcmcuY2hyb21pdW0ubmF0aXZlX3Rlc3QnCiBEUlRfQUNUSVZJVFlfRlVMTF9OQU1FID0g RFJUX0FQUF9QQUNLQUdFICsgJy8uQ2hyb21lTmF0aXZlVGVzdEFjdGl2aXR5JwotRFJUX0FQUF9G SUxFX0RJUiA9ICcvZGF0YS91c2VyLzAvJyArIERSVF9BUFBfUEFDS0FHRSArICcvZmlsZXMvJwor RFJUX0FQUF9ESVIgPSAnL2RhdGEvdXNlci8wLycgKyBEUlRfQVBQX1BBQ0tBR0UgKyAnLycKK0RS VF9BUFBfRklMRVNfRElSID0gRFJUX0FQUF9ESVIgKyAnZmlsZXMvJworRFJUX0FQUF9DQUNIRV9E SVIgPSBESVJfQVBQX0RJUiArICdjYWNoZS8nCiAKICMgVGhpcyBvbmx5IHdvcmtzIGZvciBzaW5n bGUgY29yZSBkZXZpY2VzIHNvIGZhci4KICMgRklYTUU6IEZpbmQgYSBzb2x1dGlvbiBmb3IgbXVs dGktY29yZSBkZXZpY2VzLgpAQCAtMjM1LDcgKzIzNyw3IEBAIGNsYXNzIENocm9taXVtQW5kcm9p ZFBvcnQoY2hyb21pdW0uQ2hyb21pdW1Qb3J0KToKICAgICAgICAgIyBTYW1lIGFzIHN0YXJ0X2h0 dHBfc2VydmVyKCkuCiAgICAgICAgIHBhc3MKIAotICAgIGRlZiBzdGFydF9oZWxwZXIoc2VsZik6 CisgICAgZGVmIHNldHVwX3Rlc3RfcnVuKHNlbGYpOgogICAgICAgICBzZWxmLl9ydW5fYWRiX2Nv bW1hbmQoWydyb290J10pCiAgICAgICAgIHNlbGYuX3NldHVwX3BlcmZvcm1hbmNlKCkKICAgICAg ICAgIyBSZXF1aXJlZCBieSB3ZWJraXRfc3VwcG9ydDo6R2V0V2ViS2l0Um9vdERpckZpbGVQYXRo KCkuCkBAIC0yNDksMTMgKzI1MSwxNyBAQCBjbGFzcyBDaHJvbWl1bUFuZHJvaWRQb3J0KGNocm9t aXVtLkNocm9taXVtUG9ydCk6CiAgICAgICAgIHNlbGYuX3B1c2hfZm9udHMoKQogICAgICAgICBz ZWxmLl9zeW5jaHJvbml6ZV9kYXRldGltZSgpCiAKKyAgICAgICAgIyBEZWxldGUgdGhlIGRpc2sg Y2FjaGUgaWYgYW55IHRvIGVuc3VyZSBhIGNsZWFuIHRlc3QgcnVuLgorICAgICAgICAjIFRoaXMg aXMgbGlrZSB3aGF0J3MgZG9uZSBpbiBDaHJvbWl1bVBvcnQuc2V0dXBfdGVzdF9ydW4gYnV0IG9u IHRoZSBkZXZpY2UuCisgICAgICAgIHNlbGYuX3J1bl9hZGJfY29tbWFuZChbJ3NoZWxsJywgJ3Jt JywgJy1yJywgREVWSUNFX0FQUF9DQUNIRV9ESVJdKQorCiAgICAgICAgICMgU3RhcnQgdGhlIEhU VFAgc2VydmVyIHNvIHRoYXQgdGhlIGRldmljZSBjYW4gYWNjZXNzIHRoZSB0ZXN0IGNhc2VzLgog ICAgICAgICBjaHJvbWl1bS5DaHJvbWl1bVBvcnQuc3RhcnRfaHR0cF9zZXJ2ZXIoc2VsZiwgYWRk aXRpb25hbF9kaXJzPXtURVNUX1BBVEhfUFJFRklYOiBzZWxmLmxheW91dF90ZXN0c19kaXIoKX0p CiAKICAgICAgICAgX2xvZy5kZWJ1ZygnU3RhcnRpbmcgZm9yd2FyZGVyJykKLSAgICAgICAgY21k ID0gc2VsZi5fcnVuX2FkYl9jb21tYW5kKFsnc2hlbGwnLCAnJXMgJXMnICUgKERFVklDRV9GT1JX QVJERVJfUEFUSCwgRk9SV0FSRF9QT1JUUyldKQorICAgICAgICBzZWxmLl9ydW5fYWRiX2NvbW1h bmQoWydzaGVsbCcsICclcyAlcycgJSAoREVWSUNFX0ZPUldBUkRFUl9QQVRILCBGT1JXQVJEX1BP UlRTKV0pCiAKLSAgICBkZWYgc3RvcF9oZWxwZXIoc2VsZik6CisgICAgZGVmIGNsZWFuX3VwX3Rl c3RfcnVuKHNlbGYpOgogICAgICAgICAjIExlYXZlIHRoZSBmb3J3YXJkZXIgYW5kIHRlc3RzIGh0 dHBkIHNlcnZlciB0aGVyZSBiZWNhdXNlIHRoZXkgYXJlCiAgICAgICAgICMgdXNlZnVsIGZvciBk ZWJ1Z2dpbmcgYW5kIGRvIG5vIGhhcm0gdG8gc3Vic2VxdWVudCB0ZXN0cy4KICAgICAgICAgc2Vs Zi5fdGVhcmRvd25fcGVyZm9ybWFuY2UoKQpAQCAtMjg0LDYgKzI5MCw5IEBAIGNsYXNzIENocm9t aXVtQW5kcm9pZFBvcnQoY2hyb21pdW0uQ2hyb21pdW1Qb3J0KToKICAgICAgICAgcmV0dXJuIHNl bGYuX2J1aWxkX3BhdGgoY29uZmlndXJhdGlvbiwgJ0R1bXBSZW5kZXJUcmVlX2Fway9EdW1wUmVu ZGVyVHJlZS1kZWJ1Zy5hcGsnKQogCiAgICAgZGVmIF9wYXRoX3RvX2hlbHBlcihzZWxmKToKKyAg ICAgICAgcmV0dXJuIE5vbmUKKworICAgIGRlZiBfcGF0aF90b19mb3J3YXJkZXIoc2VsZik6CiAg ICAgICAgIHJldHVybiBzZWxmLl9idWlsZF9wYXRoKHNlbGYuZ2V0X29wdGlvbignY29uZmlndXJh dGlvbicpLCAnZm9yd2FyZGVyJykKIAogICAgIGRlZiBfcGF0aF90b19pbWFnZV9kaWZmKHNlbGYp OgpAQCAtMzIwLDcgKzMyOSw3IEBAIGNsYXNzIENocm9taXVtQW5kcm9pZFBvcnQoY2hyb21pdW0u Q2hyb21pdW1Qb3J0KToKIAogICAgIGRlZiBfcHVzaF9leGVjdXRhYmxlKHNlbGYpOgogICAgICAg ICBkcnRfaG9zdF9wYXRoID0gc2VsZi5fcGF0aF90b19kcml2ZXIoKQotICAgICAgICBmb3J3YXJk ZXJfaG9zdF9wYXRoID0gc2VsZi5fcGF0aF90b19oZWxwZXIoKQorICAgICAgICBmb3J3YXJkZXJf aG9zdF9wYXRoID0gc2VsZi5fcGF0aF90b19mb3J3YXJkZXIoKQogICAgICAgICBob3N0X3N0YW1w ID0gaW50KGZsb2F0KG1heChvcy5zdGF0KGRydF9ob3N0X3BhdGgpLnN0X210aW1lLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBvcy5zdGF0KGZvcndhcmRlcl9ob3N0X3BhdGgp LnN0X210aW1lKSkpCiAgICAgICAgIGRldmljZV9zdGFtcCA9IGludChmbG9hdChzZWxmLl9ydW5f YWRiX2NvbW1hbmQoWwpAQCAtNDUyLDkgKzQ2MSw5IEBAIGNsYXNzIENocm9taXVtQW5kcm9pZERy aXZlcihjaHJvbWl1bS5DaHJvbWl1bURyaXZlcik6CiAKICAgICBkZWYgX19pbml0X18oc2VsZiwg cG9ydCwgd29ya2VyX251bWJlciwgcGl4ZWxfdGVzdHMsIG5vX3RpbWVvdXQ9RmFsc2UpOgogICAg ICAgICBjaHJvbWl1bS5DaHJvbWl1bURyaXZlci5fX2luaXRfXyhzZWxmLCBwb3J0LCB3b3JrZXJf bnVtYmVyLCBwaXhlbF90ZXN0cywgbm9fdGltZW91dCkKLSAgICAgICAgc2VsZi5faW5fZmlmb19w YXRoID0gRFJUX0FQUF9GSUxFX0RJUiArICdEdW1wUmVuZGVyVHJlZS5pbicKLSAgICAgICAgc2Vs Zi5fb3V0X2ZpZm9fcGF0aCA9IERSVF9BUFBfRklMRV9ESVIgKyAnRHVtcFJlbmRlclRyZWUub3V0 JwotICAgICAgICBzZWxmLl9lcnJfZmlsZV9wYXRoID0gRFJUX0FQUF9GSUxFX0RJUiArICdEdW1w UmVuZGVyVHJlZS5lcnInCisgICAgICAgIHNlbGYuX2luX2ZpZm9fcGF0aCA9IERSVF9BUFBfRklM RVNfRElSICsgJ0R1bXBSZW5kZXJUcmVlLmluJworICAgICAgICBzZWxmLl9vdXRfZmlmb19wYXRo ID0gRFJUX0FQUF9GSUxFU19ESVIgKyAnRHVtcFJlbmRlclRyZWUub3V0JworICAgICAgICBzZWxm Ll9lcnJfZmlsZV9wYXRoID0gRFJUX0FQUF9GSUxFU19ESVIgKyAnRHVtcFJlbmRlclRyZWUuZXJy JwogICAgICAgICBzZWxmLl9yZXN0YXJ0X2FmdGVyX2tpbGxlZCA9IEZhbHNlCiAgICAgICAgIHNl bGYuX3JlYWRfZmlmb19wcm9jID0gTm9uZQogCkBAIC00NjcsNyArNDc2LDcgQEAgY2xhc3MgQ2hy b21pdW1BbmRyb2lkRHJpdmVyKGNocm9taXVtLkNocm9taXVtRHJpdmVyKToKICAgICAgICAgY21k ID0gW10KICAgICAgICAgZm9yIHBhcmFtIGluIG9yaWdpbmFsX2NtZDoKICAgICAgICAgICAgIGlm IHBhcmFtLnN0YXJ0c3dpdGgoJy0tcGl4ZWwtdGVzdHM9Jyk6Ci0gICAgICAgICAgICAgICAgc2Vs Zi5fZGV2aWNlX2ltYWdlX3BhdGggPSBEUlRfQVBQX0ZJTEVfRElSICsgc2VsZi5fcG9ydC5ob3N0 LmZpbGVzeXN0ZW0uYmFzZW5hbWUoc2VsZi5faW1hZ2VfcGF0aCkKKyAgICAgICAgICAgICAgICBz ZWxmLl9kZXZpY2VfaW1hZ2VfcGF0aCA9IERSVF9BUFBfRklMRVNfRElSICsgc2VsZi5fcG9ydC5o b3N0LmZpbGVzeXN0ZW0uYmFzZW5hbWUoc2VsZi5faW1hZ2VfcGF0aCkKICAgICAgICAgICAgICAg ICBwYXJhbSA9ICctLXBpeGVsLXRlc3RzPScgKyBzZWxmLl9kZXZpY2VfaW1hZ2VfcGF0aAogICAg ICAgICAgICAgY21kLmFwcGVuZChwYXJhbSkKIAo=