<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>90891</bug_id>
          
          <creation_ts>2012-07-10 10:00:05 -0700</creation_ts>
          <short_desc>[Gtk] fast/events/keydown-function-keys.html is failing</short_desc>
          <delta_ts>2012-07-11 11:42:28 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zan Dobersek">zan</reporter>
          <assigned_to name="Zan Dobersek">zan</assigned_to>
          <cc>eric</cc>
    
    <cc>gustavo</cc>
    
    <cc>mrobinson</cc>
    
    <cc>pnormand</cc>
    
    <cc>spena</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>665830</commentid>
    <comment_count>0</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2012-07-10 10:00:05 -0700</bug_when>
    <thetext>The test fails because when F10 key press is simulated the context menu pops up.

This is a known bug with recent xkeyboard-config version, reported at GNOME Bugzilla:
https://bugzilla.gnome.org/show_bug.cgi?id=661973

There&apos;s a workaround for this until that bug gets resolved, posted at Launchpad:
https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/937822/comments/5
This can be used, with effect, in DumpRenderTree.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>665848</commentid>
    <comment_count>1</comment_count>
      <attachid>151480</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2012-07-10 10:12:00 -0700</bug_when>
    <thetext>Created attachment 151480
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>665850</commentid>
    <comment_count>2</comment_count>
      <attachid>151480</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2012-07-10 10:13:26 -0700</bug_when>
    <thetext>Comment on attachment 151480
Patch

I guess we&apos;ll need this fix for WebKitTestRunner as well...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>665869</commentid>
    <comment_count>3</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2012-07-10 10:38:24 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 151480 [details])
&gt; I guess we&apos;ll need this fix for WebKitTestRunner as well...

True, but WebKitTestRunner doesn&apos;t currently set up any GtkCSSProviders before testing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>665908</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2012-07-10 11:40:43 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #2)
&gt; &gt; (From update of attachment 151480 [details] [details])
&gt; &gt; I guess we&apos;ll need this fix for WebKitTestRunner as well...
&gt; 
&gt; True, but WebKitTestRunner doesn&apos;t currently set up any GtkCSSProviders before testing.

It hasn&apos;t needed to up to this point because the GtkCSSProviders was added to make DRT match the non-native scrollbar of WebKitTestRunner.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>666424</commentid>
    <comment_count>5</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2012-07-11 00:03:13 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (In reply to comment #3)
&gt; &gt; (In reply to comment #2)
&gt; &gt; &gt; (From update of attachment 151480 [details] [details] [details])
&gt; &gt; &gt; I guess we&apos;ll need this fix for WebKitTestRunner as well...
&gt; &gt; 
&gt; &gt; True, but WebKitTestRunner doesn&apos;t currently set up any GtkCSSProviders before testing.
&gt; 
&gt; It hasn&apos;t needed to up to this point because the GtkCSSProviders was added to make DRT match the non-native scrollbar of WebKitTestRunner.

Oddly enough the test passes in WebKitTestRunner without unbinding the F10 key, so it seems there&apos;s no need for a GtkCSSProvider in WKTR.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>666916</commentid>
    <comment_count>6</comment_count>
      <attachid>151480</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-11 11:42:22 -0700</bug_when>
    <thetext>Comment on attachment 151480
Patch

Clearing flags on attachment: 151480

Committed r122349: &lt;http://trac.webkit.org/changeset/122349&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>666917</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-11 11:42:28 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>151480</attachid>
            <date>2012-07-10 10:12:00 -0700</date>
            <delta_ts>2012-07-11 11:42:22 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-90891-20120710191159.patch</filename>
            <type>text/plain</type>
            <size>2126</size>
            <attacher name="Zan Dobersek">zan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDk1YjZhOWRlMjRiNWI5ZjUxYjE3ZWI0YzU5M2NlZmNh
YjY2NzcyNC4uY2UyYzRmOTU4ZDcyNDQzMjU1MDNhYzU0NmI5NmY3ZDc2NDRkMDllZiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3
IEBACisyMDEyLTA3LTEwICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK
KyAgICAgICAgW0d0a10gZmFzdC9ldmVudHMva2V5ZG93bi1mdW5jdGlvbi1rZXlzLmh0bWwgaXMg
ZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
OTA4OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX
b3JrIGFyb3VuZCB0aGUgY29udGV4dCBtZW51IGJlaW5nIHNob3duIG9uIEYxMCBrZXkgYmVpbmcg
cHJlc3NlZCBieQorICAgICAgICB1bmJpZGluZyB0aGUga2V5IHdoZW4gcnVubmluZyB0ZXN0cyBp
biBEdW1wUmVuZGVyVHJlZS4gVGhlIHByb2JsZW0KKyAgICAgICAgYXBwZWFycyB3aGVuIHVzaW5n
IGEgcmVjZW50IHZlcnNpb24gb2YgdGhlIHhrZXlib2FyZC1jb25maWcgcGFja2FnZS4KKworICAg
ICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAgICAgIChz
ZXREZWZhdWx0c1RvQ29uc2lzdGVudFN0YXRlVmFsdWVzRm9yVGVzdGluZyk6CisKIDIwMTItMDct
MTAgIErDoW5vcyBCYWRpY3MgIDxqYmFkaWNzQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBb
UXRdW05SV1RdIEVuYWJsZSBjYXNjYWRlZCBUZXN0RXhwZWN0YXRpb25zCmRpZmYgLS1naXQgYS9U
b29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMvRHVtcFJl
bmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCAxMjAxNzEzMGY4OWIxZGJmMWQ3
MzVhNzJhYmQyM2MxYWE4MzZhZDk2Li4wYTRkZDRhYWUzNDE3NTg5ODNiZmU3MjkxNTIxMTJjNzcz
MWYxN2ViIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRy
ZWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAK
QEAgLTY2NCw4ICs2NjQsMTIgQEAgc3RhdGljIHZvaWQgc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRT
dGF0ZVZhbHVlc0ZvclRlc3RpbmcoKQogI2Vsc2UKICAgICBHdGtDc3NQcm92aWRlciogY3NzUHJv
dmlkZXIgPSBndGtfY3NzX3Byb3ZpZGVyX25ldygpOwogICAgIGd0a19jc3NfcHJvdmlkZXJfbG9h
ZF9mcm9tX2RhdGEoY3NzUHJvdmlkZXIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAiQGJpbmRpbmctc2V0IE5vS2V5Ym9hcmROYXZpZ2F0aW9uIHsgICAgICAgICIKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIgICB1bmJpbmQgXCI8c2hpZnQ+RjEwXCI7
ICAgICAgICAgICAgICAgICAgIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
In0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiCiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAiICogeyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIgICAt
R3RrU2Nyb2xsZWRXaW5kb3ctc2Nyb2xsYmFyLXNwYWNpbmc6IDA7IgorICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIiAgIGd0ay1rZXktYmluZGluZ3M6IE5vS2V5Ym9hcmROYXZp
Z2F0aW9uOyAiCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAifSAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIsCiAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAtMSwgMCk7CiAgICAgZ3RrX3N0eWxlX2NvbnRleHRfYWRkX3Byb3Zp
ZGVyX2Zvcl9zY3JlZW4oZ2RrX2Rpc3BsYXlfZ2V0X2RlZmF1bHRfc2NyZWVuKGdka19kaXNwbGF5
X2dldF9kZWZhdWx0KCkpLAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>