90890 2012-07-10 09:58:43 -0700 [CMAKE] Add missing feature macros 2012-07-10 15:54:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim rakuco webkit.review.bot oldest_to_newest 665827 0 gyuyoung.kim 2012-07-10 09:58:43 -0700 ENABLE_CSS_EXCLUSIONS, ENABLE_CSS_REGIONS, ENABLE_TEXT_AUTOSIZING macros haven't defined in cmake feature list. There is warning message during the build time. CMake Warning: Manually-specified variables were not used by the project: ENABLE_CSS_EXCLUSIONS ENABLE_CSS_REGIONS ENABLE_TEXT_AUTOSIZING 665834 1 151474 gyuyoung.kim 2012-07-10 10:02:09 -0700 Created attachment 151474 Patch 665905 2 151474 rakuco 2012-07-10 11:35:34 -0700 Comment on attachment 151474 Patch Looks good. 666068 3 151474 eric 2012-07-10 14:35:04 -0700 Comment on attachment 151474 Patch LGTM. 666122 4 151474 webkit.review.bot 2012-07-10 15:54:15 -0700 Comment on attachment 151474 Patch Clearing flags on attachment: 151474 Committed r122274: <http://trac.webkit.org/changeset/122274> 666123 5 webkit.review.bot 2012-07-10 15:54:20 -0700 All reviewed patches have been landed. Closing bug. 151474 2012-07-10 10:02:09 -0700 2012-07-10 15:54:14 -0700 Patch bug-90890-20120711020126.patch text/plain 3636 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggMTc5MzM1YzQ2N2U4NmJhYTJkNmY0YTc2NmM5MWM2NTBkY2JhMDYyYy4uNWNmMzU4NmNmMmY2 MjMxYjBkYWVlNjFmYWFmOGRmNTczYWJiMDRhYSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMjEsOSArMjEsMTEgQEAgTUFDUk8gKFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VC S0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NTUF9ORVhUICJUb2dnbGUgQ29udGVudCBTZWN1cml0 eSBQb2xpY3kgMS4xIHN1cHBvcnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFC TEVfQ1NTM19GTEVYQk9YICJUb2dnbGUgQ1NTMyBGbGV4Ym94IHN1cHBvcnQiIE9OKQogICAgIFdF QktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9DU1NfQk9YX0RFQ09SQVRJT05fQlJFQUsgIlRvZ2ds ZSBCb3ggRGVjb3JhdGlvbiBCcmVhayAoQ1NTIEJhY2tncm91bmRzIGFuZCBCb3JkZXJzKSBzdXBw b3J0IiBPTikKKyAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfQ1NTX0VYQ0xVU0lPTlMg IlRvZ2dsZSBDU1MgRXhjbHVzaW9uIHN1cHBvcnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RF RklORShFTkFCTEVfQ1NTX0ZJTFRFUlMgIlRvZ2dsZSBDU1MgRmlsdGVycyBzdXBwb3J0IiBPRkYp CiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NTU19JTUFHRV9SRVNPTFVUSU9OICJU b2dnbGUgQ1NTIGltYWdlLXJlc29sdXRpb24gc3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJ T05fREVGSU5FKEVOQUJMRV9DU1NfSU1BR0VfU0VUICJUb2dnbGUgQ1NTIGltYWdlLXNldCBzdXBw b3J0IiBPRkYpCisgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NTU19SRUdJT05TICJU b2dnbGUgQ1NTIHJlZ2lvbnMgc3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5F KEVOQUJMRV9DU1NfU0hBREVSUyAiVG9nZ2xlIENTUyBTaGFkZXJzICh3aXRoaW4gQ1NTIEZpbHRl cnMpIHN1cHBvcnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfQ1NTX1ZB UklBQkxFUyAiVG9nZ2xlIENTUyBWYXJpYWJsZXMgc3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9P UFRJT05fREVGSU5FKEVOQUJMRV9DVVNUT01fU0NIRU1FX0hBTkRMRVIgIlRvZ2dsZSBDdXN0b20g U2NoZW1lIEhhbmRsZXIgc3VwcG9ydCIgT0ZGKQpAQCAtOTEsNiArOTMsNyBAQCBNQUNSTyAoV0VC S0lUX09QVElPTl9CRUdJTikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfU1ZHICJU b2dnbGUgU1ZHIHN1cHBvcnQiIE9OKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9T VkdfRE9NX09CSkNfQklORElOR1MgIlRvZ2dsZSBTVkcgRE9NIE9iamVjdGl2ZS1DIGJpbmRpbmdz IHN1cHBvcnQgKGltcGxpZXMgU1ZHIHN1cHBvcnQpIiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9E RUZJTkUoRU5BQkxFX1NWR19GT05UUyAiVG9nZ2xlIFNWRyBmb250cyBzdXBwb3J0IChpbXBsZXMg U1ZHIHN1cHBvcnQpIiBPTikKKyAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfVEVYVF9B VVRPU0laSU5HICJUb2dnbGUgVGV4dCBhdXRvIHNpemluZyBzdXBwb3J0IiBPRkYpCiAgICAgV0VC S0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1RPVUNIX0VWRU5UUyAiVG9nZ2xlIFRvdWNoIEV2ZW50 cyBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1RPVUNIX0lD T05fTE9BRElORyAiVG9nZ2xlIFRvdWNoIEljb24gTG9hZGluZyBTdXBwb3J0IiBPRkYpCiAgICAg V0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1VORE9fTUFOQUdFUiAiVG9nZ2xlIFVuZG8gTWFu YWdlciBzdXBwb3J0IiBPRkYpCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFr ZSBiL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlCmluZGV4IDZmZDYwYTI3MzkzNGNkMDRkNTI3 Njc1NjdlY2I0NzlkN2IwYTcyZmUuLjUxNTgyMzIyMWVjNmQyOGVkN2YxMmQ4NzQxMTI3NTMxYmE1 YzNhMTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlCisrKyBiL1NvdXJj ZS9jbWFrZWNvbmZpZy5oLmNtYWtlCkBAIC0xNiw4ICsxNiwxMCBAQAogI2NtYWtlZGVmaW5lMDEg RU5BQkxFX0NTUF9ORVhUCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQ1NTM19GTEVYQk9YCiAjY21h a2VkZWZpbmUwMSBFTkFCTEVfQ1NTX0JPWF9ERUNPUkFUSU9OX0JSRUFLCisjY21ha2VkZWZpbmUw MSBFTkFCTEVfQ1NTX0VYQ0xVU0lPTlMKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9DU1NfSU1BR0Vf UkVTT0xVVElPTgogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0NTU19JTUFHRV9TRVQKKyNjbWFrZWRl ZmluZTAxIEVOQUJMRV9DU1NfUkVHSU9OUwogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0NTU19WQVJJ QUJMRVMKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9DVVNUT01fU0NIRU1FX0hBTkRMRVIKICNjbWFr ZWRlZmluZTAxIEVOQUJMRV9EQVRBTElTVApAQCAtNzcsNiArNzksNyBAQAogI2NtYWtlZGVmaW5l MDEgRU5BQkxFX1NUWUxFX1NDT1BFRAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1NWRwogI2NtYWtl ZGVmaW5lMDEgRU5BQkxFX1NWR19GT05UUworI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1RFWFRfQVVU T1NJWklORwogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1RPVUNIX0VWRU5UUwogI2NtYWtlZGVmaW5l MDEgRU5BQkxFX1RPVUNIX0lDT05fTE9BRElORwogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1VORE9f TUFOQUdFUgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDg2ZTFkNGZh YjQyZGQ2NDE0N2FiODhkY2ExODgzMDY2NTg1ZTRmYTguLmE3MzUyMGEwZjM4ODg2ZjU3Yzg3MWMx MzdlMDk5MTE3YTMyYmQzMmQgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNy0xMCAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2lt QHNhbXN1bmcuY29tPgorCisgICAgICAgIFtDTUFLRV0gQWRkIG1pc3NpbmcgZmVhdHVyZSBtYWNy b3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwODkw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRU5BQkxF X0NTU19FWENMVVNJT05TLCBFTkFCTEVfQ1NTX1JFR0lPTlMsIEVOQUJMRV9URVhUX0FVVE9TSVpJ TkcgbWFjcm9zCisgICAgICAgIGhhdmVuJ3QgZGVmaW5lZCBpbiBjbWFrZSBmZWF0dXJlIGxpc3Qu CisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2U6CisgICAgICAg ICogU291cmNlL2NtYWtlY29uZmlnLmguY21ha2U6CisKIDIwMTItMDctMTAgIEtlbnQgVGFtdXJh ICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJUTCBjYWxlbmRhciBwaWNrZXIgZm9y IDxpbnB1dCB0eXBlPWRhdGU+IGlzIHRvbyBuYXJyb3cgYW5kIGNsaXBwZWQK