90875 2012-07-10 06:05:46 -0700 [Qt][WK2] ASSERT: "!m_viewportItem->isMoving()" in QtViewportHandler::flickMoveEnded() 2012-07-12 03:05:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 90960 90961 1 abecsi abecsi cmarcelo hausmann jturcotte kenneth menard ossy webkit.review.bot zoltan oldest_to_newest 665695 0 abecsi 2012-07-10 06:05:46 -0700 [Qt][WK2] ASSERT: "!m_viewportItem->isMoving()" in QtViewportHandler::flickMoveEnded() 665698 1 151449 abecsi 2012-07-10 06:07:39 -0700 Created attachment 151449 Patch 666344 2 151449 kenneth 2012-07-10 22:13:45 -0700 Comment on attachment 151449 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151449&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1661 > + // touch events too, thus to hinder the canvas from sending synthesized remove "too"? > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1663 > + // childMouseEventFilter and filter incomming touch events as well. incoming* 666567 3 abecsi 2012-07-11 02:43:13 -0700 Committed r122318: <http://trac.webkit.org/changeset/122318> 666569 4 151449 abecsi 2012-07-11 02:43:50 -0700 Comment on attachment 151449 Patch Clearing flags from attachment. 666596 5 ossy 2012-07-11 03:14:46 -0700 (In reply to comment #3) > Committed r122318: <http://trac.webkit.org/changeset/122318> It made 11 tests fail. Could you check it, please? Here is the new bug report: https://bugs.webkit.org/show_bug.cgi?id=90960 666611 6 webkit.review.bot 2012-07-11 03:38:51 -0700 Re-opened since this is blocked by 90961 667577 7 abecsi 2012-07-12 03:05:04 -0700 Committed r122438: <http://trac.webkit.org/changeset/122438> 151449 2012-07-10 06:07:39 -0700 2012-07-11 02:43:49 -0700 Patch bug-90875-20120710150759.patch text/plain 3952 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYWI2Y2I0MzRmMmMyY2Q4 YmQ5MzQ2ZTZjMjA1Yjk0MGRiODM1MWM4MS4uZDRmMTJkYmUzM2MyZDBlNjdhYzI1NzNhOTg3NjY3 N2E4YjQ1OTc3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA3LTEwICBBbmRy YXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAbm9raWEuY29tPgorCisgICAgICAgIFtRdF1bV0syXSBB U1NFUlQ6ICIhbV92aWV3cG9ydEl0ZW0tPmlzTW92aW5nKCkiIGluIFF0Vmlld3BvcnRIYW5kbGVy OjpmbGlja01vdmVFbmRlZCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MDg3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFNpbmNlIE11bHRpUG9pbnRUb3VjaEFyZWEgYW5kIFBpbmNoQXJlYSB1c2UgdGhl IGNoaWxkTW91c2VFdmVudEZpbHRlcgorICAgICAgICBtZXRob2QgdG8gZmlsdGVyIHRvdWNoIGV2 ZW50cyB0b28sIGFuZCBiZWNhdXNlIEZsaWNrYWJsZSBmaWx0ZXJzIGNoaWxkCisgICAgICAgIG1v dXNlIGV2ZW50cyB0aGUgY2FudmFzIGNhbGxzIHRoaXMgZnVuY3Rpb24gYmVmb3JlIHByb3BhZ2F0 aW5nIHRoZSB0b3VjaAorICAgICAgICBldmVudCB0byB0aGUgV2ViVmlldy4gU2luY2UgRmxpY2th YmxlIGRvZXMgbm90IGFjY2VwdCB0b3VjaCBldmVudHMgdGhlCisgICAgICAgIGNhbnZhcyB0cmll cyB0byBwcm9wYWdhdGUgYSBzeW50aGVzaXplZCBtb3VzZSBldmVudCB0aHJvdWdoIHRoZSBiYXNl CisgICAgICAgIGNsYXNzIGNoaWxkTW91c2VFdmVudEZpbHRlciBmdW5jdGlvbiB3aGljaCBpcyBh Y2NlcHRlZCBieSBGbGlja2FibGUgYW5kCisgICAgICAgIGludGVyZmVyZXMgd2l0aCB0aGUgaW5w dXQgZXZlbnRzIHdlIHNlbmQgdG8gRmxpY2FrYmxlIGhlbmNlIG1lc3NlcyB1cAorICAgICAgICB0 aGUgaW50ZXJuYWwgc3RhdGUgb2YgdGhlIFdlYlZpZXcuCisgICAgICAgIFRoaXMgcGF0Y2ggcmVp bXBsZW1lbnRzIHRoZSB2aXJ0dWFsIGNoaWxkTW91c2VFdmVudEZpbHRlciBtZXRob2Qgc28gdGhh dCBhbGwKKyAgICAgICAgdGhlIG1vdXNlIGFuZCB0b3VjaCBldmVudHMgY2FuIGJlIHByb2Nlc3Nl ZCBieSBXZWJLaXQgYmVmb3JlIHRoZXkgYXJyaXZlIHRvCisgICAgICAgIEZsaWNrYWJsZS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHA6CisgICAgICAgIChR UXVpY2tXZWJWaWV3OjpjaGlsZE1vdXNlRXZlbnRGaWx0ZXIpOgorICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvcXQvcXF1aWNrd2Vidmlld19wLmg6CisKIDIwMTItMDctMTAgIFNoZXJpZmYgQm90ICA8 d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHIxMjIxNzguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3FxdWlja3dlYnZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9x cXVpY2t3ZWJ2aWV3LmNwcAppbmRleCAwNDZkODAzMzlhNGYyYmYwOWE2MTgzN2QwMTM4ZTI4MTcx ZjZkZjljLi43YTgxMTY3MTU4OWZkYjc4Yjg1YWI0NzkxZDFmNWFlNWY2Y2NkMmVlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKQEAg LTE2NTUsNiArMTY1NSwzOCBAQCB2b2lkIFFRdWlja1dlYlZpZXc6OnBsYXRmb3JtSW5pdGlhbGl6 ZSgpCiAgICAgV1RGOjppbml0aWFsaXplTWFpblRocmVhZCgpOwogfQogCitib29sIFFRdWlja1dl YlZpZXc6OmNoaWxkTW91c2VFdmVudEZpbHRlcihRUXVpY2tJdGVtKiBpdGVtLCBRRXZlbnQqIGV2 ZW50KQoreworICAgIC8vIFRoaXMgZnVuY3Rpb24gaXMgdXNlZCBieSBNdWx0aVBvaW50VG91Y2hB cmVhIGFuZCBQaW5jaEFyZWEgdG8gZmlsdGVyCisgICAgLy8gdG91Y2ggZXZlbnRzIHRvbywgdGh1 cyB0byBoaW5kZXIgdGhlIGNhbnZhcyBmcm9tIHNlbmRpbmcgc3ludGhlc2l6ZWQKKyAgICAvLyBt b3VzZSBldmVudHMgdG8gdGhlIEZsaWNrYWJsZSBpbXBsZW1lbnRhdGlvbiB3ZSBuZWVkIHRvIHJl aW1wbGVtZW50CisgICAgLy8gY2hpbGRNb3VzZUV2ZW50RmlsdGVyIGFuZCBmaWx0ZXIgaW5jb21t aW5nIHRvdWNoIGV2ZW50cyBhcyB3ZWxsLgorCisgICAgaWYgKCFpc1Zpc2libGUoKSB8fCAhaXNF bmFibGVkKCkpCisgICAgICAgIHJldHVybiBRUXVpY2tGbGlja2FibGU6OmNoaWxkTW91c2VFdmVu dEZpbHRlcihpdGVtLCBldmVudCk7CisKKyAgICBzd2l0Y2ggKGV2ZW50LT50eXBlKCkpIHsKKyAg ICBjYXNlIFFFdmVudDo6TW91c2VCdXR0b25QcmVzczoKKyAgICAgICAgbW91c2VQcmVzc0V2ZW50 KHN0YXRpY19jYXN0PFFNb3VzZUV2ZW50Kj4oZXZlbnQpKTsKKyAgICAgICAgcmV0dXJuIGV2ZW50 LT5pc0FjY2VwdGVkKCk7CisgICAgY2FzZSBRRXZlbnQ6Ok1vdXNlTW92ZToKKyAgICAgICAgbW91 c2VNb3ZlRXZlbnQoc3RhdGljX2Nhc3Q8UU1vdXNlRXZlbnQqPihldmVudCkpOworICAgICAgICBy ZXR1cm4gZXZlbnQtPmlzQWNjZXB0ZWQoKTsKKyAgICBjYXNlIFFFdmVudDo6TW91c2VCdXR0b25S ZWxlYXNlOgorICAgICAgICBtb3VzZVJlbGVhc2VFdmVudChzdGF0aWNfY2FzdDxRTW91c2VFdmVu dCo+KGV2ZW50KSk7CisgICAgICAgIHJldHVybiBldmVudC0+aXNBY2NlcHRlZCgpOworICAgIGNh c2UgUUV2ZW50OjpUb3VjaEJlZ2luOgorICAgIGNhc2UgUUV2ZW50OjpUb3VjaFVwZGF0ZToKKyAg ICBjYXNlIFFFdmVudDo6VG91Y2hFbmQ6CisgICAgICAgIHRvdWNoRXZlbnQoc3RhdGljX2Nhc3Q8 UVRvdWNoRXZlbnQqPihldmVudCkpOworICAgICAgICByZXR1cm4gZXZlbnQtPmlzQWNjZXB0ZWQo KTsKKyAgICBkZWZhdWx0OgorICAgICAgICBicmVhazsKKyAgICB9CisKKyAgICByZXR1cm4gUVF1 aWNrRmxpY2thYmxlOjpjaGlsZE1vdXNlRXZlbnRGaWx0ZXIoaXRlbSwgZXZlbnQpOworfQorCiB2 b2lkIFFRdWlja1dlYlZpZXc6Omdlb21ldHJ5Q2hhbmdlZChjb25zdCBRUmVjdEYmIG5ld0dlb21l dHJ5LCBjb25zdCBRUmVjdEYmIG9sZEdlb21ldHJ5KQogewogICAgIFFfRChRUXVpY2tXZWJWaWV3 KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vi dmlld19wLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdf cC5oCmluZGV4IGUyYzhjMGRhZGYxYTgxZDFjMGJjNmJkMTJmNjNkNzg3MTJkNWRkZjAuLmNlYWFi NjhhMGVjMTk3ZDExZmUxMDRiNjczNGJhYzQzNDE4Mzk2ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wLmgKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3AuaApAQCAtMTY4LDYgKzE2OCw3 IEBAIFFfU0lHTkFMUzoKICAgICB2b2lkIG5hdmlnYXRpb25SZXF1ZXN0ZWQoUVdlYk5hdmlnYXRp b25SZXF1ZXN0KiByZXF1ZXN0KTsKIAogcHJvdGVjdGVkOgorICAgIHZpcnR1YWwgYm9vbCBjaGls ZE1vdXNlRXZlbnRGaWx0ZXIoUVF1aWNrSXRlbSosIFFFdmVudCopOwogICAgIHZpcnR1YWwgdm9p ZCBnZW9tZXRyeUNoYW5nZWQoY29uc3QgUVJlY3RGJiwgY29uc3QgUVJlY3RGJik7CiAgICAgdmly dHVhbCB2b2lkIGNvbXBvbmVudENvbXBsZXRlKCk7CiAgICAgdmlydHVhbCB2b2lkIGtleVByZXNz RXZlbnQoUUtleUV2ZW50Kik7Cg==