90868 2012-07-10 03:23:39 -0700 [EFL] WebKit DRT and WTR fail to build due to undefined reference to WTF::MD5::* 2012-07-10 05:03:14 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim lucas.de.marchi naginenis rakuco tmpsantos webkit.review.bot oldest_to_newest 665616 0 cdumez 2012-07-10 03:23:39 -0700 We get the following linking errors on the EFL build bot: CMakeFiles/DumpRenderTree.dir/__/cairo/PixelDumpSupportCairo.cpp.o: In function `computeMD5HashStringForBitmapContext(BitmapContext*, char*)': /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:75: undefined reference to `WTF::MD5::MD5()' /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:78: undefined reference to `WTF::MD5::addBytes(unsigned char const*, unsigned long)' /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:82: undefined reference to `WTF::MD5::checksum(WTF::Vector<unsigned char, 16ul>&)' collect2: ld returned 1 exit status 665624 1 151427 cdumez 2012-07-10 03:29:11 -0700 Created attachment 151427 Patch Could someone please validate and cq+ ? 665629 2 151427 rakuco 2012-07-10 03:39:34 -0700 Comment on attachment 151427 Patch Looks sane, it looks like I shouldn't have removed ${WTF_LIBRARY_NAME} in r109983... 665666 3 151427 webkit.review.bot 2012-07-10 05:03:09 -0700 Comment on attachment 151427 Patch Clearing flags on attachment: 151427 Committed r122213: <http://trac.webkit.org/changeset/122213> 665667 4 webkit.review.bot 2012-07-10 05:03:14 -0700 All reviewed patches have been landed. Closing bug. 151427 2012-07-10 03:29:11 -0700 2012-07-10 05:03:09 -0700 Patch 90868_build_fix.patch text/plain 1668 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3NzA1 NTgxLi5hZjYyZDA2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDctMTAgIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBXZWJLaXQgRFJUIGFu ZCBXVFIgZmFpbCB0byBidWlsZCBkdWUgdG8gdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBXVEY6Ok1E NTo6KgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA4 NjgKKworICAgICAgICBVbnJldmlld2VkIEVGTCBidWlsZCBmaXguCisKKyAgICAgICAgQ29ycmVj dCBDTWFrZSBjb25maWd1cmF0aW9uIHRvIGhhdmUgRUZMJ3MgRFJUIGFuZCBXZWJLaXRUZXN0UnVu bmVyIGxpbmsKKyAgICAgICAgV1RGIGxpYnJhcnkuIFRoaXMgaXMgbmVlZGVkIHRvIHJlc29sdmUg dW5kZWZpbmVkIHJlZmVyZW5jZSB0byBXVEY6Ok1ENTo6Ki4KKworICAgICAgICAqIER1bXBSZW5k ZXJUcmVlL2VmbC9DTWFrZUxpc3RzLnR4dDoKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Bs YXRmb3JtRWZsLmNtYWtlOgorCiAyMDEyLTA3LTEwICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtp dC5vcmc+CiAKICAgICAgICAgTGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcENvbmZpZ3VyYXRpb25G b3JWaWV3cG9ydCBzaG91bGQgbW92ZSB0byBJbnRlcm5hbHMKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2VmbC9DTWFrZUxpc3RzLnR4dCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Vm bC9DTWFrZUxpc3RzLnR4dAppbmRleCAwYThmZDA2Li5lMWRhY2Y5IDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9lZmwvQ01ha2VMaXN0cy50eHQKKysrIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvZWZsL0NNYWtlTGlzdHMudHh0CkBAIC0yOSw2ICsyOSw3IEBAIFNFVChEdW1wUmVuZGVy VHJlZV9MSUJSQVJJRVMKICAgICAke1dlYkNvcmVUZXN0U3VwcG9ydF9MSUJSQVJZX05BTUV9CiAg ICAgJHtXZWJDb3JlX0xJQlJBUllfTkFNRX0KICAgICAke1dlYktpdF9MSUJSQVJZX05BTUV9Cisg ICAgJHtXVEZfTElCUkFSWV9OQU1FfQogICAgICR7Q0FJUk9fTElCUkFSSUVTfQogICAgICR7RUNP UkVfWF9MSUJSQVJJRVN9CiAgICAgJHtFREpFX0xJQlJBUklFU30KZGlmZiAtLWdpdCBhL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1FZmwuY21ha2UgYi9Ub29scy9XZWJLaXRUZXN0UnVu bmVyL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IDg0OTY0Y2MuLmU0M2ZlYmQgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1FZmwuY21ha2UKKysrIGIvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9QbGF0Zm9ybUVmbC5jbWFrZQpAQCAtNDEsNiArNDEsNyBAQCBMSVNUKEFQ UEVORCBXZWJLaXRUZXN0UnVubmVyX0xJQlJBUklFUwogICAgICR7RURKRV9MSUJSQVJJRVN9CiAg ICAgJHtFRkxERVBTX0xJQlJBUklFU30KICAgICAke0dsaWJfTElCUkFSSUVTfQorICAgICR7V1RG X0xJQlJBUllfTkFNRX0KICkKIAogTElTVChBUFBFTkQgV2ViS2l0VGVzdFJ1bm5lckluamVjdGVk QnVuZGxlX1NPVVJDRVMK