90864 2012-07-10 02:10:04 -0700 RTL calendar picker for <input type=date> is too narrow and clipped 2012-07-12 00:33:00 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 1 tkent tkent haraken morrita webkit.review.bot oldest_to_newest 665582 0 tkent 2012-07-10 02:10:04 -0700 http://code.google.com/p/chromium/issues/detail?id=135421 A calendar picker is too narrow if user's date setting is for an RTL language. This affects only desktop Chromium. 665591 1 151422 tkent 2012-07-10 02:17:45 -0700 Created attachment 151422 Patch 665607 2 151422 haraken 2012-07-10 02:54:29 -0700 Comment on attachment 151422 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151422&action=review > Source/WebCore/Resources/calendarPicker.js:319 > + yearMonthEnd = startOffset - yearMonthRightElement.offsetLeft; > + daysAreaEnd = startOffset - (daysAreaElement.offsetLeft + daysAreaElement.offsetWidth) + maxCellWidth * 7 + DaysAreaContainerBorder; For daysAreaEnd, daysAreaElement.offsetWidth is subtracted from startOffset. On the other hand, for yearMonthEnd, yearMonthRightElement.offsetWidth is not subtracted from startOffset. Why? 665611 3 151422 tkent 2012-07-10 03:05:41 -0700 Comment on attachment 151422 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151422&action=review >> Source/WebCore/Resources/calendarPicker.js:319 >> + daysAreaEnd = startOffset - (daysAreaElement.offsetLeft + daysAreaElement.offsetWidth) + maxCellWidth * 7 + DaysAreaContainerBorder; > > For daysAreaEnd, daysAreaElement.offsetWidth is subtracted from startOffset. On the other hand, for yearMonthEnd, yearMonthRightElement.offsetWidth is not subtracted from startOffset. Why? For yearMonthEnd, we need the distance from the right edge of "main" to the left edge of yearMonthRightElement. For daysAreaEnd, we need the sum of the followings: o the distane from the right edge of "main" to the right edge of the daysAreaElement o 7 * maxCellWidth o DaysAreaContainerBorder. We don't use the left edge of the daysAreaElement because we'd like to assign the same width (maxCellWidth) for each of day-of-week columns. 665612 4 151422 haraken 2012-07-10 03:08:38 -0700 Comment on attachment 151422 Patch Thanks for the clarification. rs=me 665613 5 151422 tkent 2012-07-10 03:09:27 -0700 Comment on attachment 151422 Patch Thanks! 665645 6 151422 webkit.review.bot 2012-07-10 04:21:43 -0700 Comment on attachment 151422 Patch Clearing flags on attachment: 151422 Committed r122212: <http://trac.webkit.org/changeset/122212> 665646 7 webkit.review.bot 2012-07-10 04:21:48 -0700 All reviewed patches have been landed. Closing bug. 151422 2012-07-10 02:17:45 -0700 2012-07-10 04:21:43 -0700 Patch bug-90864-20120710181744.patch text/plain 4374 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGE1YjhjYTI3MGVhYzJh NmVlNThlNDljODkzMzg3YTc1MGJlMTlmMS4uNzI4NmU2ODMxZDA1Y2FiNzY0NDUxNTA5ODA4MDky NGU5NWI0NzdiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTEwICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBSVEwgY2FsZW5kYXIgcGlj a2VyIGZvciA8aW5wdXQgdHlwZT1kYXRlPiBpcyB0b28gbmFycm93IGFuZCBjbGlwcGVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDg2NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RzOiBNYW51YWxU ZXN0cy9mb3Jtcy9jYWxlbmRhci1waWNrZXIuaHRtbAorCisgICAgICAgICogUmVzb3VyY2VzL2Nh bGVuZGFyUGlja2VyLmpzOgorICAgICAgICAoZml4V2luZG93U2l6ZSk6CisgICAgICAgIENoZWNr cyB0aGUgbGVmdCBlZGdlIG9mIGVsZW1lbmV0cyBpbiBSVEwuCisgICAgICAgIChsYXlvdXQpOiBB ZGQgZGlyPWx0ciBmb3IgdGhlIG1hbnVhbCB0ZXN0LCB3aGljaCByZS11c2VzIHRoZSBkb2N1bWVu dC4KKwogMjAxMi0wNy0xMCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyMjE3OC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNlcy9jYWxlbmRhclBpY2tlci5qcyBiL1NvdXJjZS9X ZWJDb3JlL1Jlc291cmNlcy9jYWxlbmRhclBpY2tlci5qcwppbmRleCA0YTdlZjA2YWMyYzE4YmFi NzYxZmJlYTc4Mzc2MjhhMzdmNjRlNmIyLi5mMmE4NTFmMDMyY2UwZmNkOGQxM2Q4MzI5ZDBlOWNh MTg5YTQxZGU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9SZXNvdXJjZXMvY2FsZW5kYXJQ aWNrZXIuanMKKysrIGIvU291cmNlL1dlYkNvcmUvUmVzb3VyY2VzL2NhbGVuZGFyUGlja2VyLmpz CkBAIC0zMTAsMTMgKzMxMCwyMyBAQCBmdW5jdGlvbiBmaXhXaW5kb3dTaXplKCkgewogICAgICAg ICAgICAgbWF4Q2VsbFdpZHRoID0gaGVhZGVyc1tpXS5vZmZzZXRXaWR0aDsKICAgICB9CiAgICAg dmFyIERheXNBcmVhQ29udGFpbmVyQm9yZGVyID0gMTsKLSAgICB2YXIgbWF4UmlnaHQgPSBNYXRo Lm1heCh5ZWFyTW9udGhSaWdodEVsZW1lbnQub2Zmc2V0TGVmdCArIHllYXJNb250aFJpZ2h0RWxl bWVudC5vZmZzZXRXaWR0aCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBkYXlzQXJlYUVs ZW1lbnQub2Zmc2V0TGVmdCArIG1heENlbGxXaWR0aCAqIDcgKyBEYXlzQXJlYUNvbnRhaW5lckJv cmRlcik7CisgICAgdmFyIG1haW4gPSAkKCJtYWluIik7CisgICAgdmFyIHllYXJNb250aEVuZDsK KyAgICB2YXIgZGF5c0FyZWFFbmQ7CisgICAgaWYgKGdsb2JhbC5wYXJhbXMuaXNSVEwpIHsKKyAg ICAgICAgdmFyIHN0YXJ0T2Zmc2V0ID0gbWFpbi5vZmZzZXRMZWZ0ICsgbWFpbi5vZmZzZXRXaWR0 aDsKKyAgICAgICAgeWVhck1vbnRoRW5kID0gc3RhcnRPZmZzZXQgLSB5ZWFyTW9udGhSaWdodEVs ZW1lbnQub2Zmc2V0TGVmdDsKKyAgICAgICAgZGF5c0FyZWFFbmQgPSBzdGFydE9mZnNldCAtIChk YXlzQXJlYUVsZW1lbnQub2Zmc2V0TGVmdCArIGRheXNBcmVhRWxlbWVudC5vZmZzZXRXaWR0aCkg KyBtYXhDZWxsV2lkdGggKiA3ICsgRGF5c0FyZWFDb250YWluZXJCb3JkZXI7CisgICAgfSBlbHNl IHsKKyAgICAgICAgeWVhck1vbnRoRW5kID0geWVhck1vbnRoUmlnaHRFbGVtZW50Lm9mZnNldExl ZnQgKyB5ZWFyTW9udGhSaWdodEVsZW1lbnQub2Zmc2V0V2lkdGg7CisgICAgICAgIGRheXNBcmVh RW5kID0gZGF5c0FyZWFFbGVtZW50Lm9mZnNldExlZnQgKyBtYXhDZWxsV2lkdGggKiA3ICsgRGF5 c0FyZWFDb250YWluZXJCb3JkZXI7CisgICAgfQorCisgICAgdmFyIG1heEVuZCA9IE1hdGgubWF4 KHllYXJNb250aEVuZCwgZGF5c0FyZWFFbmQpOwogICAgIHZhciBNYWluUGFkZGluZyA9IDY7CiAg ICAgdmFyIE1haW5Cb3JkZXIgPSAxOwotICAgIHZhciBkZXNpcmVkQm9keVdpZHRoID0gbWF4Umln aHQgKyBNYWluUGFkZGluZyArIE1haW5Cb3JkZXI7CisgICAgdmFyIGRlc2lyZWRCb2R5V2lkdGgg PSBtYXhFbmQgKyBNYWluUGFkZGluZyArIE1haW5Cb3JkZXI7CiAKLSAgICB2YXIgbWFpbiA9ICQo Im1haW4iKTsKICAgICB2YXIgbWFpbkhlaWdodCA9IG1haW4ub2Zmc2V0SGVpZ2h0OwogICAgIG1h aW4uc3R5bGUud2lkdGggPSAiYXV0byI7CiAgICAgZGF5c0FyZWFFbGVtZW50LnN0eWxlLndpZHRo ID0gIjEwMCUiOwpAQCAtMzU1LDYgKzM2NSw4IEBAIGZ1bmN0aW9uIGNoZWNrTGltaXRzKCkgewog ZnVuY3Rpb24gbGF5b3V0KCkgewogICAgIGlmIChnbG9iYWwucGFyYW1zLmlzUlRMKQogICAgICAg ICBkb2N1bWVudC5ib2R5LmRpciA9ICJydGwiOworICAgIGVsc2UKKyAgICAgICAgZG9jdW1lbnQu Ym9keS5kaXIgPSAibHRyIjsKICAgICB2YXIgbWFpbiA9ICQoIm1haW4iKTsKICAgICB2YXIgcGFy YW1zID0gZ2xvYmFsLnBhcmFtczsKICAgICBtYWluLnJlbW92ZUNoaWxkKG1haW4uZmlyc3RDaGls ZCk7CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMjNmNDRkNTNhYzVh MDFkNWFiNTk2ZjJmZTJlYWZmNDJmNTE2ZmU1Zi4uZjllNzExZWZlZDc3Yjk3OTQ3MTZjNzk0ZjE5 YmYyNzE5ZDczNzQyNyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE0IEBACisyMDEyLTA3LTEwICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9y Zz4KKworICAgICAgICBSVEwgY2FsZW5kYXIgcGlja2VyIGZvciA8aW5wdXQgdHlwZT1kYXRlPiBp cyB0b28gbmFycm93IGFuZCBjbGlwcGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05MDg2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogTWFudWFsVGVzdHMvZm9ybXMvY2FsZW5kYXItcGlja2VyLmh0bWw6 CisgICAgICAgIC0gQWRkIGlzUlRMOnRydWUgZm9yIHRoZSBhcmFiaWMgc2V0dGluZworICAgICAg ICAtIFJlc2V0IHRoZSBpZnJhbWUgc2l6ZSB3aGVuIHRoZSBzZXR0aW5nIGlzIGNoYW5nZWQuCisK IDIwMTItMDctMTAgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjIxNzguCmRpZmYgLS1naXQgYS9N YW51YWxUZXN0cy9mb3Jtcy9jYWxlbmRhci1waWNrZXIuaHRtbCBiL01hbnVhbFRlc3RzL2Zvcm1z L2NhbGVuZGFyLXBpY2tlci5odG1sCmluZGV4IGZmMDEwMjg0MDdkYjlmMzhmYWVlNjIzZDZkNDg5 Y2Q2OGM5MzFhODkuLmEzOGRjMzAwMGJiYzU2NTg1NGE5ODQzNTk0MDk1YTkwNmUzYjFmZGQgMTAw NjQ0Ci0tLSBhL01hbnVhbFRlc3RzL2Zvcm1zL2NhbGVuZGFyLXBpY2tlci5odG1sCisrKyBiL01h bnVhbFRlc3RzL2Zvcm1zL2NhbGVuZGFyLXBpY2tlci5odG1sCkBAIC01OCw2ICs1OCw3IEBAIHZh ciBqYXBhbmVzZUFyZ3VtZW50cyA9IHsKIH07CiB2YXIgYXJhYmljQXJndW1lbnRzID0gewogICAg IGxvY2FsZTogJ2FyJywKKyAgICBpc1JUTDogdHJ1ZSwKICAgICBtb250aExhYmVscyA6IFsn2YrZ htin2YrYsScsICfZgdio2LHYp9mK2LEnLCAn2YXYp9ix2LMnLCAn2KPYqNix2YrZhCcsICfZhdin 2YrZiCcsICfZitmI2YbZitmIJywKICAgICAgICAgICAgICAgICAgICAn2YrZiNmE2YrZiCcsICfY o9i62LPYt9izJywgJ9iz2KjYqtmF2KjYsScsICfYo9mD2KrZiNio2LEnLCAn2YbZiNmB2YXYqNix JywgJ9iv2YrYs9mF2KjYsSddLAogICAgIGRheUxhYmVscyA6IFsn2K0nLCAn2YYnLCAn2KsnLCAn 2LEnLCAn2K4nLCAn2KwnLCAn2LMnXSwKQEAgLTk1LDYgKzk2LDkgQEAgZnVuY3Rpb24gb3BlbkNh bGVuZGFyKGFyZ3MpIHsKIH0KIAogZnVuY3Rpb24gc2VsZWN0ZWQoc2VsZWN0KSB7CisgICAgdmFy IGZyYW1lID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ2lmcmFtZScpWzBdOworICAg IGZyYW1lLnN0eWxlLndpZHRoID0gJzEwMHB4JzsKKyAgICBmcmFtZS5zdHlsZS5oZWlnaHQgPSAn MTAwcHgnOwogICAgIHN3aXRjaCAoc2VsZWN0LnNlbGVjdGVkSW5kZXgpIHsKICAgICBjYXNlIDA6 CiAgICAgICAgIG9wZW5DYWxlbmRhcihlbmdsaXNoQXJndW1lbnRzKTsK