90848 2012-07-09 22:15:17 -0700 [chromium] Assert in decideRenderPassAllocationsForFrame fails when surface is larger than max texture size 2015-02-18 12:40:34 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 90841 P2 Normal --- 90573 1 hayato danakj cc-bugs danakj enne jamesr piman webkit.review.bot wjmaclean zlieber oldest_to_newest 665481 0 hayato 2012-07-09 22:15:17 -0700 Started to hit an assertion introduced in http://trac.webkit.org/changeset/122160. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/7343/steps/interactive_ui_tests/logs/stdio [ RUN ] MenuItemViewTestBasic2.SelectItem2 Xlib: extension "RANDR" missing on display ":9.0". ASSERTION FAILED: reserved third_party/WebKit/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp(360) : virtual void WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame(const WebCore::CCRenderPassList&) 1 0x7f5ded399660 2 0x7f5ded3fc0f6 3 0x7f5ded3fc90b 4 0x7f5ded4222ae 5 0x7f5ded422138 6 0x7f5ded421fa6 7 0x7f5ded3edc2c 8 0x7f5dec11c8f2 WebKit::WebLayerTreeView::composite() 9 0x7f5df0bf54b9 ui::Compositor::Draw(bool) 10 0x7f5df0ce2c1b aura::RootWindow::Draw() 11 0x7f5df0ce98bf 12 0x7f5df0ce9382 13 0x7f5df0ce8c1b 14 0x7f5df5635469 15 0x7f5df5676e8c MessageLoop::RunTask(base::PendingTask const&) 16 0x7f5df5676fa4 MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) 17 0x7f5df56777ad MessageLoop::DoWork() 18 0x7f5df5614ebe 19 0x7f5df561529e 20 0x7f5df5676b51 MessageLoop::RunInternal() 21 0x7f5df5676a08 MessageLoop::RunHandler() 22 0x7f5df56a7db6 base::RunLoop::Run() 23 0x7f5470 24 0x7f5433 25 0x7f55dc 26 0x75bf15 27 0x73120e 28 0x84a898 29 0x847a16 30 0x83c602 31 0x83ce26 665483 1 hayato 2012-07-09 22:24:17 -0700 I commented out the assertion in http://trac.webkit.org/changeset/122194 as I and hbono discussed. Let me watch the result. 665932 2 danakj 2012-07-10 12:01:36 -0700 These tests are crashing for me locally still, but the assertion has stopped breaking once I adjust it to account for valid reservation failure. So I think this should resolve the problem. 665935 3 151499 danakj 2012-07-10 12:03:35 -0700 Created attachment 151499 Patch 665939 4 151499 enne 2012-07-10 12:07:44 -0700 Comment on attachment 151499 Patch It's weird to me that calling code needs to know about the conditions in which reserve could fail. I think you should either move the assert to reserve itself or punt and let bug 90841 take care of this. 665940 5 danakj 2012-07-10 12:08:46 -0700 ya.. ok punt it is! 665971 6 danakj 2012-07-10 12:58:04 -0700 *** This bug has been marked as a duplicate of bug 90841 *** 151499 2012-07-10 12:03:35 -0700 2015-02-18 12:40:34 -0800 Patch bug-90848-20120710150334.patch text/plain 2092 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDczYTE3Yjk3OWRjNzIy ZDZmYjk2YzlhMzYwNWEzZWU0N2Y5YTNmYy4uNWVhMzg5NmJhODZiODJiMTYwNzM0M2U1YjA5NDQ0 YzMwNzgwMDNlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTEwICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQXNz ZXJ0IGluIGRlY2lkZVJlbmRlclBhc3NBbGxvY2F0aW9uc0ZvckZyYW1lIGZhaWxzIHdoZW4gc3Vy ZmFjZSBpcyBsYXJnZXIgdGhhbiBtYXggdGV4dHVyZSBzaXplCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDg0OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v TGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheWVyUmVuZGVy ZXJDaHJvbWl1bTo6ZGVjaWRlUmVuZGVyUGFzc0FsbG9jYXRpb25zRm9yRnJhbWUpOgorICAgICAg ICBXaGVuIHJlc2VydmUoKSBpcyByZXF1ZXN0ZWQgZm9yIGEgdGV4dHVyZSBsYXJnZXIgdGhhbiB0 aGUgbWF4IHRleHR1cmUKKyAgICAgICAgc2l6ZSwgdGhlIGNhbGwgc2hvdWxkIGJlIGV4cGVjdGVk IHRvIGZhaWwuCisKIDIwMTItMDctMTAgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5u YWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CiAKICAgICAgICAgW0dUS10gRml4IG1lbW9yeSBsZWFr cyBieSBhZG9wdGluZyBhbGxvY2F0aW9uIG9mIEdka1BpeGJ1ZgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVt LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVu ZGVyZXJDaHJvbWl1bS5jcHAKaW5kZXggYTZmOTBmYmYyOTlhMTZjY2I3ZTI3Y2FiNjJkMzViOGNm ZWYyNmU5ZS4uMDhiZGQzMDY4YTJhMjFjYmUzZGZjMzMxZmI4ZGIzZjU0YTE1NTVjZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5k ZXJlckNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwCkBAIC0zNTYsMTAgKzM1Niw4IEBAIHZv aWQgTGF5ZXJSZW5kZXJlckNocm9taXVtOjpkZWNpZGVSZW5kZXJQYXNzQWxsb2NhdGlvbnNGb3JG cmFtZShjb25zdCBDQ1JlbmRlclBhCiAKICAgICAgICAgY29uc3QgSW50U2l6ZSYgcmVxdWlyZWRT aXplID0gcmVuZGVyUGFzc2VzSW5EcmF3T3JkZXJbaV0tPmZyYW1lYnVmZmVyT3V0cHV0UmVjdCgp LnNpemUoKTsKICAgICAgICAgR0MzRGVudW0gcmVxdWlyZWRGb3JtYXQgPSBHcmFwaGljc0NvbnRl eHQzRDo6UkdCQTsKLSAgICAgICAgLy8gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MDg0OAotICAgICAgICAvLyBib29sIHJlc2VydmVkID0gdGV4dHVyZS0+cmVz ZXJ2ZShyZXF1aXJlZFNpemUsIHJlcXVpcmVkRm9ybWF0KTsKLSAgICAgICAgLy8gQVNTRVJUX1VO VVNFRChyZXNlcnZlZCwgcmVzZXJ2ZWQpOwotICAgICAgICB0ZXh0dXJlLT5yZXNlcnZlKHJlcXVp cmVkU2l6ZSwgcmVxdWlyZWRGb3JtYXQpOworICAgICAgICBib29sIHJlc2VydmVkID0gdGV4dHVy ZS0+cmVzZXJ2ZShyZXF1aXJlZFNpemUsIHJlcXVpcmVkRm9ybWF0KTsKKyAgICAgICAgQVNTRVJU X1VOVVNFRChyZXNlcnZlZCwgcmVzZXJ2ZWQgfHwgcmVxdWlyZWRTaXplLndpZHRoKCkgPiBtX2Nh cGFiaWxpdGllcy5tYXhUZXh0dXJlU2l6ZSB8fCByZXF1aXJlZFNpemUuaGVpZ2h0KCkgPiBtX2Nh cGFiaWxpdGllcy5tYXhUZXh0dXJlU2l6ZSk7CiAgICAgfQogfQogCg==