90845 2012-07-09 19:13:49 -0700 REGRESSION (r122168): Layout Test http/tests/misc/script-defer.html is failing 2012-07-10 09:09:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89102 1 hayato eric abarth eric kadam mrobinson ossy pnormand tmpsantos webkit.review.bot zan oldest_to_newest 665414 0 hayato 2012-07-09 19:13:49 -0700 The following layout test is failing on WebKit Mac, Linux and Win on chromium. http/tests/misc/script-defer.html Dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmisc%2Fscript-defer.html I've found the same failure on Apple Lion. http://build.webkit.org/builders/Apple%20Lion%20Debug%20WK2%20%28Tests%29/builds/1065/steps/layout-test/logs/stdio 18:23:00.347 5232 http/tests/misc/script-defer.html -> unexpected text diff mismatch Probable cause: The dashboard said it started to fail after r122168. 665420 1 eric 2012-07-09 19:20:18 -0700 Sad. I'm surprised this wasn't caught on cr-linux. maybe cr-linux doesn't run this test? http://trac.webkit.org/changeset/122168 665432 2 hayato 2012-07-09 19:32:44 -0700 I marked it TEXT TestExpectations on chromium in http://trac.webkit.org/changeset/122186. (In reply to comment #1) > Sad. I'm surprised this wasn't caught on cr-linux. maybe cr-linux doesn't run this test? > http://trac.webkit.org/changeset/122168 That should run. I am not sure why cr-linux could not catch. Is it rare case? 665500 3 abarth 2012-07-09 23:13:25 -0700 > That should run. I am not sure why cr-linux could not catch. Is it rare case? It looks like Eric's patch just made it flaky. It happened to pass in exactly the right pattern to trick the bot into landing the patch. 665661 4 ossy 2012-07-10 04:50:59 -0700 It became flakey on GTK and Qt too: --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/http/tests/misc/script-defer-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/http/tests/misc/script-defer-actual.txt @@ -1,7 +1,9 @@ This tests for proper execution order of scripts with the defer attribute https://bugs.webkit.org/show_bug.cgi?id=20710. external inline +DOMContentLoaded slowDefer +DOMContentLoaded defer DOMContentLoaded load 665663 5 eric 2012-07-10 04:57:57 -0700 We definitely shoudl not be delivering more than one DOMContentLoaded event. I'll look when I wake tomorrow. I'm also happy to roll out (or have someone roll out) the patch. 665669 6 eric 2012-07-10 05:08:58 -0700 I've found the bug. Will fix. 665671 7 kadam 2012-07-10 05:11:19 -0700 I skipped this flakey test on Qt. http://trac.webkit.org/changeset/122214/trunk/LayoutTests/platform/qt/Skipped 665686 8 151445 eric 2012-07-10 05:45:36 -0700 Created attachment 151445 Patch 665758 9 tmpsantos 2012-07-10 07:40:58 -0700 (In reply to comment #4) > It became flakey on GTK and Qt too: > --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/http/tests/misc/script-defer-expected.txt > +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/http/tests/misc/script-defer-actual.txt > @@ -1,7 +1,9 @@ > This tests for proper execution order of scripts with the defer attribute https://bugs.webkit.org/show_bug.cgi?id=20710. > external > inline > +DOMContentLoaded > slowDefer > +DOMContentLoaded > defer > DOMContentLoaded > load EFL too. 665761 10 151445 zan 2012-07-10 07:57:32 -0700 Comment on attachment 151445 Patch The patch was reviewed, let's try landing it. 665790 11 151445 webkit.review.bot 2012-07-10 09:09:24 -0700 Comment on attachment 151445 Patch Clearing flags on attachment: 151445 Committed r122226: <http://trac.webkit.org/changeset/122226> 665791 12 webkit.review.bot 2012-07-10 09:09:31 -0700 All reviewed patches have been landed. Closing bug. 151445 2012-07-10 05:45:36 -0700 2012-07-10 09:09:24 -0700 Patch bug-90845-20120710054535.patch text/plain 6007 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTQ2NmU1ZWIwZDgyY2I3 M2YyMmQwNmUxMjA5OTZkYjVkMDA5MjZmYy4uNjQ1OGY1MDQ2YzQ5M2E0NzFmMWEwYzg2MzdjM2Iz YjNiMzMxMzdkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTEwICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTIyMTY4 KTogTGF5b3V0IFRlc3QgaHR0cC90ZXN0cy9taXNjL3NjcmlwdC1kZWZlci5odG1sIGlzIGZhaWxp bmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwODQ1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSB3YXMg YSBiaXQgb3ZlcnplYWxvdXMgaW4gcmVtb3ZpbmcgYm9vbCByZXR1cm5zLiBUaGlzIG9uZSBzdGls bCBtYWtlcyBzZW5zZS4KKyAgICAgICAgVGhpcyBqdXN0IHJldmVydHMgdGhlIHdyb25nIHBhcnQg b2YgbXkgcHJldmlvdXMgY2hhbmdlLgorCisgICAgICAgICogaHRtbC9wYXJzZXIvSFRNTERvY3Vt ZW50UGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxEb2N1bWVudFBhcnNlcjo6YXR0 ZW1wdFRvUnVuRGVmZXJyZWRTY3JpcHRzQW5kRW5kKToKKyAgICAgICAgKiBodG1sL3BhcnNlci9I VE1MU2NyaXB0UnVubmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxTY3JpcHRSdW5uZXI6 OmV4ZWN1dGVTY3JpcHRzV2FpdGluZ0ZvclBhcnNpbmcpOgorICAgICAgICAqIGh0bWwvcGFyc2Vy L0hUTUxTY3JpcHRSdW5uZXIuaDoKKyAgICAgICAgKEhUTUxTY3JpcHRSdW5uZXIpOgorCiAyMDEy LTA3LTEwICBIdWFuZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCiAgICAg ICAgIERvbid0IGRlc3Ryb3kgdGhlIGRlY29kZWQgZGF0YSBvZiBhbiBpbWFnZSBpZiBXZWJLaXQg aXMgYWJvdXQgdG8gcmVuZGVyIHRoZSBpbWFnZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvcGFyc2VyL0hUTUxEb2N1bWVudFBhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L3BhcnNlci9IVE1MRG9jdW1lbnRQYXJzZXIuY3BwCmluZGV4IDU5MDFhM2VkNzEyZDc2MTA3ZmFm MWI3YTBhODFjOTUxYzhkNGU5Y2MuLjMzNjMyODdlZjc3YTM4ZTg4MjdkMTAwN2U3OTMwNGU4OWQ1 ODJmMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxEb2N1bWVu dFBhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTERvY3VtZW50 UGFyc2VyLmNwcApAQCAtMzgwLDExICszODAsOCBAQCB2b2lkIEhUTUxEb2N1bWVudFBhcnNlcjo6 YXR0ZW1wdFRvUnVuRGVmZXJyZWRTY3JpcHRzQW5kRW5kKCkKIHsKICAgICBBU1NFUlQoaXNTdG9w cGluZygpKTsKICAgICBBU1NFUlQoIWhhc0luc2VydGlvblBvaW50KCkpOwotICAgIGlmIChtX3Nj cmlwdFJ1bm5lcikgewotICAgICAgICBtX3NjcmlwdFJ1bm5lci0+ZXhlY3V0ZVNjcmlwdHNXYWl0 aW5nRm9yUGFyc2luZygpOwotICAgICAgICBpZiAoaXNXYWl0aW5nRm9yU2NyaXB0cygpKQotICAg ICAgICAgICAgcmV0dXJuOwotICAgIH0KKyAgICBpZiAobV9zY3JpcHRSdW5uZXIgJiYgIW1fc2Ny aXB0UnVubmVyLT5leGVjdXRlU2NyaXB0c1dhaXRpbmdGb3JQYXJzaW5nKCkpCisgICAgICAgIHJl dHVybjsKICAgICBlbmQoKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9w YXJzZXIvSFRNTFNjcmlwdFJ1bm5lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9I VE1MU2NyaXB0UnVubmVyLmNwcAppbmRleCBkMjcwOWU4MzEyYzkxOGFkOGEzNGYwZDVkNTE3OTBm ZThlODg1NjZiLi4wNDI0NGE2NThmNmUxY2M0MDhhMTU1YmQ3MjBlMTRmMDc1ZTlmNWI5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MU2NyaXB0UnVubmVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MU2NyaXB0UnVubmVyLmNwcApAQCAt MjEwLDcgKzIxMCw3IEBAIHZvaWQgSFRNTFNjcmlwdFJ1bm5lcjo6ZXhlY3V0ZVNjcmlwdHNXYWl0 aW5nRm9yU3R5bGVzaGVldHMoKQogICAgIGV4ZWN1dGVQYXJzaW5nQmxvY2tpbmdTY3JpcHRzKCk7 CiB9CiAKLXZvaWQgSFRNTFNjcmlwdFJ1bm5lcjo6ZXhlY3V0ZVNjcmlwdHNXYWl0aW5nRm9yUGFy c2luZygpCitib29sIEhUTUxTY3JpcHRSdW5uZXI6OmV4ZWN1dGVTY3JpcHRzV2FpdGluZ0ZvclBh cnNpbmcoKQogewogICAgIHdoaWxlICghbV9zY3JpcHRzVG9FeGVjdXRlQWZ0ZXJQYXJzaW5nLmlz RW1wdHkoKSkgewogICAgICAgICBBU1NFUlQoIW1fc2NyaXB0TmVzdGluZ0xldmVsKTsKQEAgLTIx OCwxNCArMjE4LDE1IEBAIHZvaWQgSFRNTFNjcmlwdFJ1bm5lcjo6ZXhlY3V0ZVNjcmlwdHNXYWl0 aW5nRm9yUGFyc2luZygpCiAgICAgICAgIEFTU0VSVChtX3NjcmlwdHNUb0V4ZWN1dGVBZnRlclBh cnNpbmcuZmlyc3QoKS5jYWNoZWRTY3JpcHQoKSk7CiAgICAgICAgIGlmICghbV9zY3JpcHRzVG9F eGVjdXRlQWZ0ZXJQYXJzaW5nLmZpcnN0KCkuY2FjaGVkU2NyaXB0KCktPmlzTG9hZGVkKCkpIHsK ICAgICAgICAgICAgIHdhdGNoRm9yTG9hZChtX3NjcmlwdHNUb0V4ZWN1dGVBZnRlclBhcnNpbmcu Zmlyc3QoKSk7Ci0gICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CiAgICAgICAgIH0KICAgICAgICAgUGVuZGluZ1NjcmlwdCBmaXJzdCA9IG1fc2NyaXB0c1RvRXhl Y3V0ZUFmdGVyUGFyc2luZy50YWtlRmlyc3QoKTsKICAgICAgICAgZXhlY3V0ZVBlbmRpbmdTY3Jp cHRBbmREaXNwYXRjaEV2ZW50KGZpcnN0KTsKICAgICAgICAgLy8gRklYTUU6IFdoYXQgaXMgdGhp cyBtX2RvY3VtZW50IGNoZWNrIGZvcj8KICAgICAgICAgaWYgKCFtX2RvY3VtZW50KQotICAgICAg ICAgICAgcmV0dXJuOworICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KKyAgICByZXR1 cm4gdHJ1ZTsKIH0KIAogdm9pZCBIVE1MU2NyaXB0UnVubmVyOjpyZXF1ZXN0UGFyc2luZ0Jsb2Nr aW5nU2NyaXB0KEVsZW1lbnQqIGVsZW1lbnQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL3BhcnNlci9IVE1MU2NyaXB0UnVubmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNl ci9IVE1MU2NyaXB0UnVubmVyLmgKaW5kZXggZmRiMzVhYTE3ZDhkZmQ3YWNjM2QwYWEyNTVmZTFi NGQyOTQ4ZTMwZS4uYTcyMjZkYzFjMjM1ZTk4ZmZkNDhjYWI4ZDAzNTYxYzU3M2M1ZDBhZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFNjcmlwdFJ1bm5lci5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxTY3JpcHRSdW5uZXIuaApAQCAtNTgs NyArNTgsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBleGVjdXRlU2NyaXB0c1dhaXRpbmdGb3JMb2Fk KENhY2hlZFJlc291cmNlKik7CiAgICAgYm9vbCBoYXNTY3JpcHRzV2FpdGluZ0ZvclN0eWxlc2hl ZXRzKCkgY29uc3QgeyByZXR1cm4gbV9oYXNTY3JpcHRzV2FpdGluZ0ZvclN0eWxlc2hlZXRzOyB9 CiAgICAgdm9pZCBleGVjdXRlU2NyaXB0c1dhaXRpbmdGb3JTdHlsZXNoZWV0cygpOwotICAgIHZv aWQgZXhlY3V0ZVNjcmlwdHNXYWl0aW5nRm9yUGFyc2luZygpOworICAgIGJvb2wgZXhlY3V0ZVNj cmlwdHNXYWl0aW5nRm9yUGFyc2luZygpOwogCiAgICAgYm9vbCBoYXNQYXJzZXJCbG9ja2luZ1Nj cmlwdCgpIGNvbnN0OwogICAgIGJvb2wgaXNFeGVjdXRpbmdTY3JpcHQoKSBjb25zdCB7IHJldHVy biAhIW1fc2NyaXB0TmVzdGluZ0xldmVsOyB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjA5MTJhNWUzM2Q4NGZjYTM0Zjkz M2UxM2YyODQ2ZTY2MDY0N2U2My4uNDc2ZDFlNmVhMjBlMjI2YWNkNWQ5OWYzN2NlZjAzOTE4Y2Rl MWQ5NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTEwICBFcmljIFNlaWRlbCAgPGVy aWNAd2Via2l0Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTIyMTY4KTogTGF5b3V0IFRl c3QgaHR0cC90ZXN0cy9taXNjL3NjcmlwdC1kZWZlci5odG1sIGlzIGZhaWxpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwODQ1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHRlc3Qgc2hvdWxkIG5v IGxvbmdlciBmbGFrZS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3Rh dGlvbnM6CisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDoKKwogMjAxMi0wNy0wOSAgQW5k cmV5IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtFeHRlbnNpb25zIEFQSV0gc2ltcGxpZnkgcGFuZWwgc2l6ZSBjaGVjayBpbiBleHRlbnNp b25zLXBhbmVsLmh0bWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVt L1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhw ZWN0YXRpb25zCmluZGV4IDYzZWJmNjYwZGJkODk3M2ZmN2ZiZDVhOTY1OTJhNTIyNDkzNWY3ZjMu LmYxZDljNTM2YWJiMjhhZDI1MDc0NmI3YmI0YzU4OTMyODA1ODdhZmMgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucwpAQCAtMzc0MSw2ICszNzQx LDMgQEAgQlVHV0s5MDc0NiA6IGZhc3QvbXVsdGljb2wvY29sdW1uLXNwYW4tcGFyZW50LWNvbnRp bnVhdGlvbi1jcmFzaC5odG1sID0gUEFTUyBUSU0KIAogQlVHQ1IxMzY0NDEgOiBmYXN0L2NhbnZh cy93ZWJnbC9nbHNsLWNvbmZvcm1hbmNlLmh0bWwgPSBURVhUCiBCVUdDUjEzNjQ0MSA6IHBsYXRm b3JtL2Nocm9taXVtL3ZpcnR1YWwvZ3B1L2Zhc3QvY2FudmFzL3dlYmdsL2dsc2wtY29uZm9ybWFu Y2UuaHRtbCA9IFRFWFQKLQotLy8gU3RhcnRlZCBmYWlsaW5nIGFmdGVyIHIxMjIxNjguCi1CVUdX SzkwODQ1IDogaHR0cC90ZXN0cy9taXNjL3NjcmlwdC1kZWZlci5odG1sID0gVEVYVApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRm b3JtL3F0L1NraXBwZWQKaW5kZXggMmU4ZjIxYWQxYWRhZjRjOWFiYmY4ZjFkNTQ5NzQyNGI3YTM4 YWVjMy4uMzY2MWYxN2VkMWJmOTk3NWVhY2IzMWI4MzY2MDI5M2Y3MGYxMGQ3NiAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9xdC9Ta2lwcGVkCkBAIC05NzMsOSArOTczLDYgQEAgaHR0cC90ZXN0cy9taXNjL2xpbmst cmVsLWljb24tYmVmb3JlbG9hZC5odG1sCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02NDAwMgogZmFzdC9zZWxlY3RvcnMvdW5xdWFsaWZpZWQtaG92ZXItc3RyaWN0 Lmh0bWwKIAotIyBbUXRdIGh0dHAvdGVzdHMvbWlzYy9zY3JpcHQtZGVmZXIuaHRtbCBpcyBmbGFr ZXkKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwODQ1Ci1odHRw L3Rlc3RzL21pc2Mvc2NyaXB0LWRlZmVyLmh0bWwKIAogIyA9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0gIwog IyBmYWlsaW5nIG1lZGlhIHRlc3RzCg==