90826 2012-07-09 15:18:32 -0700 [Chromium-Android] Use default font rendering styles in FontPlatformData::querySystemForRenderStyle() 2012-07-10 13:30:24 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 wangxianzhu wangxianzhu abarth jamesr tony webkit.review.bot oldest_to_newest 665221 0 wangxianzhu 2012-07-09 15:18:32 -0700 With WebKit API, we can set font rendering styles from Chromium side for chromium-android. To use the styles, FontPlatformData::querySystemForRenderStyle() should initialize the fields of m_style with FontRenderStyle::NoPreference. 665228 1 151332 wangxianzhu 2012-07-09 15:27:06 -0700 Created attachment 151332 Patch 665958 2 151332 abarth 2012-07-10 12:37:04 -0700 Comment on attachment 151332 Patch Ok. 665959 3 abarth 2012-07-10 12:38:06 -0700 I'm not an expert here, so let me know if you'd like an expert review. 665993 4 151332 webkit.review.bot 2012-07-10 13:30:19 -0700 Comment on attachment 151332 Patch Clearing flags on attachment: 151332 Committed r122255: <http://trac.webkit.org/changeset/122255> 665994 5 webkit.review.bot 2012-07-10 13:30:24 -0700 All reviewed patches have been landed. Closing bug. 151332 2012-07-09 15:27:06 -0700 2012-07-10 13:30:19 -0700 Patch bug-90826-20120709152705.patch text/plain 5203 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjI2NGUwNTRhYmU5NGI4 Nzc2MDhmYjAzZTdkOTkyZTYyMjU4MGJhZi4uYjM2YmQxNTBlZTE0MWMyZjAzZDFkMzc4MjM3Njdj MTg0NDNhNzI3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTA5ICBYaWFu emh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVt LUFuZHJvaWRdIFVzZSBkZWZhdWx0IGZvbnQgcmVuZGVyaW5nIHN0eWxlcyBpbiBGb250UGxhdGZv cm1EYXRhOjpxdWVyeVN5c3RlbUZvclJlbmRlclN0eWxlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwODI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGUgY2hhbmdlIHRvIHRo aXMgZmlsZSBpcyByZWZhY3RvcmluZyBvbmx5LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvaGFyZmJ1enovRm9udFBsYXRmb3JtRGF0YUhhcmZCdXp6LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkZvbnRQbGF0Zm9ybURhdGE6OnF1ZXJ5U3lzdGVtRm9yUmVuZGVyU3R5bGUpOiBNb3ZlZCB0 aGUgIk5vUHJlZmVyZW5jZSIgaW5pdGlhbGl6YXRpb24gaW50byBQbGF0Zm9ybVN1cHBvcnQ6OlBs YXRmb3JtU3VwcG9ydDo6Z2V0UmVuZGVyU3R5bGVGb3JTdHJpa2UoKS4KKwogMjAxMi0wNy0wOSAg U2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyMjEwNy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5k ZXggMTczYTI3Nzg4ZTZjMGVlYmJjNTQ5NDMwZGJhY2UwOGVmMjIxYmJmNC4uZTliMDJlMjk0NGYz OTc2MmVjOTU2M2VmOWYxOTcyNzBkYjJkYjNjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNCBAQAorMjAxMi0wNy0wOSAgWGlhbnpodSBXYW5nICA8d2FuZ3hpYW56aHVA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bS1BbmRyb2lkXSBVc2UgZGVmYXVsdCBm b250IHJlbmRlcmluZyBzdHlsZXMgaW4gRm9udFBsYXRmb3JtRGF0YTo6cXVlcnlTeXN0ZW1Gb3JS ZW5kZXJTdHlsZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05MDgyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogV2ViS2l0Lmd5cDoKKyAgICAgICAgKiBzcmMvUGxhdGZvcm1TdXBwb3J0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtU3VwcG9ydDo6Z2V0UmVuZGVyU3R5bGVGb3JTdHJpa2Up OiBDYWxsIHN0eWxlLnNldERlZmF1bHQoKSBvbiBBbmRyb2lkIG9yIHdoZW4gdGhlIGZvbnQgaXMg bm90IHNwZWNpZmllZC4KKwogMjAxMi0wNy0wOSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3 LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyMjEw Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6 L0ZvbnRQbGF0Zm9ybURhdGFIYXJmQnV6ei5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9oYXJmYnV6ei9Gb250UGxhdGZvcm1EYXRhSGFyZkJ1enouY3BwCmluZGV4IDU0ZGY3 NzA2MzAzYTdhZTczNmRkNWFlNzhhOGFkZmFlMzc2OWZjYmQuLjI2NTViNjFhYjFmOTE2ZWVkNzA2 M2I4ZThmNDY2YWVlOGYyMDQxZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2hhcmZidXp6L0ZvbnRQbGF0Zm9ybURhdGFIYXJmQnV6ei5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovRm9udFBsYXRmb3JtRGF0YUhh cmZCdXp6LmNwcApAQCAtMjYxLDE4ICsyNjEsNiBAQCBIYXJmYnV6ekZhY2UqIEZvbnRQbGF0Zm9y bURhdGE6OmhhcmZidXp6RmFjZSgpIGNvbnN0CiAKIHZvaWQgRm9udFBsYXRmb3JtRGF0YTo6cXVl cnlTeXN0ZW1Gb3JSZW5kZXJTdHlsZSgpCiB7Ci0gICAgaWYgKCFtX2ZhbWlseS5sZW5ndGgoKSkg ewotICAgICAgICAvLyBXZSBkb24ndCBoYXZlIGEgZmFtaWx5IGZvciB0aGlzLCBwcm9iYWJseSBi ZWNhdXNlIGl0J3MgYSB3ZWJmb250LiBXZQotICAgICAgICAvLyBzZXQgYWxsIHRoZSB2YWx1ZXMg dG8gJ25vIHByZWZlcmVuY2UnIGFuZCB0YWtlIHRoZSBzeXN0ZW0gZGVmYXVsdHMuCi0gICAgICAg IG1fc3R5bGUudXNlQml0bWFwcyA9IEZvbnRSZW5kZXJTdHlsZTo6Tm9QcmVmZXJlbmNlOwotICAg ICAgICBtX3N0eWxlLnVzZUF1dG9IaW50ID0gRm9udFJlbmRlclN0eWxlOjpOb1ByZWZlcmVuY2U7 Ci0gICAgICAgIG1fc3R5bGUudXNlSGludGluZyA9IEZvbnRSZW5kZXJTdHlsZTo6Tm9QcmVmZXJl bmNlOwotICAgICAgICBtX3N0eWxlLnVzZUFudGlBbGlhcyA9IEZvbnRSZW5kZXJTdHlsZTo6Tm9Q cmVmZXJlbmNlOwotICAgICAgICBtX3N0eWxlLnVzZVN1YnBpeGVsUmVuZGVyaW5nID0gRm9udFJl bmRlclN0eWxlOjpOb1ByZWZlcmVuY2U7Ci0gICAgICAgIG1fc3R5bGUudXNlU3VicGl4ZWxQb3Np dGlvbmluZyA9IEZvbnRSZW5kZXJTdHlsZTo6Tm9QcmVmZXJlbmNlOwotICAgICAgICByZXR1cm47 Ci0gICAgfQotCiAgICAgUGxhdGZvcm1TdXBwb3J0OjpnZXRSZW5kZXJTdHlsZUZvclN0cmlrZSht X2ZhbWlseS5kYXRhKCksICgoKGludCltX3RleHRTaXplKSA8PCAyKSB8IChtX3R5cGVmYWNlLT5z dHlsZSgpICYgMyksICZtX3N0eWxlKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9XZWJLaXQuZ3lwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCmlu ZGV4IDJmZWVjYzczODlkM2M1ODFkNGY0M2ZiOTQ0NjAyZTNiMDdkNTMyNTMuLjZmY2U0NDA3NTg3 ODNhM2UyZDE5MmU4YTNjZTk3YjBkMjdhMGE0YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vV2ViS2l0Lmd5cAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5n eXAKQEAgLTg2NCw2ICs4NjQsNyBAQAogICAgICAgICAgICAgICAgIFsnT1M9PSJhbmRyb2lkIics IHsKICAgICAgICAgICAgICAgICAgICAgJ3NvdXJjZXMvJzogWwogICAgICAgICAgICAgICAgICAg ICAgICAgWydpbmNsdWRlJywgJ15zcmMvbGludXgvV2ViRm9udFJlbmRlcmluZ1xcLmNwcCQnXSwK KyAgICAgICAgICAgICAgICAgICAgICAgIFsnaW5jbHVkZScsICdec3JjL2xpbnV4L1dlYkZvbnRS ZW5kZXJTdHlsZVxcLmNwcCQnXSwKICAgICAgICAgICAgICAgICAgICAgXSwKICAgICAgICAgICAg ICAgICB9XSwKICAgICAgICAgICAgIF0sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9QbGF0Zm9ybVN1cHBvcnQuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv UGxhdGZvcm1TdXBwb3J0LmNwcAppbmRleCA5NGIyNmYwNWE4M2M1M2FmOTI4ZGRhYzQzZTMwMzI4 MjY3OTE0MjQwLi4xOTNiNjhiM2E4MWNkMzczNjU1MDkzODZjYmViYTc2OTQ2YzU1MTRkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9QbGF0Zm9ybVN1cHBvcnQuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1BsYXRmb3JtU3VwcG9ydC5jcHAKQEAgLTY4 LDEzICs2OCwxNSBAQAogCiAjaWYgT1MoREFSV0lOKQogI2luY2x1ZGUgPHB1YmxpYy9tYWMvV2Vi VGhlbWVFbmdpbmUuaD4KLSNlbGlmIE9TKFVOSVgpICYmICFPUyhBTkRST0lEKQotI2luY2x1ZGUg IldlYkZvbnRJbmZvLmgiCisjZWxpZiBPUyhVTklYKQogI2luY2x1ZGUgIldlYkZvbnRSZW5kZXJT dHlsZS5oIgotI2luY2x1ZGUgPHB1YmxpYy9saW51eC9XZWJUaGVtZUVuZ2luZS5oPgotI2VsaWYg T1MoQU5EUk9JRCkKKyNpZiBPUyhBTkRST0lEKQogI2luY2x1ZGUgPHB1YmxpYy9hbmRyb2lkL1dl YlRoZW1lRW5naW5lLmg+Ci0jZW5kaWYKKyNlbHNlCisjaW5jbHVkZSAiV2ViRm9udEluZm8uaCIK KyNpbmNsdWRlIDxwdWJsaWMvbGludXgvV2ViVGhlbWVFbmdpbmUuaD4KKyNlbmRpZiAvLyBPUyhB TkRST0lEKQorI2VuZGlmIC8vIGVsaWYgT1MoVU5JWCkKIAogI2luY2x1ZGUgIk5hdGl2ZUltYWdl U2tpYS5oIgogCkBAIC0yNTcsMTYgKzI1OSwyMCBAQCB2b2lkIFBsYXRmb3JtU3VwcG9ydDo6Z2V0 Rm9udEZhbWlseUZvckNoYXJhY3RlcnMoY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMsIHNpemVfdAog CiB2b2lkIFBsYXRmb3JtU3VwcG9ydDo6Z2V0UmVuZGVyU3R5bGVGb3JTdHJpa2UoY29uc3QgY2hh ciogZm9udCwgaW50IHNpemVBbmRTdHlsZSwgRm9udFJlbmRlclN0eWxlKiByZXN1bHQpCiB7Ci0j aWYgIU9TKEFORFJPSUQpCiAgICAgV2ViRm9udFJlbmRlclN0eWxlIHN0eWxlOwogCi0gICAgaWYg KFdlYktpdDo6UGxhdGZvcm06OmN1cnJlbnQoKS0+c2FuZGJveFN1cHBvcnQoKSkKKyNpZiBPUyhB TkRST0lEKQorICAgIHN0eWxlLnNldERlZmF1bHRzKCk7CisjZWxzZQorICAgIGlmICghZm9udCB8 fCAhKmZvbnQpCisgICAgICAgIHN0eWxlLnNldERlZmF1bHRzKCk7IC8vIEl0J3MgcHJvYmFibHkg YSB3ZWJmb250LiBUYWtlIHRoZSBzeXN0ZW0gZGVmYXVsdHMuCisgICAgZWxzZSBpZiAoV2ViS2l0 OjpQbGF0Zm9ybTo6Y3VycmVudCgpLT5zYW5kYm94U3VwcG9ydCgpKQogICAgICAgICBXZWJLaXQ6 OlBsYXRmb3JtOjpjdXJyZW50KCktPnNhbmRib3hTdXBwb3J0KCktPmdldFJlbmRlclN0eWxlRm9y U3RyaWtlKGZvbnQsIHNpemVBbmRTdHlsZSwgJnN0eWxlKTsKICAgICBlbHNlCiAgICAgICAgIFdl YkZvbnRJbmZvOjpyZW5kZXJTdHlsZUZvclN0cmlrZShmb250LCBzaXplQW5kU3R5bGUsICZzdHls ZSk7CisjZW5kaWYKIAogICAgIHN0eWxlLnRvRm9udFJlbmRlclN0eWxlKHJlc3VsdCk7Ci0jZW5k aWYKIH0KICNlbmRpZgogCg==