90817 2012-07-09 13:34:15 -0700 [BlackBerry] PagePopupBlackBerry::closePopup() should always clear the pointer in WebPagePrivate 2012-07-09 16:05:41 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yong.li.webkit webkit-unassigned haizhang mifenton tonikitoo webkit.review.bot oldest_to_newest 665122 0 yong.li.webkit 2012-07-09 13:34:15 -0700 PagePopupBlackBerry::closePopup() should always clear the pointer in WebPagePrivate to avoid crashes. 665159 1 151316 yong.li.webkit 2012-07-09 14:13:59 -0700 Created attachment 151316 the patch 665163 2 151316 staikos 2012-07-09 14:15:52 -0700 Comment on attachment 151316 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=151316&action=review > Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:147 > + ASSERT(m_element); Which one is it? Can it, or can it not be null? 665169 3 yong.li.webkit 2012-07-09 14:25:19 -0700 (In reply to comment #2) > (From update of attachment 151316 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151316&action=review > > > Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:147 > > + ASSERT(m_element); > > Which one is it? Can it, or can it not be null? It is assigned through ctor, but cleared when the popup is closed. However the JS object is still there. It is theoretically possible the method is called by JS, e.g., window.popPup.setValueAndClosePopup(). Crystal, is that possible? 665183 4 haizhang 2012-07-09 14:31:25 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 151316 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=151316&action=review > > > > > Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:147 > > > + ASSERT(m_element); > > > > Which one is it? Can it, or can it not be null? > > It is assigned through ctor, but cleared when the popup is closed. However the JS object is still there. It is theoretically possible the method is called by JS, e.g., window.popPup.setValueAndClosePopup(). > > Crystal, is that possible? window.popPup.setValueAndClosePopup() will only be called by popup's JS file, if you want to be safe, we can add guard here, however ASSERT should be removed then, as they are conflicting each other. 665189 5 151322 yong.li.webkit 2012-07-09 14:37:43 -0700 Created attachment 151322 again 665194 6 151322 rwlbuis 2012-07-09 14:43:58 -0700 Comment on attachment 151322 again Looks good. 665268 7 151322 webkit.review.bot 2012-07-09 16:05:37 -0700 Comment on attachment 151322 again Clearing flags on attachment: 151322 Committed r122162: <http://trac.webkit.org/changeset/122162> 665269 8 webkit.review.bot 2012-07-09 16:05:41 -0700 All reviewed patches have been landed. Closing bug. 151316 2012-07-09 14:13:59 -0700 2012-07-09 14:37:43 -0700 the patch 90817.patch text/plain 5111 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDRmZTZjYTUuLmM2 OGNjMWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNDA0 LDcgKzQwNCw2IEBAIFdlYlBhZ2VQcml2YXRlOjpXZWJQYWdlUHJpdmF0ZShXZWJQYWdlKiB3ZWJQ YWdlLCBXZWJQYWdlQ2xpZW50KiBjbGllbnQsIGNvbnN0IEluCiAgICAgLCBtX3VwZGF0ZURlbGVn YXRlZE92ZXJsYXlzRGlzcGF0Y2hlZChmYWxzZSkKICAgICAsIG1fZGVmZXJyZWRUYXNrc1RpbWVy KHRoaXMsICZXZWJQYWdlUHJpdmF0ZTo6ZGVmZXJyZWRUYXNrc1RpbWVyRmlyZWQpCiAgICAgLCBt X3NlbGVjdFBvcHVwKDApCi0gICAgLCBtX3BhcmVudFBvcHVwKDApCiAgICAgLCBtX2F1dG9maWxs TWFuYWdlcihBdXRvZmlsbE1hbmFnZXI6OmNyZWF0ZSh0aGlzKSkKIHsKICAgICBzdGF0aWMgYm9v bCBpc0luaXRpYWxpemVkID0gZmFsc2U7CkBAIC02NjY2LDExICs2NjY1LDYgQEAgUGFnZVBvcHVw QmxhY2tCZXJyeSogV2ViUGFnZTo6cG9wdXAoKQogICAgIHJldHVybiBkLT5tX3NlbGVjdFBvcHVw OwogfQogCi12b2lkIFdlYlBhZ2VQcml2YXRlOjpzZXRQYXJlbnRQb3B1cChQYWdlUG9wdXBCbGFj a0JlcnJ5KiB3ZWJQb3B1cCkKLXsKLSAgICBtX3BhcmVudFBvcHVwID0gd2ViUG9wdXA7Ci19Ci0K IHZvaWQgV2ViUGFnZVByaXZhdGU6OnNldEluc3BlY3Rvck92ZXJsYXlDbGllbnQoV2ViQ29yZTo6 SW5zcGVjdG9yT3ZlcmxheTo6SW5zcGVjdG9yT3ZlcmxheUNsaWVudCogaW5zcGVjdG9yT3Zlcmxh eUNsaWVudCkKIHsKICAgICBpZiAoaW5zcGVjdG9yT3ZlcmxheUNsaWVudCkgewpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlX3AuaCBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZV9wLmgKaW5kZXggODNlNGE4Yy4uYTBmZmNlMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlX3AuaAorKysgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VfcC5oCkBAIC02MjIsOCArNjIyLDYg QEAgcHVibGljOgogCiAgICAgLy8gVGhlIHBvcHVwIHRoYXQgb3BlbmVkIGluIHRoaXMgd2VicGFn ZQogICAgIFdlYkNvcmU6OlBhZ2VQb3B1cEJsYWNrQmVycnkqIG1fc2VsZWN0UG9wdXA7Ci0gICAg Ly8gVGhlIHBvcHVwIHRoYXQgb3duZWQgdGhpcyB3ZWJwYWdlCi0gICAgV2ViQ29yZTo6UGFnZVBv cHVwQmxhY2tCZXJyeSogbV9wYXJlbnRQb3B1cDsKIAogICAgIFJlZlB0cjxXZWJDb3JlOjpBdXRv ZmlsbE1hbmFnZXI+IG1fYXV0b2ZpbGxNYW5hZ2VyOwogcHJvdGVjdGVkOgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9DaGFuZ2VMb2cKaW5kZXggZjE1NGU3ZS4uYjBjMmExZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTItMDctMDkgIFlvbmcgTGkgIDx5b2xp QHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFBhZ2VQb3B1cEJsYWNrQmVycnk6OmNs b3NlUG9wdXAoKSBzaG91bGQgYWx3YXlzIGNsZWFyIHRoZSBwb2ludGVyIGluIFdlYlBhZ2VQcml2 YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDgx NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBSIyAx NzQwODUuCisgICAgICAgIFBhZ2VQb3B1cEJsYWNrQmVycnk6OmNsb3NlUG9wdXAoKSBzaG91bGQg YWx3YXlzIGNsZWFyIHRoZSBwb2ludGVyIGluIFdlYlBhZ2VQcml2YXRlIHRvIGF2b2lkIGNyYXNo ZXMuCisgICAgICAgIFRoaXMgcGF0Y2ggYWxzbyByZW1vdmVzIHVudXNlZCB2YXJpYWJsZSBtX3Bh cmVudFBvcHVwIGFuZCBpdHMgc2V0dGVyLgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgor ICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6V2ViUGFnZVByaXZh dGUpOiBSZW1vdmUgbV9wYXJlbnRQb3B1cC4KKyAgICAgICAgKiBBcGkvV2ViUGFnZV9wLmg6Cisg ICAgICAgIChXZWJQYWdlUHJpdmF0ZSk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQ2hyb21l Q2xpZW50QmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWVDbGllbnRCbGFj a0JlcnJ5OjpjbG9zZVBhZ2VQb3B1cCk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvUGFnZVBv cHVwQmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdlUG9wdXBCbGFja0JlcnJ5 Ojppbml0KTogUmVtb3ZlIHRoZSBzZXRQYXJlbnRQb3B1cCgpIGNhbGwuCisgICAgICAgIChXZWJD b3JlOjpQYWdlUG9wdXBCbGFja0JlcnJ5OjpjbG9zZVBvcHVwKTogQ2xlYXIgdGhlIHJlZmVyZW5j ZSBpbiBXZWJQYWdlUHJpdmF0ZS4KKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9TZWxlY3RQb3B1 cENsaWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RQb3B1cENsaWVudDo6c2V0VmFs dWVBbmRDbG9zZVBvcHVwKTogQWRkIGFuIGFzc2VydCBhbmQgcnVudGltZSBzYW5pdHkgY2hlY2sg anVzdCBpbiBjYXNlLgorCiAyMDEyLTA3LTA5ICBNaWtlIExhdHRhbnppbyAgPG1sYXR0YW56aW9A cmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gbWV0YSB2aWV3cG9ydCBpbml0aWFsLXNj YWxlIGRvZXNuJ3QgZmFjdG9yIGluIGRldmljZSBwaXhlbCByYXRpbwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVy cnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNs aWVudEJsYWNrQmVycnkuY3BwCmluZGV4IDRmZDhiZjQuLjI5ZGU4MDAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0Jl cnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hy b21lQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTMxNiwxMSArMzE2LDExIEBAIFBhZ2VQb3B1cCog Q2hyb21lQ2xpZW50QmxhY2tCZXJyeTo6b3BlblBhZ2VQb3B1cChQYWdlUG9wdXBDbGllbnQqIGNs aWVudCwgY29uc3QKIAogdm9pZCBDaHJvbWVDbGllbnRCbGFja0JlcnJ5OjpjbG9zZVBhZ2VQb3B1 cChQYWdlUG9wdXAqKQogewotICAgIGlmIChoYXNPcGVuZWRQb3B1cCgpKSB7Ci0gICAgICAgIFBh Z2VQb3B1cEJsYWNrQmVycnkqIHdlYlBvcHVwID0gbV93ZWJQYWdlUHJpdmF0ZS0+bV93ZWJQYWdl LT5wb3B1cCgpOwotICAgICAgICB3ZWJQb3B1cC0+Y2xvc2VQb3B1cCgpOwotICAgICAgICBtX3dl YlBhZ2VQcml2YXRlLT5tX3dlYlBhZ2UtPnBvcHVwQ2xvc2VkKCk7Ci0gICAgfQorICAgIGlmICgh aGFzT3BlbmVkUG9wdXAoKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgUGFnZVBvcHVwQmxhY2tC ZXJyeSogd2ViUG9wdXAgPSBtX3dlYlBhZ2VQcml2YXRlLT5tX3dlYlBhZ2UtPnBvcHVwKCk7Cisg ICAgd2ViUG9wdXAtPmNsb3NlUG9wdXAoKTsKIH0KIAogdm9pZCBDaHJvbWVDbGllbnRCbGFja0Jl cnJ5OjpzZXRUb29sYmFyc1Zpc2libGUoYm9vbCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9QYWdlUG9wdXBCbGFja0JlcnJ5LmNwcCBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9QYWdlUG9wdXBCbGFja0JlcnJ5LmNw cAppbmRleCAzNTRmMTI4Li41MTQxYTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViQ29yZVN1cHBvcnQvUGFnZVBvcHVwQmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1BhZ2VQb3B1cEJsYWNrQmVycnkuY3Bw CkBAIC02OCw4ICs2OCw2IEBAIGJvb2wgUGFnZVBvcHVwQmxhY2tCZXJyeTo6aW5pdChXZWJQYWdl KiB3ZWJwYWdlKQogCiAgICAgaW5zdGFsbERvbUZ1bmN0aW9uKHdlYnBhZ2UtPmQtPm1haW5GcmFt ZSgpKTsKIAotICAgIHdlYnBhZ2UtPmQtPnNldFBhcmVudFBvcHVwKHRoaXMpOwotCiAgICAgcmV0 dXJuIHRydWU7CiB9CiAKQEAgLTE2Miw2ICsxNjAsNyBAQCB2b2lkIFBhZ2VQb3B1cEJsYWNrQmVy cnk6OmNsb3NlUG9wdXAoKQogewogICAgIG1fY2xpZW50LT5kaWRDbG9zZVBvcHVwKCk7CiAgICAg bV93ZWJQYWdlUHJpdmF0ZS0+Y2xpZW50KCktPmNsb3NlUG9wdXBXZWJWaWV3KCk7CisgICAgbV93 ZWJQYWdlUHJpdmF0ZS0+bV93ZWJQYWdlLT5wb3B1cENsb3NlZCgpOwogfQogCiB9CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvU2VsZWN0UG9wdXBD bGllbnQuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1NlbGVj dFBvcHVwQ2xpZW50LmNwcAppbmRleCAzNjA3NjY0Li5lOWUyMDAyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvU2VsZWN0UG9wdXBDbGllbnQuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9TZWxlY3RQb3B1 cENsaWVudC5jcHAKQEAgLTE0NCw2ICsxNDQsOSBAQCBTdHJpbmcgU2VsZWN0UG9wdXBDbGllbnQ6 Omh0bWxTb3VyY2UoKQogCiB2b2lkIFNlbGVjdFBvcHVwQ2xpZW50OjpzZXRWYWx1ZUFuZENsb3Nl UG9wdXAoaW50LCBjb25zdCBTdHJpbmcmIHN0cmluZ1ZhbHVlKQogeworICAgIEFTU0VSVChtX2Vs ZW1lbnQpOworICAgIGlmICghbV9lbGVtZW50KQorICAgICAgICByZXR1cm47CiAKICAgICBBU1NF UlQobV9zaXplID09IHN0cmluZ1ZhbHVlLmxlbmd0aCgpKTsKIAo= 151322 2012-07-09 14:37:43 -0700 2012-07-09 16:05:37 -0700 again 90817.patch text/plain 5078 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDRmZTZjYTUuLmM2 OGNjMWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNDA0 LDcgKzQwNCw2IEBAIFdlYlBhZ2VQcml2YXRlOjpXZWJQYWdlUHJpdmF0ZShXZWJQYWdlKiB3ZWJQ YWdlLCBXZWJQYWdlQ2xpZW50KiBjbGllbnQsIGNvbnN0IEluCiAgICAgLCBtX3VwZGF0ZURlbGVn YXRlZE92ZXJsYXlzRGlzcGF0Y2hlZChmYWxzZSkKICAgICAsIG1fZGVmZXJyZWRUYXNrc1RpbWVy KHRoaXMsICZXZWJQYWdlUHJpdmF0ZTo6ZGVmZXJyZWRUYXNrc1RpbWVyRmlyZWQpCiAgICAgLCBt X3NlbGVjdFBvcHVwKDApCi0gICAgLCBtX3BhcmVudFBvcHVwKDApCiAgICAgLCBtX2F1dG9maWxs TWFuYWdlcihBdXRvZmlsbE1hbmFnZXI6OmNyZWF0ZSh0aGlzKSkKIHsKICAgICBzdGF0aWMgYm9v bCBpc0luaXRpYWxpemVkID0gZmFsc2U7CkBAIC02NjY2LDExICs2NjY1LDYgQEAgUGFnZVBvcHVw QmxhY2tCZXJyeSogV2ViUGFnZTo6cG9wdXAoKQogICAgIHJldHVybiBkLT5tX3NlbGVjdFBvcHVw OwogfQogCi12b2lkIFdlYlBhZ2VQcml2YXRlOjpzZXRQYXJlbnRQb3B1cChQYWdlUG9wdXBCbGFj a0JlcnJ5KiB3ZWJQb3B1cCkKLXsKLSAgICBtX3BhcmVudFBvcHVwID0gd2ViUG9wdXA7Ci19Ci0K IHZvaWQgV2ViUGFnZVByaXZhdGU6OnNldEluc3BlY3Rvck92ZXJsYXlDbGllbnQoV2ViQ29yZTo6 SW5zcGVjdG9yT3ZlcmxheTo6SW5zcGVjdG9yT3ZlcmxheUNsaWVudCogaW5zcGVjdG9yT3Zlcmxh eUNsaWVudCkKIHsKICAgICBpZiAoaW5zcGVjdG9yT3ZlcmxheUNsaWVudCkgewpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlX3AuaCBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZV9wLmgKaW5kZXggODNlNGE4Yy4uYTBmZmNlMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlX3AuaAorKysgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VfcC5oCkBAIC02MjIsOCArNjIyLDYg QEAgcHVibGljOgogCiAgICAgLy8gVGhlIHBvcHVwIHRoYXQgb3BlbmVkIGluIHRoaXMgd2VicGFn ZQogICAgIFdlYkNvcmU6OlBhZ2VQb3B1cEJsYWNrQmVycnkqIG1fc2VsZWN0UG9wdXA7Ci0gICAg Ly8gVGhlIHBvcHVwIHRoYXQgb3duZWQgdGhpcyB3ZWJwYWdlCi0gICAgV2ViQ29yZTo6UGFnZVBv cHVwQmxhY2tCZXJyeSogbV9wYXJlbnRQb3B1cDsKIAogICAgIFJlZlB0cjxXZWJDb3JlOjpBdXRv ZmlsbE1hbmFnZXI+IG1fYXV0b2ZpbGxNYW5hZ2VyOwogcHJvdGVjdGVkOgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9DaGFuZ2VMb2cKaW5kZXggZjE1NGU3ZS4uNGI1NDg2YSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTItMDctMDkgIFlvbmcgTGkgIDx5b2xp QHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFBhZ2VQb3B1cEJsYWNrQmVycnk6OmNs b3NlUG9wdXAoKSBzaG91bGQgYWx3YXlzIGNsZWFyIHRoZSBwb2ludGVyIGluIFdlYlBhZ2VQcml2 YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDgx NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBSIyAx NzQwODUuCisgICAgICAgIFBhZ2VQb3B1cEJsYWNrQmVycnk6OmNsb3NlUG9wdXAoKSBzaG91bGQg YWx3YXlzIGNsZWFyIHRoZSBwb2ludGVyIGluIFdlYlBhZ2VQcml2YXRlIHRvIGF2b2lkIGNyYXNo ZXMuCisgICAgICAgIFRoaXMgcGF0Y2ggYWxzbyByZW1vdmVzIHVudXNlZCB2YXJpYWJsZSBtX3Bh cmVudFBvcHVwIGFuZCBpdHMgc2V0dGVyLgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgor ICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6V2ViUGFnZVByaXZh dGUpOiBSZW1vdmUgbV9wYXJlbnRQb3B1cC4KKyAgICAgICAgKiBBcGkvV2ViUGFnZV9wLmg6Cisg ICAgICAgIChXZWJQYWdlUHJpdmF0ZSk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQ2hyb21l Q2xpZW50QmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWVDbGllbnRCbGFj a0JlcnJ5OjpjbG9zZVBhZ2VQb3B1cCk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvUGFnZVBv cHVwQmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdlUG9wdXBCbGFja0JlcnJ5 Ojppbml0KTogUmVtb3ZlIHRoZSBzZXRQYXJlbnRQb3B1cCgpIGNhbGwuCisgICAgICAgIChXZWJD b3JlOjpQYWdlUG9wdXBCbGFja0JlcnJ5OjpjbG9zZVBvcHVwKTogQ2xlYXIgdGhlIHJlZmVyZW5j ZSBpbiBXZWJQYWdlUHJpdmF0ZS4KKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9TZWxlY3RQb3B1 cENsaWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RQb3B1cENsaWVudDo6c2V0VmFs dWVBbmRDbG9zZVBvcHVwKTogQWRkIGFuIGFzc2VydCBmb3IgdmFsaWQgbV9lbGVtZW50LgorCiAy MDEyLTA3LTA5ICBNaWtlIExhdHRhbnppbyAgPG1sYXR0YW56aW9AcmltLmNvbT4KIAogICAgICAg ICBbQmxhY2tCZXJyeV0gbWV0YSB2aWV3cG9ydCBpbml0aWFsLXNjYWxlIGRvZXNuJ3QgZmFjdG9y IGluIGRldmljZSBwaXhlbCByYXRpbwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVycnkuY3Bw CmluZGV4IDRmZDhiZjQuLjI5ZGU4MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tCZXJy eS5jcHAKQEAgLTMxNiwxMSArMzE2LDExIEBAIFBhZ2VQb3B1cCogQ2hyb21lQ2xpZW50QmxhY2tC ZXJyeTo6b3BlblBhZ2VQb3B1cChQYWdlUG9wdXBDbGllbnQqIGNsaWVudCwgY29uc3QKIAogdm9p ZCBDaHJvbWVDbGllbnRCbGFja0JlcnJ5OjpjbG9zZVBhZ2VQb3B1cChQYWdlUG9wdXAqKQogewot ICAgIGlmIChoYXNPcGVuZWRQb3B1cCgpKSB7Ci0gICAgICAgIFBhZ2VQb3B1cEJsYWNrQmVycnkq IHdlYlBvcHVwID0gbV93ZWJQYWdlUHJpdmF0ZS0+bV93ZWJQYWdlLT5wb3B1cCgpOwotICAgICAg ICB3ZWJQb3B1cC0+Y2xvc2VQb3B1cCgpOwotICAgICAgICBtX3dlYlBhZ2VQcml2YXRlLT5tX3dl YlBhZ2UtPnBvcHVwQ2xvc2VkKCk7Ci0gICAgfQorICAgIGlmICghaGFzT3BlbmVkUG9wdXAoKSkK KyAgICAgICAgcmV0dXJuOworCisgICAgUGFnZVBvcHVwQmxhY2tCZXJyeSogd2ViUG9wdXAgPSBt X3dlYlBhZ2VQcml2YXRlLT5tX3dlYlBhZ2UtPnBvcHVwKCk7CisgICAgd2ViUG9wdXAtPmNsb3Nl UG9wdXAoKTsKIH0KIAogdm9pZCBDaHJvbWVDbGllbnRCbGFja0JlcnJ5OjpzZXRUb29sYmFyc1Zp c2libGUoYm9vbCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3Jl U3VwcG9ydC9QYWdlUG9wdXBCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJDb3JlU3VwcG9ydC9QYWdlUG9wdXBCbGFja0JlcnJ5LmNwcAppbmRleCAzNTRmMTI4Li41 MTQxYTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBv cnQvUGFnZVBvcHVwQmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L1dlYkNvcmVTdXBwb3J0L1BhZ2VQb3B1cEJsYWNrQmVycnkuY3BwCkBAIC02OCw4ICs2OCw2IEBA IGJvb2wgUGFnZVBvcHVwQmxhY2tCZXJyeTo6aW5pdChXZWJQYWdlKiB3ZWJwYWdlKQogCiAgICAg aW5zdGFsbERvbUZ1bmN0aW9uKHdlYnBhZ2UtPmQtPm1haW5GcmFtZSgpKTsKIAotICAgIHdlYnBh Z2UtPmQtPnNldFBhcmVudFBvcHVwKHRoaXMpOwotCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKQEAg LTE2Miw2ICsxNjAsNyBAQCB2b2lkIFBhZ2VQb3B1cEJsYWNrQmVycnk6OmNsb3NlUG9wdXAoKQog ewogICAgIG1fY2xpZW50LT5kaWRDbG9zZVBvcHVwKCk7CiAgICAgbV93ZWJQYWdlUHJpdmF0ZS0+ Y2xpZW50KCktPmNsb3NlUG9wdXBXZWJWaWV3KCk7CisgICAgbV93ZWJQYWdlUHJpdmF0ZS0+bV93 ZWJQYWdlLT5wb3B1cENsb3NlZCgpOwogfQogCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvU2VsZWN0UG9wdXBDbGllbnQuY3BwIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1NlbGVjdFBvcHVwQ2xpZW50LmNwcApp bmRleCAzNjA3NjY0Li4wMDA1OGVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViQ29yZVN1cHBvcnQvU2VsZWN0UG9wdXBDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9TZWxlY3RQb3B1cENsaWVudC5jcHAKQEAgLTE0 NCw3ICsxNDQsNyBAQCBTdHJpbmcgU2VsZWN0UG9wdXBDbGllbnQ6Omh0bWxTb3VyY2UoKQogCiB2 b2lkIFNlbGVjdFBvcHVwQ2xpZW50OjpzZXRWYWx1ZUFuZENsb3NlUG9wdXAoaW50LCBjb25zdCBT dHJpbmcmIHN0cmluZ1ZhbHVlKQogewotCisgICAgQVNTRVJUKG1fZWxlbWVudCk7CiAgICAgQVNT RVJUKG1fc2l6ZSA9PSBzdHJpbmdWYWx1ZS5sZW5ndGgoKSk7CiAKICAgICBpZiAobV9zaXplID4g MCkgewo=