90785 2012-07-09 06:26:31 -0700 [EFL][UT] Delete shutdown method. 2012-08-12 04:26:24 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 0 k.czech webkit-unassigned g.czajkowski gyuyoung.kim lucas.de.marchi rakuco sw0524.lee tmpsantos webkit.review.bot oldest_to_newest 664843 0 k.czech 2012-07-09 06:26:31 -0700 Delete shutdown method from EWKTestBase class. 664845 1 151245 k.czech 2012-07-09 06:30:27 -0700 Created attachment 151245 shutdown method is not needed. 666668 2 tmpsantos 2012-07-11 04:51:38 -0700 LGTM. 666781 3 151245 gyuyoung.kim 2012-07-11 08:53:32 -0700 Comment on attachment 151245 shutdown method is not needed. Looks fine. BTW, in my humble opinion, isn't it better to use shutdown() instead of shutdownAll() in order to be in sync with init() ? 667472 4 k.czech 2012-07-12 00:48:42 -0700 (In reply to comment #3) > (From update of attachment 151245 [details]) > Looks fine. BTW, in my humble opinion, isn't it better to use shutdown() instead of shutdownAll() in order to be in sync with init() ? I will take a look at it, thanks 668127 5 rakuco 2012-07-12 13:05:55 -0700 I disagree with this approach for the same reason I mentioned in <https://bugs.webkit.org/show_bug.cgi?id=90606#c7>: you shouldn't need to loop to call the shutdown() functions; if you called _init() once, you should need to call _shutdown() only once. If it doesn't return 0, there's some unbalanced call somewhere. 693216 6 151245 eric 2012-08-12 03:39:06 -0700 Comment on attachment 151245 shutdown method is not needed. rs=me. 693236 7 151245 webkit.review.bot 2012-08-12 04:26:19 -0700 Comment on attachment 151245 shutdown method is not needed. Clearing flags on attachment: 151245 Committed r125369: <http://trac.webkit.org/changeset/125369> 693237 8 webkit.review.bot 2012-08-12 04:26:24 -0700 All reviewed patches have been landed. Closing bug. 151245 2012-07-09 06:30:27 -0700 2012-08-12 04:26:19 -0700 shutdown method is not needed. ut-delete-shutdown.patch text/plain 1882 k.czech ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBiOGM5Y2EwLi5hN2E3ZWY2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTggQEAKIDIwMTItMDctMDkgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ft c3VuZy5jb20+CiAKKyAgICAgICAgW0VGTF1bVVRdIERlbGV0ZSBzaHV0ZG93biBtZXRob2QuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDc4NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVXS1Rlc3RCYXNl IGNsYXNzIGFscmVhZHkgaGFzIGEgc2h1dGRvd25BbGwgbWV0aG9kIHRoYXQgY2FuIGJlIHVzZWQg aW5zdGVhZCBvZiBzaHV0ZG93bi4KKworICAgICAgICAqIHRlc3RzL1VuaXRUZXN0VXRpbHMvRVdL VGVzdEJhc2UuY3BwOgorICAgICAgICAqIHRlc3RzL1VuaXRUZXN0VXRpbHMvRVdLVGVzdEJhc2Uu aDoKKyAgICAgICAgKEVXS1Rlc3RCYXNlKToKKworMjAxMi0wNy0wOSAgS3J6eXN6dG9mIEN6ZWNo ICA8ay5jemVjaEBzYW1zdW5nLmNvbT4KKwogICAgICAgICBbRUZMXSBTaW1wbGlmeSBydW5UZXN0 IGZ1bmN0aW9uIGJ5IGRlZmluaW5nIGRlZmF1bHQgYXJndW1lbnRzLgogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA1MjUKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0tUZXN0QmFzZS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXS1Rlc3RCYXNlLmNwcAppbmRleCA2 MDgzMDBhLi4yZDNlMmFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC90ZXN0cy9Vbml0 VGVzdFV0aWxzL0VXS1Rlc3RCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC90ZXN0cy9V bml0VGVzdFV0aWxzL0VXS1Rlc3RCYXNlLmNwcApAQCAtNDksMTMgKzQ5LDYgQEAgYm9vbCBFV0tU ZXN0QmFzZTo6aW5pdCgpCiAgICAgcmV0dXJuIHJldDsKIH0KIAotdm9pZCBFV0tUZXN0QmFzZTo6 c2h1dGRvd24oKQotewotICAgIGVjb3JlX2V2YXNfc2h1dGRvd24oKTsKLSAgICBlZGplX3NodXRk b3duKCk7Ci0gICAgZXdrX3NodXRkb3duKCk7Ci19Ci0KIHZvaWQgRVdLVGVzdEJhc2U6OnNodXRk b3duQWxsKCkKIHsKICAgICBpbnQgY291bnQgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0tUZXN0QmFzZS5oIGIvU291cmNlL1dlYktpdC9l ZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0tUZXN0QmFzZS5oCmluZGV4IGZjMWQyNzEuLmVjNzUx MzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdL VGVzdEJhc2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VX S1Rlc3RCYXNlLmgKQEAgLTU0LDcgKzU0LDYgQEAgY2xhc3MgRVdLVGVzdEJhc2UgewogICAgIHN0 YXRpYyBib29sIGNyZWF0ZVRlc3QoY29uc3QgY2hhciogdXJsLCB2b2lkICgqZXZlbnRfY2FsbGJh Y2spKHZvaWQqLCBFdmFzX09iamVjdCosIHZvaWQqKSwgY29uc3QgY2hhciogZXZlbnRfbmFtZSwg dm9pZCogZXZlbnRfZGF0YSk7CiBwdWJsaWM6CiAgICAgc3RhdGljIGJvb2wgaW5pdCgpOwotICAg IHN0YXRpYyB2b2lkIHNodXRkb3duKCk7CiAgICAgc3RhdGljIHZvaWQgc2h1dGRvd25BbGwoKTsK ICAgICBzdGF0aWMgdm9pZCBzdGFydFRlc3QoKTsKICAgICBzdGF0aWMgdm9pZCBlbmRUZXN0KCk7 Cg==