90769 2012-07-09 03:34:05 -0700 [SOUP] Use soup_cookie_jar_is_persistent() to set whether cookie is a session one or not 2012-07-09 05:28:32 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Soup P2 Normal --- 1 cgarcia webkit-unassigned danw gustavo mrobinson rakuco webkit.review.bot xan.lopez oldest_to_newest 664772 0 cgarcia 2012-07-09 03:34:05 -0700 It's currently set to false, because there were no API to know whether cookies were persistent or not. Now that we bumped libsoup requirements, we can use soup_cookie_jar_is_persistent(). 664773 1 151224 cgarcia 2012-07-09 03:36:28 -0700 Created attachment 151224 Patch 664816 2 cgarcia 2012-07-09 05:28:32 -0700 Committed r122103: <http://trac.webkit.org/changeset/122103> 151224 2012-07-09 03:36:28 -0700 2012-07-09 04:28:50 -0700 Patch soup-cookies-is-persistent.diff text/plain 2082 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMWYwNTA2Li4wYWFmY2JjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDctMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtTT1VQXSBVc2Ugc291cF9jb29raWVfamFyX2lzX3BlcnNpc3RlbnQoKSB0 byBzZXQgd2hldGhlciBjb29raWUgaXMgYSBzZXNzaW9uIG9uZSBvciBub3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwNzY5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQncyBjdXJyZW50bHkgc2V0IHRv IGZhbHNlLCBiZWNhdXNlIHRoZXJlIHdlcmUgbm8gQVBJIHRvIGtub3cKKyAgICAgICAgd2hldGhl ciBjb29raWVzIHdlcmUgcGVyc2lzdGVudCBvciBub3QuIE5vdyB0aGF0IHdlIGJ1bXBlZCBsaWJz b3VwCisgICAgICAgIHJlcXVpcmVtZW50cywgd2UgY2FuIHVzZSBzb3VwX2Nvb2tpZV9qYXJfaXNf cGVyc2lzdGVudCgpLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL0Nvb2tpZUph clNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2V0UmF3Q29va2llcyk6CisKIDIwMTItMDct MDggIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAgICAg IEludHJvZHVjZSBhIGJ1aWxkIGZsYWcgZm9yIGxvdyBxdWFsaXR5IEpQRUcgaW1hZ2VzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291 cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291 cC5jcHAKaW5kZXggYzZlOWJjZS4uY2VhMTE1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9zb3VwL0Nvb2tpZUphclNvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmNwcApAQCAtMTYyLDExICsx NjIsOSBAQCBib29sIGdldFJhd0Nvb2tpZXMoY29uc3QgRG9jdW1lbnQqIGRvY3VtZW50LCBjb25z dCBLVVJMJiB1cmwsIFZlY3RvcjxDb29raWU+JiByYQogICAgICAgICBHT3duUHRyPFNvdXBDb29r aWU+IGNvb2tpZShzdGF0aWNfY2FzdDxTb3VwQ29va2llKj4oaXRlci0+ZGF0YSkpOwogICAgICAg ICBpZiAoIXNvdXBfY29va2llX2FwcGxpZXNfdG9fdXJpKGNvb2tpZS5nZXQoKSwgdXJpLmdldCgp KSkKICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICAvLyBGSVhNRTogd2UgYXJlIGN1cnJl bnRseSBwYXNzaW5nIGZhbHNlIGFsd2F5cyBmb3Igc2Vzc2lvbiBiZWNhdXNlIHRoZXJlJ3Mgbm8g QVBJIHRvIGtub3cKLSAgICAgICAgLy8gd2hldGhlciBTb3VwQ29va2llSmFyIGlzIHBlcnNpc3Rl bnQgb3Igbm90LiBXZSBjb3VsZCBwcm9iYWJseSBhZGQgc291cF9jb29raWVfamFyX2lzX3BlcnNp c3RlbnQoKS4KICAgICAgICAgcmF3Q29va2llcy5hcHBlbmQoQ29va2llKFN0cmluZzo6ZnJvbVVU RjgoY29va2llLT5uYW1lKSwgU3RyaW5nOjpmcm9tVVRGOChjb29raWUtPnZhbHVlKSwgU3RyaW5n Ojpmcm9tVVRGOChjb29raWUtPmRvbWFpbiksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBTdHJpbmc6OmZyb21VVEY4KGNvb2tpZS0+cGF0aCksIHN0YXRpY19jYXN0PGRvdWJsZT4o c291cF9kYXRlX3RvX3RpbWVfdChjb29raWUtPmV4cGlyZXMpKSAqIDEwMDAsCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBjb29raWUtPmh0dHBfb25seSwgY29va2llLT5zZWN1cmUs IGZhbHNlKSk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb29raWUtPmh0dHBf b25seSwgY29va2llLT5zZWN1cmUsIHNvdXBfY29va2llX2phcl9pc19wZXJzaXN0ZW50KGphcikp KTsKICAgICB9CiAKICAgICByZXR1cm4gdHJ1ZTsK