90767 2012-07-09 03:03:43 -0700 [GTK] Inspector should set a default attached height before being attached 2012-08-02 10:44:52 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson webkit.review.bot xan.lopez oldest_to_newest 664758 0 cgarcia 2012-07-09 03:03:43 -0700 We are currently using the minimum attached height in WebKitWebViewBase as the default height for the inspector when attached. It would be easier for WebKitWebViewBase and embedders implementing attach() if the inspector already had an attached height set when it's being attached. 664762 1 151221 cgarcia 2012-07-09 03:08:12 -0700 Created attachment 151221 Patch 664763 2 webkit.review.bot 2012-07-09 03:10:44 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 685344 3 151221 xan.lopez 2012-08-02 07:13:09 -0700 Comment on attachment 151221 Patch This looks reasonable to me, but I'm not an expert in this area of the code. Maybe martin wants to have a second look. 685350 4 151221 mrobinson 2012-08-02 07:18:45 -0700 Comment on attachment 151221 Patch This looks sane to me. 685566 5 cgarcia 2012-08-02 10:44:52 -0700 Committed r124479: <http://trac.webkit.org/changeset/124479> 151221 2012-07-09 03:08:12 -0700 2012-08-02 07:18:45 -0700 Patch wk2-inspector-attached-height.diff text/plain 6036 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwOGUwZmU5Li5hODZiNGExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkg QEAKKzIwMTItMDctMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEluc3BlY3RvciBzaG91bGQgc2V0IGEgZGVmYXVsdCBhdHRhY2hl ZCBoZWlnaHQgYmVmb3JlIGJlaW5nIGF0dGFjaGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDc2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlIGFyZSBjdXJyZW50bHkgdXNpbmcgdGhlIG1pbmltdW0g YXR0YWNoZWQgaGVpZ2h0IGluCisgICAgICAgIFdlYktpdFdlYlZpZXdCYXNlIGFzIHRoZSBkZWZh dWx0IGhlaWdodCBmb3IgdGhlIGluc3BlY3RvciB3aGVuCisgICAgICAgIGF0dGFjaGVkLiBJdCB3 b3VsZCBiZSBlYXNpZXIgZm9yIFdlYktpdFdlYlZpZXdCYXNlIGFuZCBlbWJlZGRlcnMKKyAgICAg ICAgaW1wbGVtZW50aW5nIGF0dGFjaCgpIGlmIHRoZSBpbnNwZWN0b3IgYWxyZWFkeSBoYWQgYW4g YXR0YWNoZWQKKyAgICAgICAgaGVpZ2h0IHNldCB3aGVuIGl0J3MgYmVpbmcgYXR0YWNoZWQuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAg ICAgICh3ZWJraXRXZWJWaWV3QmFzZUNvbnRhaW5lckFkZCk6IERvbid0IGluaXRpYWxpemUKKyAg ICAgICAgaW5zcGVjdG9yVmlld0hlaWdodC4KKyAgICAgICAgKHdlYmtpdFdlYlZpZXdCYXNlU2V0 SW5zcGVjdG9yVmlld0hlaWdodCk6IEFsbG93IHRvIHNldCB0aGUKKyAgICAgICAgaW5zcGVjdG9y IHZpZXcgaGVpZ2h0IGJlZm9yZSBoYXZpbmcgYW4gaW5wZWN0b3IgdmlldywgYnV0IG9ubHkKKyAg ICAgICAgcXVldWUgYSByZXNpemUgd2hlbiB0aGUgdmlldyBhbHJlYWR5IGhhcyBhbiBpbnNwZWN0 b3Igdmlldy4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0SW5zcGVjdG9y LmNwcDoKKyAgICAgICAgKHRlc3RJbnNwZWN0b3JEZWZhdWx0KToKKyAgICAgICAgKHRlc3RJbnNw ZWN0b3JNYW51YWxBdHRhY2hEZXRhY2gpOgorICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvV2ViSW5z cGVjdG9yUHJveHlHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6 cGxhdGZvcm1BdHRhY2gpOiBTZXQgdGhlIGRlZmF1bHQKKyAgICAgICAgYXR0YWNoZWQgaGVpZ2h0 IGJlZm9yZSBhdHRhY2ggdGhlIGluc3BlY3RvciB2aWV3LgorCiAyMDEyLTA3LTA2ICBDaHJpc3Rv cGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgW1dLMl0g QWRkIHN1cHBvcnQgZm9yIE5ldHdvcmsgSW5mb3JtYXRpb24gQVBJCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKaW5kZXgg YjdmZmM5OC4uYmYxOTZlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtMTAxLDkgKzEwMSw2IEBAIHN0cnVj dCBfV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlIHsKIAogR19ERUZJTkVfVFlQRShXZWJLaXRXZWJW aWV3QmFzZSwgd2Via2l0X3dlYl92aWV3X2Jhc2UsIEdUS19UWVBFX0NPTlRBSU5FUikKIAotLy8g S2VlcCB0aGlzIGluIHN5bmMgd2l0aCB0aGUgdmFsdWUgbWluaW11bUF0dGFjaGVkSGVpZ2h0IGlu IFdlYkluc3BlY3RvclByb3h5Lgotc3RhdGljIGNvbnN0IHVuc2lnbmVkIGdNaW5pbXVtQXR0YWNo ZWRJbnNwZWN0b3JIZWlnaHQgPSAyNTA7Ci0KIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNl Tm90aWZ5UmVzaXplclNpemVGb3JXaW5kb3coV2ViS2l0V2ViVmlld0Jhc2UqIHdlYlZpZXdCYXNl LCBHdGtXaW5kb3cqIHdpbmRvdykKIHsKICAgICBnYm9vbGVhbiByZXNpemVyVmlzaWJsZTsKQEAg LTE5MCw3ICsxODcsNiBAQCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZUNvbnRhaW5lckFk ZChHdGtDb250YWluZXIqIGNvbnRhaW5lciwgR3RrV2lkZ2V0KiB3aQogICAgICAgICAmJiBXZWJJ bnNwZWN0b3JQcm94eTo6aXNJbnNwZWN0b3JQYWdlKFdFQktJVF9XRUJfVklFV19CQVNFKHdpZGdl dCktPnByaXYtPnBhZ2VQcm94eS5nZXQoKSkpIHsKICAgICAgICAgQVNTRVJUKHByaXYtPmluc3Bl Y3RvclZpZXcpOwogICAgICAgICBwcml2LT5pbnNwZWN0b3JWaWV3ID0gd2lkZ2V0OwotICAgICAg ICBwcml2LT5pbnNwZWN0b3JWaWV3SGVpZ2h0ID0gZ01pbmltdW1BdHRhY2hlZEluc3BlY3Rvckhl aWdodDsKICAgICB9IGVsc2UgewogICAgICAgICBHdGtBbGxvY2F0aW9uIGNoaWxkQWxsb2NhdGlv bjsKICAgICAgICAgZ3RrX3dpZGdldF9nZXRfYWxsb2NhdGlvbih3aWRnZXQsICZjaGlsZEFsbG9j YXRpb24pOwpAQCAtNzczLDEyICs3NjksMTEgQEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZUluaXRp YWxpemVGdWxsU2NyZWVuQ2xpZW50KFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJraXRXZWJWaWUKIAog dm9pZCB3ZWJraXRXZWJWaWV3QmFzZVNldEluc3BlY3RvclZpZXdIZWlnaHQoV2ViS2l0V2ViVmll d0Jhc2UqIHdlYmtpdFdlYlZpZXdCYXNlLCB1bnNpZ25lZCBoZWlnaHQpCiB7Ci0gICAgaWYgKCF3 ZWJraXRXZWJWaWV3QmFzZS0+cHJpdi0+aW5zcGVjdG9yVmlldykKLSAgICAgICAgcmV0dXJuOwog ICAgIGlmICh3ZWJraXRXZWJWaWV3QmFzZS0+cHJpdi0+aW5zcGVjdG9yVmlld0hlaWdodCA9PSBo ZWlnaHQpCiAgICAgICAgIHJldHVybjsKICAgICB3ZWJraXRXZWJWaWV3QmFzZS0+cHJpdi0+aW5z cGVjdG9yVmlld0hlaWdodCA9IGhlaWdodDsKLSAgICBndGtfd2lkZ2V0X3F1ZXVlX3Jlc2l6ZV9u b19yZWRyYXcoR1RLX1dJREdFVCh3ZWJraXRXZWJWaWV3QmFzZSkpOworICAgIGlmICh3ZWJraXRX ZWJWaWV3QmFzZS0+cHJpdi0+aW5zcGVjdG9yVmlldykKKyAgICAgICAgZ3RrX3dpZGdldF9xdWV1 ZV9yZXNpemVfbm9fcmVkcmF3KEdUS19XSURHRVQod2Via2l0V2ViVmlld0Jhc2UpKTsKIH0KIAog dm9pZCB3ZWJraXRXZWJWaWV3QmFzZVNldEFjdGl2ZUNvbnRleHRNZW51UHJveHkoV2ViS2l0V2Vi Vmlld0Jhc2UqIHdlYmtpdFdlYlZpZXdCYXNlLCBXZWJDb250ZXh0TWVudVByb3h5R3RrKiBjb250 ZXh0TWVudVByb3h5KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvdGVzdHMvVGVzdEluc3BlY3Rvci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay90ZXN0cy9UZXN0SW5zcGVjdG9yLmNwcAppbmRleCA5YjAyM2YzLi42NzM3NDk0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0SW5zcGVj dG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0 SW5zcGVjdG9yLmNwcApAQCAtMjIsOCArMjIsNiBAQAogI2luY2x1ZGUgIldlYlZpZXdUZXN0Lmgi CiAjaW5jbHVkZSA8d3RmL2dvYmplY3QvR1JlZlB0ci5oPgogCi1zdGF0aWMgY29uc3QgdW5zaWdu ZWQgZ01pbmltdW1BdHRhY2hlZEluc3BlY3RvckhlaWdodCA9IDI1MDsKLQogY2xhc3MgSW5zcGVj dG9yVGVzdDogcHVibGljIFdlYlZpZXdUZXN0IHsKIHB1YmxpYzoKICAgICBNQUtFX0dMSUJfVEVT VF9GSVhUVVJFKEluc3BlY3RvclRlc3QpOwpAQCAtMTgxLDYgKzE3OSw3IEBAIHN0YXRpYyB2b2lk IHRlc3RJbnNwZWN0b3JEZWZhdWx0KEluc3BlY3RvclRlc3QqIHRlc3QsIGdjb25zdHBvaW50ZXIp CiAKICAgICB0ZXN0LT5yZXNpemVWaWV3QW5kQXR0YWNoKCk7CiAgICAgZ19hc3NlcnQod2Via2l0 X3dlYl9pbnNwZWN0b3JfaXNfYXR0YWNoZWQodGVzdC0+bV9pbnNwZWN0b3IpKTsKKyAgICBnX2Fz c2VydF9jbXB1aW50KHdlYmtpdF93ZWJfaW5zcGVjdG9yX2dldF9hdHRhY2hlZF9oZWlnaHQodGVz dC0+bV9pbnNwZWN0b3IpLCA+PSwgSW5zcGVjdG9yVGVzdDo6Z01pbmltdW1BdHRhY2hlZEluc3Bl Y3RvckhlaWdodCk7CiAgICAgZXZlbnRzID0gdGVzdC0+bV9ldmVudHM7CiAgICAgZ19hc3NlcnRf Y21waW50KGV2ZW50cy5zaXplKCksID09LCAxKTsKICAgICBnX2Fzc2VydF9jbXBpbnQoZXZlbnRz WzBdLCA9PSwgSW5zcGVjdG9yVGVzdDo6QXR0YWNoKTsKQEAgLTI1OCw2ICsyNTcsNyBAQCBwdWJs aWM6CiAgICAgICAgICAgICBndGtfd2lkZ2V0X3Nob3dfYWxsKHBhbmUpOwogICAgICAgICB9IGVs c2UKICAgICAgICAgICAgIHBhbmUgPSBndGtfYmluX2dldF9jaGlsZChHVEtfQklOKG1fcGFyZW50 V2luZG93KSk7CisgICAgICAgIGd0a19wYW5lZF9zZXRfcG9zaXRpb24oR1RLX1BBTkVEKHBhbmUp LCB3ZWJraXRfd2ViX2luc3BlY3Rvcl9nZXRfYXR0YWNoZWRfaGVpZ2h0KG1faW5zcGVjdG9yKSk7 CiAgICAgICAgIGd0a19wYW5lZF9hZGQyKEdUS19QQU5FRChwYW5lKSwgR1RLX1dJREdFVChpbnNw ZWN0b3JWaWV3LmdldCgpKSk7CiAKICAgICAgICAgcmV0dXJuIEluc3BlY3RvclRlc3Q6OmF0dGFj aCgpOwpAQCAtMzAxLDYgKzMwMSw3IEBAIHN0YXRpYyB2b2lkIHRlc3RJbnNwZWN0b3JNYW51YWxB dHRhY2hEZXRhY2goQ3VzdG9tSW5zcGVjdG9yVGVzdCogdGVzdCwgZ2NvbnN0cG9pCiAKICAgICB0 ZXN0LT5yZXNpemVWaWV3QW5kQXR0YWNoKCk7CiAgICAgZ19hc3NlcnQod2Via2l0X3dlYl9pbnNw ZWN0b3JfaXNfYXR0YWNoZWQodGVzdC0+bV9pbnNwZWN0b3IpKTsKKyAgICBnX2Fzc2VydF9jbXB1 aW50KHdlYmtpdF93ZWJfaW5zcGVjdG9yX2dldF9hdHRhY2hlZF9oZWlnaHQodGVzdC0+bV9pbnNw ZWN0b3IpLCA+PSwgSW5zcGVjdG9yVGVzdDo6Z01pbmltdW1BdHRhY2hlZEluc3BlY3RvckhlaWdo dCk7CiAgICAgZXZlbnRzID0gdGVzdC0+bV9ldmVudHM7CiAgICAgZ19hc3NlcnRfY21waW50KGV2 ZW50cy5zaXplKCksID09LCAxKTsKICAgICBnX2Fzc2VydF9jbXBpbnQoZXZlbnRzWzBdLCA9PSwg SW5zcGVjdG9yVGVzdDo6QXR0YWNoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL2d0ay9XZWJJbnNwZWN0b3JQcm94eUd0ay5jcHAKaW5kZXggZmFjMTlkYy4uNDc2OGZmYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJJbnNwZWN0b3JQcm94 eUd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJJbnNwZWN0b3JQ cm94eUd0ay5jcHAKQEAgLTE4Miw2ICsxODIsMTEgQEAgdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6 cGxhdGZvcm1BdHRhY2goKQogICAgICAgICBtX2luc3BlY3RvcldpbmRvdyA9IDA7CiAgICAgfQog CisgICAgLy8gU2V0IGEgZGVmYXVsdCBhdHRhY2hlZCBoZWlnaHQgYmFzZWQgb24gSW5zcGVjdG9y RnJvbnRlbmRDbGllbnRMb2NhbC4KKyAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgZGVmYXVsdEF0 dGFjaGVkSGVpZ2h0ID0gMzAwOworICAgIHVuc2lnbmVkIG1heGltdW1BdHRhY2hlZEhlaWdodCA9 IHBsYXRmb3JtSW5zcGVjdGVkV2luZG93SGVpZ2h0KCkgKiAzIC8gNDsKKyAgICBwbGF0Zm9ybVNl dEF0dGFjaGVkV2luZG93SGVpZ2h0KHN0ZDo6bWF4KG1pbmltdW1BdHRhY2hlZEhlaWdodCwgc3Rk OjptaW4oZGVmYXVsdEF0dGFjaGVkSGVpZ2h0LCBtYXhpbXVtQXR0YWNoZWRIZWlnaHQpKSk7CisK ICAgICBpZiAobV9jbGllbnQuYXR0YWNoKHRoaXMpKQogICAgICAgICByZXR1cm47CiAK