90765 2012-07-09 02:13:59 -0700 garden-o-matic should refuse rebaseline for reftests 2012-12-20 19:12:38 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 101976 P2 Normal --- 69227 1 hayato alancutter abarth dpranke mikelawther ojan simon.fraser tony oldest_to_newest 664745 0 hayato 2012-07-09 02:13:59 -0700 It might be user-friendly if garden-o-matic can refuse rebaseline for reftests. 664901 1 abarth 2012-07-09 08:50:40 -0700 Yes! We don't have a good meta bug to collect these feature requests, but Bug 69227 will have to do for now. 664908 2 ojan 2012-07-09 09:23:09 -0700 It should already do hide the rebaseline button for reftests. Did you see a case where it doesn't? Oh, on the main page where tests are grouped together, I suppose it still shows the rebaseline button. I was thinking that we actually need to make webkit-patch be a noop for rebaselining reftests. Fixing it at that level is better because it means that other users of the webkit-patch command will also be safe. 665263 3 hayato 2012-07-09 16:02:38 -0700 (In reply to comment #2) > It should already do hide the rebaseline button for reftests. Did you see a case where it doesn't? Yes. Yesterday, when I was gardening, I saw 'Rebaseline' button for a single test, 'fast/text-autosizing/simple-paragraph.html' on the main page. It was not grouped. As far as I remembered, I clicked a 'Rebaseline' button for the test, and I noticed it was a reftest after a patch was created by garden-o-matic. > > Oh, on the main page where tests are grouped together, I suppose it still shows the rebaseline button. I was thinking that we actually need to make webkit-patch be a noop for rebaselining reftests. Fixing it at that level is better because it means that other users of the webkit-patch command will also be safe. That sounds nice. webkit-patch is a good place as a last defense. 796053 4 tony 2012-12-20 19:12:38 -0800 This was recently fixed. *** This bug has been marked as a duplicate of bug 101976 ***