90763 2012-07-09 01:31:16 -0700 [GTK] Fix inspector detach when inspector was attached by the client 2012-07-09 08:12:05 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo xan.lopez oldest_to_newest 664729 0 cgarcia 2012-07-09 01:31:16 -0700 When the inspector is detached, we are unconditionally removing it from the inspected view, but if the inspector was attached by the client, the parent might be another widget. 664730 1 151213 cgarcia 2012-07-09 01:33:17 -0700 Created attachment 151213 Patch 664871 2 cgarcia 2012-07-09 08:12:05 -0700 Committed r122108: <http://trac.webkit.org/changeset/122108> 151213 2012-07-09 01:33:17 -0700 2012-07-09 08:04:31 -0700 Patch wk2-inspector-detach.diff text/plain 1673 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwOGUwZmU5Li45ZjJiYTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDctMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEZpeCBpbnNwZWN0b3IgZGV0YWNoIHdoZW4gaW5zcGVjdG9yIHdh cyBhdHRhY2hlZCBieSB0aGUgY2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05MDc2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdoZW4gdGhlIGluc3BlY3RvciBpcyBkZXRhY2hlZCwgd2UgYXJlIHVu Y29uZGl0aW9uYWxseSByZW1vdmluZyBpdAorICAgICAgICBmcm9tIHRoZSBpbnNwZWN0ZWQgdmll dywgYnV0IGlmIHRoZSBpbnNwZWN0b3Igd2FzIGF0dGFjaGVkIGJ5IHRoZQorICAgICAgICBjbGll bnQsIHRoZSBwYXJlbnQgbWlnaHQgYmUgYW5vdGhlciB3aWRnZXQuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvZ3RrL1dlYkluc3BlY3RvclByb3h5R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi SW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtRGV0YWNoKTogUmVtb3ZlIHRoZSBpbnNwZWN0b3IKKyAg ICAgICAgdmlldyBmcm9tIGl0cyBwYXJlbnQgd2lkZ2V0LgorCiAyMDEyLTA3LTA2ICBDaHJpc3Rv cGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgW1dLMl0g QWRkIHN1cHBvcnQgZm9yIE5ldHdvcmsgSW5mb3JtYXRpb24gQVBJCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkluc3BlY3RvclByb3h5R3RrLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwCmluZGV4IDQy NWQ3OTkuLmZhYzE5ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsv V2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9n dGsvV2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwCkBAIC0xOTUsOCArMTk1LDExIEBAIHZvaWQgV2Vi SW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtRGV0YWNoKCkKICAgICAgICAgcmV0dXJuOwogCiAgICAg R1JlZlB0cjxHdGtXaWRnZXQ+IGluc3BlY3RvclZpZXcgPSBtX2luc3BlY3RvclZpZXc7Ci0gICAg aWYgKCFtX2NsaWVudC5kZXRhY2godGhpcykpCi0gICAgICAgIGd0a19jb250YWluZXJfcmVtb3Zl KEdUS19DT05UQUlORVIobV9wYWdlLT52aWV3V2lkZ2V0KCkpLCBtX2luc3BlY3RvclZpZXcpOwor ICAgIGlmICghbV9jbGllbnQuZGV0YWNoKHRoaXMpKSB7CisgICAgICAgIEd0a1dpZGdldCogcGFy ZW50ID0gZ3RrX3dpZGdldF9nZXRfcGFyZW50KG1faW5zcGVjdG9yVmlldyk7CisgICAgICAgIEFT U0VSVChwYXJlbnQpOworICAgICAgICBndGtfY29udGFpbmVyX3JlbW92ZShHVEtfQ09OVEFJTkVS KHBhcmVudCksIG1faW5zcGVjdG9yVmlldyk7CisgICAgfQogCiAgICAgaWYgKCFtX2lzVmlzaWJs ZSkKICAgICAgICAgcmV0dXJuOwo=