90748 2012-07-08 21:37:05 -0700 Introduce a build flag for low quality JPEG images 2012-07-08 23:12:47 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 laszlo.gombos webkit-unassigned abarth peter qinmin webkit.review.bot oldest_to_newest 664619 0 laszlo.gombos 2012-07-08 21:37:05 -0700 Commit r113243 introduced low quality jpeg images for android with the intention of improving performance on small screen devices. I think that this (build) option could be useful for other ports targeting mobile as well. 664623 1 151181 laszlo.gombos 2012-07-08 21:46:57 -0700 Created attachment 151181 1st try The patch introduced 2 new build flags. We could consider creating a USE(LOW_QUALITY_IMAGE) instead and use it everywhere where USE(LOW_QUALITY_IMAGE_*) is used. 664642 2 151181 abarth 2012-07-08 22:15:12 -0700 Comment on attachment 151181 1st try Thanks! 664664 3 151181 webkit.review.bot 2012-07-08 23:12:42 -0700 Comment on attachment 151181 1st try Clearing flags on attachment: 151181 Committed r122089: <http://trac.webkit.org/changeset/122089> 664665 4 webkit.review.bot 2012-07-08 23:12:47 -0700 All reviewed patches have been landed. Closing bug. 151181 2012-07-08 21:46:57 -0700 2012-07-08 23:12:42 -0700 1st try 90748.patch text/plain 3028 laszlo.gombos SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMjIwODIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA3LTA4ICBMYXN6bG8gR29tYm9zICA8bGFz emxvLjEuZ29tYm9zQG5va2lhLmNvbT4KKworICAgICAgICBJbnRyb2R1Y2UgYSBidWlsZCBmbGFn IGZvciBsb3cgcXVhbGl0eSBKUEVHIGltYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA3NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUdXJuIG9uIHRoZSBuZXdseSBpbnRyb2R1Y2VkIGZsYWdzIGZv ciBhbmRyb2lkLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTItMDctMDUgIEZp bGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBJTkxJTkVfQVJNX0ZVTkNU SU9OKHRoaW5neSkgc2hvdWxkIG1ha2UgdGhpbmd5IGJlIHRodW1iMiBpZiB3ZSdyZSB1c2luZyB0 aHVtYjIKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dURi93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gMTIyMDYwKQorKysgU291cmNlL1dURi93 dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtNDc1LDYgKzQ3NSw4IEBACiAjZWxpZiBP UyhBTkRST0lEKQogI2RlZmluZSBXVEZfVVNFX1NLSUEgMQogI2RlZmluZSBXVEZfVVNFX0xPV19R VUFMSVRZX0lNQUdFX0lOVEVSUE9MQVRJT04gMQorI2RlZmluZSBXVEZfVVNFX0xPV19RVUFMSVRZ X0lNQUdFX05PX0pQRUdfRElUSEVSSU5HIDEKKyNkZWZpbmUgV1RGX1VTRV9MT1dfUVVBTElUWV9J TUFHRV9OT19KUEVHX0ZBTkNZX1VQU0FNUExJTkcgMQogI2Vsc2UKICNkZWZpbmUgV1RGX1VTRV9T S0lBIDEKICNkZWZpbmUgV1RGX1VTRV9JQ0NKUEVHIDEKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9u IDEyMjA4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE5IEBACisyMDEyLTA3LTA4ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9z QG5va2lhLmNvbT4KKworICAgICAgICBJbnRyb2R1Y2UgYSBidWlsZCBmbGFnIGZvciBsb3cgcXVh bGl0eSBKUEVHIGltYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTA3NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJbnRyb2R1Y2UgYnVpbGQgb3B0aW9ucyBmb3Igbm8gSlBFRyBkaXRoZXJpbmcgKFVT RShMT1dfUVVBTElUWV9JTUFHRV9OT19KUEVHX0RJVEhFUklORykpCisgICAgICAgIGFuZCBubyBK UEVHIGZhbmN5IHVwc2FtcGxpbmcgKFVTRShMT1dfUVVBTElUWV9JTUFHRV9OT19KUEVHX0ZBTkNZ X1VQU0FNUExJTkcpKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhlcmUgaXMgbm8gY2hh bmdlIGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVy cy9qcGVnL0pQRUdJbWFnZURlY29kZXIuY3BwOgorICAgICAgICAoZGl0aGVyTW9kZSk6CisgICAg ICAgIChkb0ZhbmN5VXBzYW1wbGluZyk6CisKIDIwMTItMDctMDUgIE1PUklUQSBIYWppbWUgIDxt b3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgSGVhcC11c2UtYWZ0ZXItZnJlZSBpbiBXZWJD b3JlOjpSZW5kZXJPYmplY3Q6OmRlc3Ryb3lBbmRDbGVhbnVwQW5vbnltb3VzV3JhcHBlcnMKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2pwZWcvSlBFR0ltYWdl RGVjb2Rlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2Ut ZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcAkocmV2aXNpb24gMTIyMDYwKQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNv ZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODYsMTMgKzg2LDE3IEBAIGlubGluZSBKX0NPTE9S X1NQQUNFIHJnYk91dHB1dENvbG9yU3BhY2UKIGlubGluZSBib29sIGNvbG9yU3BhY2VIYXNBbHBo YShKX0NPTE9SX1NQQUNFKSB7IHJldHVybiBmYWxzZTsgfQogI2VuZGlmCiAKLSNpZiBPUyhBTkRS T0lEKQorI2lmIFVTRShMT1dfUVVBTElUWV9JTUFHRV9OT19KUEVHX0RJVEhFUklORykKIGlubGlu ZSBKX0RDVF9NRVRIT0QgZGN0TWV0aG9kKCkgeyByZXR1cm4gSkRDVF9JRkFTVDsgfQogaW5saW5l IEpfRElUSEVSX01PREUgZGl0aGVyTW9kZSgpIHsgcmV0dXJuIEpESVRIRVJfTk9ORTsgfQotaW5s aW5lIGJvb2wgZG9GYW5jeVVwc2FtcGxpbmcoKSB7IHJldHVybiBmYWxzZTsgfQogI2Vsc2UKIGlu bGluZSBKX0RDVF9NRVRIT0QgZGN0TWV0aG9kKCkgeyByZXR1cm4gSkRDVF9JU0xPVzsgfQogaW5s aW5lIEpfRElUSEVSX01PREUgZGl0aGVyTW9kZSgpIHsgcmV0dXJuIEpESVRIRVJfRlM7IH0KKyNl bmRpZgorCisjaWYgVVNFKExPV19RVUFMSVRZX0lNQUdFX05PX0pQRUdfRkFOQ1lfVVBTQU1QTElO RykKK2lubGluZSBib29sIGRvRmFuY3lVcHNhbXBsaW5nKCkgeyByZXR1cm4gZmFsc2U7IH0KKyNl bHNlCiBpbmxpbmUgYm9vbCBkb0ZhbmN5VXBzYW1wbGluZygpIHsgcmV0dXJuIHRydWU7IH0KICNl bmRpZgogCg==