90745 2012-07-08 20:56:20 -0700 REGRESSION(r121968): Caused a link error on chromium Win dbg. (Requested by hayato on #webkit). 2012-07-08 23:10:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 90749 P2 Normal --- 90615 1 webkit.review.bot webkit.review.bot hayato yurys oldest_to_newest 664591 0 webkit.review.bot 2012-07-08 20:56:20 -0700 http://trac.webkit.org/changeset/121968 broke the build: Caused a link error on chromium Win dbg. (Requested by hayato on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 664593 1 151176 webkit.review.bot 2012-07-08 20:56:58 -0700 Created attachment 151176 ROLLOUT of r121968 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 664596 2 hayato 2012-07-08 20:59:00 -0700 Chromium WebKit Win (dbg) build bot started to fail on link from r121968: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20Builder%20%28dbg%29/builds/25935 6>Link: 6> Creating library ../../../../..\build\Debug\lib\webkit.lib and object ../../../../..\build\Debug\lib\webkit.exp 6>webcore_platform.lib(MemoryUsageSupportChromium.obj) : error LNK2019: unresolved external symbol "public: static void __cdecl SkGlyphCache::VisitAllCaches(bool (__cdecl*)(class SkGlyphCache *,void *),void *)" (?VisitAllCaches@SkGlyphCache@@SAXP6A_NPAV1@PAX@Z1@Z) referenced in function "public: static void __cdecl WebCore::MemoryUsageSupport::memoryUsageByComponents(class WTF::Vector<class WebCore::MemoryUsageSupport::ComponentInfo,0> &)" (?memoryUsageByComponents@MemoryUsageSupport@WebCore@@SAXAAV?$Vector@VComponentInfo@MemoryUsageSupport@WebCore@@$0A@@WTF@@@Z) 6>../../../../..\build\Debug\webkit.dll : fatal error LNK1120: 1 unresolved externals 6> 664598 3 151176 webkit.review.bot 2012-07-08 21:01:33 -0700 Comment on attachment 151176 ROLLOUT of r121968 Rejecting attachment 151176 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13166100 664624 4 hayato 2012-07-08 21:48:50 -0700 It seems that the patch created by sheriffbot can not be committed due to http://trac.webkit.org/changeset/122076. After tkent-san fixed that, let me recreate another rollout patch. (In reply to comment #3) > (From update of attachment 151176 [details]) > Rejecting attachment 151176 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 > > ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). > > Full output: http://queues.webkit.org/results/13166100 664628 5 hayato 2012-07-08 21:52:34 -0700 Created another rollout patch in https://bugs.webkit.org/show_bug.cgi?id=90749. 664662 6 hayato 2012-07-08 23:10:40 -0700 *** This bug has been marked as a duplicate of bug 90749 *** 151176 2012-07-08 20:56:58 -0700 2012-07-08 21:01:33 -0700 ROLLOUT of r121968 bug-90745-20120709040217.patch text/plain 6458 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGQ5YWFjNjM3NmZjNDg2 MzNiMmNhOWY3ZmU5NTRkODJmYTZhNmY1Yi4uNzdjMTFlMzhhM2U1OWQxNWM1Zjk1MzUyM2IzZTk1 MWI0MjUzZTVhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA3LTA4ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBOZWVkIGEg c2hvcnQgZGVzY3JpcHRpb24gKE9PUFMhKS4KKyAgICAgICAgTmVlZCB0aGUgYnVnIFVSTCAoT09Q UyEpLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFk ZGl0aW9uYWwgaW5mb3JtYXRpb24gb2YgdGhlIGNoYW5nZSBzdWNoIGFzIGFwcHJvYWNoLCByYXRp b25hbGUuIFBsZWFzZSBhZGQgcGVyLWZ1bmN0aW9uIGRlc2NyaXB0aW9ucyBiZWxvdy4gKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rv ci9JbnNwZWN0b3JNZW1vcnlBZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JN ZW1vcnlBZ2VudDo6Z2V0UHJvY2Vzc01lbW9yeURpc3RyaWJ1dGlvbik6CisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9OYXRpdmVNZW1vcnlTbmFwc2hvdFZpZXcuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuTWVtb3J5QmxvY2tWaWV3UHJvcGVydGllcy5faW5pdGlhbGl6ZSk6CisgICAg ICAgICogcGxhdGZvcm0vTWVtb3J5VXNhZ2VTdXBwb3J0LmNwcDoKKyAgICAgICAgKiBwbGF0Zm9y bS9NZW1vcnlVc2FnZVN1cHBvcnQuaDoKKyAgICAgICAgKE1lbW9yeVVzYWdlU3VwcG9ydCk6Cisg ICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vTWVtb3J5VXNhZ2VTdXBwb3J0Q2hyb21pdW0uY3Bw OgorCiAyMDEyLTA3LTA4ICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBYSFIuc2VuZCBzaG91bGQgc3VwcG9ydCBBcnJheUJ1ZmZlclZpZXcKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JNZW1vcnlBZ2VudC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yTWVtb3J5QWdlbnQuY3BwCmluZGV4IGVm MDdmZTI5YmJjMmQ2M2M5NWFiZjgwMDY3OTJkNDMxZWNiODEzODEuLmU5MDcyNTdjOWFlNmY5YzQ1 MTdjYzY0NDY1MmFhNDI2NDUyMWU0NDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JNZW1vcnlBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3Rvck1lbW9yeUFnZW50LmNwcApAQCAtNTQ0LDE3ICs1NDQsNiBAQCBzdGF0aWMg UGFzc1JlZlB0cjxJbnNwZWN0b3JNZW1vcnlCbG9jaz4gZG9tVHJlZUluZm8oUGFnZSogcGFnZSwg VmlzaXRlZE9iamVjdHMmCiAgICAgcmV0dXJuIGRvbVRyZWVzSXRlcmF0b3IuZHVtcFN0YXRpc3Rp Y3MoKTsKIH0KIAotc3RhdGljIHZvaWQgYWRkUGxhdGZvcm1Db21wb25lbnRzSW5mbyhQYXNzUmVm UHRyPFR5cGVCdWlsZGVyOjpBcnJheTxJbnNwZWN0b3JNZW1vcnlCbG9jaz4gPiBjaGlsZHJlbikK LXsKLSAgICBWZWN0b3I8TWVtb3J5VXNhZ2VTdXBwb3J0OjpDb21wb25lbnRJbmZvPiBjb21wb25l bnRzOwotICAgIE1lbW9yeVVzYWdlU3VwcG9ydDo6bWVtb3J5VXNhZ2VCeUNvbXBvbmVudHMoY29t cG9uZW50cyk7Ci0gICAgZm9yIChWZWN0b3I8TWVtb3J5VXNhZ2VTdXBwb3J0OjpDb21wb25lbnRJ bmZvPjo6aXRlcmF0b3IgaXQgPSBjb21wb25lbnRzLmJlZ2luKCk7IGl0ICE9IGNvbXBvbmVudHMu ZW5kKCk7ICsraXQpIHsKLSAgICAgICAgUmVmUHRyPEluc3BlY3Rvck1lbW9yeUJsb2NrPiBibG9j ayA9IEluc3BlY3Rvck1lbW9yeUJsb2NrOjpjcmVhdGUoKS5zZXROYW1lKGl0LT5tX25hbWUpOwot ICAgICAgICBibG9jay0+c2V0U2l6ZShpdC0+bV9zaXplSW5CeXRlcyk7Ci0gICAgICAgIGNoaWxk cmVuLT5hZGRJdGVtKGJsb2NrKTsKLSAgICB9Ci19Ci0KIHN0YXRpYyBQYXNzUmVmUHRyPEluc3Bl Y3Rvck1lbW9yeUJsb2NrPiBtZW1vcnlDYWNoZUluZm8oKQogewogICAgIE1lbW9yeUNhY2hlOjpT dGF0aXN0aWNzIHN0YXRzID0gbWVtb3J5Q2FjaGUoKS0+Z2V0U3RhdGlzdGljcygpOwpAQCAtNjEz LDcgKzYwMiw2IEBAIHZvaWQgSW5zcGVjdG9yTWVtb3J5QWdlbnQ6OmdldFByb2Nlc3NNZW1vcnlE aXN0cmlidXRpb24oRXJyb3JTdHJpbmcqLCBSZWZQdHI8SW5zCiAgICAgY2hpbGRyZW4tPmFkZEl0 ZW0ocmVuZGVyVHJlZUluZm8obV9wYWdlKSk7IC8vIFRPRE86IGNvbGxlY3QgZm9yIGFsbCBwYWdl cz8KICAgICBjaGlsZHJlbi0+YWRkSXRlbShkb21UcmVlSW5mbyhtX3BhZ2UsIHZpc2l0ZWRPYmpl Y3RzKSk7IC8vIFRPRE86IGNvbGxlY3QgZm9yIGFsbCBwYWdlcz8KICAgICBjaGlsZHJlbi0+YWRk SXRlbShqc0V4dGVybmFsUmVzb3VyY2VzSW5mbyh2aXNpdGVkT2JqZWN0cykpOwotICAgIGFkZFBs YXRmb3JtQ29tcG9uZW50c0luZm8oY2hpbGRyZW4pOwogICAgIHByb2Nlc3NNZW1vcnktPnNldENo aWxkcmVuKGNoaWxkcmVuKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9OYXRpdmVNZW1vcnlTbmFwc2hvdFZpZXcuanMgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05hdGl2ZU1lbW9yeVNuYXBzaG90Vmlldy5qcwppbmRleCA0 Mjk0YzAzMjY0Y2RjNzQwNmVlYmMyMjI4MjdkNGQ5ZjZmZGNmNGUxLi5iODM0NzBhNTNkNTQ0ZjM5 ZTQzOGJlN2Y2Yjg3ZDFiNDUyNDk0ZjA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL05hdGl2ZU1lbW9yeVNuYXBzaG90Vmlldy5qcworKysgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05hdGl2ZU1lbW9yeVNuYXBzaG90Vmlldy5qcwpA QCAtMjI0LDcgKzIyNCw2IEBAIFdlYkluc3BlY3Rvci5NZW1vcnlCbG9ja1ZpZXdQcm9wZXJ0aWVz Ll9pbml0aWFsaXplID0gZnVuY3Rpb24oKQogICAgIGFkZEJsb2NrKCJoc2woIDkwLCA1MCUsICA4 MCUpIiwgIkpTRXh0ZXJuYWxTdHJpbmdzIiwgIkphdmFTY3JpcHQgZXh0ZXJuYWwgc3RyaW5ncyIp OwogICAgIGFkZEJsb2NrKCJoc2woMjEwLCA2MCUsICA4MCUpIiwgIkluc3BlY3RvckRhdGEiLCAi SW5zcGVjdG9yIGRhdGEiKTsKICAgICBhZGRCbG9jaygiaHNsKCAzMCwgNjAlLCAgODAlKSIsICJN ZW1vcnlDYWNoZSIsICJNZW1vcnkgY2FjaGUgcmVzb3VyY2VzIik7Ci0gICAgYWRkQmxvY2soImhz bCggNDAsIDYwJSwgIDgwJSkiLCAiR2x5cGhDYWNoZSIsICJHbHlwaCBjYWNoZSByZXNvdXJjZXMi KTsKICAgICBhZGRCbG9jaygiaHNsKCA2MCwgNjAlLCAgODAlKSIsICJSZW5kZXJUcmVlQWxsb2Nh dGVkIiwgIlJlbmRlciB0cmVlIik7CiAgICAgYWRkQmxvY2soImhzbCggNjAsIDYwJSwgIDgwJSki LCAiUmVuZGVyVHJlZVVzZWQiLCAiUmVuZGVyIHRyZWUgdXNlZCIpOwogfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTWVtb3J5VXNhZ2VTdXBwb3J0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL01lbW9yeVVzYWdlU3VwcG9ydC5jcHAKaW5kZXggNmVkNDM1Njk3MDkz ZDQ5MjFiMmJjODhlZjY0Mzk3NWZkN2M4NDNjOS4uNzdlYjRmNDZmYWEwOWNmMzc3M2JlYjkxMzQ4 MjY0MTcxZjJhZTQ3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTWVtb3J5 VXNhZ2VTdXBwb3J0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NZW1vcnlVc2Fn ZVN1cHBvcnQuY3BwCkBAIC02Myw4ICs2Myw0IEBAIGJvb2wgTWVtb3J5VXNhZ2VTdXBwb3J0Ojpw cm9jZXNzTWVtb3J5U2l6ZXNJbkJ5dGVzKHNpemVfdCosIHNpemVfdCopCiAgICAgcmV0dXJuIGZh bHNlOwogfQogCi12b2lkIE1lbW9yeVVzYWdlU3VwcG9ydDo6bWVtb3J5VXNhZ2VCeUNvbXBvbmVu dHMoVmVjdG9yPENvbXBvbmVudEluZm8+JikKLXsKLX0KLQogfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTWVtb3J5VXNhZ2VTdXBwb3J0 LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NZW1vcnlVc2FnZVN1cHBvcnQuaAppbmRleCA4 YzM5ZWJhNWM0NjQwODZjNzJkNDAzZDYyNDU1OTJkNGIzZjAyNDEwLi40ZjFhMGJkZDdkZGQ3YWJh MWRlNmU1ZGRhMDIyODJlZWYyYzA2YTJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9NZW1vcnlVc2FnZVN1cHBvcnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9N ZW1vcnlVc2FnZVN1cHBvcnQuaApAQCAtMzEsOSArMzEsNiBAQAogI2lmbmRlZiBNZW1vcnlVc2Fn ZVN1cHBvcnRfaAogI2RlZmluZSBNZW1vcnlVc2FnZVN1cHBvcnRfaAogCi0jaW5jbHVkZSA8d3Rm L1ZlY3Rvci5oPgotI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgotCiBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKIGNsYXNzIE1lbW9yeVVzYWdlU3VwcG9ydCB7CkBAIC02MCwxNyArNTcsNiBA QCBwdWJsaWM6CiAgICAgLy8gbWVtb3J5IGN1cnJlbnRseSBhbGxvY2F0ZWQgdG8gdGhpcyBwcm9j ZXNzIHRoYXQgY2Fubm90IGJlIHNoYXJlZC4gUmV0dXJucwogICAgIC8vIGZhbHNlIG9uIHBsYXRm b3JtIHNwZWNpZmljIGVycm9yIGNvbmRpdGlvbnMuCiAgICAgc3RhdGljIGJvb2wgcHJvY2Vzc01l bW9yeVNpemVzSW5CeXRlcyhzaXplX3QqIHByaXZhdGVCeXRlcywgc2l6ZV90KiBzaGFyZWRCeXRl cyk7Ci0KLSAgICBjbGFzcyBDb21wb25lbnRJbmZvIHsKLSAgICBwdWJsaWM6Ci0gICAgICAgIENv bXBvbmVudEluZm8oY29uc3QgU3RyaW5nJiBuYW1lLCBzaXplX3Qgc2l6ZSkgOiBtX25hbWUobmFt ZSksIG1fc2l6ZUluQnl0ZXMoc2l6ZSkgeyB9Ci0KLSAgICAgICAgY29uc3QgU3RyaW5nIG1fbmFt ZTsKLSAgICAgICAgc2l6ZV90IG1fc2l6ZUluQnl0ZXM7Ci0gICAgfTsKLQotICAgIC8vIFJlcG9y dHMgcHJpdmF0ZSBtZW1vcnkgdXNlZCBieSBjb21wb25lbnRzIGluIGJ5dGVzLgotICAgIHN0YXRp YyB2b2lkIG1lbW9yeVVzYWdlQnlDb21wb25lbnRzKFZlY3RvcjxDb21wb25lbnRJbmZvPiYpOwog fTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vY2hyb21pdW0vTWVtb3J5VXNhZ2VTdXBwb3J0Q2hyb21pdW0uY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vTWVtb3J5VXNhZ2VTdXBwb3J0Q2hyb21pdW0uY3Bw CmluZGV4IDUwMzNiMDM5MzQ2YWIwOWE4NmQyYzUyNzA0NWI4MmY0N2NlZGIyODUuLmQyMWRlY2U5 MGEyOGFkNDg4Y2ZjY2Y4MjcyZjgxMGVhOWMwNjQyMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2Nocm9taXVtL01lbW9yeVVzYWdlU3VwcG9ydENocm9taXVtLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9NZW1vcnlVc2FnZVN1cHBvcnRDaHJv bWl1bS5jcHAKQEAgLTMyLDcgKzMyLDYgQEAKICNpbmNsdWRlICJNZW1vcnlVc2FnZVN1cHBvcnQu aCIKIAogI2luY2x1ZGUgPHB1YmxpYy9QbGF0Zm9ybS5oPgotI2luY2x1ZGUgPHRoaXJkX3BhcnR5 L3NraWEvc3JjL2NvcmUvU2tHbHlwaENhY2hlLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApA QCAtNjYsMTggKzY1LDQgQEAgYm9vbCBNZW1vcnlVc2FnZVN1cHBvcnQ6OnByb2Nlc3NNZW1vcnlT aXplc0luQnl0ZXMoc2l6ZV90KiBwcml2YXRlQnl0ZXMsIHNpemVfdCoKICAgICByZXR1cm4gV2Vi S2l0OjpQbGF0Zm9ybTo6Y3VycmVudCgpLT5wcm9jZXNzTWVtb3J5U2l6ZXNJbkJ5dGVzKHByaXZh dGVCeXRlcywgc2hhcmVkQnl0ZXMpOwogfQogCi1zdGF0aWMgYm9vbCBnbHlwaENhY2hlVmlzaXRv cihTa0dseXBoQ2FjaGUqIGNhY2hlLCB2b2lkKiBjb250ZXh0KQotewotICAgIHNpemVfdCogc2l6 ZVB0ciA9IHJlaW50ZXJwcmV0X2Nhc3Q8c2l6ZV90Kj4oY29udGV4dCk7Ci0gICAgKnNpemVQdHIg Kz0gc2l6ZW9mKCpjYWNoZSk7Ci0gICAgcmV0dXJuIGZhbHNlOwotfQotCi12b2lkIE1lbW9yeVVz YWdlU3VwcG9ydDo6bWVtb3J5VXNhZ2VCeUNvbXBvbmVudHMoVmVjdG9yPENvbXBvbmVudEluZm8+ JiBjb21wb25lbnRzKQotewotICAgIHNpemVfdCBzaXplID0gMDsKLSAgICBTa0dseXBoQ2FjaGU6 OlZpc2l0QWxsQ2FjaGVzKGdseXBoQ2FjaGVWaXNpdG9yLCAmc2l6ZSk7Ci0gICAgY29tcG9uZW50 cy5hcHBlbmQoQ29tcG9uZW50SW5mbygiR2x5cGhDYWNoZSIsIHNpemUpKTsKLX0KLQogfSAvLyBu YW1lc3BhY2UgV2ViQ29yZQo=