90740 2012-07-08 15:37:53 -0700 children method in LLINT AST Not class should return [@child] 2013-03-07 00:20:55 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111568 0 laurent webkit-unassigned buildbot fpizlo galpeter laurent mark.lam rniwa webkit.review.bot oldest_to_newest 664502 0 laurent 2012-07-08 15:37:53 -0700 While experimenting with the new llint in JSCore, I noticed that the Not class (located in offlineasm/ast.rb) may have an incorrect method: class Not < Node attr_reader :child def initialize(codeOrigin, child) super(codeOrigin) @child = child end def children [@left, @right] end def mapChildren Not.new(codeOrigin, (yield @child)) end def dump "(not #{child.dump})" end end Shouldn't children of this 'Not' class be def children [@child] end instead, since it's a unary operator? 848762 1 191731 galpeter 2013-03-06 05:43:57 -0800 Created attachment 191731 Fix for the children method I think this is also a problem. So this patch should fix it. 849813 2 191731 buildbot 2013-03-07 00:09:51 -0800 Comment on attachment 191731 Fix for the children method Attachment 191731 did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17067209 New failing tests: editing/selection/selection-modify-crash.html 849821 3 galpeter 2013-03-07 00:18:55 -0800 (In reply to comment #2) > (From update of attachment 191731 [details]) > Attachment 191731 [details] did not pass mac-ews (mac): > Output: http://webkit-commit-queue.appspot.com/results/17067209 > > New failing tests: > editing/selection/selection-modify-crash.html This patch can not cause this fail, because at this time the 'Not' node is not used at all. 849822 4 fpizlo 2013-03-07 00:19:13 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 191731 [details] [details]) > > Attachment 191731 [details] [details] did not pass mac-ews (mac): > > Output: http://webkit-commit-queue.appspot.com/results/17067209 > > > > New failing tests: > > editing/selection/selection-modify-crash.html > > This patch can not cause this fail, because at this time the 'Not' node is not used at all. Agreed. 849823 5 191731 webkit.review.bot 2013-03-07 00:20:51 -0800 Comment on attachment 191731 Fix for the children method Clearing flags on attachment: 191731 Committed r145047: <http://trac.webkit.org/changeset/145047> 849824 6 webkit.review.bot 2013-03-07 00:20:55 -0800 All reviewed patches have been landed. Closing bug. 191731 2013-03-06 05:43:57 -0800 2013-03-07 00:20:51 -0800 Fix for the children method offlineasm_ast_not_fix.patch text/plain 1006 galpeter ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGM1OTVkNDkuLjFjMmRlOTAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAzLTA2ICBQZXRlciBHYWwgIDxn YWxwZXRlckBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgQ2hpbGRyZW4gbWV0aG9kIGluIExM SU5UIEFTVCBOb3QgY2xhc3Mgc2hvdWxkIHJldHVybiBbQGNoaWxkXQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA3NDAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG9mZmxpbmVhc20vYXN0LnJiOiBGaXhl ZCB0aGUgcmV0dXJuIHZhbHVlIG9mIHRoZSBjaGlsZHJlbiBtZXRob2QgaW4gdGhlIE5vdCBBU1Qg Y2xhc3MuCisKIDIwMTMtMDMtMDYgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgog CiAgICAgICAgIFVudXNlZCBTdHJ1Y3R1cmUgcHJvcGVydHkgdGFibGVzIHdhc3RlIDE0TUIgb24g TWVtYnVzdGVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20v YXN0LnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXN0LnJiCmluZGV4IDkz MzMyNDcuLjRmMGMzZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5l YXNtL2FzdC5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hc3QucmIK QEAgLTExMzksNyArMTEzOSw3IEBAIGNsYXNzIE5vdCA8IE5vZGUKICAgICBlbmQKICAgICAKICAg ICBkZWYgY2hpbGRyZW4KLSAgICAgICAgW0BsZWZ0LCBAcmlnaHRdCisgICAgICAgIFtAY2hpbGRd CiAgICAgZW5kCiAgICAgCiAgICAgZGVmIG1hcENoaWxkcmVuCg==