90730 2012-07-07 14:32:20 -0700 [BlackBerry] Race destroying the compositor 2012-07-08 21:06:10 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 staikos staikos mifenton tonikitoo webkit.review.bot oldest_to_newest 664417 0 staikos 2012-07-07 14:32:20 -0700 There is a race condition destroying the compositor that can allow it to process animations after it has been detached. Properly setup a detach() method. 664421 1 151148 staikos 2012-07-07 14:57:54 -0700 Created attachment 151148 Patch to fix it. Reviewed and tested already. No idea how to make a testcase for this. Requires Cascades. 664422 2 webkit.review.bot 2012-07-07 14:59:26 -0700 Attachment 151148 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1 Source/WebKit/blackberry/Api/WebPageCompositor_p.h:93: The parameter name "page" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 664424 3 151148 webkit.review.bot 2012-07-07 15:26:50 -0700 Comment on attachment 151148 Patch to fix it. Reviewed and tested already. Clearing flags on attachment: 151148 Committed r122056: <http://trac.webkit.org/changeset/122056> 664425 4 webkit.review.bot 2012-07-07 15:26:54 -0700 All reviewed patches have been landed. Closing bug. 151148 2012-07-07 14:57:54 -0700 2012-07-07 15:26:50 -0700 Patch to fix it. Reviewed and tested already. 90730.patch text/plain 3379 staikos SW5kZXg6IFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkocmV2aXNpb24gMTIyMDU1KQorKysg U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDEyLTA3LTA3ICBHZW9yZ2UgU3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9y Zz4KKworICAgICAgICBEZXRhY2ggYW5pbWF0aW9uIGNsaWVudHMgcHJvcGVybHkgaWYgd2UgY2xl YXIgdGhlIHdlYiBwYWdlIHBvaW50ZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05MDczMAorCisgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gVHJlYXQu CisKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJL aXQ6OldlYlBhZ2VQcml2YXRlOjpkZXN0cm95Q29tcG9zaXRvcik6CisgICAgICAgICogQXBpL1dl YlBhZ2VDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFn ZUNvbXBvc2l0b3JQcml2YXRlOjpXZWJQYWdlQ29tcG9zaXRvclByaXZhdGUpOgorICAgICAgICAo QmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlQ29tcG9zaXRvclByaXZhdGU6On5XZWJQYWdlQ29t cG9zaXRvclByaXZhdGUpOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKEJsYWNrQmVycnk6 OldlYktpdDo6V2ViUGFnZUNvbXBvc2l0b3JQcml2YXRlOjpkZXRhY2gpOgorICAgICAgICAoQmxh Y2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlQ29tcG9zaXRvclByaXZhdGU6OnNldFBhZ2UpOgorICAg ICAgICAqIEFwaS9XZWJQYWdlQ29tcG9zaXRvcl9wLmg6CisgICAgICAgIChXZWJQYWdlQ29tcG9z aXRvclByaXZhdGUpOgorCiAyMDEyLTA3LTA2ICBNYXggRmVpbCAgPG1mZWlsQHJpbS5jb20+CiAK ICAgICAgICAgW0JsYWNrQmVycnldIGV4aXRGdWxsU2NyZWVuRm9yRWxlbWVudCgpIGlzIG5vdCB3 b3JraW5nIGZvciBmdWxsc2NyZWVuIGVsZW1lbnRzIGluIGlmcmFtZXMKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAkocmV2aXNpb24gMTIxODA1KQorKysgU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NjA4Myw3ICs2MDgzLDcgQEAgdm9pZCBXZWJQYWdlUHJpdmF0ZTo6ZGVzdHJveUNvbXBvc2l0b3Io KQogewogICAgIC8vIG1fY29tcG9zaXRvciBpcyBhIFJlZlB0ciwgc28gaXQgbWF5IGxpdmUgb24g YmV5b25kIHRoaXMgcG9pbnQuCiAgICAgLy8gRGlzY29ubmVjdCB0aGUgY29tcG9zaXRvciBmcm9t IHVzCi0gICAgbV9jb21wb3NpdG9yLT5zZXRQYWdlKDApOworICAgIG1fY29tcG9zaXRvci0+ZGV0 YWNoKCk7CiAgICAgbV9jb21wb3NpdG9yLmNsZWFyKCk7CiAgICAgbV9vd25lZENvbnRleHQuY2xl YXIoKTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNvbXBv c2l0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZUNvbXBvc2l0b3IuY3BwCShyZXZpc2lvbiAxMjE4MDUpCisrKyBTb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQXBpL1dlYlBhZ2VDb21wb3NpdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDcs MTIgKzQ3LDI5IEBAIFdlYlBhZ2VDb21wb3NpdG9yUHJpdmF0ZTo6V2ViUGFnZUNvbXBvc2kKICAg ICAsIG1fd2ViUGFnZShwYWdlKQogICAgICwgbV9kcmF3c1Jvb3RMYXllcihmYWxzZSkKIHsKKyAg ICBBU1NFUlQobV93ZWJQYWdlKTsKICAgICBzZXRPbmVTaG90KHRydWUpOyAvLyBvbmUtc2hvdCBh bmltYXRpb24gY2xpZW50CiB9CiAKIFdlYlBhZ2VDb21wb3NpdG9yUHJpdmF0ZTo6fldlYlBhZ2VD b21wb3NpdG9yUHJpdmF0ZSgpCiB7Ci0gICAgUGxhdGZvcm06OkFuaW1hdGlvbkZyYW1lUmF0ZUNv bnRyb2xsZXI6Omluc3RhbmNlKCktPnJlbW92ZUNsaWVudCh0aGlzKTsKKyAgICBkZXRhY2goKTsK K30KKwordm9pZCBXZWJQYWdlQ29tcG9zaXRvclByaXZhdGU6OmRldGFjaCgpCit7CisgICAgaWYg KG1fd2ViUGFnZSkKKyAgICAgICAgUGxhdGZvcm06OkFuaW1hdGlvbkZyYW1lUmF0ZUNvbnRyb2xs ZXI6Omluc3RhbmNlKCktPnJlbW92ZUNsaWVudCh0aGlzKTsKKyAgICBtX3dlYlBhZ2UgPSAwOwor fQorCit2b2lkIFdlYlBhZ2VDb21wb3NpdG9yUHJpdmF0ZTo6c2V0UGFnZShXZWJQYWdlUHJpdmF0 ZSAqcCkKK3sKKyAgICBpZiAocCA9PSBtX3dlYlBhZ2UpCisgICAgICAgIHJldHVybjsKKyAgICBB U1NFUlQocCk7CisgICAgQVNTRVJUKG1fd2ViUGFnZSk7IC8vIGlmIHRoaXMgaXMgbnVsbCwgd2Ug aGF2ZSBhIGJ1ZyBhbmQgd2UgbmVlZCB0byByZS1hZGQuCisgICAgbV93ZWJQYWdlID0gcDsKIH0K IAogdm9pZCBXZWJQYWdlQ29tcG9zaXRvclByaXZhdGU6OnNldENvbnRleHQoUGxhdGZvcm06Okdy YXBoaWNzOjpHTEVTMkNvbnRleHQqIGNvbnRleHQpCkluZGV4OiBTb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQXBpL1dlYlBhZ2VDb21wb3NpdG9yX3AuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDb21wb3NpdG9yX3AuaAkocmV2aXNpb24gMTIxODA1 KQorKysgU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ29tcG9zaXRvcl9wLmgJ KHdvcmtpbmcgY29weSkKQEAgLTkwLDcgKzkwLDggQEAgcHVibGljOgogICAgIHZvaWQgcmVsZWFz ZUxheWVyUmVzb3VyY2VzKCk7CiAKICAgICBXZWJQYWdlUHJpdmF0ZSogcGFnZSgpIGNvbnN0IHsg cmV0dXJuIG1fd2ViUGFnZTsgfQotICAgIHZvaWQgc2V0UGFnZShXZWJQYWdlUHJpdmF0ZSogcGFn ZSkgeyBtX3dlYlBhZ2UgPSBwYWdlOyB9CisgICAgdm9pZCBzZXRQYWdlKFdlYlBhZ2VQcml2YXRl KiBwYWdlKTsKKyAgICB2b2lkIGRldGFjaCgpOwogICAgIFdlYlBhZ2VDb21wb3NpdG9yQ2xpZW50 KiBjbGllbnQoKSBjb25zdCB7IHJldHVybiBtX2NsaWVudDsgfQogICAgIHZvaWQgY29tcG9zaXRv ckRlc3Ryb3llZCgpOwogCg==