90719 2012-07-06 23:31:50 -0700 REGRESSION (r122035): fullscreen/exit-full-screen-iframe.html failing on GTK Linux 64-bit Release 2012-07-07 12:49:45 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r122035%20(26209)/results.html LayoutTestFailure, MakingBotsRed, Regression P2 Normal --- 1 zan zan pnormand oldest_to_newest 664345 0 zan 2012-07-06 23:31:50 -0700 fullscreen/exit-full-screen-iframe.html started failing on GTK Linux 64-bit Release in r122035 <http://trac.webkit.org/changeset/122035>. http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r122034%20(26208)/results.html passed http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r122035%20(26209)/results.html failed Here's the crashlog: (from http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r122035%20(26209)/fullscreen/exit-full-screen-iframe-crash-log.txt) Crash log for DumpRenderTree (pid 19882): [New LWP 19882] [New LWP 19899] [New LWP 20020] [New LWP 20026] [New LWP 20028] [New LWP 20031] [New LWP 20034] [New LWP 20036] [New LWP 21368] [New LWP 20033] [New LWP 20025] [Thread debugging using libthread_db enabled] Core was generated by `/home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/Programs/D'. Program terminated with signal 11, Segmentation fault. #0 0x00007f2c199cf823 in WebKit::ChromeClient::exitFullScreenForElement(WebCore::Element*) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0 ... Thread 1 (Thread 0x7f2c1b3f2900 (LWP 19882)): #0 0x00007f2c199cf823 in WebKit::ChromeClient::exitFullScreenForElement(WebCore::Element*) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0 #1 0x00007f2c19c9cb18 in WebCore::Document::webkitExitFullscreen() () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0 #2 0x00007f2c19c9cd6f in WebCore::Document::webkitCancelFullScreen() () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0 #3 0x00007f2c1a5799b9 in WebCore::jsDocumentPrototypeFunctionWebkitCancelFullScreen(JSC::ExecState*) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0 #4 0x00007f2bcf2f2265 in ?? () #5 0xffff000000000002 in ?? () #6 0x00007f2c1b1b65fd in llint_op_call () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0 #7 0x0000000000000000 in ?? () STDERR: STDERR: warning: Can't read pathname for load map: Input/output error. STDERR: WebKitDOMHTMLElement* WebKit::kit(WebCore::HTMLElement*): assertion `obj' failed 664391 1 pnormand 2012-07-07 09:38:42 -0700 Thanks Zan for always keeping an eye out! A patch for this should be trivial, getting inspired from http://trac.webkit.org/changeset/122035/trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp Do you want to take up on this, Zan? 664402 2 151145 zan 2012-07-07 12:27:22 -0700 Created attachment 151145 Patch 664403 3 151145 zan 2012-07-07 12:49:38 -0700 Comment on attachment 151145 Patch Clearing flags on attachment: 151145 Committed r122054: <http://trac.webkit.org/changeset/122054> 664404 4 zan 2012-07-07 12:49:45 -0700 All reviewed patches have been landed. Closing bug. 151145 2012-07-07 12:27:22 -0700 2012-07-07 12:49:38 -0700 Patch bug-90719-20120707212720.patch text/plain 4448 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggYjFhN2MxY2Uz YzBmMTRiMWNmNjU4MTg4NDZjMWUyN2NiMGY1OTg4ZC4uMDkxMjBmYWY4MDQ1YjgzMTk3MmMzYzAw ZTBlMTFmYmI4YTllYWFhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEy LTA3LTA3ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisKKyAgICAgICAg UkVHUkVTU0lPTiAocjEyMjAzNSk6IGZ1bGxzY3JlZW4vZXhpdC1mdWxsLXNjcmVlbi1pZnJhbWUu aHRtbCBmYWlsaW5nIG9uIEdUSyBMaW51eCA2NC1iaXQgUmVsZWFzZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA3MTkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb2xsb3cgdGhlIGFwcHJvYWNoIG9mIHRo ZSBCbGFja0JlcnJ5IHBvcnQgb3V0bGluZWQgaW4gcjEyMjAzNSwgdXNpbmcgaW4gZXhpdEZ1bGxT Y3JlZW5Gb3JFbGVtZW50CisgICAgICAgIHRoZSBmdWxsc2NyZWVuIGVsZW1lbnQgdG8gd2hpY2gg dGhlIHJlZmVyZW5jZSB3YXMgc2F2ZWQgd2hlbiBlbnRlckZ1bGxTY3JlZW5Gb3JFbGVtZW50IHdh cyBjYWxsZWQuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3Bw OgorICAgICAgICAoV2ViS2l0OjpDaHJvbWVDbGllbnQ6OmV4aXRGdWxsU2NyZWVuRm9yRWxlbWVu dCk6CisKIDIwMTItMDctMDIgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgRG8gbm90IGRvIGFueSBsb2dnaW5nIGluaXRpYWxpemF0aW9uIHdoZW4gbG9n Z2luZyBpcyBkaXNhYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1 cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBw b3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKaW5kZXggM2IzMDlmOGI4ZjNlNWM1YTc2YTUyNmI3MzEw MmM3YzE5ZDFhMmNjYy4uOTFhMjFlODE5YmJkNzIyZmY2ZGZiYzdjM2VjZTM4NmIzZWEzZjI0MyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50 R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGll bnRHdGsuY3BwCkBAIC05NDUsMTAgKzk0NSwxNSBAQCB2b2lkIENocm9tZUNsaWVudDo6ZW50ZXJG dWxsU2NyZWVuRm9yRWxlbWVudChXZWJDb3JlOjpFbGVtZW50KiBlbGVtZW50KQogICAgIGVsZW1l bnQtPmRvY3VtZW50KCktPndlYmtpdERpZEVudGVyRnVsbFNjcmVlbkZvckVsZW1lbnQoZWxlbWVu dCk7CiB9CiAKLXZvaWQgQ2hyb21lQ2xpZW50OjpleGl0RnVsbFNjcmVlbkZvckVsZW1lbnQoV2Vi Q29yZTo6RWxlbWVudCogZWxlbWVudCkKK3ZvaWQgQ2hyb21lQ2xpZW50OjpleGl0RnVsbFNjcmVl bkZvckVsZW1lbnQoV2ViQ29yZTo6RWxlbWVudCopCiB7CisgICAgLy8gVGhlIGVsZW1lbnQgcGFz c2VkIGludG8gdGhpcyBmdW5jdGlvbiBpcyBub3QgcmVsaWFibGUsIGkuZS4gaXQgY291bGQKKyAg ICAvLyBiZSBudWxsLiBJbiBhZGRpdGlvbiB0aGUgcGFyYW1ldGVyIG1heSBiZSBkaXNhcHBlYXJp bmcgaW4gdGhlIGZ1dHVyZS4KKyAgICAvLyBTbyB3ZSB1c2UgdGhlIHJlZmVyZW5jZSB0byB0aGUg ZWxlbWVudCB3ZSBzYXZlZCBhYm92ZS4KKyAgICBBU1NFUlQobV9mdWxsU2NyZWVuRWxlbWVudCk7 CisKICAgICBnYm9vbGVhbiByZXR1cm5WYWx1ZTsKLSAgICBHUmVmUHRyPFdlYktpdERPTUhUTUxF bGVtZW50PiBraXRFbGVtZW50KGFkb3B0R1JlZihraXQocmVpbnRlcnByZXRfY2FzdDxIVE1MRWxl bWVudCo+KGVsZW1lbnQpKSkpOworICAgIEdSZWZQdHI8V2ViS2l0RE9NSFRNTEVsZW1lbnQ+IGtp dEVsZW1lbnQoYWRvcHRHUmVmKGtpdChyZWludGVycHJldF9jYXN0PEhUTUxFbGVtZW50Kj4obV9m dWxsU2NyZWVuRWxlbWVudC5nZXQoKSkpKSk7CiAgICAgZ19zaWduYWxfZW1pdF9ieV9uYW1lKG1f d2ViVmlldywgImxlYXZpbmctZnVsbHNjcmVlbiIsIGtpdEVsZW1lbnQuZ2V0KCksICZyZXR1cm5W YWx1ZSk7CiAgICAgaWYgKHJldHVyblZhbHVlKQogICAgICAgICByZXR1cm47CkBAIC05NTcsMTAg Kzk2MiwxMCBAQCB2b2lkIENocm9tZUNsaWVudDo6ZXhpdEZ1bGxTY3JlZW5Gb3JFbGVtZW50KFdl YkNvcmU6OkVsZW1lbnQqIGVsZW1lbnQpCiAgICAgQVNTRVJUKHdpZGdldElzT25zY3JlZW5Ub3Bs ZXZlbFdpbmRvdyh3aW5kb3cpKTsKICAgICBnX3NpZ25hbF9oYW5kbGVyc19kaXNjb25uZWN0X2J5 X2Z1bmMod2luZG93LCByZWludGVycHJldF9jYXN0PHZvaWQqPihvbkZ1bGxzY3JlZW5HdGtLZXlQ cmVzc0V2ZW50KSwgdGhpcyk7CiAKLSAgICBlbGVtZW50LT5kb2N1bWVudCgpLT53ZWJraXRXaWxs RXhpdEZ1bGxTY3JlZW5Gb3JFbGVtZW50KGVsZW1lbnQpOworICAgIG1fZnVsbFNjcmVlbkVsZW1l bnQtPmRvY3VtZW50KCktPndlYmtpdFdpbGxFeGl0RnVsbFNjcmVlbkZvckVsZW1lbnQobV9mdWxs U2NyZWVuRWxlbWVudC5nZXQoKSk7CiAgICAgZ3RrX3dpbmRvd191bmZ1bGxzY3JlZW4oR1RLX1dJ TkRPVyh3aW5kb3cpKTsKICAgICBtX2FkanVzdG1lbnRXYXRjaGVyLmVuYWJsZUFsbFNjcm9sbGJh cnMoKTsKLSAgICBlbGVtZW50LT5kb2N1bWVudCgpLT53ZWJraXREaWRFeGl0RnVsbFNjcmVlbkZv ckVsZW1lbnQoZWxlbWVudCk7CisgICAgbV9mdWxsU2NyZWVuRWxlbWVudC0+ZG9jdW1lbnQoKS0+ d2Via2l0RGlkRXhpdEZ1bGxTY3JlZW5Gb3JFbGVtZW50KG1fZnVsbFNjcmVlbkVsZW1lbnQuZ2V0 KCkpOwogICAgIG1fZnVsbFNjcmVlbkVsZW1lbnQuY2xlYXIoKTsKIH0KICNlbmRpZgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IGZkZDg4Nzc4MDNhNTljYWIyY2MxYTQ1NTI2ZTRjNmJlMGU1ZTUxZjkuLjdhN2ZlZjA2Y2IwNWNl MDNmMWFiOGRjYWNjZDRlNmVkNjE4OWJlYTMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0w Ny0wNyAgWmFuIERvYmVyc2VrICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgorCisgICAgICAgIFJF R1JFU1NJT04gKHIxMjIwMzUpOiBmdWxsc2NyZWVuL2V4aXQtZnVsbC1zY3JlZW4taWZyYW1lLmh0 bWwgZmFpbGluZyBvbiBHVEsgTGludXggNjQtYml0IFJlbGVhc2UKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwNzE5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRoZSBjcmFzaGluZyB0ZXN0IGV4 cGVjdGF0aW9uIGZvciB0aGUgYWZmZWN0ZWQgdGVzdC4KKworICAgICAgICAqIHBsYXRmb3JtL2d0 ay9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEyLTA3LTA3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0Bh cHBsZS5jb20+CiAKICAgICAgICAgbWVkaWEvbWVkaWEtYmxvY2tlZC1ieS1iZWZvcmVsb2FkLmh0 bWwgaXMgZmxha3kKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhw ZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5k ZXggYmUxNDZlMTQ3Y2U2NTMwZWVmNDc1MjkyYmNmNWZkY2VlYjE1MTc2Yi4uNGIzNmJmMzUzNjdi MzhlYjJiZDJhYWFlMzJhYzQyMzI3N2M2YzA5YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTM3Myw4ICszNzMsNiBAQCBCVUdXSzg5OTU0IERFQlVHIDog aHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9yZWVudHJhbnQtY2FuY2VsLmh0bWwgPSBDUkFTSAog CiBCVUdXSzkwNTg5IFJFTEVBU0UgOiBmYXN0L2Nzcy91c2VyLWRyYWctbm9uZS5odG1sID0gQ1JB U0ggVElNRU9VVAogCi1CVUdXSzkwNzE5IDogZnVsbHNjcmVlbi9leGl0LWZ1bGwtc2NyZWVuLWlm cmFtZS5odG1sID0gQ1JBU0gKLQogLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCiAv LyBFbmQgb2YgQ3Jhc2hpbmcgdGVzdHMKIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Lwo=