90718 2012-07-06 22:41:06 -0700 [EFL] Fix build break when Accelerated Compositing is on 2012-07-07 18:03:15 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 jinwoo7.song webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 664339 0 jinwoo7.song 2012-07-06 22:41:06 -0700 ewk_view_accelerated_compositing_XXX APIs are in ewk_view_private.h 664340 1 151133 jinwoo7.song 2012-07-06 22:44:21 -0700 Created attachment 151133 patch 664344 2 151134 jinwoo7.song 2012-07-06 23:25:18 -0700 Created attachment 151134 patch 664382 3 151134 ryuan.choi 2012-07-07 07:05:13 -0700 Comment on attachment 151134 patch View in context: https://bugs.webkit.org/attachment.cgi?id=151134&action=review > Source/WebKit/efl/ChangeLog:8 > + ewk_view_accelerated_compositing_XXX APIs are in ewk_view_private.h This comment is partially commented the reason. Unreviewed build fix looks enough or you'd better to explain all of your changes. For your information, ewk_view_accelerated_compositing_XXX APIs are moved to ewk_view_private.h after r117046. And PageClientEfl is moved out of WebCore namespace after r114367 to fix build break of WebKit2. 664433 4 151134 webkit.review.bot 2012-07-07 18:03:10 -0700 Comment on attachment 151134 patch Clearing flags on attachment: 151134 Committed r122057: <http://trac.webkit.org/changeset/122057> 664435 5 webkit.review.bot 2012-07-07 18:03:15 -0700 All reviewed patches have been landed. Closing bug. 151133 2012-07-06 22:44:21 -0700 2012-07-06 23:25:18 -0700 patch ac_build_fail.patch text/plain 2618 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBiODAzMjNiLi42ZWYxYzViIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDctMDYgIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNh bXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIEZpeCBidWlsZCBicmVhayB3aGVuIEFjY2VsZXJh dGVkIENvbXBvc2l0aW5nIGlzIG9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTA3MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBld2tfdmlld19hY2NlbGVyYXRlZF9jb21wb3NpdGluZ19YWFggQVBJcyBh cmUgaW4gZXdrX3ZpZXdfcHJpdmF0ZS5oCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9QYWdl Q2xpZW50RWZsLmNwcDoKKyAgICAgICAgKFBhZ2VDbGllbnRFZmw6OmNyZWF0ZUV2YXNPYmplY3RG b3JBY2NlbGVyYXRlZENvbXBvc2l0aW5nKToKKyAgICAgICAgKFBhZ2VDbGllbnRFZmw6OmFjY2Vs ZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0KToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9QYWdl Q2xpZW50RWZsLmg6CisgICAgICAgIChQYWdlQ2xpZW50RWZsKToKKwogMjAxMi0wNy0wNiAgU2Vv a2p1IEt3b24gIDxzZW9ranUua3dvbkBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBBZGQg V2ViIEluc3BlY3RvciB0byBXZWJLaXQtRUZMCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9XZWJDb3JlU3VwcG9ydC9QYWdlQ2xpZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dl YkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRFZmwuY3BwCmluZGV4IDI1ZmJkNzUuLjZkNDA5YzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRFZmwu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRFZmwu Y3BwCkBAIC0yMCw3ICsyMCw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiUGFn ZUNsaWVudEVmbC5oIgogCi0jaW5jbHVkZSAiZXdrX3ByaXZhdGUuaCIKKyNpbmNsdWRlICJld2tf dmlld19wcml2YXRlLmgiCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNzIEludFJlY3Q7CkBA IC0zNywxMiArMzcsMTIgQEAgUGFnZUNsaWVudEVmbDo6flBhZ2VDbGllbnRFZmwoKQogfQogCiAj aWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQotYm9vbCBQYWdlQ2xpZW50RWZsOjpjcmVh dGVFdmFzT2JqZWN0Rm9yQWNjZWxlcmF0ZWRDb21wb3NpdGluZyhFdmFzX05hdGl2ZV9TdXJmYWNl KiBuYXRpdmVTdXJmYWNlLCBjb25zdCBJbnRSZWN0JiByZWN0KQorYm9vbCBQYWdlQ2xpZW50RWZs OjpjcmVhdGVFdmFzT2JqZWN0Rm9yQWNjZWxlcmF0ZWRDb21wb3NpdGluZyhFdmFzX05hdGl2ZV9T dXJmYWNlKiBuYXRpdmVTdXJmYWNlLCBjb25zdCBXZWJDb3JlOjpJbnRSZWN0JiByZWN0KQogewog ICAgIHJldHVybiBld2tfdmlld19hY2NlbGVyYXRlZF9jb21wb3NpdGluZ19vYmplY3RfY3JlYXRl KG1fdmlldywgbmF0aXZlU3VyZmFjZSwgcmVjdCk7CiB9CiAKLUdyYXBoaWNzQ29udGV4dDNEKiBQ YWdlQ2xpZW50RWZsOjphY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dCgpCitXZWJDb3JlOjpH cmFwaGljc0NvbnRleHQzRCogUGFnZUNsaWVudEVmbDo6YWNjZWxlcmF0ZWRDb21wb3NpdGluZ0Nv bnRleHQoKQogewogICAgIHJldHVybiBld2tfdmlld19hY2NlbGVyYXRlZF9jb21wb3NpdGluZ19j b250ZXh0X2dldChtX3ZpZXcpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvV2Vi Q29yZVN1cHBvcnQvUGFnZUNsaWVudEVmbC5oIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1 cHBvcnQvUGFnZUNsaWVudEVmbC5oCmluZGV4IGI5NTgyM2MuLjZmOThkNzAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRFZmwuaAorKysgYi9T b3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9QYWdlQ2xpZW50RWZsLmgKQEAgLTM1LDgg KzM1LDggQEAgcHVibGljOgogICAgIHZpcnR1YWwgflBhZ2VDbGllbnRFZmwoKTsKIAogI2lmIFVT RShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAgICBib29sIGNyZWF0ZUV2YXNPYmplY3RGb3JB Y2NlbGVyYXRlZENvbXBvc2l0aW5nKEV2YXNfTmF0aXZlX1N1cmZhY2UqLCBjb25zdCBJbnRSZWN0 Jik7Ci0gICAgR3JhcGhpY3NDb250ZXh0M0QqIGFjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0 KCk7CisgICAgYm9vbCBjcmVhdGVFdmFzT2JqZWN0Rm9yQWNjZWxlcmF0ZWRDb21wb3NpdGluZyhF dmFzX05hdGl2ZV9TdXJmYWNlKiwgY29uc3QgV2ViQ29yZTo6SW50UmVjdCYpOworICAgIFdlYkNv cmU6OkdyYXBoaWNzQ29udGV4dDNEKiBhY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dCgpOwog I2VuZGlmCiAKICAgICBFdmFzX09iamVjdCogdmlldygpIHsgcmV0dXJuIG1fdmlldzsgfQo= 151134 2012-07-06 23:25:18 -0700 2012-07-07 18:03:10 -0700 patch ac_build_fail.patch text/plain 2612 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBiODAzMjNiLi40M2NhOGM2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDctMDYgIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNh bXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIEZpeCBidWlsZCBicmVhayB3aGVuIEFjY2VsZXJh dGVkIENvbXBvc2l0aW5nIGlzIG9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTA3MTgKKworICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KKwor ICAgICAgICBld2tfdmlld19hY2NlbGVyYXRlZF9jb21wb3NpdGluZ19YWFggQVBJcyBhcmUgaW4g ZXdrX3ZpZXdfcHJpdmF0ZS5oCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9QYWdlQ2xpZW50 RWZsLmNwcDoKKyAgICAgICAgKFBhZ2VDbGllbnRFZmw6OmNyZWF0ZUV2YXNPYmplY3RGb3JBY2Nl bGVyYXRlZENvbXBvc2l0aW5nKToKKyAgICAgICAgKFBhZ2VDbGllbnRFZmw6OmFjY2VsZXJhdGVk Q29tcG9zaXRpbmdDb250ZXh0KToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9QYWdlQ2xpZW50 RWZsLmg6CisgICAgICAgIChQYWdlQ2xpZW50RWZsKToKKwogMjAxMi0wNy0wNiAgU2Vva2p1IEt3 b24gIDxzZW9ranUua3dvbkBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBBZGQgV2ViIElu c3BlY3RvciB0byBXZWJLaXQtRUZMCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJD b3JlU3VwcG9ydC9QYWdlQ2xpZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVT dXBwb3J0L1BhZ2VDbGllbnRFZmwuY3BwCmluZGV4IDI1ZmJkNzUuLjZkNDA5YzAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRFZmwuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRFZmwuY3BwCkBA IC0yMCw3ICsyMCw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiUGFnZUNsaWVu dEVmbC5oIgogCi0jaW5jbHVkZSAiZXdrX3ByaXZhdGUuaCIKKyNpbmNsdWRlICJld2tfdmlld19w cml2YXRlLmgiCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNzIEludFJlY3Q7CkBAIC0zNywx MiArMzcsMTIgQEAgUGFnZUNsaWVudEVmbDo6flBhZ2VDbGllbnRFZmwoKQogfQogCiAjaWYgVVNF KEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQotYm9vbCBQYWdlQ2xpZW50RWZsOjpjcmVhdGVFdmFz T2JqZWN0Rm9yQWNjZWxlcmF0ZWRDb21wb3NpdGluZyhFdmFzX05hdGl2ZV9TdXJmYWNlKiBuYXRp dmVTdXJmYWNlLCBjb25zdCBJbnRSZWN0JiByZWN0KQorYm9vbCBQYWdlQ2xpZW50RWZsOjpjcmVh dGVFdmFzT2JqZWN0Rm9yQWNjZWxlcmF0ZWRDb21wb3NpdGluZyhFdmFzX05hdGl2ZV9TdXJmYWNl KiBuYXRpdmVTdXJmYWNlLCBjb25zdCBXZWJDb3JlOjpJbnRSZWN0JiByZWN0KQogewogICAgIHJl dHVybiBld2tfdmlld19hY2NlbGVyYXRlZF9jb21wb3NpdGluZ19vYmplY3RfY3JlYXRlKG1fdmll dywgbmF0aXZlU3VyZmFjZSwgcmVjdCk7CiB9CiAKLUdyYXBoaWNzQ29udGV4dDNEKiBQYWdlQ2xp ZW50RWZsOjphY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dCgpCitXZWJDb3JlOjpHcmFwaGlj c0NvbnRleHQzRCogUGFnZUNsaWVudEVmbDo6YWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQo KQogewogICAgIHJldHVybiBld2tfdmlld19hY2NlbGVyYXRlZF9jb21wb3NpdGluZ19jb250ZXh0 X2dldChtX3ZpZXcpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1 cHBvcnQvUGFnZUNsaWVudEVmbC5oIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQv UGFnZUNsaWVudEVmbC5oCmluZGV4IGI5NTgyM2MuLjZmOThkNzAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRFZmwuaAorKysgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9QYWdlQ2xpZW50RWZsLmgKQEAgLTM1LDggKzM1LDgg QEAgcHVibGljOgogICAgIHZpcnR1YWwgflBhZ2VDbGllbnRFZmwoKTsKIAogI2lmIFVTRShBQ0NF TEVSQVRFRF9DT01QT1NJVElORykKLSAgICBib29sIGNyZWF0ZUV2YXNPYmplY3RGb3JBY2NlbGVy YXRlZENvbXBvc2l0aW5nKEV2YXNfTmF0aXZlX1N1cmZhY2UqLCBjb25zdCBJbnRSZWN0Jik7Ci0g ICAgR3JhcGhpY3NDb250ZXh0M0QqIGFjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0KCk7Cisg ICAgYm9vbCBjcmVhdGVFdmFzT2JqZWN0Rm9yQWNjZWxlcmF0ZWRDb21wb3NpdGluZyhFdmFzX05h dGl2ZV9TdXJmYWNlKiwgY29uc3QgV2ViQ29yZTo6SW50UmVjdCYpOworICAgIFdlYkNvcmU6Okdy YXBoaWNzQ29udGV4dDNEKiBhY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dCgpOwogI2VuZGlm CiAKICAgICBFdmFzX09iamVjdCogdmlldygpIHsgcmV0dXJuIG1fdmlldzsgfQo=