90714 2012-07-06 17:29:29 -0700 Add MIPS convertibleLoadPtr and other functions 2012-07-11 12:48:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 fu webkit-unassigned oliver webkit.review.bot oldest_to_newest 664307 0 fu 2012-07-06 17:29:29 -0700 I will post a patch to fix MIPS build soon. Thanks! 664318 1 151126 fu 2012-07-06 17:50:51 -0700 Created attachment 151126 Add MIPS labelIgnoringWatchpoints, replaceWithLoad, replaceWithAddressComputation, convertibleLoadPtr Here is the patch to add necessary functions. JSC testing is ok. Thanks a lot! 666946 2 oliver 2012-07-11 12:24:38 -0700 Sorry for the delay 666965 3 151126 webkit.review.bot 2012-07-11 12:48:46 -0700 Comment on attachment 151126 Add MIPS labelIgnoringWatchpoints, replaceWithLoad, replaceWithAddressComputation, convertibleLoadPtr Clearing flags on attachment: 151126 Committed r122357: <http://trac.webkit.org/changeset/122357> 666966 4 webkit.review.bot 2012-07-11 12:48:50 -0700 All reviewed patches have been landed. Closing bug. 151126 2012-07-06 17:50:51 -0700 2012-07-11 12:48:46 -0700 Add MIPS labelIgnoringWatchpoints, replaceWithLoad, replaceWithAddressComputation, convertibleLoadPtr mips-20120706.diff text/plain 3349 fu SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIyMDQ2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDEyLTA3LTA2ICBDaGFvLXlpbmcgRnUgIDxmdUBtaXBzLmNvbT4KKworICAgICAgICBBZGQg TUlQUyBjb252ZXJ0aWJsZUxvYWRQdHIgYW5kIG90aGVyIGZ1bmN0aW9ucworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA3MTQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFzc2VtYmxlci9NSVBTQXNzZW1i bGVyLmg6CisgICAgICAgIChKU0M6Ok1JUFNBc3NlbWJsZXI6OmxhYmVsSWdub3JpbmdXYXRjaHBv aW50cyk6CisgICAgICAgIChNSVBTQXNzZW1ibGVyKToKKyAgICAgICAgKEpTQzo6TUlQU0Fzc2Vt Ymxlcjo6cmVwbGFjZVdpdGhMb2FkKToKKyAgICAgICAgKEpTQzo6TUlQU0Fzc2VtYmxlcjo6cmVw bGFjZVdpdGhBZGRyZXNzQ29tcHV0YXRpb24pOgorICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fz c2VtYmxlck1JUFMuaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBTOjpjb252ZXJ0 aWJsZUxvYWRQdHIpOgorICAgICAgICAoTWFjcm9Bc3NlbWJsZXJNSVBTKToKKwogMjAxMi0wNy0w NiAgUHJhdmluIEQgIDxwcmF2aW5kLjJrNEBnbWFpbC5jb20+CiAKICAgICAgICAgQnVpbGQgRXJy b3Igb24gUXQgTGludXggYnVpbGQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTUlQU0Fzc2VtYmxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCShyZXZpc2lvbiAxMjE5NTIpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaAkod29ya2luZyBjb3B5KQpAQCAt NjE2LDYgKzYxNiwxMSBAQCBwdWJsaWM6CiAKICAgICAvLyBHZW5lcmFsIGhlbHBlcnMKIAorICAg IEFzc2VtYmxlckxhYmVsIGxhYmVsSWdub3JpbmdXYXRjaHBvaW50cygpCisgICAgeworICAgICAg ICByZXR1cm4gbV9idWZmZXIubGFiZWwoKTsKKyAgICB9CisKICAgICBBc3NlbWJsZXJMYWJlbCBs YWJlbCgpCiAgICAgewogICAgICAgICByZXR1cm4gbV9idWZmZXIubGFiZWwoKTsKQEAgLTgwOSw2 ICs4MTQsMjggQEAgcHVibGljOgogI2VuZGlmCiAgICAgfQogCisgICAgc3RhdGljIHZvaWQgcmVw bGFjZVdpdGhMb2FkKHZvaWQqIGluc3RydWN0aW9uU3RhcnQpCisgICAgeworICAgICAgICBNSVBT V29yZCogaW5zbiA9IHJlaW50ZXJwcmV0X2Nhc3Q8TUlQU1dvcmQqPihpbnN0cnVjdGlvblN0YXJ0 KTsKKyAgICAgICAgQVNTRVJUKCgqaW5zbiAmIDB4ZmZlMDAwMDApID09IDB4M2MwMDAwMDApOyAv LyBsdWkKKyAgICAgICAgaW5zbisrOworICAgICAgICBBU1NFUlQoKCppbnNuICYgMHhmYzAwMDdm ZikgPT0gMHgwMDAwMDAyMSk7IC8vIGFkZHUKKyAgICAgICAgaW5zbisrOworICAgICAgICAqaW5z biA9IDB4OGMwMDAwMDAgfCAoKCppbnNuKSAmIDB4M2ZmZmZmZik7IC8vIGx3CisgICAgICAgIGNh Y2hlRmx1c2goaW5zbiwgNCk7CisgICAgfQorCisgICAgc3RhdGljIHZvaWQgcmVwbGFjZVdpdGhB ZGRyZXNzQ29tcHV0YXRpb24odm9pZCogaW5zdHJ1Y3Rpb25TdGFydCkKKyAgICB7CisgICAgICAg IE1JUFNXb3JkKiBpbnNuID0gcmVpbnRlcnByZXRfY2FzdDxNSVBTV29yZCo+KGluc3RydWN0aW9u U3RhcnQpOworICAgICAgICBBU1NFUlQoKCppbnNuICYgMHhmZmUwMDAwMCkgPT0gMHgzYzAwMDAw MCk7IC8vIGx1aQorICAgICAgICBpbnNuKys7CisgICAgICAgIEFTU0VSVCgoKmluc24gJiAweGZj MDAwN2ZmKSA9PSAweDAwMDAwMDIxKTsgLy8gYWRkdQorICAgICAgICBpbnNuKys7CisgICAgICAg ICppbnNuID0gMHgyNDAwMDAwMCB8ICgoKmluc24pICYgMHgzZmZmZmZmKTsgLy8gYWRkaXUKKyAg ICAgICAgY2FjaGVGbHVzaChpbnNuLCA0KTsKKyAgICB9CisKIHByaXZhdGU6CiAgICAgLyogVXBk YXRlIGVhY2gganVtcCBpbiB0aGUgYnVmZmVyIG9mIG5ld0Jhc2UuICAqLwogICAgIHZvaWQgcmVs b2NhdGVKdW1wcyh2b2lkKiBvbGRCYXNlLCB2b2lkKiBuZXdCYXNlKQpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCShy ZXZpc2lvbiAxMjE5NTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3Jv QXNzZW1ibGVyTUlQUy5oCSh3b3JraW5nIGNvcHkpCkBAIC00OTYsNiArNDk2LDIwIEBAIHB1Ymxp YzoKICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQogCisgICAgQ29udmVydGli bGVMb2FkTGFiZWwgY29udmVydGlibGVMb2FkUHRyKEFkZHJlc3MgYWRkcmVzcywgUmVnaXN0ZXJJ RCBkZXN0KQorICAgIHsKKyAgICAgICAgQ29udmVydGlibGVMb2FkTGFiZWwgcmVzdWx0KHRoaXMp OworICAgICAgICAvKgorICAgICAgICAgICAgbHVpICAgICBhZGRyVGVtcCwgKG9mZnNldCArIDB4 ODAwMCkgPj4gMTYKKyAgICAgICAgICAgIGFkZHUgICAgYWRkclRlbXAsIGFkZHJUZW1wLCBiYXNl CisgICAgICAgICAgICBsdyAgICAgIGRlc3QsIChvZmZzZXQgJiAweGZmZmYpKGFkZHJUZW1wKQor ICAgICAgICAqLworICAgICAgICBtX2Fzc2VtYmxlci5sdWkoYWRkclRlbXBSZWdpc3RlciwgKGFk ZHJlc3Mub2Zmc2V0ICsgMHg4MDAwKSA+PiAxNik7CisgICAgICAgIG1fYXNzZW1ibGVyLmFkZHUo YWRkclRlbXBSZWdpc3RlciwgYWRkclRlbXBSZWdpc3RlciwgYWRkcmVzcy5iYXNlKTsKKyAgICAg ICAgbV9hc3NlbWJsZXIubHcoZGVzdCwgYWRkclRlbXBSZWdpc3RlciwgYWRkcmVzcy5vZmZzZXQp OworICAgICAgICByZXR1cm4gcmVzdWx0OworICAgIH0KKwogICAgIC8vIE1lbW9yeSBhY2Nlc3Mg b3BlcmF0aW9uczoKICAgICAvLwogICAgIC8vIExvYWRzIGFyZSBvZiB0aGUgZm9ybSBsb2FkKGFk ZHJlc3MsIGRlc3RpbmF0aW9uKSBhbmQgc3RvcmVzIG9mIHRoZSBmb3JtCg==