90705 2012-07-06 14:50:16 -0700 [Qt] Avoid deep copy of QImage in GraphicsContext3D::getImageData() 2012-07-06 15:45:16 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 lauro.neto webkit-unassigned webkit.review.bot oldest_to_newest 664270 0 lauro.neto 2012-07-06 14:50:16 -0700 getImageData is using non-const QImage.bits() as the first argument to packPixels, which expects a const uchar*. This is causing a deep copy of the QImage for each call. 664271 1 151118 lauro.neto 2012-07-06 14:55:02 -0700 Created attachment 151118 Use QImage.constBits instead of bits 664278 2 151118 webkit.review.bot 2012-07-06 15:45:12 -0700 Comment on attachment 151118 Use QImage.constBits instead of bits Clearing flags on attachment: 151118 Committed r122037: <http://trac.webkit.org/changeset/122037> 664279 3 webkit.review.bot 2012-07-06 15:45:16 -0700 All reviewed patches have been landed. Closing bug. 151118 2012-07-06 14:55:02 -0700 2012-07-06 15:45:12 -0700 Use QImage.constBits instead of bits bug-90705-20120706185500.patch text/plain 1701 lauro.neto U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTM5MDYyZDgxNTM4ZjI2 MjM0MzgzYzdmZTQ1YzIzMTkyZDAxMjc1Ny4uYzU2OTA4NTJjZjBkOGM2Y2EwZWYzZGM3NmEyY2I1 YzE5ZTgzMzg3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTA2ICBMYXVy byBOZXRvICA8bGF1cm8ubmV0b0BvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtRdF0gQXZvaWQg ZGVlcCBjb3B5IG9mIFFJbWFnZSBpbiBHcmFwaGljc0NvbnRleHQzRDo6Z2V0SW1hZ2VEYXRhKCkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwNzA1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIFFJbWFn ZS5jb25zdEJpdHMoKSBhcyBhcmd1bWVudCB0byBwYWNrUGl4ZWxzIGluc3RlYWQgb2YgYml0cygp IHRvIGF2b2lkCisgICAgICAgIGRlZXAgY29weWluZyBpdC4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 R3JhcGhpY3NDb250ZXh0M0Q6OmdldEltYWdlRGF0YSk6CisKIDIwMTItMDctMDYgIEp1c3RpbiBO b3Zvc2FkICA8anVub3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIERyYXdpbmcgdG8gYWNjZWxl cmF0ZWQgMkQgY2FudmFzIGNhdXNlcyBjb21wb3NpdG9yIHRvIHJlY29tcHV0ZSBsYXllciB0cmVl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGlj c0NvbnRleHQzRFF0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dy YXBoaWNzQ29udGV4dDNEUXQuY3BwCmluZGV4IDcwZDNmMjRhZmE1NTQyYTY4YTEyNDFkMzgxYzNj ZTkzNDg3ODE4ODUuLjcyYjZiYjQzMDdiM2I2MWQzMmFlZDBkM2UzMDIxZjE1MjMyOTdlOGQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29u dGV4dDNEUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dy YXBoaWNzQ29udGV4dDNEUXQuY3BwCkBAIC01MjksNyArNTI5LDcgQEAgYm9vbCBHcmFwaGljc0Nv bnRleHQzRDo6Z2V0SW1hZ2VEYXRhKEltYWdlKiBpbWFnZSwKIAogICAgIG91dHB1dFZlY3Rvci5y ZXNpemUocGFja2VkU2l6ZSk7CiAKLSAgICByZXR1cm4gcGFja1BpeGVscyhxdEltYWdlLmJpdHMo KSwgU291cmNlRm9ybWF0QkdSQTgsIGltYWdlLT53aWR0aCgpLCBpbWFnZS0+aGVpZ2h0KCksIDAs IGZvcm1hdCwgdHlwZSwgYWxwaGFPcCwgb3V0cHV0VmVjdG9yLmRhdGEoKSk7CisgICAgcmV0dXJu IHBhY2tQaXhlbHMocXRJbWFnZS5jb25zdEJpdHMoKSwgU291cmNlRm9ybWF0QkdSQTgsIGltYWdl LT53aWR0aCgpLCBpbWFnZS0+aGVpZ2h0KCksIDAsIGZvcm1hdCwgdHlwZSwgYWxwaGFPcCwgb3V0 cHV0VmVjdG9yLmRhdGEoKSk7CiB9CiAKIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnNldENvbnRl eHRMb3N0Q2FsbGJhY2soUGFzc093blB0cjxDb250ZXh0TG9zdENhbGxiYWNrPikK