90701 2012-07-06 13:35:25 -0700 WebKit2 doesn't build with recent clang 2012-08-12 04:29:49 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 nlopes webkit-unassigned ap jonlee laszlo.gombos webkit.review.bot oldest_to_newest 664248 0 nlopes 2012-07-06 13:35:25 -0700 WebKit2 doesn't build with recent clang. 664250 1 151115 nlopes 2012-07-06 13:37:33 -0700 Created attachment 151115 fix warnings by the new -Wunused-private-field 664254 2 151115 webkit-ews 2012-07-06 13:42:46 -0700 Comment on attachment 151115 fix warnings by the new -Wunused-private-field Attachment 151115 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13143573 664264 3 151117 nlopes 2012-07-06 14:16:05 -0700 Created attachment 151117 fix warnings by the new -Wunused-private-field (take #2) 664366 4 ap 2012-07-07 01:23:45 -0700 I wonder what these notification-related files are not in an ifdef as a whole. Perhaps projects that don't enable notifications should not include them at all? 664399 5 jonlee 2012-07-07 12:08:38 -0700 (In reply to comment #4) > I wonder what these notification-related files are not in an ifdef as a whole. Perhaps projects that don't enable notifications should not include them at all? That makes sense. 664893 6 nlopes 2012-07-09 08:42:07 -0700 (In reply to comment #4) > I wonder what these notification-related files are not in an ifdef as a whole. Perhaps projects that don't enable notifications should not include them at all? Well, it makes sense to me, but I don't know anything about webkit's code nor I do work on anything related. I was just trying to fix the build for me :) If this enables a better fix, the better, but I' certainly not able to do more complex changes. 693220 7 151117 eric 2012-08-12 03:40:49 -0700 Comment on attachment 151117 fix warnings by the new -Wunused-private-field (take #2) rs=me. 693241 8 151117 webkit.review.bot 2012-08-12 04:29:45 -0700 Comment on attachment 151117 fix warnings by the new -Wunused-private-field (take #2) Clearing flags on attachment: 151117 Committed r125370: <http://trac.webkit.org/changeset/125370> 693242 9 webkit.review.bot 2012-08-12 04:29:49 -0700 All reviewed patches have been landed. Closing bug. 151115 2012-07-06 13:37:33 -0700 2012-07-06 14:16:05 -0700 fix warnings by the new -Wunused-private-field webkit.90701.patch text/plain 4530 nlopes SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMjAzMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTA2ICBOdW5vIExv cGVzICA8bmxvcGVzQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgd2l0aCByZWNlbnQg Y2xhbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MDcwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2hhcmVkL0NvbW1hbmRMaW5lLmg6CisgICAgICAgIChDb21tYW5kTGluZSk6CisgICAgICAgICog V2ViUHJvY2Vzcy9Ob3RpZmljYXRpb25zL05vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFu YWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0 TWFuYWdlcjo6Y3JlYXRlKToKKyAgICAgICAgKFdlYktpdDo6Tm90aWZpY2F0aW9uUGVybWlzc2lv blJlcXVlc3RNYW5hZ2VyOjpOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIpOgor ICAgICAgICAqIFdlYlByb2Nlc3MvTm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25QZXJtaXNzaW9u UmVxdWVzdE1hbmFnZXIuaDoKKyAgICAgICAgKE5vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0 TWFuYWdlcik6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJQYWdlOjpub3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFn ZXIpOgorCiAyMDEyLTA3LTA2ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBp bnRlbC5jb20+CiAKICAgICAgICAgW1dLMl0gQWRkIHN1cHBvcnQgZm9yIE5ldHdvcmsgSW5mb3Jt YXRpb24gQVBJCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29tbWFuZExpbmUuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29tbWFuZExpbmUuaAkocmV2aXNpb24g MTIyMDE3KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL0NvbW1hbmRMaW5lLmgJKHdvcmtpbmcg Y29weSkKQEAgLTQ4LDggKzQ4LDYgQEAgcHVibGljOgogICAgIH0KIAogcHJpdmF0ZToKLSAgICBi b29sIG1fcGFyc2VkU3VjY2Vzc2Z1bGx5OwotCiAgICAgSGFzaE1hcDxTdHJpbmcsIFN0cmluZz4g bV9hcmdzOwogfTsKIApJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Ob3RpZmljYXRp b25zL05vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlci5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Ob3RpZmljYXRpb25zL05vdGlmaWNhdGlvblBl cm1pc3Npb25SZXF1ZXN0TWFuYWdlci5jcHAJKHJldmlzaW9uIDEyMjAxNykKKysrIFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvTm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25QZXJtaXNzaW9uUmVx dWVzdE1hbmFnZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OSwxMyArNDksMTIgQEAgc3RhdGlj IHVpbnQ2NF90IGdlbmVyYXRlUmVxdWVzdElEKCkKIH0KICNlbmRpZgogCi1QYXNzUmVmUHRyPE5v dGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlcj4gTm90aWZpY2F0aW9uUGVybWlzc2lv blJlcXVlc3RNYW5hZ2VyOjpjcmVhdGUoV2ViUGFnZSogcGFnZSkKK1Bhc3NSZWZQdHI8Tm90aWZp Y2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyPiBOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVx dWVzdE1hbmFnZXI6OmNyZWF0ZSgpCiB7Ci0gICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBOb3RpZmlj YXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIocGFnZSkpOworICAgIHJldHVybiBhZG9wdFJl ZihuZXcgTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyKTsKIH0KIAotTm90aWZp Y2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyOjpOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVx dWVzdE1hbmFnZXIoV2ViUGFnZSogcGFnZSkKLSAgICA6IG1fcGFnZShwYWdlKQorTm90aWZpY2F0 aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyOjpOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVz dE1hbmFnZXIoKQogewogfQogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05vdGlm aWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Ob3RpZmljYXRpb25zL05vdGlmaWNhdGlv blBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlci5oCShyZXZpc2lvbiAxMjIwMTcpCisrKyBTb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJl cXVlc3RNYW5hZ2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ1LDcgKzQ1LDcgQEAgY2xhc3MgV2Vi UGFnZTsKIC8vLyBGSVhNRTogTmVlZCB0byBrZWVwIGEgcXVldWUgb2YgcGVuZGluZyBub3RpZmlj YXRpb25zIHdoaWNoIHBlcm1pc3Npb24gaXMgc3RpbGwgYmVpbmcgcmVxdWVzdGVkLgogY2xhc3Mg Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyIDogcHVibGljIFJlZkNvdW50ZWQ8 Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyPiB7CiBwdWJsaWM6Ci0gICAgc3Rh dGljIFBhc3NSZWZQdHI8Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyPiBjcmVh dGUoV2ViUGFnZSopOworICAgIHN0YXRpYyBQYXNzUmVmUHRyPE5vdGlmaWNhdGlvblBlcm1pc3Np b25SZXF1ZXN0TWFuYWdlcj4gY3JlYXRlKCk7CiAKICNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykK ICAgICB2b2lkIHN0YXJ0UmVxdWVzdChXZWJDb3JlOjpTZWN1cml0eU9yaWdpbiosIFBhc3NSZWZQ dHI8V2ViQ29yZTo6Tm90aWZpY2F0aW9uUGVybWlzc2lvbkNhbGxiYWNrPik7CkBAIC02MSw3ICs2 MSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGRpZFJlY2VpdmVOb3RpZmljYXRpb25QZXJtaXNzaW9u RGVjaXNpb24odWludDY0X3Qgbm90aWZpY2F0aW9uSUQsIGJvb2wgYWxsb3dlZCk7CiAgICAgCiBw cml2YXRlOgotICAgIE5vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlcihXZWJQYWdl Kik7CisgICAgTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyKCk7CiAKICNpZiBF TkFCTEUoTk9USUZJQ0FUSU9OUykKICAgICBIYXNoTWFwPHVpbnQ2NF90LCBSZWZQdHI8V2ViQ29y ZTo6Tm90aWZpY2F0aW9uUGVybWlzc2lvbkNhbGxiYWNrPiA+IG1faWRUb0NhbGxiYWNrTWFwOwpA QCAtNzEsOCArNzEsNiBAQCBwcml2YXRlOgogI2VuZGlmCiAgICAgSGFzaE1hcDxSZWZQdHI8V2Vi Q29yZTo6U2VjdXJpdHlPcmlnaW4+LCB1aW50NjRfdD4gbV9vcmlnaW5Ub0lETWFwOwogICAgIEhh c2hNYXA8dWludDY0X3QsIFJlZlB0cjxXZWJDb3JlOjpTZWN1cml0eU9yaWdpbj4gPiBtX2lkVG9P cmlnaW5NYXA7Ci0KLSAgICBXZWJQYWdlKiBtX3BhZ2U7CiB9OwogCiBpbmxpbmUgYm9vbCBpc1Jl cXVlc3RJRFZhbGlkKHVpbnQ2NF90IGlkKQpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkocmV2aXNpb24gMTIyMDE3KQorKysgU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y MTAwLDcgKzIxMDAsNyBAQCBOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIqIFdl CiAgICAgaWYgKG1fbm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyKQogICAgICAg ICByZXR1cm4gbV9ub3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIuZ2V0KCk7CiAK LSAgICBtX25vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlciA9IE5vdGlmaWNhdGlv blBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlcjo6Y3JlYXRlKHRoaXMpOworICAgIG1fbm90aWZpY2F0 aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyID0gTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVl c3RNYW5hZ2VyOjpjcmVhdGUoKTsKICAgICByZXR1cm4gbV9ub3RpZmljYXRpb25QZXJtaXNzaW9u UmVxdWVzdE1hbmFnZXIuZ2V0KCk7CiB9CiAK 151117 2012-07-06 14:16:05 -0700 2012-08-12 04:29:44 -0700 fix warnings by the new -Wunused-private-field (take #2) webkit.90701.patch text/plain 2529 nlopes SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMjAzNCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTA2ICBOdW5vIExv cGVzICA8bmxvcGVzQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgd2l0aCByZWNlbnQg Y2xhbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MDcwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2hhcmVkL0NvbW1hbmRMaW5lLmg6CisgICAgICAgIChDb21tYW5kTGluZSk6CisgICAgICAgICog V2ViUHJvY2Vzcy9Ob3RpZmljYXRpb25zL05vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFu YWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0 TWFuYWdlcjo6Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyKToKKyAgICAgICAg KiBXZWJQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RN YW5hZ2VyLmg6CisgICAgICAgIChOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIp OgorCiAyMDEyLTA3LTA2ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRl bC5jb20+CiAKICAgICAgICAgW1dLMl0gQWRkIHN1cHBvcnQgZm9yIE5ldHdvcmsgSW5mb3JtYXRp b24gQVBJCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29tbWFuZExpbmUuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29tbWFuZExpbmUuaAkocmV2aXNpb24gMTIy MDE3KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL0NvbW1hbmRMaW5lLmgJKHdvcmtpbmcgY29w eSkKQEAgLTQ4LDggKzQ4LDYgQEAgcHVibGljOgogICAgIH0KIAogcHJpdmF0ZToKLSAgICBib29s IG1fcGFyc2VkU3VjY2Vzc2Z1bGx5OwotCiAgICAgSGFzaE1hcDxTdHJpbmcsIFN0cmluZz4gbV9h cmdzOwogfTsKIApJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Ob3RpZmljYXRpb25z L05vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Ob3RpZmljYXRpb25zL05vdGlmaWNhdGlvblBlcm1p c3Npb25SZXF1ZXN0TWFuYWdlci5jcHAJKHJldmlzaW9uIDEyMjAxNykKKysrIFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvTm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVz dE1hbmFnZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NSw4ICs1NSwxMSBAQCBQYXNzUmVmUHRy PE5vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0CiB9CiAKIE5vdGlmaWNhdGlvblBlcm1pc3Np b25SZXF1ZXN0TWFuYWdlcjo6Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyKFdl YlBhZ2UqIHBhZ2UpCisjaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpIHx8IEVOQUJMRShMRUdBQ1lf Tk9USUZJQ0FUSU9OUykKICAgICA6IG1fcGFnZShwYWdlKQorI2VuZGlmCiB7CisgICAgKHZvaWQp cGFnZTsKIH0KIAogI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKQpJbmRleDogU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9Ob3RpZmljYXRpb25zL05vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0 TWFuYWdlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTm90aWZp Y2F0aW9ucy9Ob3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIuaAkocmV2aXNpb24g MTIyMDE3KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Ob3RpZmljYXRpb25zL05vdGlm aWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlci5oCSh3b3JraW5nIGNvcHkpCkBAIC03Miw3 ICs3Miw5IEBAIHByaXZhdGU6CiAgICAgSGFzaE1hcDxSZWZQdHI8V2ViQ29yZTo6U2VjdXJpdHlP cmlnaW4+LCB1aW50NjRfdD4gbV9vcmlnaW5Ub0lETWFwOwogICAgIEhhc2hNYXA8dWludDY0X3Qs IFJlZlB0cjxXZWJDb3JlOjpTZWN1cml0eU9yaWdpbj4gPiBtX2lkVG9PcmlnaW5NYXA7CiAKKyNp ZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykgfHwgRU5BQkxFKExFR0FDWV9OT1RJRklDQVRJT05TKQog ICAgIFdlYlBhZ2UqIG1fcGFnZTsKKyNlbmRpZgogfTsKIAogaW5saW5lIGJvb2wgaXNSZXF1ZXN0 SURWYWxpZCh1aW50NjRfdCBpZCkK