90694 2012-07-06 10:10:49 -0700 [BlackBerry] Add an API to explicitly call a JavaScript function with args. 2012-07-06 13:43:42 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 ben webkit-unassigned dglazkov mifenton tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 664166 0 151098 ben 2012-07-06 10:10:49 -0700 Created attachment 151098 patch Add an API to explicitly call a JavaScript function with args. Currently the Blackberry port doesn't expose the JavaScript engine to 3rd parties so they rely upon executeJavaScript which can be slower than necessary and unsafe as eval is used. This new API provides a way to explicitly call a specific JavaScript function with a list of args preventing the case where an argument comes from a untrusted source and tries to escape the arg list to take control of the JavaScript engine. In the future if the Blackberry port introduces a formal way to interact with the JavaScript engine this function should be removed. 664168 1 webkit.review.bot 2012-07-06 10:14:13 -0700 Attachment 151098 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1 Source/WebKit/blackberry/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/blackberry/Api/WebPage.cpp:863: Declaration has space between type name and * in JSStringRef *argList [whitespace/declaration] [3] Source/WebKit/blackberry/Api/WebPage.cpp:864: Declaration has space between type name and * in JSValueRef *argListRef [whitespace/declaration] [3] Source/WebKit/blackberry/Api/WebPage.cpp:873: Use 0 instead of NULL. [readability/null] [5] Source/WebKit/blackberry/Api/WebPage.cpp:878: Use 0 instead of NULL. [readability/null] [5] Source/WebKit/blackberry/Api/WebPage.cpp:892: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebKit/blackberry/Api/WebPage.cpp:933: Use 0 instead of NULL. [readability/null] [5] Source/WebKit/blackberry/Api/WebPage.h:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 8 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 664173 2 151098 yong.li.webkit 2012-07-06 10:21:38 -0700 Comment on attachment 151098 patch View in context: https://bugs.webkit.org/attachment.cgi?id=151098&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:951 > + size_t bufferSize = JSStringGetMaximumUTF8CStringSize(stringRef); > + char* buffer = new char[bufferSize]; > + size_t s2 = JSStringGetUTF8CString(stringRef, buffer, bufferSize); > + returnValue = WebString(buffer, s2); > + delete buffer; should be delete[]. actually we should use Vector<char>. Also, WebString is supposed to be either UTF16 or latin1. probably we should use WebString::fromUtf8()? or consider using std::string? 664174 3 151098 webkit.review.bot 2012-07-06 10:21:41 -0700 Comment on attachment 151098 patch Attachment 151098 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13153358 664205 4 151105 ben 2012-07-06 11:11:06 -0700 Created attachment 151105 updated with corrections from the review 664208 5 webkit.review.bot 2012-07-06 11:17:00 -0700 Attachment 151105 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1 Source/WebKit/blackberry/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 664209 6 151105 yong.li.webkit 2012-07-06 11:20:59 -0700 Comment on attachment 151105 updated with corrections from the review View in context: https://bugs.webkit.org/attachment.cgi?id=151105&action=review LGTM > Source/WebKit/blackberry/Api/WebPage.cpp:897 > + JSObjectRef fn = obj; minor: I prefer long names to short ones. > Source/WebKit/blackberry/ChangeLog:3 > + > + Add an API to explicitly call a JavaScript function with args. should we also put webkit bug number here? 664221 7 151108 ben 2012-07-06 12:08:47 -0700 Created attachment 151108 updated with corrections from the review 664234 8 151108 webkit.review.bot 2012-07-06 12:42:14 -0700 Comment on attachment 151108 updated with corrections from the review Rejecting attachment 151108 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/blackberry/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13143555 664235 9 151111 ben 2012-07-06 12:46:21 -0700 Created attachment 151111 Add reviewed by line to changelog and commit msg 664255 10 151111 webkit.review.bot 2012-07-06 13:43:37 -0700 Comment on attachment 151111 Add reviewed by line to changelog and commit msg Clearing flags on attachment: 151111 Committed r122034: <http://trac.webkit.org/changeset/122034> 664256 11 webkit.review.bot 2012-07-06 13:43:42 -0700 All reviewed patches have been landed. Closing bug. 151098 2012-07-06 10:10:49 -0700 2012-07-06 11:11:06 -0700 patch 0001-2012-07-06-Benjamin-C-Meyer-bmeyer-rim.com.patch text/plain 7589 ben RnJvbSAwMWU1MmQ1Zjg3MTA0MGExNjRlMzQ0YTNiN2FhYWI4YzAwZDhlMWI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxibWV5ZXJAcmltLmNvbT4KRGF0 ZTogTW9uLCAyIEp1bCAyMDEyIDE3OjU3OjIwIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMi0w Ny0wNiAgQmVuamFtaW4gQyBNZXllciAgPGJtZXllckByaW0uY29tPgoKICAgICAgICBBZGQgYW4g QVBJIHRvIGV4cGxpY2l0bHkgY2FsbCBhIEphdmFTY3JpcHQgZnVuY3Rpb24gd2l0aCBhcmdzLgoK ICAgICAgICBDdXJyZW50bHkgdGhlIEJsYWNrYmVycnkgcG9ydCBkb2Vzbid0IGV4cG9zZSB0aGUg SmF2YVNjcmlwdAogICAgICAgIGVuZ2luZSB0byAzcmQgcGFydGllcyBzbyB0aGV5IHJlbHkgdXBv biBleGVjdXRlSmF2YVNjcmlwdAogICAgICAgIHdoaWNoIGNhbiBiZSBzbG93ZXIgdGhhbiBuZWNl c3NhcnkgYW5kIHVuc2FmZSBhcyBldmFsIGlzIHVzZWQuCiAgICAgICAgVGhpcyBuZXcgQVBJIHBy b3ZpZGVzIGEgd2F5IHRvIGV4cGxpY2l0bHkgY2FsbCBhIHNwZWNpZmljCiAgICAgICAgSmF2YVNj cmlwdCBmdW5jdGlvbiB3aXRoIGEgbGlzdCBvZiBhcmdzIHByZXZlbnRpbmcgdGhlIGNhc2UKICAg ICAgICB3aGVyZSBhbiBhcmd1bWVudCBjb21lcyBmcm9tIGEgdW50cnVzdGVkIHNvdXJjZSBhbmQg dHJpZXMgdG8KICAgICAgICBlc2NhcGUgdGhlIGFyZyBsaXN0IHRvIHRha2UgY29udHJvbCBvZiB0 aGUgSmF2YVNjcmlwdCBlbmdpbmUuCgogICAgICAgIEluIHRoZSBmdXR1cmUgaWYgdGhlIEJsYWNr YmVycnkgcG9ydCBpbnRyb2R1Y2VzIGEgZm9ybWFsCiAgICAgICAgd2F5IHRvIGludGVyYWN0IHdp dGggdGhlIEphdmFTY3JpcHQgZW5naW5lIHRoaXMgZnVuY3Rpb24gc2hvdWxkCiAgICAgICAgYmUg cmVtb3ZlZC4KCiAgICAgICAgUFIgMTQ5Mjk0CgogICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgog ICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2U6OmV4ZWN1dGVKYXZhU2NyaXB0RnVu Y3Rpb24pOgogICAgICAgIChXZWJLaXQpOgogICAgICAgICogQXBpL1dlYlBhZ2UuaDoKLS0tCiBT b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwIHwgICA5MiArKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFn ZS5oICAgfCAgICA0ICsKIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAg fCAgIDI3ICsrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAxMjMgaW5zZXJ0aW9ucygrKSwgMCBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAppbmRl eCBiOTM0MzlhLi5kMjljYmI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFn ZS5jcHAKQEAgLTE1OSw2ICsxNTksNyBAQAogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybVNl dHRpbmdzLmg+CiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvQVBJQ2FzdC5oPgogI2luY2x1ZGUg PEphdmFTY3JpcHRDb3JlL0pTQ29udGV4dFJlZi5oPgorI2luY2x1ZGUgPEphdmFTY3JpcHRDb3Jl L0pTU3RyaW5nUmVmLmg+CiAjaW5jbHVkZSA8U2hhcmVkUG9pbnRlci5oPgogI2luY2x1ZGUgPHN5 cy9rZXljb2Rlcy5oPgogI2luY2x1ZGUgPHVuaWNvZGUvdXN0cmluZy5oPiAvLyBwbGF0Zm9ybSBJ Q1UKQEAgLTg2Miw2ICs4NjMsOTcgQEAgYm9vbCBXZWJQYWdlOjpleGVjdXRlSmF2YVNjcmlwdElu SXNvbGF0ZWRXb3JsZChjb25zdCBjaGFyKiBzY3JpcHQsIEphdmFTY3JpcHREYXQKICAgICByZXR1 cm4gZC0+ZXhlY3V0ZUphdmFTY3JpcHRJbklzb2xhdGVkV29ybGQoc291cmNlQ29kZSwgcmV0dXJu VHlwZSwgcmV0dXJuVmFsdWUpOwogfQogCitib29sIFdlYlBhZ2U6OmV4ZWN1dGVKYXZhU2NyaXB0 RnVuY3Rpb24oY29uc3Qgc3RkOjp2ZWN0b3I8c3RkOjpzdHJpbmc+ICZmdW5jdGlvbiwgY29uc3Qg c3RkOjp2ZWN0b3I8c3RkOjpzdHJpbmc+ICZhcmdzLCBKYXZhU2NyaXB0RGF0YVR5cGUmIHJldHVy blR5cGUsIFdlYlN0cmluZyYgcmV0dXJuVmFsdWUpCit7CisgICAgaWYgKCFkLT5tX21haW5GcmFt ZSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIEpTQzo6QmluZGluZ3M6OlJvb3RPYmplY3Qg KnJvb3QgPSBkLT5tX21haW5GcmFtZS0+c2NyaXB0KCktPmJpbmRpbmdSb290T2JqZWN0KCk7Cisg ICAgaWYgKCFyb290KQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgSlNDOjpFeGVjU3RhdGUg KmV4ZWMgPSByb290LT5nbG9iYWxPYmplY3QoKS0+Z2xvYmFsRXhlYygpOworICAgIEpTR2xvYmFs Q29udGV4dFJlZiBjdHggPSB0b0dsb2JhbFJlZihleGVjKTsKKworICAgIEpTU3RyaW5nUmVmICph cmdMaXN0ID0gbmV3IEpTU3RyaW5nUmVmW2FyZ3Muc2l6ZSgpXTsKKyAgICBKU1ZhbHVlUmVmICph cmdMaXN0UmVmID0gbmV3IEpTVmFsdWVSZWZbYXJncy5zaXplKCldOworICAgIGZvciAodW5zaWdu ZWQgaSA9IDA7IGkgPCBhcmdzLnNpemUoKTsgKytpKSB7CisgICAgICAgIEpTU3RyaW5nUmVmIHN0 ciA9IEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKGFyZ3NbaV0uY19zdHIoKSk7CisgICAg ICAgIGFyZ0xpc3RbaV0gPSBzdHI7CisgICAgICAgIEpTVmFsdWVSZWYgc3RyUmVmID0gSlNWYWx1 ZU1ha2VTdHJpbmcoY3R4LCBzdHIpOworICAgICAgICBhcmdMaXN0UmVmW2ldID0gc3RyUmVmOwor ICAgIH0KKworICAgIEpTVmFsdWVSZWYgd2luZG93T2JqZWN0VmFsdWUgPSB3aW5kb3dPYmplY3Qo KTsKKyAgICBKU09iamVjdFJlZiBvYmogPSBKU1ZhbHVlVG9PYmplY3QoY3R4LCB3aW5kb3dPYmpl Y3RWYWx1ZSwgTlVMTCk7CisgICAgSlNPYmplY3RSZWYgdGhpc09iamVjdCA9IG9iajsKKyAgICBm b3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgZnVuY3Rpb24uc2l6ZSgpOyArK2kpIHsKKyAgICAgICAg SlNTdHJpbmdSZWYgc3RyID0gSlNTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoZnVuY3Rpb25b aV0uY19zdHIoKSk7CisgICAgICAgIHRoaXNPYmplY3QgPSBvYmo7CisgICAgICAgIG9iaiA9IEpT VmFsdWVUb09iamVjdChjdHgsIEpTT2JqZWN0R2V0UHJvcGVydHkoY3R4LCBvYmosIHN0ciwgTlVM TCksIE5VTEwpOworICAgICAgICBKU1N0cmluZ1JlbGVhc2Uoc3RyKTsKKyAgICAgICAgaWYgKCFv YmopCisgICAgICAgICAgICBicmVhazsKKyAgICB9CisKKyAgICBKU09iamVjdFJlZiBmbiA9IG9i ajsKKyAgICBKU1ZhbHVlUmVmIHJlc3VsdCA9IDA7CisgICAgSlNWYWx1ZVJlZiBleGNlcHRpb247 CisgICAgaWYgKGZuICYmIHRoaXNPYmplY3QpCisgICAgICAgIHJlc3VsdCA9IEpTT2JqZWN0Q2Fs bEFzRnVuY3Rpb24oY3R4LCBmbiwgdGhpc09iamVjdCwgYXJncy5zaXplKCksIGFyZ0xpc3RSZWYs ICZleGNlcHRpb24pOworCisgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGFyZ3Muc2l6ZSgp OyArK2kpIHsKKyAgICAgICAgSlNTdHJpbmdSZWxlYXNlKGFyZ0xpc3RbaV0pOworICAgIH0KKyAg ICBkZWxldGUgW10gYXJnTGlzdFJlZjsKKyAgICBkZWxldGUgW10gYXJnTGlzdDsKKworICAgIEpT Qzo6SlNWYWx1ZSB2YWx1ZSA9IHRvSlMoZXhlYywgcmVzdWx0KTsKKworICAgIGlmICghdmFsdWUp IHsKKyAgICAgICAgcmV0dXJuVHlwZSA9IEpTRXhjZXB0aW9uOworICAgICAgICBzaXplX3QgYnVm ZmVyU2l6ZSA9IEpTU3RyaW5nR2V0TWF4aW11bVVURjhDU3RyaW5nU2l6ZShleGNlcHRpb24pOwor ICAgICAgICBjaGFyKiBidWZmZXIgPSBuZXcgY2hhcltidWZmZXJTaXplXTsKKyAgICAgICAgc2l6 ZV90IHMyID0gSlNTdHJpbmdHZXRVVEY4Q1N0cmluZyhleGNlcHRpb24sIGJ1ZmZlciwgYnVmZmVy U2l6ZSk7CisgICAgICAgIHJldHVyblZhbHVlID0gV2ViU3RyaW5nKGJ1ZmZlciwgczIpOworICAg ICAgICBkZWxldGUgYnVmZmVyOworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorCisgICAg SlNUeXBlIHR5cGUgPSBKU1ZhbHVlR2V0VHlwZShjdHgsIHJlc3VsdCk7CisKKyAgICBzd2l0Y2gg KHR5cGUpIHsKKyAgICBjYXNlIGtKU1R5cGVOdWxsOgorICAgICAgICByZXR1cm5UeXBlID0gSlNO dWxsOworICAgICAgICBicmVhazsKKyAgICBjYXNlIGtKU1R5cGVCb29sZWFuOgorICAgICAgICBy ZXR1cm5UeXBlID0gSlNCb29sZWFuOworICAgICAgICBicmVhazsKKyAgICBjYXNlIGtKU1R5cGVO dW1iZXI6CisgICAgICAgIHJldHVyblR5cGUgPSBKU051bWJlcjsKKyAgICAgICAgYnJlYWs7Cisg ICAgY2FzZSBrSlNUeXBlU3RyaW5nOgorICAgICAgICByZXR1cm5UeXBlID0gSlNTdHJpbmc7Cisg ICAgICAgIGJyZWFrOworICAgIGNhc2Uga0pTVHlwZU9iamVjdDoKKyAgICAgICAgcmV0dXJuVHlw ZSA9IEpTT2JqZWN0OworICAgICAgICBicmVhazsKKyAgICBjYXNlIGtKU1R5cGVVbmRlZmluZWQ6 CisgICAgZGVmYXVsdDoKKyAgICAgICAgcmV0dXJuVHlwZSA9IEpTVW5kZWZpbmVkOworICAgICAg ICBicmVhazsKKyAgICB9CisKKyAgICBpZiAocmV0dXJuVHlwZSA9PSBKU0Jvb2xlYW4gfHwgcmV0 dXJuVHlwZSA9PSBKU051bWJlciB8fCByZXR1cm5UeXBlID09IEpTU3RyaW5nIHx8IHJldHVyblR5 cGUgPT0gSlNPYmplY3QpIHsKKyAgICAgICAgSlNTdHJpbmdSZWYgc3RyaW5nUmVmID0gSlNWYWx1 ZVRvU3RyaW5nQ29weShjdHgsIHJlc3VsdCwgTlVMTCk7CisgICAgICAgIHNpemVfdCBidWZmZXJT aXplID0gSlNTdHJpbmdHZXRNYXhpbXVtVVRGOENTdHJpbmdTaXplKHN0cmluZ1JlZik7CisgICAg ICAgIGNoYXIqIGJ1ZmZlciA9IG5ldyBjaGFyW2J1ZmZlclNpemVdOworICAgICAgICBzaXplX3Qg czIgPSBKU1N0cmluZ0dldFVURjhDU3RyaW5nKHN0cmluZ1JlZiwgYnVmZmVyLCBidWZmZXJTaXpl KTsKKyAgICAgICAgcmV0dXJuVmFsdWUgPSBXZWJTdHJpbmcoYnVmZmVyLCBzMik7CisgICAgICAg IGRlbGV0ZSBidWZmZXI7CisgICAgfQorCisgICAgcmV0dXJuIHRydWU7Cit9CisKIHZvaWQgV2Vi UGFnZVByaXZhdGU6OnN0b3BDdXJyZW50TG9hZCgpCiB7CiAgICAgLy8gVGhpcyBmdW5jdGlvbiBz aG91bGQgY29udGFpbiBhbGwgY29tbW9uIGNvZGUgdHJpZ2dlcmVkIGJ5IFdlYlBhZ2U6OmxvYWQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5oIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKaW5kZXggOTU5ODgzNi4uOGRjMzNm MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKKysr IGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKQEAgLTI3LDYgKzI3LDgg QEAKICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1XZWJDb250ZXh0Lmg+CiAjaW5jbHVkZSA8 aW1mL2lucHV0X2RhdGEuaD4KICNpbmNsdWRlIDxuZXR3b3JrL05ldHdvcmtSZXF1ZXN0Lmg+Cisj aW5jbHVkZSA8dmVjdG9yPgorI2luY2x1ZGUgPHN0cmluZz4KIAogc3RydWN0IE9wYXF1ZUpTQ29u dGV4dDsKIHR5cGVkZWYgY29uc3Qgc3RydWN0IE9wYXF1ZUpTQ29udGV4dCogSlNDb250ZXh0UmVm OwpAQCAtMTAzLDYgKzEwNSw4IEBAIHB1YmxpYzoKICAgICAvLyBUYWtlcyBhIFVURjE2IGVuY29k ZWQgc2NyaXB0IHRoYXQgaXMgdXNlZCBleHBsaWNpdGx5IGJ5IHRoZSBwYXR0ZXJuIG1hdGNoaW5n IGNvZGUKICAgICBib29sIGV4ZWN1dGVKYXZhU2NyaXB0SW5Jc29sYXRlZFdvcmxkKGNvbnN0IHN0 ZDo6d3N0cmluZyYgc2NyaXB0LCBKYXZhU2NyaXB0RGF0YVR5cGUmIHJldHVyblR5cGUsIFdlYlN0 cmluZyYgcmV0dXJuVmFsdWUpOwogCisgICAgYm9vbCBleGVjdXRlSmF2YVNjcmlwdEZ1bmN0aW9u KGNvbnN0IHN0ZDo6dmVjdG9yPHN0ZDo6c3RyaW5nPiAmc2NyaXB0LCBjb25zdCBzdGQ6OnZlY3Rv cjxzdGQ6OnN0cmluZz4gJmFyZ3MsIEphdmFTY3JpcHREYXRhVHlwZSYgcmV0dXJuVHlwZSwgV2Vi U3RyaW5nJiByZXR1cm5WYWx1ZSk7CisKICAgICB2b2lkIGluaXRpYWxpemVJY29uRGF0YUJhc2Uo KTsKIAogICAgIHZvaWQgc3RvcExvYWRpbmcoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9n CmluZGV4IDAyMzAwOWYuLmQxYmNhY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpA QCAtMSwzICsxLDMwIEBACisyMDEyLTA3LTA2ICBCZW5qYW1pbiBDIE1leWVyICA8Ym1leWVyQHJp bS5jb20+CisKKyAgICAgICAgQWRkIGFuIEFQSSB0byBleHBsaWNpdGx5IGNhbGwgYSBKYXZhU2Ny aXB0IGZ1bmN0aW9uIHdpdGggYXJncy4KKworICAgICAgICBDdXJyZW50bHkgdGhlIEJsYWNrYmVy cnkgcG9ydCBkb2Vzbid0IGV4cG9zZSB0aGUgSmF2YVNjcmlwdAorICAgICAgICBlbmdpbmUgdG8g M3JkIHBhcnRpZXMgc28gdGhleSByZWx5IHVwb24gZXhlY3V0ZUphdmFTY3JpcHQKKyAgICAgICAg d2hpY2ggY2FuIGJlIHNsb3dlciB0aGFuIG5lY2Vzc2FyeSBhbmQgdW5zYWZlIGFzIGV2YWwgaXMg dXNlZC4KKyAgICAgICAgVGhpcyBuZXcgQVBJIHByb3ZpZGVzIGEgd2F5IHRvIGV4cGxpY2l0bHkg Y2FsbCBhIHNwZWNpZmljCisgICAgICAgIEphdmFTY3JpcHQgZnVuY3Rpb24gd2l0aCBhIGxpc3Qg b2YgYXJncyBwcmV2ZW50aW5nIHRoZSBjYXNlCisgICAgICAgIHdoZXJlIGFuIGFyZ3VtZW50IGNv bWVzIGZyb20gYSB1bnRydXN0ZWQgc291cmNlIGFuZCB0cmllcyB0bworICAgICAgICBlc2NhcGUg dGhlIGFyZyBsaXN0IHRvIHRha2UgY29udHJvbCBvZiB0aGUgSmF2YVNjcmlwdCBlbmdpbmUuCisK KyAgICAgICAgSW4gdGhlIGZ1dHVyZSBpZiB0aGUgQmxhY2tiZXJyeSBwb3J0IGludHJvZHVjZXMg YSBmb3JtYWwKKyAgICAgICAgd2F5IHRvIGludGVyYWN0IHdpdGggdGhlIEphdmFTY3JpcHQgZW5n aW5lIHRoaXMgZnVuY3Rpb24gc2hvdWxkCisgICAgICAgIGJlIHJlbW92ZWQuCisKKyAgICAgICAg UFIgMTQ5Mjk0CisKKyAgICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBidWcgVVJM IChPT1BTISkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFn ZTo6ZXhlY3V0ZUphdmFTY3JpcHRGdW5jdGlvbik6CisgICAgICAgIChXZWJLaXQpOgorICAgICAg ICAqIEFwaS9XZWJQYWdlLmg6CisKIDIwMTItMDYtMzAgIEphc29uIExpdSAgPGphc29uLmxpdUB0 b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFdlYlZpZXcvQnJvd3Nl ciBjYXVzZSBibGFuayBzY3JlZW4gd2hlbiBzZWxlY3RpbmcgYSBkcm9wZG93biBmaWVsZC4KLS0g CjEuNy4xCgo= 151105 2012-07-06 11:11:06 -0700 2012-07-06 12:08:47 -0700 updated with corrections from the review 0001-2012-07-06-Benjamin-C-Meyer-bmeyer-rim.com.patch text/plain 7461 ben RnJvbSAxODQzN2FkOTljYzJiYjcwNjFhYmUwZTZhNzIwZDYxOWI1OTgwZTJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxibWV5ZXJAcmltLmNvbT4KRGF0 ZTogTW9uLCAyIEp1bCAyMDEyIDE3OjU3OjIwIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMi0w Ny0wNiAgQmVuamFtaW4gQyBNZXllciAgPGJtZXllckByaW0uY29tPgoKICAgICAgICBBZGQgYW4g QVBJIHRvIGV4cGxpY2l0bHkgY2FsbCBhIEphdmFTY3JpcHQgZnVuY3Rpb24gd2l0aCBhcmdzLgoK ICAgICAgICBDdXJyZW50bHkgdGhlIEJsYWNrYmVycnkgcG9ydCBkb2Vzbid0IGV4cG9zZSB0aGUg SmF2YVNjcmlwdAogICAgICAgIGVuZ2luZSB0byAzcmQgcGFydGllcyBzbyB0aGV5IHJlbHkgdXBv biBleGVjdXRlSmF2YVNjcmlwdAogICAgICAgIHdoaWNoIGNhbiBiZSBzbG93ZXIgdGhhbiBuZWNl c3NhcnkgYW5kIHVuc2FmZSBhcyBldmFsIGlzIHVzZWQuCiAgICAgICAgVGhpcyBuZXcgQVBJIHBy b3ZpZGVzIGEgd2F5IHRvIGV4cGxpY2l0bHkgY2FsbCBhIHNwZWNpZmljCiAgICAgICAgSmF2YVNj cmlwdCBmdW5jdGlvbiB3aXRoIGEgbGlzdCBvZiBhcmdzIHByZXZlbnRpbmcgdGhlIGNhc2UKICAg ICAgICB3aGVyZSBhbiBhcmd1bWVudCBjb21lcyBmcm9tIGEgdW50cnVzdGVkIHNvdXJjZSBhbmQg dHJpZXMgdG8KICAgICAgICBlc2NhcGUgdGhlIGFyZyBsaXN0IHRvIHRha2UgY29udHJvbCBvZiB0 aGUgSmF2YVNjcmlwdCBlbmdpbmUuCgogICAgICAgIEluIHRoZSBmdXR1cmUgaWYgdGhlIEJsYWNr YmVycnkgcG9ydCBpbnRyb2R1Y2VzIGEgZm9ybWFsCiAgICAgICAgd2F5IHRvIGludGVyYWN0IHdp dGggdGhlIEphdmFTY3JpcHQgZW5naW5lIHRoaXMgZnVuY3Rpb24gc2hvdWxkCiAgICAgICAgYmUg cmVtb3ZlZC4KCiAgICAgICAgUFIgMTQ5Mjk0CgogICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgog ICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2U6OmV4ZWN1dGVKYXZhU2NyaXB0RnVu Y3Rpb24pOgogICAgICAgIChXZWJLaXQpOgogICAgICAgICogQXBpL1dlYlBhZ2UuaDoKLS0tCiBT b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwIHwgICA4OCArKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFn ZS5oICAgfCAgICA0ICsrCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nICAgICAg IHwgICAyMyArKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAxMTUgaW5zZXJ0aW9ucygrKSwgMCBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAppbmRl eCBiOTM0MzlhLi42MmI3YjMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFn ZS5jcHAKQEAgLTE1OSw2ICsxNTksNyBAQAogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybVNl dHRpbmdzLmg+CiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvQVBJQ2FzdC5oPgogI2luY2x1ZGUg PEphdmFTY3JpcHRDb3JlL0pTQ29udGV4dFJlZi5oPgorI2luY2x1ZGUgPEphdmFTY3JpcHRDb3Jl L0pTU3RyaW5nUmVmLmg+CiAjaW5jbHVkZSA8U2hhcmVkUG9pbnRlci5oPgogI2luY2x1ZGUgPHN5 cy9rZXljb2Rlcy5oPgogI2luY2x1ZGUgPHVuaWNvZGUvdXN0cmluZy5oPiAvLyBwbGF0Zm9ybSBJ Q1UKQEAgLTg2Miw2ICs4NjMsOTMgQEAgYm9vbCBXZWJQYWdlOjpleGVjdXRlSmF2YVNjcmlwdElu SXNvbGF0ZWRXb3JsZChjb25zdCBjaGFyKiBzY3JpcHQsIEphdmFTY3JpcHREYXQKICAgICByZXR1 cm4gZC0+ZXhlY3V0ZUphdmFTY3JpcHRJbklzb2xhdGVkV29ybGQoc291cmNlQ29kZSwgcmV0dXJu VHlwZSwgcmV0dXJuVmFsdWUpOwogfQogCitib29sIFdlYlBhZ2U6OmV4ZWN1dGVKYXZhU2NyaXB0 RnVuY3Rpb24oY29uc3Qgc3RkOjp2ZWN0b3I8c3RkOjpzdHJpbmc+ICZmdW5jdGlvbiwgY29uc3Qg c3RkOjp2ZWN0b3I8c3RkOjpzdHJpbmc+ICZhcmdzLCBKYXZhU2NyaXB0RGF0YVR5cGUmIHJldHVy blR5cGUsIFdlYlN0cmluZyYgcmV0dXJuVmFsdWUpCit7CisgICAgaWYgKCFkLT5tX21haW5GcmFt ZSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIEpTQzo6QmluZGluZ3M6OlJvb3RPYmplY3Qq IHJvb3QgPSBkLT5tX21haW5GcmFtZS0+c2NyaXB0KCktPmJpbmRpbmdSb290T2JqZWN0KCk7Cisg ICAgaWYgKCFyb290KQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgSlNDOjpFeGVjU3RhdGUq IGV4ZWMgPSByb290LT5nbG9iYWxPYmplY3QoKS0+Z2xvYmFsRXhlYygpOworICAgIEpTR2xvYmFs Q29udGV4dFJlZiBjdHggPSB0b0dsb2JhbFJlZihleGVjKTsKKworICAgIFdURjo6VmVjdG9yPEpT U3RyaW5nUmVmPiBhcmdMaXN0KGFyZ3Muc2l6ZSgpKTsKKyAgICBXVEY6OlZlY3RvcjxKU1ZhbHVl UmVmPiBhcmdMaXN0UmVmKGFyZ3Muc2l6ZSgpKTsKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBp IDwgYXJncy5zaXplKCk7ICsraSkgeworICAgICAgICBKU1N0cmluZ1JlZiBzdHIgPSBKU1N0cmlu Z0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhhcmdzW2ldLmNfc3RyKCkpOworICAgICAgICBhcmdMaXN0 W2ldID0gc3RyOworICAgICAgICBKU1ZhbHVlUmVmIHN0clJlZiA9IEpTVmFsdWVNYWtlU3RyaW5n KGN0eCwgc3RyKTsKKyAgICAgICAgYXJnTGlzdFJlZltpXSA9IHN0clJlZjsKKyAgICB9CisKKyAg ICBKU1ZhbHVlUmVmIHdpbmRvd09iamVjdFZhbHVlID0gd2luZG93T2JqZWN0KCk7CisgICAgSlNP YmplY3RSZWYgb2JqID0gSlNWYWx1ZVRvT2JqZWN0KGN0eCwgd2luZG93T2JqZWN0VmFsdWUsIDAp OworICAgIEpTT2JqZWN0UmVmIHRoaXNPYmplY3QgPSBvYmo7CisgICAgZm9yICh1bnNpZ25lZCBp ID0gMDsgaSA8IGZ1bmN0aW9uLnNpemUoKTsgKytpKSB7CisgICAgICAgIEpTU3RyaW5nUmVmIHN0 ciA9IEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKGZ1bmN0aW9uW2ldLmNfc3RyKCkpOwor ICAgICAgICB0aGlzT2JqZWN0ID0gb2JqOworICAgICAgICBvYmogPSBKU1ZhbHVlVG9PYmplY3Qo Y3R4LCBKU09iamVjdEdldFByb3BlcnR5KGN0eCwgb2JqLCBzdHIsIDApLCAwKTsKKyAgICAgICAg SlNTdHJpbmdSZWxlYXNlKHN0cik7CisgICAgICAgIGlmICghb2JqKQorICAgICAgICAgICAgYnJl YWs7CisgICAgfQorCisgICAgSlNPYmplY3RSZWYgZm4gPSBvYmo7CisgICAgSlNWYWx1ZVJlZiBy ZXN1bHQgPSAwOworICAgIEpTVmFsdWVSZWYgZXhjZXB0aW9uOworICAgIGlmIChmbiAmJiB0aGlz T2JqZWN0KQorICAgICAgICByZXN1bHQgPSBKU09iamVjdENhbGxBc0Z1bmN0aW9uKGN0eCwgZm4s IHRoaXNPYmplY3QsIGFyZ3Muc2l6ZSgpLCBhcmdMaXN0UmVmLmRhdGEoKSwgJmV4Y2VwdGlvbik7 CisKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgYXJncy5zaXplKCk7ICsraSkKKyAgICAg ICAgSlNTdHJpbmdSZWxlYXNlKGFyZ0xpc3RbaV0pOworCisgICAgSlNDOjpKU1ZhbHVlIHZhbHVl ID0gdG9KUyhleGVjLCByZXN1bHQpOworCisgICAgaWYgKCF2YWx1ZSkgeworICAgICAgICByZXR1 cm5UeXBlID0gSlNFeGNlcHRpb247CisgICAgICAgIEpTU3RyaW5nUmVmIHN0cmluZ1JlZiA9IEpT VmFsdWVUb1N0cmluZ0NvcHkoY3R4LCBleGNlcHRpb24sIDApOworICAgICAgICBzaXplX3QgYnVm ZmVyU2l6ZSA9IEpTU3RyaW5nR2V0TWF4aW11bVVURjhDU3RyaW5nU2l6ZShzdHJpbmdSZWYpOwor ICAgICAgICBXVEY6OlZlY3RvcjxjaGFyPiBidWZmZXIoYnVmZmVyU2l6ZSk7CisgICAgICAgIEpT U3RyaW5nR2V0VVRGOENTdHJpbmcoc3RyaW5nUmVmLCBidWZmZXIuZGF0YSgpLCBidWZmZXJTaXpl KTsKKyAgICAgICAgcmV0dXJuVmFsdWUgPSBXZWJTdHJpbmc6OmZyb21VdGY4KGJ1ZmZlci5kYXRh KCkpOworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorCisgICAgSlNUeXBlIHR5cGUgPSBK U1ZhbHVlR2V0VHlwZShjdHgsIHJlc3VsdCk7CisKKyAgICBzd2l0Y2ggKHR5cGUpIHsKKyAgICBj YXNlIGtKU1R5cGVOdWxsOgorICAgICAgICByZXR1cm5UeXBlID0gSlNOdWxsOworICAgICAgICBi cmVhazsKKyAgICBjYXNlIGtKU1R5cGVCb29sZWFuOgorICAgICAgICByZXR1cm5UeXBlID0gSlNC b29sZWFuOworICAgICAgICBicmVhazsKKyAgICBjYXNlIGtKU1R5cGVOdW1iZXI6CisgICAgICAg IHJldHVyblR5cGUgPSBKU051bWJlcjsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBrSlNUeXBl U3RyaW5nOgorICAgICAgICByZXR1cm5UeXBlID0gSlNTdHJpbmc7CisgICAgICAgIGJyZWFrOwor ICAgIGNhc2Uga0pTVHlwZU9iamVjdDoKKyAgICAgICAgcmV0dXJuVHlwZSA9IEpTT2JqZWN0Owor ICAgICAgICBicmVhazsKKyAgICBjYXNlIGtKU1R5cGVVbmRlZmluZWQ6CisgICAgZGVmYXVsdDoK KyAgICAgICAgcmV0dXJuVHlwZSA9IEpTVW5kZWZpbmVkOworICAgICAgICBicmVhazsKKyAgICB9 CisKKyAgICBpZiAocmV0dXJuVHlwZSA9PSBKU0Jvb2xlYW4gfHwgcmV0dXJuVHlwZSA9PSBKU051 bWJlciB8fCByZXR1cm5UeXBlID09IEpTU3RyaW5nIHx8IHJldHVyblR5cGUgPT0gSlNPYmplY3Qp IHsKKyAgICAgICAgSlNTdHJpbmdSZWYgc3RyaW5nUmVmID0gSlNWYWx1ZVRvU3RyaW5nQ29weShj dHgsIHJlc3VsdCwgMCk7CisgICAgICAgIHNpemVfdCBidWZmZXJTaXplID0gSlNTdHJpbmdHZXRN YXhpbXVtVVRGOENTdHJpbmdTaXplKHN0cmluZ1JlZik7CisgICAgICAgIFdURjo6VmVjdG9yPGNo YXI+IGJ1ZmZlcihidWZmZXJTaXplKTsKKyAgICAgICAgSlNTdHJpbmdHZXRVVEY4Q1N0cmluZyhz dHJpbmdSZWYsIGJ1ZmZlci5kYXRhKCksIGJ1ZmZlclNpemUpOworICAgICAgICByZXR1cm5WYWx1 ZSA9IFdlYlN0cmluZzo6ZnJvbVV0ZjgoYnVmZmVyLmRhdGEoKSk7CisgICAgfQorCisgICAgcmV0 dXJuIHRydWU7Cit9CisKIHZvaWQgV2ViUGFnZVByaXZhdGU6OnN0b3BDdXJyZW50TG9hZCgpCiB7 CiAgICAgLy8gVGhpcyBmdW5jdGlvbiBzaG91bGQgY29udGFpbiBhbGwgY29tbW9uIGNvZGUgdHJp Z2dlcmVkIGJ5IFdlYlBhZ2U6OmxvYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9BcGkvV2ViUGFnZS5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdl LmgKaW5kZXggOTU5ODgzNi4uY2YyMTNiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0FwaS9XZWJQYWdlLmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9X ZWJQYWdlLmgKQEAgLTI3LDYgKzI3LDggQEAKICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1X ZWJDb250ZXh0Lmg+CiAjaW5jbHVkZSA8aW1mL2lucHV0X2RhdGEuaD4KICNpbmNsdWRlIDxuZXR3 b3JrL05ldHdvcmtSZXF1ZXN0Lmg+CisjaW5jbHVkZSA8c3RyaW5nPgorI2luY2x1ZGUgPHZlY3Rv cj4KIAogc3RydWN0IE9wYXF1ZUpTQ29udGV4dDsKIHR5cGVkZWYgY29uc3Qgc3RydWN0IE9wYXF1 ZUpTQ29udGV4dCogSlNDb250ZXh0UmVmOwpAQCAtMTAzLDYgKzEwNSw4IEBAIHB1YmxpYzoKICAg ICAvLyBUYWtlcyBhIFVURjE2IGVuY29kZWQgc2NyaXB0IHRoYXQgaXMgdXNlZCBleHBsaWNpdGx5 IGJ5IHRoZSBwYXR0ZXJuIG1hdGNoaW5nIGNvZGUKICAgICBib29sIGV4ZWN1dGVKYXZhU2NyaXB0 SW5Jc29sYXRlZFdvcmxkKGNvbnN0IHN0ZDo6d3N0cmluZyYgc2NyaXB0LCBKYXZhU2NyaXB0RGF0 YVR5cGUmIHJldHVyblR5cGUsIFdlYlN0cmluZyYgcmV0dXJuVmFsdWUpOwogCisgICAgYm9vbCBl eGVjdXRlSmF2YVNjcmlwdEZ1bmN0aW9uKGNvbnN0IHN0ZDo6dmVjdG9yPHN0ZDo6c3RyaW5nPiAm c2NyaXB0LCBjb25zdCBzdGQ6OnZlY3RvcjxzdGQ6OnN0cmluZz4gJmFyZ3MsIEphdmFTY3JpcHRE YXRhVHlwZSYgcmV0dXJuVHlwZSwgV2ViU3RyaW5nJiByZXR1cm5WYWx1ZSk7CisKICAgICB2b2lk IGluaXRpYWxpemVJY29uRGF0YUJhc2UoKTsKIAogICAgIHZvaWQgc3RvcExvYWRpbmcoKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDAyMzAwOWYuLjQyNmY5MGYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA3LTA2ICBCZW5q YW1pbiBDIE1leWVyICA8Ym1leWVyQHJpbS5jb20+CisKKyAgICAgICAgQWRkIGFuIEFQSSB0byBl eHBsaWNpdGx5IGNhbGwgYSBKYXZhU2NyaXB0IGZ1bmN0aW9uIHdpdGggYXJncy4KKworICAgICAg ICBDdXJyZW50bHkgdGhlIEJsYWNrYmVycnkgcG9ydCBkb2Vzbid0IGV4cG9zZSB0aGUgSmF2YVNj cmlwdAorICAgICAgICBlbmdpbmUgdG8gM3JkIHBhcnRpZXMgc28gdGhleSByZWx5IHVwb24gZXhl Y3V0ZUphdmFTY3JpcHQKKyAgICAgICAgd2hpY2ggY2FuIGJlIHNsb3dlciB0aGFuIG5lY2Vzc2Fy eSBhbmQgdW5zYWZlIGFzIGV2YWwgaXMgdXNlZC4KKyAgICAgICAgVGhpcyBuZXcgQVBJIHByb3Zp ZGVzIGEgd2F5IHRvIGV4cGxpY2l0bHkgY2FsbCBhIHNwZWNpZmljCisgICAgICAgIEphdmFTY3Jp cHQgZnVuY3Rpb24gd2l0aCBhIGxpc3Qgb2YgYXJncyBwcmV2ZW50aW5nIHRoZSBjYXNlCisgICAg ICAgIHdoZXJlIGFuIGFyZ3VtZW50IGNvbWVzIGZyb20gYSB1bnRydXN0ZWQgc291cmNlIGFuZCB0 cmllcyB0bworICAgICAgICBlc2NhcGUgdGhlIGFyZyBsaXN0IHRvIHRha2UgY29udHJvbCBvZiB0 aGUgSmF2YVNjcmlwdCBlbmdpbmUuCisKKyAgICAgICAgSW4gdGhlIGZ1dHVyZSBpZiB0aGUgQmxh Y2tiZXJyeSBwb3J0IGludHJvZHVjZXMgYSBmb3JtYWwKKyAgICAgICAgd2F5IHRvIGludGVyYWN0 IHdpdGggdGhlIEphdmFTY3JpcHQgZW5naW5lIHRoaXMgZnVuY3Rpb24gc2hvdWxkCisgICAgICAg IGJlIHJlbW92ZWQuCisKKyAgICAgICAgUFIgMTQ5Mjk0CisKKyAgICAgICAgKiBBcGkvV2ViUGFn ZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2U6OmV4ZWN1dGVKYXZh U2NyaXB0RnVuY3Rpb24pOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBBcGkvV2ViUGFn ZS5oOgorCiAyMDEyLTA2LTMwICBKYXNvbiBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29t LmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBXZWJWaWV3L0Jyb3dzZXIgY2F1c2UgYmxhbmsg c2NyZWVuIHdoZW4gc2VsZWN0aW5nIGEgZHJvcGRvd24gZmllbGQuCi0tIAoxLjcuMQoK 151108 2012-07-06 12:08:47 -0700 2012-07-06 12:46:21 -0700 updated with corrections from the review 0001-2012-07-06-Benjamin-C-Meyer-bmeyer-rim.com.patch text/plain 7606 ben RnJvbSBlMGY1ZDc0OTJmMjE0MzZlYjAzZWU1YjdjYjIxZTljZTg1NDk1MmM0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxibWV5ZXJAcmltLmNvbT4KRGF0 ZTogTW9uLCAyIEp1bCAyMDEyIDE3OjU3OjIwIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMi0w Ny0wNiAgQmVuamFtaW4gQyBNZXllciAgPGJtZXllckByaW0uY29tPgoKICAgICAgICBBZGQgYW4g QVBJIHRvIGV4cGxpY2l0bHkgY2FsbCBhIEphdmFTY3JpcHQgZnVuY3Rpb24gd2l0aCBhcmdzLgog ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDY5NAoKICAg ICAgICBDdXJyZW50bHkgdGhlIEJsYWNrYmVycnkgcG9ydCBkb2Vzbid0IGV4cG9zZSB0aGUgSmF2 YVNjcmlwdAogICAgICAgIGVuZ2luZSB0byAzcmQgcGFydGllcyBzbyB0aGV5IHJlbHkgdXBvbiBl eGVjdXRlSmF2YVNjcmlwdAogICAgICAgIHdoaWNoIGNhbiBiZSBzbG93ZXIgdGhhbiBuZWNlc3Nh cnkgYW5kIHVuc2FmZSBhcyBldmFsIGlzIHVzZWQuCiAgICAgICAgVGhpcyBuZXcgQVBJIHByb3Zp ZGVzIGEgd2F5IHRvIGV4cGxpY2l0bHkgY2FsbCBhIHNwZWNpZmljCiAgICAgICAgSmF2YVNjcmlw dCBmdW5jdGlvbiB3aXRoIGEgbGlzdCBvZiBhcmdzIHByZXZlbnRpbmcgdGhlIGNhc2UKICAgICAg ICB3aGVyZSBhbiBhcmd1bWVudCBjb21lcyBmcm9tIGEgdW50cnVzdGVkIHNvdXJjZSBhbmQgdHJp ZXMgdG8KICAgICAgICBlc2NhcGUgdGhlIGFyZyBsaXN0IHRvIHRha2UgY29udHJvbCBvZiB0aGUg SmF2YVNjcmlwdCBlbmdpbmUuCgogICAgICAgIEluIHRoZSBmdXR1cmUgaWYgdGhlIEJsYWNrYmVy cnkgcG9ydCBpbnRyb2R1Y2VzIGEgZm9ybWFsCiAgICAgICAgd2F5IHRvIGludGVyYWN0IHdpdGgg dGhlIEphdmFTY3JpcHQgZW5naW5lIHRoaXMgZnVuY3Rpb24gc2hvdWxkCiAgICAgICAgYmUgcmVt b3ZlZC4KCiAgICAgICAgUFIgMTQ5Mjk0CgogICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgogICAg ICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2U6OmV4ZWN1dGVKYXZhU2NyaXB0RnVuY3Rp b24pOgogICAgICAgIChXZWJLaXQpOgogICAgICAgICogQXBpL1dlYlBhZ2UuaDoKLS0tCiBTb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwIHwgICA4OCArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5o ICAgfCAgICA0ICsrCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nICAgICAgIHwg ICAyNCArKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAxMTYgaW5zZXJ0aW9ucygrKSwgMCBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBh Z2UuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAppbmRleCBi OTM0MzlhLi5hMzcwMzhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBp L1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j cHAKQEAgLTE1OSw2ICsxNTksNyBAQAogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybVNldHRp bmdzLmg+CiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvQVBJQ2FzdC5oPgogI2luY2x1ZGUgPEph dmFTY3JpcHRDb3JlL0pTQ29udGV4dFJlZi5oPgorI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pT U3RyaW5nUmVmLmg+CiAjaW5jbHVkZSA8U2hhcmVkUG9pbnRlci5oPgogI2luY2x1ZGUgPHN5cy9r ZXljb2Rlcy5oPgogI2luY2x1ZGUgPHVuaWNvZGUvdXN0cmluZy5oPiAvLyBwbGF0Zm9ybSBJQ1UK QEAgLTg2Miw2ICs4NjMsOTMgQEAgYm9vbCBXZWJQYWdlOjpleGVjdXRlSmF2YVNjcmlwdEluSXNv bGF0ZWRXb3JsZChjb25zdCBjaGFyKiBzY3JpcHQsIEphdmFTY3JpcHREYXQKICAgICByZXR1cm4g ZC0+ZXhlY3V0ZUphdmFTY3JpcHRJbklzb2xhdGVkV29ybGQoc291cmNlQ29kZSwgcmV0dXJuVHlw ZSwgcmV0dXJuVmFsdWUpOwogfQogCitib29sIFdlYlBhZ2U6OmV4ZWN1dGVKYXZhU2NyaXB0RnVu Y3Rpb24oY29uc3Qgc3RkOjp2ZWN0b3I8c3RkOjpzdHJpbmc+ICZmdW5jdGlvbiwgY29uc3Qgc3Rk Ojp2ZWN0b3I8c3RkOjpzdHJpbmc+ICZhcmdzLCBKYXZhU2NyaXB0RGF0YVR5cGUmIHJldHVyblR5 cGUsIFdlYlN0cmluZyYgcmV0dXJuVmFsdWUpCit7CisgICAgaWYgKCFkLT5tX21haW5GcmFtZSkK KyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIEpTQzo6QmluZGluZ3M6OlJvb3RPYmplY3QqIHJv b3QgPSBkLT5tX21haW5GcmFtZS0+c2NyaXB0KCktPmJpbmRpbmdSb290T2JqZWN0KCk7CisgICAg aWYgKCFyb290KQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgSlNDOjpFeGVjU3RhdGUqIGV4 ZWMgPSByb290LT5nbG9iYWxPYmplY3QoKS0+Z2xvYmFsRXhlYygpOworICAgIEpTR2xvYmFsQ29u dGV4dFJlZiBjdHggPSB0b0dsb2JhbFJlZihleGVjKTsKKworICAgIFdURjo6VmVjdG9yPEpTU3Ry aW5nUmVmPiBhcmdMaXN0KGFyZ3Muc2l6ZSgpKTsKKyAgICBXVEY6OlZlY3RvcjxKU1ZhbHVlUmVm PiBhcmdMaXN0UmVmKGFyZ3Muc2l6ZSgpKTsKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwg YXJncy5zaXplKCk7ICsraSkgeworICAgICAgICBKU1N0cmluZ1JlZiBzdHIgPSBKU1N0cmluZ0Ny ZWF0ZVdpdGhVVEY4Q1N0cmluZyhhcmdzW2ldLmNfc3RyKCkpOworICAgICAgICBhcmdMaXN0W2ld ID0gc3RyOworICAgICAgICBKU1ZhbHVlUmVmIHN0clJlZiA9IEpTVmFsdWVNYWtlU3RyaW5nKGN0 eCwgc3RyKTsKKyAgICAgICAgYXJnTGlzdFJlZltpXSA9IHN0clJlZjsKKyAgICB9CisKKyAgICBK U1ZhbHVlUmVmIHdpbmRvd09iamVjdFZhbHVlID0gd2luZG93T2JqZWN0KCk7CisgICAgSlNPYmpl Y3RSZWYgb2JqID0gSlNWYWx1ZVRvT2JqZWN0KGN0eCwgd2luZG93T2JqZWN0VmFsdWUsIDApOwor ICAgIEpTT2JqZWN0UmVmIHRoaXNPYmplY3QgPSBvYmo7CisgICAgZm9yICh1bnNpZ25lZCBpID0g MDsgaSA8IGZ1bmN0aW9uLnNpemUoKTsgKytpKSB7CisgICAgICAgIEpTU3RyaW5nUmVmIHN0ciA9 IEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKGZ1bmN0aW9uW2ldLmNfc3RyKCkpOworICAg ICAgICB0aGlzT2JqZWN0ID0gb2JqOworICAgICAgICBvYmogPSBKU1ZhbHVlVG9PYmplY3QoY3R4 LCBKU09iamVjdEdldFByb3BlcnR5KGN0eCwgb2JqLCBzdHIsIDApLCAwKTsKKyAgICAgICAgSlNT dHJpbmdSZWxlYXNlKHN0cik7CisgICAgICAgIGlmICghb2JqKQorICAgICAgICAgICAgYnJlYWs7 CisgICAgfQorCisgICAgSlNPYmplY3RSZWYgZnVuY3Rpb25PYmplY3QgPSBvYmo7CisgICAgSlNW YWx1ZVJlZiByZXN1bHQgPSAwOworICAgIEpTVmFsdWVSZWYgZXhjZXB0aW9uOworICAgIGlmIChm dW5jdGlvbk9iamVjdCAmJiB0aGlzT2JqZWN0KQorICAgICAgICByZXN1bHQgPSBKU09iamVjdENh bGxBc0Z1bmN0aW9uKGN0eCwgZnVuY3Rpb25PYmplY3QsIHRoaXNPYmplY3QsIGFyZ3Muc2l6ZSgp LCBhcmdMaXN0UmVmLmRhdGEoKSwgJmV4Y2VwdGlvbik7CisKKyAgICBmb3IgKHVuc2lnbmVkIGkg PSAwOyBpIDwgYXJncy5zaXplKCk7ICsraSkKKyAgICAgICAgSlNTdHJpbmdSZWxlYXNlKGFyZ0xp c3RbaV0pOworCisgICAgSlNDOjpKU1ZhbHVlIHZhbHVlID0gdG9KUyhleGVjLCByZXN1bHQpOwor CisgICAgaWYgKCF2YWx1ZSkgeworICAgICAgICByZXR1cm5UeXBlID0gSlNFeGNlcHRpb247Cisg ICAgICAgIEpTU3RyaW5nUmVmIHN0cmluZ1JlZiA9IEpTVmFsdWVUb1N0cmluZ0NvcHkoY3R4LCBl eGNlcHRpb24sIDApOworICAgICAgICBzaXplX3QgYnVmZmVyU2l6ZSA9IEpTU3RyaW5nR2V0TWF4 aW11bVVURjhDU3RyaW5nU2l6ZShzdHJpbmdSZWYpOworICAgICAgICBXVEY6OlZlY3RvcjxjaGFy PiBidWZmZXIoYnVmZmVyU2l6ZSk7CisgICAgICAgIEpTU3RyaW5nR2V0VVRGOENTdHJpbmcoc3Ry aW5nUmVmLCBidWZmZXIuZGF0YSgpLCBidWZmZXJTaXplKTsKKyAgICAgICAgcmV0dXJuVmFsdWUg PSBXZWJTdHJpbmc6OmZyb21VdGY4KGJ1ZmZlci5kYXRhKCkpOworICAgICAgICByZXR1cm4gZmFs c2U7CisgICAgfQorCisgICAgSlNUeXBlIHR5cGUgPSBKU1ZhbHVlR2V0VHlwZShjdHgsIHJlc3Vs dCk7CisKKyAgICBzd2l0Y2ggKHR5cGUpIHsKKyAgICBjYXNlIGtKU1R5cGVOdWxsOgorICAgICAg ICByZXR1cm5UeXBlID0gSlNOdWxsOworICAgICAgICBicmVhazsKKyAgICBjYXNlIGtKU1R5cGVC b29sZWFuOgorICAgICAgICByZXR1cm5UeXBlID0gSlNCb29sZWFuOworICAgICAgICBicmVhazsK KyAgICBjYXNlIGtKU1R5cGVOdW1iZXI6CisgICAgICAgIHJldHVyblR5cGUgPSBKU051bWJlcjsK KyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBrSlNUeXBlU3RyaW5nOgorICAgICAgICByZXR1cm5U eXBlID0gSlNTdHJpbmc7CisgICAgICAgIGJyZWFrOworICAgIGNhc2Uga0pTVHlwZU9iamVjdDoK KyAgICAgICAgcmV0dXJuVHlwZSA9IEpTT2JqZWN0OworICAgICAgICBicmVhazsKKyAgICBjYXNl IGtKU1R5cGVVbmRlZmluZWQ6CisgICAgZGVmYXVsdDoKKyAgICAgICAgcmV0dXJuVHlwZSA9IEpT VW5kZWZpbmVkOworICAgICAgICBicmVhazsKKyAgICB9CisKKyAgICBpZiAocmV0dXJuVHlwZSA9 PSBKU0Jvb2xlYW4gfHwgcmV0dXJuVHlwZSA9PSBKU051bWJlciB8fCByZXR1cm5UeXBlID09IEpT U3RyaW5nIHx8IHJldHVyblR5cGUgPT0gSlNPYmplY3QpIHsKKyAgICAgICAgSlNTdHJpbmdSZWYg c3RyaW5nUmVmID0gSlNWYWx1ZVRvU3RyaW5nQ29weShjdHgsIHJlc3VsdCwgMCk7CisgICAgICAg IHNpemVfdCBidWZmZXJTaXplID0gSlNTdHJpbmdHZXRNYXhpbXVtVVRGOENTdHJpbmdTaXplKHN0 cmluZ1JlZik7CisgICAgICAgIFdURjo6VmVjdG9yPGNoYXI+IGJ1ZmZlcihidWZmZXJTaXplKTsK KyAgICAgICAgSlNTdHJpbmdHZXRVVEY4Q1N0cmluZyhzdHJpbmdSZWYsIGJ1ZmZlci5kYXRhKCks IGJ1ZmZlclNpemUpOworICAgICAgICByZXR1cm5WYWx1ZSA9IFdlYlN0cmluZzo6ZnJvbVV0Zjgo YnVmZmVyLmRhdGEoKSk7CisgICAgfQorCisgICAgcmV0dXJuIHRydWU7Cit9CisKIHZvaWQgV2Vi UGFnZVByaXZhdGU6OnN0b3BDdXJyZW50TG9hZCgpCiB7CiAgICAgLy8gVGhpcyBmdW5jdGlvbiBz aG91bGQgY29udGFpbiBhbGwgY29tbW9uIGNvZGUgdHJpZ2dlcmVkIGJ5IFdlYlBhZ2U6OmxvYWQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5oIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKaW5kZXggOTU5ODgzNi4uY2YyMTNi MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKKysr IGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKQEAgLTI3LDYgKzI3LDgg QEAKICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1XZWJDb250ZXh0Lmg+CiAjaW5jbHVkZSA8 aW1mL2lucHV0X2RhdGEuaD4KICNpbmNsdWRlIDxuZXR3b3JrL05ldHdvcmtSZXF1ZXN0Lmg+Cisj aW5jbHVkZSA8c3RyaW5nPgorI2luY2x1ZGUgPHZlY3Rvcj4KIAogc3RydWN0IE9wYXF1ZUpTQ29u dGV4dDsKIHR5cGVkZWYgY29uc3Qgc3RydWN0IE9wYXF1ZUpTQ29udGV4dCogSlNDb250ZXh0UmVm OwpAQCAtMTAzLDYgKzEwNSw4IEBAIHB1YmxpYzoKICAgICAvLyBUYWtlcyBhIFVURjE2IGVuY29k ZWQgc2NyaXB0IHRoYXQgaXMgdXNlZCBleHBsaWNpdGx5IGJ5IHRoZSBwYXR0ZXJuIG1hdGNoaW5n IGNvZGUKICAgICBib29sIGV4ZWN1dGVKYXZhU2NyaXB0SW5Jc29sYXRlZFdvcmxkKGNvbnN0IHN0 ZDo6d3N0cmluZyYgc2NyaXB0LCBKYXZhU2NyaXB0RGF0YVR5cGUmIHJldHVyblR5cGUsIFdlYlN0 cmluZyYgcmV0dXJuVmFsdWUpOwogCisgICAgYm9vbCBleGVjdXRlSmF2YVNjcmlwdEZ1bmN0aW9u KGNvbnN0IHN0ZDo6dmVjdG9yPHN0ZDo6c3RyaW5nPiAmc2NyaXB0LCBjb25zdCBzdGQ6OnZlY3Rv cjxzdGQ6OnN0cmluZz4gJmFyZ3MsIEphdmFTY3JpcHREYXRhVHlwZSYgcmV0dXJuVHlwZSwgV2Vi U3RyaW5nJiByZXR1cm5WYWx1ZSk7CisKICAgICB2b2lkIGluaXRpYWxpemVJY29uRGF0YUJhc2Uo KTsKIAogICAgIHZvaWQgc3RvcExvYWRpbmcoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9n CmluZGV4IDAyMzAwOWYuLjZiODRiMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpA QCAtMSwzICsxLDI3IEBACisyMDEyLTA3LTA2ICBCZW5qYW1pbiBDIE1leWVyICA8Ym1leWVyQHJp bS5jb20+CisKKyAgICAgICAgQWRkIGFuIEFQSSB0byBleHBsaWNpdGx5IGNhbGwgYSBKYXZhU2Ny aXB0IGZ1bmN0aW9uIHdpdGggYXJncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkwNjk0CisKKyAgICAgICAgQ3VycmVudGx5IHRoZSBCbGFja2JlcnJ5 IHBvcnQgZG9lc24ndCBleHBvc2UgdGhlIEphdmFTY3JpcHQKKyAgICAgICAgZW5naW5lIHRvIDNy ZCBwYXJ0aWVzIHNvIHRoZXkgcmVseSB1cG9uIGV4ZWN1dGVKYXZhU2NyaXB0CisgICAgICAgIHdo aWNoIGNhbiBiZSBzbG93ZXIgdGhhbiBuZWNlc3NhcnkgYW5kIHVuc2FmZSBhcyBldmFsIGlzIHVz ZWQuCisgICAgICAgIFRoaXMgbmV3IEFQSSBwcm92aWRlcyBhIHdheSB0byBleHBsaWNpdGx5IGNh bGwgYSBzcGVjaWZpYworICAgICAgICBKYXZhU2NyaXB0IGZ1bmN0aW9uIHdpdGggYSBsaXN0IG9m IGFyZ3MgcHJldmVudGluZyB0aGUgY2FzZQorICAgICAgICB3aGVyZSBhbiBhcmd1bWVudCBjb21l cyBmcm9tIGEgdW50cnVzdGVkIHNvdXJjZSBhbmQgdHJpZXMgdG8KKyAgICAgICAgZXNjYXBlIHRo ZSBhcmcgbGlzdCB0byB0YWtlIGNvbnRyb2wgb2YgdGhlIEphdmFTY3JpcHQgZW5naW5lLgorCisg ICAgICAgIEluIHRoZSBmdXR1cmUgaWYgdGhlIEJsYWNrYmVycnkgcG9ydCBpbnRyb2R1Y2VzIGEg Zm9ybWFsCisgICAgICAgIHdheSB0byBpbnRlcmFjdCB3aXRoIHRoZSBKYXZhU2NyaXB0IGVuZ2lu ZSB0aGlzIGZ1bmN0aW9uIHNob3VsZAorICAgICAgICBiZSByZW1vdmVkLgorCisgICAgICAgIFBS IDE0OTI5NAorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJy eTo6V2ViS2l0OjpXZWJQYWdlOjpleGVjdXRlSmF2YVNjcmlwdEZ1bmN0aW9uKToKKyAgICAgICAg KFdlYktpdCk6CisgICAgICAgICogQXBpL1dlYlBhZ2UuaDoKKwogMjAxMi0wNi0zMCAgSmFzb24g TGl1ICA8amFzb24ubGl1QHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJy eV0gV2ViVmlldy9Ccm93c2VyIGNhdXNlIGJsYW5rIHNjcmVlbiB3aGVuIHNlbGVjdGluZyBhIGRy b3Bkb3duIGZpZWxkLgotLSAKMS43LjEKCg== 151111 2012-07-06 12:46:21 -0700 2012-07-06 13:43:37 -0700 Add reviewed by line to changelog and commit msg 0001-2012-07-06-Benjamin-C-Meyer-bmeyer-rim.com.patch text/plain 7673 ben RnJvbSBhODY4ZTNhYjU2NGU2NTg1MzE5ZjVkZGMwNTNkODFmNDA3YzI5ZmFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxibWV5ZXJAcmltLmNvbT4KRGF0 ZTogTW9uLCAyIEp1bCAyMDEyIDE3OjU3OjIwIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMi0w Ny0wNiAgQmVuamFtaW4gQyBNZXllciAgPGJtZXllckByaW0uY29tPgoKICAgICAgICBBZGQgYW4g QVBJIHRvIGV4cGxpY2l0bHkgY2FsbCBhIEphdmFTY3JpcHQgZnVuY3Rpb24gd2l0aCBhcmdzLgog ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDY5NAoKICAg ICAgICBDdXJyZW50bHkgdGhlIEJsYWNrYmVycnkgcG9ydCBkb2Vzbid0IGV4cG9zZSB0aGUgSmF2 YVNjcmlwdAogICAgICAgIGVuZ2luZSB0byAzcmQgcGFydGllcyBzbyB0aGV5IHJlbHkgdXBvbiBl eGVjdXRlSmF2YVNjcmlwdAogICAgICAgIHdoaWNoIGNhbiBiZSBzbG93ZXIgdGhhbiBuZWNlc3Nh cnkgYW5kIHVuc2FmZSBhcyBldmFsIGlzIHVzZWQuCiAgICAgICAgVGhpcyBuZXcgQVBJIHByb3Zp ZGVzIGEgd2F5IHRvIGV4cGxpY2l0bHkgY2FsbCBhIHNwZWNpZmljCiAgICAgICAgSmF2YVNjcmlw dCBmdW5jdGlvbiB3aXRoIGEgbGlzdCBvZiBhcmdzIHByZXZlbnRpbmcgdGhlIGNhc2UKICAgICAg ICB3aGVyZSBhbiBhcmd1bWVudCBjb21lcyBmcm9tIGEgdW50cnVzdGVkIHNvdXJjZSBhbmQgdHJp ZXMgdG8KICAgICAgICBlc2NhcGUgdGhlIGFyZyBsaXN0IHRvIHRha2UgY29udHJvbCBvZiB0aGUg SmF2YVNjcmlwdCBlbmdpbmUuCgogICAgICAgIEluIHRoZSBmdXR1cmUgaWYgdGhlIEJsYWNrYmVy cnkgcG9ydCBpbnRyb2R1Y2VzIGEgZm9ybWFsCiAgICAgICAgd2F5IHRvIGludGVyYWN0IHdpdGgg dGhlIEphdmFTY3JpcHQgZW5naW5lIHRoaXMgZnVuY3Rpb24gc2hvdWxkCiAgICAgICAgYmUgcmVt b3ZlZC4KCiAgICAgICAgUFIgMTQ5Mjk0CgogICAgICAgIFJldmlld2VkIGJ5IFVucmV2aWV3ZWQK CiAgICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6 V2ViUGFnZTo6ZXhlY3V0ZUphdmFTY3JpcHRGdW5jdGlvbik6CiAgICAgICAgKFdlYktpdCk6CiAg ICAgICAgKiBBcGkvV2ViUGFnZS5oOgotLS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv V2ViUGFnZS5jcHAgfCAgIDg4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmggICB8ICAgIDQgKysKIFNvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgfCAgIDI2ICsrKysrKysrKwogMyBmaWxlcyBj aGFuZ2VkLCAxMTggaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAppbmRleCBiOTM0MzlhLi5hMzcwMzhmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKQEAgLTE1OSw2ICsxNTksNyBAQAog I2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybVNldHRpbmdzLmg+CiAjaW5jbHVkZSA8SmF2YVNj cmlwdENvcmUvQVBJQ2FzdC5oPgogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTQ29udGV4dFJl Zi5oPgorI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTU3RyaW5nUmVmLmg+CiAjaW5jbHVkZSA8 U2hhcmVkUG9pbnRlci5oPgogI2luY2x1ZGUgPHN5cy9rZXljb2Rlcy5oPgogI2luY2x1ZGUgPHVu aWNvZGUvdXN0cmluZy5oPiAvLyBwbGF0Zm9ybSBJQ1UKQEAgLTg2Miw2ICs4NjMsOTMgQEAgYm9v bCBXZWJQYWdlOjpleGVjdXRlSmF2YVNjcmlwdEluSXNvbGF0ZWRXb3JsZChjb25zdCBjaGFyKiBz Y3JpcHQsIEphdmFTY3JpcHREYXQKICAgICByZXR1cm4gZC0+ZXhlY3V0ZUphdmFTY3JpcHRJbklz b2xhdGVkV29ybGQoc291cmNlQ29kZSwgcmV0dXJuVHlwZSwgcmV0dXJuVmFsdWUpOwogfQogCiti b29sIFdlYlBhZ2U6OmV4ZWN1dGVKYXZhU2NyaXB0RnVuY3Rpb24oY29uc3Qgc3RkOjp2ZWN0b3I8 c3RkOjpzdHJpbmc+ICZmdW5jdGlvbiwgY29uc3Qgc3RkOjp2ZWN0b3I8c3RkOjpzdHJpbmc+ICZh cmdzLCBKYXZhU2NyaXB0RGF0YVR5cGUmIHJldHVyblR5cGUsIFdlYlN0cmluZyYgcmV0dXJuVmFs dWUpCit7CisgICAgaWYgKCFkLT5tX21haW5GcmFtZSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwor ICAgIEpTQzo6QmluZGluZ3M6OlJvb3RPYmplY3QqIHJvb3QgPSBkLT5tX21haW5GcmFtZS0+c2Ny aXB0KCktPmJpbmRpbmdSb290T2JqZWN0KCk7CisgICAgaWYgKCFyb290KQorICAgICAgICByZXR1 cm4gZmFsc2U7CisgICAgSlNDOjpFeGVjU3RhdGUqIGV4ZWMgPSByb290LT5nbG9iYWxPYmplY3Qo KS0+Z2xvYmFsRXhlYygpOworICAgIEpTR2xvYmFsQ29udGV4dFJlZiBjdHggPSB0b0dsb2JhbFJl ZihleGVjKTsKKworICAgIFdURjo6VmVjdG9yPEpTU3RyaW5nUmVmPiBhcmdMaXN0KGFyZ3Muc2l6 ZSgpKTsKKyAgICBXVEY6OlZlY3RvcjxKU1ZhbHVlUmVmPiBhcmdMaXN0UmVmKGFyZ3Muc2l6ZSgp KTsKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgYXJncy5zaXplKCk7ICsraSkgeworICAg ICAgICBKU1N0cmluZ1JlZiBzdHIgPSBKU1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhhcmdz W2ldLmNfc3RyKCkpOworICAgICAgICBhcmdMaXN0W2ldID0gc3RyOworICAgICAgICBKU1ZhbHVl UmVmIHN0clJlZiA9IEpTVmFsdWVNYWtlU3RyaW5nKGN0eCwgc3RyKTsKKyAgICAgICAgYXJnTGlz dFJlZltpXSA9IHN0clJlZjsKKyAgICB9CisKKyAgICBKU1ZhbHVlUmVmIHdpbmRvd09iamVjdFZh bHVlID0gd2luZG93T2JqZWN0KCk7CisgICAgSlNPYmplY3RSZWYgb2JqID0gSlNWYWx1ZVRvT2Jq ZWN0KGN0eCwgd2luZG93T2JqZWN0VmFsdWUsIDApOworICAgIEpTT2JqZWN0UmVmIHRoaXNPYmpl Y3QgPSBvYmo7CisgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGZ1bmN0aW9uLnNpemUoKTsg KytpKSB7CisgICAgICAgIEpTU3RyaW5nUmVmIHN0ciA9IEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhD U3RyaW5nKGZ1bmN0aW9uW2ldLmNfc3RyKCkpOworICAgICAgICB0aGlzT2JqZWN0ID0gb2JqOwor ICAgICAgICBvYmogPSBKU1ZhbHVlVG9PYmplY3QoY3R4LCBKU09iamVjdEdldFByb3BlcnR5KGN0 eCwgb2JqLCBzdHIsIDApLCAwKTsKKyAgICAgICAgSlNTdHJpbmdSZWxlYXNlKHN0cik7CisgICAg ICAgIGlmICghb2JqKQorICAgICAgICAgICAgYnJlYWs7CisgICAgfQorCisgICAgSlNPYmplY3RS ZWYgZnVuY3Rpb25PYmplY3QgPSBvYmo7CisgICAgSlNWYWx1ZVJlZiByZXN1bHQgPSAwOworICAg IEpTVmFsdWVSZWYgZXhjZXB0aW9uOworICAgIGlmIChmdW5jdGlvbk9iamVjdCAmJiB0aGlzT2Jq ZWN0KQorICAgICAgICByZXN1bHQgPSBKU09iamVjdENhbGxBc0Z1bmN0aW9uKGN0eCwgZnVuY3Rp b25PYmplY3QsIHRoaXNPYmplY3QsIGFyZ3Muc2l6ZSgpLCBhcmdMaXN0UmVmLmRhdGEoKSwgJmV4 Y2VwdGlvbik7CisKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgYXJncy5zaXplKCk7ICsr aSkKKyAgICAgICAgSlNTdHJpbmdSZWxlYXNlKGFyZ0xpc3RbaV0pOworCisgICAgSlNDOjpKU1Zh bHVlIHZhbHVlID0gdG9KUyhleGVjLCByZXN1bHQpOworCisgICAgaWYgKCF2YWx1ZSkgeworICAg ICAgICByZXR1cm5UeXBlID0gSlNFeGNlcHRpb247CisgICAgICAgIEpTU3RyaW5nUmVmIHN0cmlu Z1JlZiA9IEpTVmFsdWVUb1N0cmluZ0NvcHkoY3R4LCBleGNlcHRpb24sIDApOworICAgICAgICBz aXplX3QgYnVmZmVyU2l6ZSA9IEpTU3RyaW5nR2V0TWF4aW11bVVURjhDU3RyaW5nU2l6ZShzdHJp bmdSZWYpOworICAgICAgICBXVEY6OlZlY3RvcjxjaGFyPiBidWZmZXIoYnVmZmVyU2l6ZSk7Cisg ICAgICAgIEpTU3RyaW5nR2V0VVRGOENTdHJpbmcoc3RyaW5nUmVmLCBidWZmZXIuZGF0YSgpLCBi dWZmZXJTaXplKTsKKyAgICAgICAgcmV0dXJuVmFsdWUgPSBXZWJTdHJpbmc6OmZyb21VdGY4KGJ1 ZmZlci5kYXRhKCkpOworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorCisgICAgSlNUeXBl IHR5cGUgPSBKU1ZhbHVlR2V0VHlwZShjdHgsIHJlc3VsdCk7CisKKyAgICBzd2l0Y2ggKHR5cGUp IHsKKyAgICBjYXNlIGtKU1R5cGVOdWxsOgorICAgICAgICByZXR1cm5UeXBlID0gSlNOdWxsOwor ICAgICAgICBicmVhazsKKyAgICBjYXNlIGtKU1R5cGVCb29sZWFuOgorICAgICAgICByZXR1cm5U eXBlID0gSlNCb29sZWFuOworICAgICAgICBicmVhazsKKyAgICBjYXNlIGtKU1R5cGVOdW1iZXI6 CisgICAgICAgIHJldHVyblR5cGUgPSBKU051bWJlcjsKKyAgICAgICAgYnJlYWs7CisgICAgY2Fz ZSBrSlNUeXBlU3RyaW5nOgorICAgICAgICByZXR1cm5UeXBlID0gSlNTdHJpbmc7CisgICAgICAg IGJyZWFrOworICAgIGNhc2Uga0pTVHlwZU9iamVjdDoKKyAgICAgICAgcmV0dXJuVHlwZSA9IEpT T2JqZWN0OworICAgICAgICBicmVhazsKKyAgICBjYXNlIGtKU1R5cGVVbmRlZmluZWQ6CisgICAg ZGVmYXVsdDoKKyAgICAgICAgcmV0dXJuVHlwZSA9IEpTVW5kZWZpbmVkOworICAgICAgICBicmVh azsKKyAgICB9CisKKyAgICBpZiAocmV0dXJuVHlwZSA9PSBKU0Jvb2xlYW4gfHwgcmV0dXJuVHlw ZSA9PSBKU051bWJlciB8fCByZXR1cm5UeXBlID09IEpTU3RyaW5nIHx8IHJldHVyblR5cGUgPT0g SlNPYmplY3QpIHsKKyAgICAgICAgSlNTdHJpbmdSZWYgc3RyaW5nUmVmID0gSlNWYWx1ZVRvU3Ry aW5nQ29weShjdHgsIHJlc3VsdCwgMCk7CisgICAgICAgIHNpemVfdCBidWZmZXJTaXplID0gSlNT dHJpbmdHZXRNYXhpbXVtVVRGOENTdHJpbmdTaXplKHN0cmluZ1JlZik7CisgICAgICAgIFdURjo6 VmVjdG9yPGNoYXI+IGJ1ZmZlcihidWZmZXJTaXplKTsKKyAgICAgICAgSlNTdHJpbmdHZXRVVEY4 Q1N0cmluZyhzdHJpbmdSZWYsIGJ1ZmZlci5kYXRhKCksIGJ1ZmZlclNpemUpOworICAgICAgICBy ZXR1cm5WYWx1ZSA9IFdlYlN0cmluZzo6ZnJvbVV0ZjgoYnVmZmVyLmRhdGEoKSk7CisgICAgfQor CisgICAgcmV0dXJuIHRydWU7Cit9CisKIHZvaWQgV2ViUGFnZVByaXZhdGU6OnN0b3BDdXJyZW50 TG9hZCgpCiB7CiAgICAgLy8gVGhpcyBmdW5jdGlvbiBzaG91bGQgY29udGFpbiBhbGwgY29tbW9u IGNvZGUgdHJpZ2dlcmVkIGJ5IFdlYlBhZ2U6OmxvYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9XZWJQYWdlLmgKaW5kZXggOTU5ODgzNi4uY2YyMTNiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0FwaS9XZWJQYWdlLmgKQEAgLTI3LDYgKzI3LDggQEAKICNpbmNsdWRlIDxCbGFja0JlcnJ5 UGxhdGZvcm1XZWJDb250ZXh0Lmg+CiAjaW5jbHVkZSA8aW1mL2lucHV0X2RhdGEuaD4KICNpbmNs dWRlIDxuZXR3b3JrL05ldHdvcmtSZXF1ZXN0Lmg+CisjaW5jbHVkZSA8c3RyaW5nPgorI2luY2x1 ZGUgPHZlY3Rvcj4KIAogc3RydWN0IE9wYXF1ZUpTQ29udGV4dDsKIHR5cGVkZWYgY29uc3Qgc3Ry dWN0IE9wYXF1ZUpTQ29udGV4dCogSlNDb250ZXh0UmVmOwpAQCAtMTAzLDYgKzEwNSw4IEBAIHB1 YmxpYzoKICAgICAvLyBUYWtlcyBhIFVURjE2IGVuY29kZWQgc2NyaXB0IHRoYXQgaXMgdXNlZCBl eHBsaWNpdGx5IGJ5IHRoZSBwYXR0ZXJuIG1hdGNoaW5nIGNvZGUKICAgICBib29sIGV4ZWN1dGVK YXZhU2NyaXB0SW5Jc29sYXRlZFdvcmxkKGNvbnN0IHN0ZDo6d3N0cmluZyYgc2NyaXB0LCBKYXZh U2NyaXB0RGF0YVR5cGUmIHJldHVyblR5cGUsIFdlYlN0cmluZyYgcmV0dXJuVmFsdWUpOwogCisg ICAgYm9vbCBleGVjdXRlSmF2YVNjcmlwdEZ1bmN0aW9uKGNvbnN0IHN0ZDo6dmVjdG9yPHN0ZDo6 c3RyaW5nPiAmc2NyaXB0LCBjb25zdCBzdGQ6OnZlY3RvcjxzdGQ6OnN0cmluZz4gJmFyZ3MsIEph dmFTY3JpcHREYXRhVHlwZSYgcmV0dXJuVHlwZSwgV2ViU3RyaW5nJiByZXR1cm5WYWx1ZSk7CisK ICAgICB2b2lkIGluaXRpYWxpemVJY29uRGF0YUJhc2UoKTsKIAogICAgIHZvaWQgc3RvcExvYWRp bmcoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDAyMzAwOWYuLjIxYTBiYTAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTA3 LTA2ICBCZW5qYW1pbiBDIE1leWVyICA8Ym1leWVyQHJpbS5jb20+CisKKyAgICAgICAgQWRkIGFu IEFQSSB0byBleHBsaWNpdGx5IGNhbGwgYSBKYXZhU2NyaXB0IGZ1bmN0aW9uIHdpdGggYXJncy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwNjk0CisK KyAgICAgICAgQ3VycmVudGx5IHRoZSBCbGFja2JlcnJ5IHBvcnQgZG9lc24ndCBleHBvc2UgdGhl IEphdmFTY3JpcHQKKyAgICAgICAgZW5naW5lIHRvIDNyZCBwYXJ0aWVzIHNvIHRoZXkgcmVseSB1 cG9uIGV4ZWN1dGVKYXZhU2NyaXB0CisgICAgICAgIHdoaWNoIGNhbiBiZSBzbG93ZXIgdGhhbiBu ZWNlc3NhcnkgYW5kIHVuc2FmZSBhcyBldmFsIGlzIHVzZWQuCisgICAgICAgIFRoaXMgbmV3IEFQ SSBwcm92aWRlcyBhIHdheSB0byBleHBsaWNpdGx5IGNhbGwgYSBzcGVjaWZpYworICAgICAgICBK YXZhU2NyaXB0IGZ1bmN0aW9uIHdpdGggYSBsaXN0IG9mIGFyZ3MgcHJldmVudGluZyB0aGUgY2Fz ZQorICAgICAgICB3aGVyZSBhbiBhcmd1bWVudCBjb21lcyBmcm9tIGEgdW50cnVzdGVkIHNvdXJj ZSBhbmQgdHJpZXMgdG8KKyAgICAgICAgZXNjYXBlIHRoZSBhcmcgbGlzdCB0byB0YWtlIGNvbnRy b2wgb2YgdGhlIEphdmFTY3JpcHQgZW5naW5lLgorCisgICAgICAgIEluIHRoZSBmdXR1cmUgaWYg dGhlIEJsYWNrYmVycnkgcG9ydCBpbnRyb2R1Y2VzIGEgZm9ybWFsCisgICAgICAgIHdheSB0byBp bnRlcmFjdCB3aXRoIHRoZSBKYXZhU2NyaXB0IGVuZ2luZSB0aGlzIGZ1bmN0aW9uIHNob3VsZAor ICAgICAgICBiZSByZW1vdmVkLgorCisgICAgICAgIFBSIDE0OTI5NAorCisgICAgICAgIFJldmll d2VkIGJ5IFVucmV2aWV3ZWQKKworICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAg KEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZTo6ZXhlY3V0ZUphdmFTY3JpcHRGdW5jdGlvbik6 CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAqIEFwaS9XZWJQYWdlLmg6CisKIDIwMTItMDYt MzAgIEphc29uIExpdSAgPGphc29uLmxpdUB0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAg W0JsYWNrQmVycnldIFdlYlZpZXcvQnJvd3NlciBjYXVzZSBibGFuayBzY3JlZW4gd2hlbiBzZWxl Y3RpbmcgYSBkcm9wZG93biBmaWVsZC4KLS0gCjEuNy4xCgo=