90681 2012-07-06 06:28:48 -0700 [EFL] WebKit-EFL headers do not build with gcc < 4.6 2012-07-06 07:16:27 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 664066 0 cdumez 2012-07-06 06:28:48 -0700 Because of forward declarations of our struct types in the public headers, we end up with redefinitions of typedefs. While this is allowed in C++, it is not valid C. We need to use #includes in the public headers instead of forwards declarations. 664068 1 cdumez 2012-07-06 06:31:58 -0700 gcc 4.6 started adding some features of upcoming C1X revision of the ISO C standard, which is why our MiniBrowser compiles: http://gcc.gnu.org/gcc-4.6/changes.html 664072 2 151076 cdumez 2012-07-06 06:34:31 -0700 Created attachment 151076 Patch Could someone please cq+ ? 664097 3 151076 webkit.review.bot 2012-07-06 07:16:23 -0700 Comment on attachment 151076 Patch Clearing flags on attachment: 151076 Committed r121969: <http://trac.webkit.org/changeset/121969> 664098 4 webkit.review.bot 2012-07-06 07:16:27 -0700 All reviewed patches have been landed. Closing bug. 151076 2012-07-06 06:34:31 -0700 2012-07-06 07:16:23 -0700 Patch 90681_build_fix.patch text/plain 1520 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1OTc5NTg2Li4yOTg4ZDMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDctMDYgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXSBXZWJLaXQtRUZMIGhlYWRlcnMgZG8gbm90IGJ1aWxkIHdp dGggZ2NjIDwgNC42CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05MDY4MQorCisgICAgICAgIFVucmV2aWV3ZWQgRUZMIGJ1aWxkIGZpeC4KKworICAgICAg ICBSZW1vdmUgc2V2ZXJhbCBmb3J3YXJkIGRlY2xhcmF0aW9ucyBmcm9tIGV3a192aWV3CisgICAg ICAgIGhlYWRlciB0byBhdm9pZCB0eXBlZGVmIHJlZGVmaW5pdGlvbnMgd2hpY2ggYXJlCisgICAg ICAgIGlsbGVnYWwgaW4gQy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3 Lmg6CisKIDIwMTItMDctMDYgIE9zd2FsZCBCdWRkZW5oYWdlbiAgPG9zd2FsZC5idWRkZW5oYWdl bkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBBZGp1c3QgdG8gY2hhbmdlZCBnZW5lcmF0aW9u IG9mIG1hc3RlciBpbmNsdWRlIGZpbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL2V3a192aWV3LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC9ld2tfdmlldy5oCmluZGV4IGExYTNhN2QuLmY2MDkyYTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmgKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaApAQCAtNDIsNiArNDIsOSBAQAogI2RlZmluZSBl d2tfdmlld19oCiAKICNpbmNsdWRlICJld2tfY29udGV4dC5oIgorI2luY2x1ZGUgImV3a19pbnRl bnQuaCIKKyNpbmNsdWRlICJld2tfdXJsX3JlcXVlc3QuaCIKKyNpbmNsdWRlICJld2tfd2ViX3Jl c291cmNlLmgiCiAjaW5jbHVkZSA8RXZhcy5oPgogCiAjaWZkZWYgX19jcGx1c3BsdXMKQEAgLTUw LDEwICs1Myw2IEBAIGV4dGVybiAiQyIgewogCiB0eXBlZGVmIHN0cnVjdCBfRXdrX1ZpZXdfU21h cnRfRGF0YSBFd2tfVmlld19TbWFydF9EYXRhOwogdHlwZWRlZiBzdHJ1Y3QgX0V3a19WaWV3X1Nt YXJ0X0NsYXNzIEV3a19WaWV3X1NtYXJ0X0NsYXNzOwotdHlwZWRlZiBzdHJ1Y3QgX0V3a19JbnRl bnQgRXdrX0ludGVudDsKLXR5cGVkZWYgc3RydWN0IF9Fd2tfVXJsX1JlcXVlc3QgRXdrX1VybF9S ZXF1ZXN0OwotdHlwZWRlZiBzdHJ1Y3QgX0V3a19XZWJfUmVzb3VyY2UgRXdrX1dlYl9SZXNvdXJj ZTsKLQogCiAvLy8gRXdrIHZpZXcncyBjbGFzcywgdG8gYmUgb3ZlcnJpZGRlbiBieSBzdWItY2xh c3Nlcy4KIHN0cnVjdCBfRXdrX1ZpZXdfU21hcnRfQ2xhc3Mgewo=