90677 2012-07-06 05:39:07 -0700 Web Inspector: start searching from the cursor position in the Sources panel. 2012-07-06 06:08:58 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 664030 0 pfeldman 2012-07-06 05:39:07 -0700 Patch to follow. 664031 1 151066 pfeldman 2012-07-06 05:41:00 -0700 Created attachment 151066 Patch 664033 2 151066 apavlov 2012-07-06 05:46:30 -0700 Comment on attachment 151066 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151066&action=review > Source/WebCore/inspector/front-end/TextEditorModel.js:120 > + if (this.startLine > other.startLine) A common approach to such comparators is along the lines of: if (this.startLine === other.startLine) return this.startColumn - other.startColumn; return this.startLine - other.startLine; (oftentimes it is not normalized to sgn(result), since only the relation to 0 is important) I understand that you are fighting for the verbosity in this case, though. 664046 3 151066 vsevik 2012-07-06 05:58:58 -0700 Comment on attachment 151066 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151066&action=review > Source/WebCore/inspector/front-end/TextEditor.js:398 > + lastSelection: function(textRange) Please remove parameter and jsdoc. > Source/WebCore/inspector/front-end/TextEditor.js:427 > + return; We might want to set (non empty) selection for other external actions (e.g. for Search across all files). Consider moving the code responsible for turning selection into a cursor position to the blur event handler instead. 664047 4 pfeldman 2012-07-06 06:06:23 -0700 > Please remove parameter and jsdoc. Removed from the code, jsdoc has it for a reason. > > > Source/WebCore/inspector/front-end/TextEditor.js:427 > > + return; > > We might want to set (non empty) selection for other external actions (e.g. for Search across all files). > Consider moving the code responsible for turning selection into a cursor position to the blur event handler instead. I am not sure I follow. 664049 5 pfeldman 2012-07-06 06:08:58 -0700 Committed r121957: <http://trac.webkit.org/changeset/121957> 151066 2012-07-06 05:41:00 -0700 2012-07-06 05:58:58 -0700 Patch bug-90677-20120706164059.patch text/plain 5269 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxOTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDk2NDJhZTkyNjk2NWFm NDBiOTkwOTlhODdhMzJkNWFkN2ZmZmI4ZS4uZWQ3OWI2OWUzMGI4NDg5MzUyMDQwMTQyMDRhYzhm NjUxZWFmODY3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA3LTA2ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHN0YXJ0IHNlYXJjaGluZyBmcm9tIHRoZSBjdXJzb3IgcG9zaXRpb24gaW4gdGhlIFNvdXJj ZXMgcGFuZWwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05MDY3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlYiBJbnNwZWN0b3I6IHN0YXJ0IHNlYXJjaGluZyBmcm9tIHRoZSBjdXJzb3IgcG9zaXRpb24g aW4gdGhlIFNvdXJjZXMgcGFuZWwuCisgICAgICAgIERyaXZlLWJ5OiBzZWxlY3Qgd2hvbGUgbWF0 Y2ggdXBvbiBzZWFyY2ggY2FuY2VsLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9T Y3JpcHRzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3Rv dHlwZS5wZXJmb3JtU2VhcmNoLmZpbmlzaGVkQ2FsbGJhY2spOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5cGUucGVyZm9ybVNlYXJjaCk6CisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5T b3VyY2VGcmFtZS5wcm90b3R5cGUucGVyZm9ybVNlYXJjaC5kb0ZpbmRTZWFyY2hNYXRjaGVzKToK KyAgICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUucGVyZm9ybVNlYXJj aCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0RWRpdG9yLmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IucHJvdG90eXBlLmxhc3RTZWxlY3Rpb24pOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IucHJvdG90eXBlLl9oYW5kbGVGb2N1c2VkKToK KyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRFZGl0b3JNb2RlbC5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5UZXh0UmFuZ2UucHJvdG90eXBlLnNlcmlhbGl6ZVRvT2JqZWN0KToK KyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0UmFuZ2UucHJvdG90eXBlLmNvbXBhcmVUbyk6CisK IDIwMTItMDctMDYgICdQYXZlbCBGZWxkbWFuJyAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBOb3QgcmV2aWV3ZWQ6IGZpeCBpbnNwZWN0b3IgZnJvbnQtZW5kIGNvbXBpbGF0aW9u LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRz UGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5l bC5qcwppbmRleCA4ZjBmZjNmODg5MTJiMzg4OTI4M2UzZTY2OGVkY2EyNWIyYTViZjUyLi45NGZj MGJlNDA4Yjk5ZmI1MWQzYzBiMGUwZWZhYTZkYjRjMzRjZjI0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcworKysgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwpAQCAtODkzLDcgKzg5 Myw3IEBAIFdlYkluc3BlY3Rvci5TY3JpcHRzUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAg ICAgICAgIHJldHVybjsKIAogICAgICAgICAgICAgV2ViSW5zcGVjdG9yLnNlYXJjaENvbnRyb2xs ZXIudXBkYXRlU2VhcmNoTWF0Y2hlc0NvdW50KHNlYXJjaE1hdGNoZXMsIHRoaXMpOwotICAgICAg ICAgICAgdmlldy5qdW1wVG9GaXJzdFNlYXJjaFJlc3VsdCgpOworICAgICAgICAgICAgdmlldy5q dW1wVG9OZXh0U2VhcmNoUmVzdWx0KCk7CiAgICAgICAgICAgICBXZWJJbnNwZWN0b3Iuc2VhcmNo Q29udHJvbGxlci51cGRhdGVDdXJyZW50TWF0Y2hJbmRleCh2aWV3LmN1cnJlbnRTZWFyY2hSZXN1 bHRJbmRleCwgdGhpcyk7CiAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUuanMKaW5kZXggZDkzOWUyMGJjZTFlMjhlNzBmYTRj YjE2Zjc3MmMwYzhkMzE3NjY5NC4uY2EwYWRmZjJlNTYzNmM5ZTYzOGJmNmVmYjJiYjBhNzk3YjNk MjkwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3Vy Y2VGcmFtZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJj ZUZyYW1lLmpzCkBAIC0zMzAsNiArMzMwLDEzIEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5w cm90b3R5cGUgPSB7CiAKICAgICAgICAgICAgIHZhciByZWdleCA9IFdlYkluc3BlY3Rvci5Tb3Vy Y2VGcmFtZS5jcmVhdGVTZWFyY2hSZWdleChxdWVyeSk7CiAgICAgICAgICAgICB0aGlzLl9zZWFy Y2hSZXN1bHRzID0gdGhpcy5fY29sbGVjdFJlZ2V4TWF0Y2hlcyhyZWdleCk7CisgICAgICAgICAg ICB2YXIgc2VsZWN0aW9uID0gdGhpcy5fdGV4dEVkaXRvci5sYXN0U2VsZWN0aW9uKCk7CisgICAg ICAgICAgICBmb3IgKHZhciBpID0gMDsgc2VsZWN0aW9uICYmIGkgPCB0aGlzLl9zZWFyY2hSZXN1 bHRzLmxlbmd0aDsgKytpKSB7CisgICAgICAgICAgICAgICAgaWYgKHRoaXMuX3NlYXJjaFJlc3Vs dHNbaV0uY29tcGFyZVRvKHNlbGVjdGlvbikgPiAwKSB7CisgICAgICAgICAgICAgICAgICAgIHRo aXMuX2N1cnJlbnRTZWFyY2hSZXN1bHRJbmRleCA9IGkgLSAxOworICAgICAgICAgICAgICAgICAg ICBicmVhazsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CiAKICAgICAgICAgICAg IGNhbGxiYWNrKHRoaXMsIHRoaXMuX3NlYXJjaFJlc3VsdHMubGVuZ3RoKTsKICAgICAgICAgfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0RWRpdG9y LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0RWRpdG9yLmpzCmlu ZGV4IDI1OTYzOWQyY2EyYTMxMzg0MDlkZmEwMWJlNmMwYTY3YmZjYjE3OGQuLmFlZjY3YjZmYTZi YTI3MTAyNmQ2Yzc1MzE4NDFjOTcwZTk0YjFhYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1RleHRFZGl0b3IuanMKQEAgLTM5Myw2ICszOTMsMTQgQEAgV2Vi SW5zcGVjdG9yLlRleHRFZGl0b3IucHJvdG90eXBlID0gewogICAgIH0sCiAKICAgICAvKioKKyAg ICAgKiBAcmV0dXJuIHtXZWJJbnNwZWN0b3IuVGV4dFJhbmdlP30KKyAgICAgKi8KKyAgICBsYXN0 U2VsZWN0aW9uOiBmdW5jdGlvbih0ZXh0UmFuZ2UpCisgICAgeworICAgICAgICByZXR1cm4gdGhp cy5fbGFzdFNlbGVjdGlvbjsKKyAgICB9LAorCisgICAgLyoqCiAgICAgICogQHBhcmFtIHtXZWJJ bnNwZWN0b3IuVGV4dFJhbmdlfSB0ZXh0UmFuZ2UKICAgICAgKi8KICAgICBzZXRTZWxlY3Rpb246 IGZ1bmN0aW9uKHRleHRSYW5nZSkKQEAgLTQxNCw4ICs0MjIsOSBAQCBXZWJJbnNwZWN0b3IuVGV4 dEVkaXRvci5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICAvLyBDb252ZXJ0IGxhc3QgbWFy a2VkIHJhbmdlIGludG8gYSBzZWxlY3Rpb24gdXBvbiBmb2N1cy4gVGhpcyBpcyBuZWVkZWQgdG8g Zm9jdXMgdGhlIHNlYXJjaCByZXN1bHQuCiAgICAgICAgIGlmICh0aGlzLl9sYXN0TWFya2VkUmFu Z2UpIHsKLSAgICAgICAgICAgIHRoaXMuX2xhc3RTZWxlY3Rpb24gPSB0aGlzLl9sYXN0TWFya2Vk UmFuZ2U7Ci0gICAgICAgICAgICBkZWxldGUgdGhpcy5fbGFzdE1hcmtlZFJhbmdlOyAKKyAgICAg ICAgICAgIHRoaXMuc2V0U2VsZWN0aW9uKHRoaXMuX2xhc3RNYXJrZWRSYW5nZSk7CisgICAgICAg ICAgICBkZWxldGUgdGhpcy5fbGFzdE1hcmtlZFJhbmdlOworICAgICAgICAgICAgcmV0dXJuOwog ICAgICAgICB9CiAKICAgICAgICAgaWYgKHRoaXMuX2xhc3RTZWxlY3Rpb24pIHsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dEVkaXRvck1vZGVsLmpz IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0RWRpdG9yTW9kZWwuanMK aW5kZXggYzIzN2E2NjBlMjBmNDY0ODUyZDZhYzkxMTU2N2FlNGYzNzBhN2RhMi4uNTUyMDVkYjRj MDdmMWUwMDAyMzZiZDFmOWNhYjQ1MjJkMmQ0YWVjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0RWRpdG9yTW9kZWwuanMKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0RWRpdG9yTW9kZWwuanMKQEAgLTEwOSw2ICsx MDksMjMgQEAgV2ViSW5zcGVjdG9yLlRleHRSYW5nZS5wcm90b3R5cGUgPSB7CiAgICAgICAgIHNl cmlhbGl6ZWRUZXh0UmFuZ2UuZW5kTGluZSA9IHRoaXMuZW5kTGluZTsKICAgICAgICAgc2VyaWFs aXplZFRleHRSYW5nZS5lbmRDb2x1bW4gPSB0aGlzLmVuZENvbHVtbjsKICAgICAgICAgcmV0dXJu IHNlcmlhbGl6ZWRUZXh0UmFuZ2U7CisgICAgfSwKKworICAgIC8qKgorICAgICAqIEBwYXJhbSB7 V2ViSW5zcGVjdG9yLlRleHRSYW5nZX0gb3RoZXIKKyAgICAgKiBAcmV0dXJuIHtudW1iZXJ9Cisg ICAgICovCisgICAgY29tcGFyZVRvOiBmdW5jdGlvbihvdGhlcikKKyAgICB7CisgICAgICAgIGlm ICh0aGlzLnN0YXJ0TGluZSA+IG90aGVyLnN0YXJ0TGluZSkKKyAgICAgICAgICAgIHJldHVybiAx OworICAgICAgICBpZiAodGhpcy5zdGFydExpbmUgPCBvdGhlci5zdGFydExpbmUpCisgICAgICAg ICAgICByZXR1cm4gLTE7CisgICAgICAgIGlmICh0aGlzLnN0YXJ0Q29sdW1uID4gb3RoZXIuc3Rh cnRDb2x1bW4pCisgICAgICAgICAgICByZXR1cm4gMTsKKyAgICAgICAgaWYgKHRoaXMuc3RhcnRD b2x1bW4gPCBvdGhlci5zdGFydENvbHVtbikKKyAgICAgICAgICAgIHJldHVybiAtMTsKKyAgICAg ICAgcmV0dXJuIDA7CiAgICAgfQogfQogCg==