90669 2012-07-06 02:33:53 -0700 Fix loadRGBA8AsFloat to work with older GCC as well 2014-02-13 14:44:31 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 92797 P2 Normal --- 1 rgabor webkit-unassigned dbates yosin zimmermann oldest_to_newest 663968 0 rgabor 2012-07-06 02:33:53 -0700 Fix loadRGBA8AsFloat to work with older GCC as well 664035 1 151067 rgabor 2012-07-06 05:48:22 -0700 Created attachment 151067 proposed patch Fix loadRGBA8AsFloat and set FECompositeArithmeticNEON.h to use NEONHelpers as well. 664069 2 151075 rgabor 2012-07-06 06:32:08 -0700 Created attachment 151075 patch2 The storeFloatAsRGBA8 in NEONHelpers.h different to what FEArithmeticNEON does so I leave that for now. 664075 3 151075 zherczeg 2012-07-06 06:37:48 -0700 Comment on attachment 151075 patch2 r=me 664076 4 151075 zherczeg 2012-07-06 06:39:27 -0700 Comment on attachment 151075 patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=151075&action=review > Source/WebCore/platform/graphics/filters/arm/NEONHelpers.h:40 > - uint32x2_t temporary1 = vset_lane_u32(*source, temporary1, 0); > + uint32x2_t temporary1 = vld1_u32(source); I think vld1_u32 reads a whole register, which can lead to buffer overflow. 767981 5 rgabor 2012-11-15 05:27:40 -0800 Bug fixed with: https://bugs.webkit.org/show_bug.cgi?id=92797 *** This bug has been marked as a duplicate of bug 92797 *** 980467 6 dbates 2014-02-13 14:44:31 -0800 I extracted the change to use loadRGBA8AsFloat() into the patch for bug #128767. 151067 2012-07-06 05:48:22 -0700 2012-07-06 06:32:08 -0700 proposed patch helpers.patch text/plain 3991 rgabor SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMTk1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTA2ICBHYWJvciBS YXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAgICAgICBGaXggbG9hZFJHQkE4QXNG bG9hdCB0byB3b3JrIHdpdGggb2xkZXIgR0NDIGFzIHdlbGwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwNjY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGxvYWRSR0JBOEFzRmxvYXQgaW4gTkVPTkhl bHBlcnMuaCBhbmQgc2V0IEZFQ29tcG9zaXRlQXJpdGhtZXRpY05FT04uaCAKKyAgICAgICAgdG8g dXNlIGl0IGFzIHdlbGwuCisKKyAgICAgICAgRXhpc3RpbmcgdGVzdHMgY292ZXIgdGhpcyBpc3N1 ZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvYXJtL0ZFQ29tcG9zaXRl QXJpdGhtZXRpY05FT04uaDoKKyAgICAgICAgKFdlYkNvcmU6OkZFQ29tcG9zaXRlOjpjb21wdXRl QXJpdGhtZXRpY1BpeGVsc05lb24pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRl cnMvYXJtL05FT05IZWxwZXJzLmg6CisgICAgICAgIChXZWJDb3JlOjpsb2FkUkdCQThBc0Zsb2F0 KToKKwogMjAxMi0wNy0wNiAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTbmlwcGV0cyBzaG91bGQgYmUgY29ycmVjdGx5IChy ZSlsb2FkZWQgd2hlbiBpbnNwZWN0b3IgaXMgb3BlbiBhbmQgb24gbmF2aWdhdGlvbi4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvYXJtL0ZFQ29tcG9zaXRl QXJpdGhtZXRpY05FT04uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9maWx0ZXJzL2FybS9GRUNvbXBvc2l0ZUFyaXRobWV0aWNORU9OLmgJKHJldmlzaW9u IDEyMTk1NikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvYXJt L0ZFQ29tcG9zaXRlQXJpdGhtZXRpY05FT04uaAkod29ya2luZyBjb3B5KQpAQCAtMzIsNyArMzIs NyBAQAogI2lmIEVOQUJMRShGSUxURVJTKSAmJiBIQVZFKEFSTV9ORU9OX0lOVFJJTlNJQ1MpCiAK ICNpbmNsdWRlICJGRUNvbXBvc2l0ZS5oIgotI2luY2x1ZGUgPGFybV9uZW9uLmg+CisjaW5jbHVk ZSAiTkVPTkhlbHBlcnMuaCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC00NCwyMCArNDQs MTUgQEAgaW5saW5lIHZvaWQgRkVDb21wb3NpdGU6OmNvbXB1dGVBcml0aG1ldAogICAgIGZsb2F0 MzJ4NF90IGsyeDQgPSB2ZHVwcV9uX2YzMihrMik7CiAgICAgZmxvYXQzMng0X3QgazN4NCA9IHZk dXBxX25fZjMyKGszKTsKICAgICBmbG9hdDMyeDRfdCBrNHg0ID0gdmR1cHFfbl9mMzIoazQgKiAy NTUpOwotICAgIHVpbnQzMng0X3QgbWF4MjU1ID0gdmR1cHFfbl91MzIoMjU1KTsKKyAgICBmbG9h dDMyeDRfdCBtYXgyNTUgPSB2ZHVwcV9uX2YzMigyNTUpOwogCiAgICAgdWludDMyX3QqIHNvdXJj ZVBpeGVsID0gcmVpbnRlcnByZXRfY2FzdDx1aW50MzJfdCo+KHNvdXJjZSk7CiAgICAgdWludDMy X3QqIGRlc3RpbmF0aW9uUGl4ZWwgPSByZWludGVycHJldF9jYXN0PHVpbnQzMl90Kj4oZGVzdGlu YXRpb24pOwogICAgIHVpbnQzMl90KiBkZXN0aW5hdGlvbkVuZFBpeGVsID0gZGVzdGluYXRpb25Q aXhlbCArIChwaXhlbEFycmF5TGVuZ3RoID4+IDIpOwogCiAgICAgd2hpbGUgKGRlc3RpbmF0aW9u UGl4ZWwgPCBkZXN0aW5hdGlvbkVuZFBpeGVsKSB7Ci0gICAgICAgIHVpbnQzMngyX3QgdGVtcG9y YXJ5MSA9IHZzZXRfbGFuZV91MzIoKnNvdXJjZVBpeGVsLCB0ZW1wb3JhcnkxLCAwKTsKLSAgICAg ICAgdWludDE2eDRfdCB0ZW1wb3JhcnkyID0gdmdldF9sb3dfdTE2KHZtb3ZsX3U4KHZyZWludGVy cHJldF91OF91MzIodGVtcG9yYXJ5MSkpKTsKLSAgICAgICAgZmxvYXQzMng0X3Qgc291cmNlUGl4 ZWxBc0Zsb2F0ID0gdmN2dHFfZjMyX3UzMih2bW92bF91MTYodGVtcG9yYXJ5MikpOwotCi0gICAg ICAgIHRlbXBvcmFyeTEgPSB2c2V0X2xhbmVfdTMyKCpkZXN0aW5hdGlvblBpeGVsLCB0ZW1wb3Jh cnkxLCAwKTsKLSAgICAgICAgdGVtcG9yYXJ5MiA9IHZnZXRfbG93X3UxNih2bW92bF91OCh2cmVp bnRlcnByZXRfdThfdTMyKHRlbXBvcmFyeTEpKSk7Ci0gICAgICAgIGZsb2F0MzJ4NF90IGRlc3Rp bmF0aW9uUGl4ZWxBc0Zsb2F0ID0gdmN2dHFfZjMyX3UzMih2bW92bF91MTYodGVtcG9yYXJ5Mikp OworICAgICAgICBmbG9hdDMyeDRfdCBzb3VyY2VQaXhlbEFzRmxvYXQgPSBsb2FkUkdCQThBc0Zs b2F0KHNvdXJjZVBpeGVsKTsKKyAgICAgICAgZmxvYXQzMng0X3QgZGVzdGluYXRpb25QaXhlbEFz RmxvYXQgPSBsb2FkUkdCQThBc0Zsb2F0KGRlc3RpbmF0aW9uUGl4ZWwpOwogCiAgICAgICAgIGZs b2F0MzJ4NF90IHJlc3VsdCA9IHZtdWxxX2YzMihzb3VyY2VQaXhlbEFzRmxvYXQsIGsyeDQpOwog ICAgICAgICByZXN1bHQgPSB2bWxhcV9mMzIocmVzdWx0LCBkZXN0aW5hdGlvblBpeGVsQXNGbG9h dCwgazN4NCk7CkBAIC02Nyw5ICs2Miw3IEBAIGlubGluZSB2b2lkIEZFQ29tcG9zaXRlOjpjb21w dXRlQXJpdGhtZXQKICAgICAgICAgICAgIHJlc3VsdCA9IHZhZGRxX2YzMihyZXN1bHQsIGs0eDQp OwogCiAgICAgICAgIC8vIENvbnZlcnQgcmVzdWx0IHRvIHVpbnQgc28gbmVnYXRpdmUgdmFsdWVz IGFyZSBjb252ZXJ0ZWQgdG8gemVyby4KLSAgICAgICAgdWludDE2eDRfdCB0ZW1wb3JhcnkzID0g dm1vdm5fdTMyKHZtaW5xX3UzMih2Y3Z0cV91MzJfZjMyKHJlc3VsdCksIG1heDI1NSkpOwotICAg ICAgICB1aW50OHg4X3QgdGVtcG9yYXJ5NCA9IHZtb3ZuX3UxNih2Y29tYmluZV91MTYodGVtcG9y YXJ5MywgdGVtcG9yYXJ5MykpOwotICAgICAgICAqZGVzdGluYXRpb25QaXhlbCsrID0gdmdldF9s YW5lX3UzMih2cmVpbnRlcnByZXRfdTMyX3U4KHRlbXBvcmFyeTQpLCAwKTsKKyAgICAgICAgc3Rv cmVGbG9hdEFzUkdCQTgodm1pbnFfZjMyKHJlc3VsdCwgbWF4MjU1KSwgZGVzdGluYXRpb25QaXhl bCsrKTsKICAgICAgICAgKytzb3VyY2VQaXhlbDsKICAgICB9CiB9CkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS9ORU9OSGVscGVycy5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvYXJtL05FT05I ZWxwZXJzLmgJKHJldmlzaW9uIDEyMTk1NikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2ZpbHRlcnMvYXJtL05FT05IZWxwZXJzLmgJKHdvcmtpbmcgY29weSkKQEAgLTM3LDcg KzM3LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBpbmxpbmUgZmxvYXQzMng0X3QgbG9hZFJH QkE4QXNGbG9hdCh1aW50MzJfdCogc291cmNlKQogewotICAgIHVpbnQzMngyX3QgdGVtcG9yYXJ5 MSA9IHZzZXRfbGFuZV91MzIoKnNvdXJjZSwgdGVtcG9yYXJ5MSwgMCk7CisgICAgdWludDMyeDJf dCB0ZW1wb3JhcnkxID0gdmxkMV91MzIoc291cmNlKTsKICAgICB1aW50MTZ4NF90IHRlbXBvcmFy eTIgPSB2Z2V0X2xvd191MTYodm1vdmxfdTgodnJlaW50ZXJwcmV0X3U4X3UzMih0ZW1wb3Jhcnkx KSkpOwogICAgIHJldHVybiB2Y3Z0cV9mMzJfdTMyKHZtb3ZsX3UxNih0ZW1wb3JhcnkyKSk7CiB9 Cg== 151075 2012-07-06 06:32:08 -0700 2012-07-06 06:39:27 -0700 patch2 helpers.patch text/plain 3048 rgabor SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMTk2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTA2ICBHYWJvciBS YXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAgICAgICBGaXggbG9hZFJHQkE4QXNG bG9hdCB0byB3b3JrIHdpdGggb2xkZXIgR0NDIGFzIHdlbGwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwNjY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGxvYWRSR0JBOEFzRmxvYXQgaW4gTkVPTkhl bHBlcnMuaCBhbmQgc2V0IEZFQ29tcG9zaXRlQXJpdGhtZXRpY05FT04uaCAKKyAgICAgICAgdG8g dXNlIGl0IGFzIHdlbGwuCisKKyAgICAgICAgRXhpc3RpbmcgdGVzdHMgY292ZXIgdGhpcyBpc3N1 ZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvYXJtL0ZFQ29tcG9zaXRl QXJpdGhtZXRpY05FT04uaDoKKyAgICAgICAgKFdlYkNvcmU6OkZFQ29tcG9zaXRlOjpjb21wdXRl QXJpdGhtZXRpY1BpeGVsc05lb24pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRl cnMvYXJtL05FT05IZWxwZXJzLmg6CisgICAgICAgIChXZWJDb3JlOjpsb2FkUkdCQThBc0Zsb2F0 KToKKwogMjAxMi0wNy0wNiAgT3N3YWxkIEJ1ZGRlbmhhZ2VuICA8b3N3YWxkLmJ1ZGRlbmhhZ2Vu QG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIFN3aXRjaCB0byBuZXctc3R5bGUgUXQgNSBjb25m aWd1cmUgdGVzdHMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRl cnMvYXJtL0ZFQ29tcG9zaXRlQXJpdGhtZXRpY05FT04uaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS9GRUNvbXBvc2l0ZUFyaXRobWV0 aWNORU9OLmgJKHJldmlzaW9uIDEyMTk2NSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2ZpbHRlcnMvYXJtL0ZFQ29tcG9zaXRlQXJpdGhtZXRpY05FT04uaAkod29ya2luZyBj b3B5KQpAQCAtMzIsNyArMzIsNyBAQAogI2lmIEVOQUJMRShGSUxURVJTKSAmJiBIQVZFKEFSTV9O RU9OX0lOVFJJTlNJQ1MpCiAKICNpbmNsdWRlICJGRUNvbXBvc2l0ZS5oIgotI2luY2x1ZGUgPGFy bV9uZW9uLmg+CisjaW5jbHVkZSAiTkVPTkhlbHBlcnMuaCIKIAogbmFtZXNwYWNlIFdlYkNvcmUg ewogCkBAIC01MSwxMyArNTEsOCBAQCBpbmxpbmUgdm9pZCBGRUNvbXBvc2l0ZTo6Y29tcHV0ZUFy aXRobWV0CiAgICAgdWludDMyX3QqIGRlc3RpbmF0aW9uRW5kUGl4ZWwgPSBkZXN0aW5hdGlvblBp eGVsICsgKHBpeGVsQXJyYXlMZW5ndGggPj4gMik7CiAKICAgICB3aGlsZSAoZGVzdGluYXRpb25Q aXhlbCA8IGRlc3RpbmF0aW9uRW5kUGl4ZWwpIHsKLSAgICAgICAgdWludDMyeDJfdCB0ZW1wb3Jh cnkxID0gdnNldF9sYW5lX3UzMigqc291cmNlUGl4ZWwsIHRlbXBvcmFyeTEsIDApOwotICAgICAg ICB1aW50MTZ4NF90IHRlbXBvcmFyeTIgPSB2Z2V0X2xvd191MTYodm1vdmxfdTgodnJlaW50ZXJw cmV0X3U4X3UzMih0ZW1wb3JhcnkxKSkpOwotICAgICAgICBmbG9hdDMyeDRfdCBzb3VyY2VQaXhl bEFzRmxvYXQgPSB2Y3Z0cV9mMzJfdTMyKHZtb3ZsX3UxNih0ZW1wb3JhcnkyKSk7Ci0KLSAgICAg ICAgdGVtcG9yYXJ5MSA9IHZzZXRfbGFuZV91MzIoKmRlc3RpbmF0aW9uUGl4ZWwsIHRlbXBvcmFy eTEsIDApOwotICAgICAgICB0ZW1wb3JhcnkyID0gdmdldF9sb3dfdTE2KHZtb3ZsX3U4KHZyZWlu dGVycHJldF91OF91MzIodGVtcG9yYXJ5MSkpKTsKLSAgICAgICAgZmxvYXQzMng0X3QgZGVzdGlu YXRpb25QaXhlbEFzRmxvYXQgPSB2Y3Z0cV9mMzJfdTMyKHZtb3ZsX3UxNih0ZW1wb3JhcnkyKSk7 CisgICAgICAgIGZsb2F0MzJ4NF90IHNvdXJjZVBpeGVsQXNGbG9hdCA9IGxvYWRSR0JBOEFzRmxv YXQoc291cmNlUGl4ZWwpOworICAgICAgICBmbG9hdDMyeDRfdCBkZXN0aW5hdGlvblBpeGVsQXNG bG9hdCA9IGxvYWRSR0JBOEFzRmxvYXQoZGVzdGluYXRpb25QaXhlbCk7CiAKICAgICAgICAgZmxv YXQzMng0X3QgcmVzdWx0ID0gdm11bHFfZjMyKHNvdXJjZVBpeGVsQXNGbG9hdCwgazJ4NCk7CiAg ICAgICAgIHJlc3VsdCA9IHZtbGFxX2YzMihyZXN1bHQsIGRlc3RpbmF0aW9uUGl4ZWxBc0Zsb2F0 LCBrM3g0KTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMv YXJtL05FT05IZWxwZXJzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZmlsdGVycy9hcm0vTkVPTkhlbHBlcnMuaAkocmV2aXNpb24gMTIxOTY1KQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9hcm0vTkVPTkhlbHBlcnMu aAkod29ya2luZyBjb3B5KQpAQCAtMzcsNyArMzcsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK IGlubGluZSBmbG9hdDMyeDRfdCBsb2FkUkdCQThBc0Zsb2F0KHVpbnQzMl90KiBzb3VyY2UpCiB7 Ci0gICAgdWludDMyeDJfdCB0ZW1wb3JhcnkxID0gdnNldF9sYW5lX3UzMigqc291cmNlLCB0ZW1w b3JhcnkxLCAwKTsKKyAgICB1aW50MzJ4Ml90IHRlbXBvcmFyeTEgPSB2bGQxX3UzMihzb3VyY2Up OwogICAgIHVpbnQxNng0X3QgdGVtcG9yYXJ5MiA9IHZnZXRfbG93X3UxNih2bW92bF91OCh2cmVp bnRlcnByZXRfdThfdTMyKHRlbXBvcmFyeTEpKSk7CiAgICAgcmV0dXJuIHZjdnRxX2YzMl91MzIo dm1vdmxfdTE2KHRlbXBvcmFyeTIpKTsKIH0K