90666 2012-07-06 01:49:23 -0700 GCC can't compile NEONHelpers.h 2012-07-06 05:54:45 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin webkit-unassigned rgabor zherczeg zimmermann oldest_to_newest 663951 0 yosin 2012-07-06 01:49:23 -0700 Here is error message. It seems some platforms enabling uninitialized variable warning (see below.) third_party/WebKit/Source/WebCore/platform/graphics/filters/arm/NEONHelpers.h: In function 'float32x4_t WebCore::loadRGBA8AsFloat(uint32_t*)': third_party/WebKit/Source/WebCore/platform/graphics/filters/arm/NEONHelpers.h:40:65: error: 'temporary1' is used uninitialized in this function [-Werror=uninitialized] Could you fix this? Sorry, I'm not familiar with ARM and NEON. Thanks in advance. 663958 1 yosin 2012-07-06 02:05:28 -0700 Introduced by: http://trac.webkit.org/changeset/121900 663960 2 zherczeg 2012-07-06 02:07:32 -0700 Gabor is working on it. 663964 3 151044 rgabor 2012-07-06 02:25:56 -0700 Created attachment 151044 proposed patch Fixed the defines of NEON intrinsics. 663969 4 151044 zherczeg 2012-07-06 02:34:03 -0700 Comment on attachment 151044 proposed patch r=me 663970 5 yosin 2012-07-06 02:36:56 -0700 Can we do something like below? uint32x2_t temporary0 = 0; uint32x2_t temporary1 = vset_lane_u32(*source, temporary0, 0); I'm not sure how to initialize uint32x2_t. 663971 6 rgabor 2012-07-06 02:39:49 -0700 (In reply to comment #5) > Can we do something like below? > > uint32x2_t temporary0 = 0; > uint32x2_t temporary1 = vset_lane_u32(*source, temporary0, 0); > > I'm not sure how to initialize uint32x2_t. Yes this just hide the problem from older compilers. I made another bug for the real problem: https://bugs.webkit.org/show_bug.cgi?id=90669 663976 7 zherczeg 2012-07-06 02:50:54 -0700 > Yes this just hide the problem from older compilers. The ifdefs were clearly wrong, if ARM_NEON_INTRINSICS is not defined, it should not be compiled. On the long run, we should do something with the uninitalized variable. From our point if view, the initialization is really unnecessary, and would reduce the performance. Would be good to tell the compiler to ignore this message. 664041 8 rgabor 2012-07-06 05:54:29 -0700 Patch landed: http://trac.webkit.org/changeset/121951 151044 2012-07-06 02:25:56 -0700 2012-07-06 05:54:45 -0700 proposed patch buildfix.patch text/plain 3321 rgabor SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMTk0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTA2ICBHYWJvciBS YXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAgICAgICBGaXhpbmcgZGVmaW5lcyBm b3IgTkVPTiBpbnRyaW5zaWNzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTA2NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBFeGlzdGluZyB0ZXN0cyBjb3ZlciB0aGlzIGlzc3VlLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRUdhdXNzaWFuQmx1ci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpGRUdhdXNzaWFuQmx1cjo6cGxhdGZvcm1BcHBseUdlbmVyaWMpOgorICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvYXJtL0ZFR2F1c3NpYW5CbHVyTkVPTi5oOgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvYXJtL05FT05IZWxwZXJzLmg6CisKIDIw MTItMDctMDUgIEFybmF1ZCBSZW5ldmllciAgPGFybm9AcmVuZXZpZXIubmV0PgogCiAgICAgICAg IFtHVEtdIFNob3dpbmcgdGhlIGNvbnRleHQgbWVudSBpbiB0aGUgV2ViIEluc3BlY3RvciBjYW4g Y3Jhc2ggdGhlIGJyb3dzZXIKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2ZpbHRlcnMvRkVHYXVzc2lhbkJsdXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVHYXVzc2lhbkJsdXIuY3BwCShyZXZpc2lvbiAx MjE5NDgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFR2F1 c3NpYW5CbHVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIwLDcgKzEyMCw3IEBAIGlubGluZSB2 b2lkIEZFR2F1c3NpYW5CbHVyOjpwbGF0Zm9ybUFwcGwKICAgICBmb3IgKGludCBpID0gMDsgaSA8 IDM7ICsraSkgewogICAgICAgICBpZiAoa2VybmVsU2l6ZVgpIHsKICAgICAgICAgICAgIGtlcm5l bFBvc2l0aW9uKGksIGtlcm5lbFNpemVYLCBkeExlZnQsIGR4UmlnaHQpOwotI2lmIENQVShBUk1f TkVPTikgJiYgQ09NUElMRVIoR0NDKQorI2lmIEhBVkUoQVJNX05FT05fSU5UUklOU0lDUykKICAg ICAgICAgICAgIGlmICghaXNBbHBoYUltYWdlKCkpCiAgICAgICAgICAgICAgICAgYm94Qmx1ck5F T04oc3JjLCBkc3QsIGtlcm5lbFNpemVYLCBkeExlZnQsIGR4UmlnaHQsIDQsIHN0cmlkZSwgcGFp bnRTaXplLndpZHRoKCksIHBhaW50U2l6ZS5oZWlnaHQoKSk7CiAgICAgICAgICAgICBlbHNlCkBA IC0xMzMsNyArMTMzLDcgQEAgaW5saW5lIHZvaWQgRkVHYXVzc2lhbkJsdXI6OnBsYXRmb3JtQXBw bAogCiAgICAgICAgIGlmIChrZXJuZWxTaXplWSkgewogICAgICAgICAgICAga2VybmVsUG9zaXRp b24oaSwga2VybmVsU2l6ZVksIGR5TGVmdCwgZHlSaWdodCk7Ci0jaWYgQ1BVKEFSTV9ORU9OKSAm JiBDT01QSUxFUihHQ0MpCisjaWYgSEFWRShBUk1fTkVPTl9JTlRSSU5TSUNTKQogICAgICAgICAg ICAgaWYgKCFpc0FscGhhSW1hZ2UoKSkKICAgICAgICAgICAgICAgICBib3hCbHVyTkVPTihzcmMs IGRzdCwga2VybmVsU2l6ZVksIGR5TGVmdCwgZHlSaWdodCwgc3RyaWRlLCA0LCBwYWludFNpemUu aGVpZ2h0KCksIHBhaW50U2l6ZS53aWR0aCgpKTsKICAgICAgICAgICAgIGVsc2UKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvYXJtL0ZFR2F1c3NpYW5CbHVy TkVPTi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Zp bHRlcnMvYXJtL0ZFR2F1c3NpYW5CbHVyTkVPTi5oCShyZXZpc2lvbiAxMjE5NDgpCisrKyBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS9GRUdhdXNzaWFuQmx1ck5F T04uaAkod29ya2luZyBjb3B5KQpAQCAtMjksNyArMjksNyBAQAogCiAjaW5jbHVkZSA8d3RmL1Bs YXRmb3JtLmg+CiAKLSNpZiBDUFUoQVJNX05FT04pICYmIENPTVBJTEVSKEdDQykKKyNpZiBFTkFC TEUoRklMVEVSUykgJiYgSEFWRShBUk1fTkVPTl9JTlRSSU5TSUNTKQogCiAjaW5jbHVkZSAiRkVH YXVzc2lhbkJsdXIuaCIKICNpbmNsdWRlICJORU9OSGVscGVycy5oIgpAQCAtNzQsNiArNzQsNiBA QCBpbmxpbmUgdm9pZCBib3hCbHVyTkVPTihVaW50OENsYW1wZWRBcnJhCiAKIH0gLy8gbmFtZXNw YWNlIFdlYkNvcmUKIAotI2VuZGlmIC8vIENQVShBUk1fTkVPTikgJiYgQ09NUElMRVIoR0NDKQor I2VuZGlmIC8vIEVOQUJMRShGSUxURVJTKSAmJiBIQVZFKEFSTV9ORU9OX0lOVFJJTlNJQ1MpCiAK ICNlbmRpZiAvLyBGRUdhdXNzaWFuQmx1ck5FT05faApJbmRleDogU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9hcm0vTkVPTkhlbHBlcnMuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS9ORU9OSGVscGVycy5o CShyZXZpc2lvbiAxMjE5NDgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9m aWx0ZXJzL2FybS9ORU9OSGVscGVycy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOSw3ICsyOSw3IEBA CiAKICNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4KIAotI2lmIENQVShBUk1fTkVPTikgJiYgQ09N UElMRVIoR0NDKQorI2lmIEVOQUJMRShGSUxURVJTKSAmJiBIQVZFKEFSTV9ORU9OX0lOVFJJTlNJ Q1MpCiAKICNpbmNsdWRlIDxhcm1fbmVvbi5oPgogCkBAIC01MSw2ICs1MSw2IEBAIGlubGluZSB2 b2lkIHN0b3JlRmxvYXRBc1JHQkE4KGZsb2F0MzJ4NF8KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQogCi0jZW5kaWYgLy8gQ1BVKEFSTV9ORU9OKSAmJiBDT01QSUxFUihHQ0MpCisjZW5kaWYgLy8g RU5BQkxFKEZJTFRFUlMpICYmIEhBVkUoQVJNX05FT05fSU5UUklOU0lDUykKIAogI2VuZGlmIC8v IE5FT05IZWxwZXJzX2gK