90620 2012-07-05 10:33:03 -0700 Update the description of LayoutTestController::textSurroundingElement 2012-07-08 20:49:23 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leandrogracia leandrogracia abarth tkent webkit.review.bot oldest_to_newest 663620 0 leandrogracia 2012-07-05 10:33:03 -0700 The description of the method no longer matches what it expects as it was changed during the review of https://bugs.webkit.org/show_bug.cgi?id=82461. 663624 1 leandrogracia 2012-07-05 10:36:03 -0700 In fact, this method is not based anymore on elements but on nodes. It might be a good idea to rename it to avoid any confusion. 663656 2 150964 leandrogracia 2012-07-05 11:12:58 -0700 Created attachment 150964 Patch 664586 3 150964 webkit.review.bot 2012-07-08 20:49:14 -0700 Comment on attachment 150964 Patch Clearing flags on attachment: 150964 Committed r122077: <http://trac.webkit.org/changeset/122077> 664587 4 webkit.review.bot 2012-07-08 20:49:23 -0700 All reviewed patches have been landed. Closing bug. 150964 2012-07-05 11:12:58 -0700 2012-07-08 20:49:13 -0700 Patch bug-90620-20120705191256.patch text/plain 5059 leandrogracia U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxOTA5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTZjNTNlMDM2ODdmZmY2YzRiMTQ0ODNjZDY0ZmZmNDI3 ZjY5ZDVhMC4uZmFlMjgwNDc2MWY5OWY5OWExMWMxNGQwMGYxMWFkNDg4YjkxYWViNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTA3LTA1ICBMZWFuZHJvIEdyYWNpYSBHaWwgIDxsZWFuZHJvZ3JhY2lhQGNocm9t aXVtLm9yZz4KKworICAgICAgICBVcGRhdGUgdGhlIGRlc2NyaXB0aW9uIG9mIExheW91dFRlc3RD b250cm9sbGVyOjp0ZXh0U3Vycm91bmRpbmdFbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDYyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmFtZSBhbmQgZml4IHRoZSBkZXNjcmlwdGlvbiBv ZiB0aGUgbWV0aG9kIGFzIGl0cyBiZWhhdmlvdXIgY2hhbmdlZAorICAgICAgICBkdXJpbmcgdGhl IHJldmlldyBvZiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI0NjEK KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVy LmNwcDoKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpMYXlvdXRUZXN0Q29udHJvbGxl cik6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6dGV4dFN1cnJvdW5kaW5nTm9kZSk6 CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIu aDoKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyKToKKwogMjAxMi0wNy0wNSAgVG9yIEFy bmUgVmVzdGLDuCAgPHRvci5hcm5lLnZlc3Rib0Bub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBS ZW1vdmUgcnBhdGgtaGFja3MgaW4gcXRfd2Via2l0LnByaQpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCmluZGV4IGQ1YzA4 YWU3ZWYzN2UyMmJhOGI2MThjMmMyZjJjZWNjYjc4YjRmYjguLjI1OGU2ODJjZWJmZGYzODYzM2Iw ZmZiNzkyNjI0MjVkODIzY2QxNjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAKQEAgLTI3Niw3ICsyNzYsNyBAQCBM YXlvdXRUZXN0Q29udHJvbGxlcjo6TGF5b3V0VGVzdENvbnRyb2xsZXIoVGVzdFNoZWxsKiBzaGVs bCkKICAgICBiaW5kTWV0aG9kKCJzZXRGaXhlZExheW91dFNpemUiLCAmTGF5b3V0VGVzdENvbnRy b2xsZXI6OnNldEZpeGVkTGF5b3V0U2l6ZSk7CiAgICAgYmluZE1ldGhvZCgic2VsZWN0aW9uQXNN YXJrdXAiLCAmTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNlbGVjdGlvbkFzTWFya3VwKTsKICAgICBi aW5kTWV0aG9kKCJzZXRIYXNDdXN0b21GdWxsU2NyZWVuQmVoYXZpb3IiLCAmTGF5b3V0VGVzdENv bnRyb2xsZXI6OnNldEhhc0N1c3RvbUZ1bGxTY3JlZW5CZWhhdmlvcik7Ci0gICAgYmluZE1ldGhv ZCgidGV4dFN1cnJvdW5kaW5nRWxlbWVudCIsICZMYXlvdXRUZXN0Q29udHJvbGxlcjo6dGV4dFN1 cnJvdW5kaW5nRWxlbWVudCk7CisgICAgYmluZE1ldGhvZCgidGV4dFN1cnJvdW5kaW5nTm9kZSIs ICZMYXlvdXRUZXN0Q29udHJvbGxlcjo6dGV4dFN1cnJvdW5kaW5nTm9kZSk7CiAKICAgICAvLyBU aGUgZmFsbGJhY2sgbWV0aG9kIGlzIGNhbGxlZCB3aGVuIGFuIHVua25vd24gbWV0aG9kIGlzIGlu dm9rZWQuCiAgICAgYmluZEZhbGxiYWNrTWV0aG9kKCZMYXlvdXRUZXN0Q29udHJvbGxlcjo6ZmFs bGJhY2tNZXRob2QpOwpAQCAtMjM0Niw3ICsyMzQ2LDcgQEAgdm9pZCBMYXlvdXRUZXN0Q29udHJv bGxlcjo6c2V0UG9pbnRlckxvY2tXaWxsRmFpbFN5bmNocm9ub3VzbHkoY29uc3QgQ3BwQXJndW1l bnQKIH0KICNlbmRpZgogCi12b2lkIExheW91dFRlc3RDb250cm9sbGVyOjp0ZXh0U3Vycm91bmRp bmdFbGVtZW50KGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLCBDcHBWYXJpYW50KiBy ZXN1bHQpCit2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjp0ZXh0U3Vycm91bmRpbmdOb2RlKGNv bnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLCBDcHBWYXJpYW50KiByZXN1bHQpCiB7CiAg ICAgcmVzdWx0LT5zZXROdWxsKCk7CiAgICAgaWYgKGFyZ3VtZW50cy5zaXplKCkgPCAzIHx8ICFh cmd1bWVudHNbMF0uaXNPYmplY3QoKSB8fCAhYXJndW1lbnRzWzFdLmlzTnVtYmVyKCkgfHwgIWFy Z3VtZW50c1syXS5pc051bWJlcigpKQpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUv Y2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuaCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmgKaW5kZXggZjViYTA2NjA2YmUyZTY2YWExYzE2 NzAzMmFiZGM5NDdiN2ZiYmQ3Yy4uNDEzMGU5M2VhMjQwZTU5MjNmNzZlM2NiYzUzM2E1YTk4OWNh YmNiYSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVz dENvbnRyb2xsZXIuaAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRU ZXN0Q29udHJvbGxlci5oCkBAIC00NTcsOSArNDU3LDkgQEAgcHVibGljOgogICAgIHZvaWQgc2V0 QmFja2luZ1NjYWxlRmFjdG9yKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYsIENwcFZhcmlhbnQqKTsK IAogICAgIC8vIFJldHJpZXZlcyB0aGUgdGV4dCBzdXJyb3VuZGluZyBhIHBvc2l0aW9uIGluIGEg dGV4dCBub2RlLgotICAgIC8vIFRoZSBmaXJzdCBjaGlsZCBvZiB0aGUgZWxlbWVudCBnaXZlbiB5 IGl0cyBpZCB3aWxsIGJlIHVzZWQgYXMgcmVmZXJlbmNlLAotICAgIC8vIG9yIGl0cyBuZXh0IHNp YmxpbmcgaWYgbm90IHByZXNlbnQuIEl0IG11c3QgYmUgYSB0ZXh0IG5vZGUuCi0gICAgdm9pZCB0 ZXh0U3Vycm91bmRpbmdFbGVtZW50KGNvbnN0IENwcEFyZ3VtZW50TGlzdCYsIENwcFZhcmlhbnQq KTsKKyAgICAvLyBFeHBlY3RzIHRoZSBmaXJzdCBhcmd1bWVudCB0byBiZSBhIHRleHQgbm9kZSwg dGhlIHNlY29uZCB0byBiZSBhbiBvZmZzZXQKKyAgICAvLyBpbiB0aGUgbm9kZSBjb250ZW50cyBh bmQgdGhlIHRoaXJkIHRoZSBtYXhpbXVtIHRleHQgbGVuZ3RoIHRvIHJldHJpZXZlLgorICAgIHZv aWQgdGV4dFN1cnJvdW5kaW5nTm9kZShjb25zdCBDcHBBcmd1bWVudExpc3QmLCBDcHBWYXJpYW50 Kik7CiAKIHB1YmxpYzoKICAgICAvLyBUaGUgZm9sbG93aW5nIG1ldGhvZHMgYXJlIG5vdCBleHBv c2VkIHRvIEphdmFTY3JpcHQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTUwN2E2OTI3YWM5MGJiNWQ5MTAzODEzNDQ2YTY1 ZGFiOTZiNmIzYy4uYjg0ZDg5OGY3NjNhNzQzYzYzNWZhNzhhMDk1OWJmYjBjY2ZhOGE5YSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA3LTA1ICBMZWFuZHJvIEdyYWNpYSBHaWwgIDxsZWFu ZHJvZ3JhY2lhQGNocm9taXVtLm9yZz4KKworICAgICAgICBVcGRhdGUgdGhlIGRlc2NyaXB0aW9u IG9mIExheW91dFRlc3RDb250cm9sbGVyOjp0ZXh0U3Vycm91bmRpbmdFbGVtZW50CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDYyMAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmFtZSB0ZXh0U3Vycm91 bmRpbmdFbGVtZW50IHRvIG1hdGNoIGlzIHJlYWwgYmVoYXZpb3VyLgorCisgICAgICAgICogcGxh dGZvcm0vY2hyb21pdW0vZWRpdGluZy9zdXJyb3VuZGluZy10ZXh0L3N1cnJvdW5kaW5nLXRleHQu aHRtbDoKKwogMjAxMi0wNy0wNSAgVmluY2VudCBTY2hlaWIgIDxzY2hlaWJAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtDaHJvbWl1bV0gQ2xlYXIgbV9jdXJyZW50SW5wdXRFdmVudCBhZnRlciBo YW5kbGVkIGJ5IHBvaW50ZXJMb2NrTW91c2VFdmVudCgpLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vY2hyb21pdW0vZWRpdGluZy9zdXJyb3VuZGluZy10ZXh0L3N1cnJvdW5kaW5n LXRleHQuaHRtbCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2VkaXRpbmcvc3Vycm91 bmRpbmctdGV4dC9zdXJyb3VuZGluZy10ZXh0Lmh0bWwKaW5kZXggNmI3ZjQ3OGM1MmE5ZjEzNWUx MzIxZjNkOWM1Yjk1NDM4OTgwNmI0Yy4uMTNhZjg3Y2Y4NzYyMTBiZDFhMGRkNWZlZTA5MDM0ZTBh ZjcwNzFkYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZWRpdGlu Zy9zdXJyb3VuZGluZy10ZXh0L3N1cnJvdW5kaW5nLXRleHQuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9jaHJvbWl1bS9lZGl0aW5nL3N1cnJvdW5kaW5nLXRleHQvc3Vycm91bmRpbmct dGV4dC5odG1sCkBAIC0yMCw3ICsyMCw3IEBAIGZ1bmN0aW9uIHN1cnJvdW5kaW5nVGV4dChodG1s LCBvZmZzZXQsIG1heExlbmd0aCkgewogICAgIGlmIChub2RlID09IG51bGwpCiAgICAgICAgIHRo cm93ICdObyBub2RlIGFmdGVyICJoZXJlIiBlbGVtZW50JzsKIAotICAgIHZhciB0ZXh0ID0gd2lu ZG93LnRlc3RSdW5uZXIudGV4dFN1cnJvdW5kaW5nRWxlbWVudChub2RlLCBvZmZzZXQsIG1heExl bmd0aCk7CisgICAgdmFyIHRleHQgPSB3aW5kb3cudGVzdFJ1bm5lci50ZXh0U3Vycm91bmRpbmdO b2RlKG5vZGUsIG9mZnNldCwgbWF4TGVuZ3RoKTsKICAgICByZXR1cm4gdGV4dC5yZXBsYWNlKC9c cysvZywgJyAnKS5yZXBsYWNlKC9eXHMqfFxzKiQvZywgJycpOwogfQogCg==