90595 2012-07-05 02:46:26 -0700 [EFL] Log significant Gamepad API-related events 2012-07-09 12:59:24 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 90570 1 cdumez cdumez cgarcia gustavo kenneth mrobinson rakuco tonikitoo webkit.review.bot oldest_to_newest 663422 0 cdumez 2012-07-05 02:46:26 -0700 Gamepad logging channel was recently added in Bug 90570. We should now make use of it for EFL port and log significant Gamepad API-related events. 663428 1 150908 cdumez 2012-07-05 02:59:03 -0700 Created attachment 150908 Patch 664393 2 150908 rakuco 2012-07-07 10:02:12 -0700 Comment on attachment 150908 Patch LGTM. 664542 3 150908 gyuyoung.kim 2012-07-08 19:20:17 -0700 Comment on attachment 150908 Patch Looks fine too. 665096 4 150908 webkit.review.bot 2012-07-09 12:59:19 -0700 Comment on attachment 150908 Patch Clearing flags on attachment: 150908 Committed r122150: <http://trac.webkit.org/changeset/122150> 665097 5 webkit.review.bot 2012-07-09 12:59:24 -0700 All reviewed patches have been landed. Closing bug. 150908 2012-07-05 02:59:03 -0700 2012-07-09 12:59:19 -0700 Patch 90595_gamepadsefl_loggin.patch text/plain 4230 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MDExYWRmLi4xODM2ZDlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTItMDctMDUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXSBMb2cgc2lnbmlmaWNhbnQgR2FtZXBhZCBBUEktcmVsYXRl ZCBldmVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTkwNTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TG9nIHNpZ25pZmljYW50IEdhbWVwYWQgQVBJLXJlbGF0ZWQgZXZlbnRzIGluCisgICAgICAgIEdh bWVwYWRzRWZsLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgor CisgICAgICAgICogcGxhdGZvcm0vZWZsL0dhbWVwYWRzRWZsLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkdhbWVwYWREZXZpY2VFZmw6OmRldmljZUZpbGUpOgorICAgICAgICAoR2FtZXBhZERldmlj ZUVmbCk6CisgICAgICAgIChXZWJDb3JlOjpHYW1lcGFkRGV2aWNlRWZsOjpHYW1lcGFkRGV2aWNl RWZsKToKKyAgICAgICAgKFdlYkNvcmU6OkdhbWVwYWREZXZpY2VFZmw6OnJlYWRDYWxsYmFjayk6 CisgICAgICAgIChXZWJDb3JlOjpHYW1lcGFkc0VmbDo6cmVnaXN0ZXJEZXZpY2UpOgorICAgICAg ICAoV2ViQ29yZTo6R2FtZXBhZHNFZmw6OnVucmVnaXN0ZXJEZXZpY2UpOgorCiAyMDEyLTA3LTA1 ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgQWRkIEdh bWVwYWQgbG9nZ2luZyBjaGFubmVsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9lZmwvR2FtZXBhZHNFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0dhbWVw YWRzRWZsLmNwcAppbmRleCA1MzA0OTZjLi5mNjdiYTQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9lZmwvR2FtZXBhZHNFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2VmbC9HYW1lcGFkc0VmbC5jcHAKQEAgLTMwLDYgKzMwLDcgQEAKIAogI2luY2x1ZGUg IkdhbWVwYWREZXZpY2VMaW51eC5oIgogI2luY2x1ZGUgIkdhbWVwYWRMaXN0LmgiCisjaW5jbHVk ZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgPEVjb3JlLmg+CiAjaW5jbHVkZSA8RWV6ZS5oPgogI2lu Y2x1ZGUgPEVpbmEuaD4KQEAgLTUxLDE3ICs1MiwyMCBAQCBwdWJsaWM6CiAgICAgfQogICAgIH5H YW1lcGFkRGV2aWNlRWZsKCk7CiAgICAgdm9pZCByZXNldEZkSGFuZGxlcigpIHsgbV9mZEhhbmRs ZXIgPSAwOyB9CisgICAgY29uc3QgU3RyaW5nJiBkZXZpY2VGaWxlKCkgY29uc3QgeyByZXR1cm4g bV9kZXZpY2VGaWxlOyB9CiAKIHByaXZhdGU6CiAgICAgR2FtZXBhZERldmljZUVmbChjb25zdCBT dHJpbmcmIGRldmljZUZpbGUpOwogICAgIHN0YXRpYyBFaW5hX0Jvb2wgcmVhZENhbGxiYWNrKHZv aWQqIHVzZXJEYXRhLCBFY29yZV9GZF9IYW5kbGVyKik7CiAKICAgICBFY29yZV9GZF9IYW5kbGVy KiBtX2ZkSGFuZGxlcjsKKyAgICBTdHJpbmcgbV9kZXZpY2VGaWxlOwogfTsKIAogR2FtZXBhZERl dmljZUVmbDo6R2FtZXBhZERldmljZUVmbChjb25zdCBTdHJpbmcmIGRldmljZUZpbGUpCiAgICAg OiBHYW1lcGFkRGV2aWNlTGludXgoZGV2aWNlRmlsZSkKICAgICAsIG1fZmRIYW5kbGVyKDApCisg ICAgLCBtX2RldmljZUZpbGUoZGV2aWNlRmlsZSkKIHsKICAgICBpZiAobV9maWxlRGVzY3JpcHRv ciA8IDApCiAgICAgICAgIHJldHVybjsKQEAgLTgyLDcgKzg2LDcgQEAgRWluYV9Cb29sIEdhbWVw YWREZXZpY2VFZmw6OnJlYWRDYWxsYmFjayh2b2lkKiB1c2VyRGF0YSwgRWNvcmVfRmRfSGFuZGxl ciogZmRIYW4KICAgICBHYW1lcGFkRGV2aWNlRWZsKiBnYW1lcGFkRGV2aWNlID0gc3RhdGljX2Nh c3Q8R2FtZXBhZERldmljZUVmbCo+KHVzZXJEYXRhKTsKIAogICAgIGlmIChlY29yZV9tYWluX2Zk X2hhbmRsZXJfYWN0aXZlX2dldChmZEhhbmRsZXIsIEVDT1JFX0ZEX0VSUk9SKSkgewotICAgICAg ICBMT0dfRVJST1IoIkFuIGVycm9yIG9jY3VycmVkIHdoaWxlIHdhdGNoaW5nIHRoZSBqb3lzdGlj ayBmaWxlIGRlc2NyaXB0b3IsIGFib3J0aW5nLiIpOworICAgICAgICBMT0dfRVJST1IoIkFuIGVy cm9yIG9jY3VycmVkIHdoaWxlIHdhdGNoaW5nIHRoZSBqb3lzdGljayBmaWxlIGRlc2NyaXB0b3Ig YXQgJXMsIGFib3J0aW5nLiIsIGdhbWVwYWREZXZpY2UtPmRldmljZUZpbGUoKS51dGY4KCkuZGF0 YSgpKTsKICAgICAgICAgZ2FtZXBhZERldmljZS0+cmVzZXRGZEhhbmRsZXIoKTsKICAgICAgICAg cmV0dXJuIEVDT1JFX0NBTExCQUNLX0NBTkNFTDsKICAgICB9CkBAIC05MiwxMiArOTYsMTIgQEAg RWluYV9Cb29sIEdhbWVwYWREZXZpY2VFZmw6OnJlYWRDYWxsYmFjayh2b2lkKiB1c2VyRGF0YSwg RWNvcmVfRmRfSGFuZGxlciogZmRIYW4KICAgICBjb25zdCBzc2l6ZV90IGxlbiA9IHJlYWQoZmRE ZXZpY2UsICZldmVudCwgc2l6ZW9mKGV2ZW50KSk7CiAKICAgICBpZiAobGVuIDw9IDApIHsKLSAg ICAgICAgTE9HX0VSUk9SKCJGYWlsZWQgdG8gcmVhZCBqb3lzdGljayBmaWxlIGRlc2NyaXB0b3Is IGFib3J0aW5nLiIpOworICAgICAgICBMT0dfRVJST1IoIkZhaWxlZCB0byByZWFkIGpveXN0aWNr IGZpbGUgZGVzY3JpcHRvciBhdCAlcywgYWJvcnRpbmcuIiwgZ2FtZXBhZERldmljZS0+ZGV2aWNl RmlsZSgpLnV0ZjgoKS5kYXRhKCkpOwogICAgICAgICBnYW1lcGFkRGV2aWNlLT5yZXNldEZkSGFu ZGxlcigpOwogICAgICAgICByZXR1cm4gRUNPUkVfQ0FMTEJBQ0tfQ0FOQ0VMOwogICAgIH0KICAg ICBpZiAobGVuICE9IHNpemVvZihldmVudCkpIHsKLSAgICAgICAgTE9HX0VSUk9SKCJXcm9uZyBq c19ldmVudCBzaXplIHJlYWQgb24gZmlsZSBkZXNjcmlwdG9yLCBpZ25vcmluZy4iKTsKKyAgICAg ICAgTE9HX0VSUk9SKCJXcm9uZyBqc19ldmVudCBzaXplIHJlYWQgb24gZmlsZSBkZXNjcmlwdG9y IGF0ICVzLCBpZ25vcmluZy4iLCBnYW1lcGFkRGV2aWNlLT5kZXZpY2VGaWxlKCkudXRmOCgpLmRh dGEoKSk7CiAgICAgICAgIHJldHVybiBFQ09SRV9DQUxMQkFDS19SRU5FVzsKICAgICB9CiAKQEAg LTE3OSwxMCArMTgzLDEzIEBAIHZvaWQgR2FtZXBhZHNFZmw6OnJlZ2lzdGVyRGV2aWNlKGNvbnN0 IFN0cmluZyYgc3lzcGF0aCkKICAgICBpZiAoIWRldmljZUZpbGUgfHwgIWVpbmFfc3RyX2hhc19w cmVmaXgoZGV2aWNlRmlsZSwgam95c3RpY2tQcmVmaXgpKQogICAgICAgICByZXR1cm47CiAKKyAg ICBMT0coR2FtZXBhZCwgIlJlZ2lzdGVyaW5nIGdhbWVwYWQgYXQgJXMiLCBkZXZpY2VGaWxlKTsK KwogICAgIGNvbnN0IHNpemVfdCBzbG90Q291bnQgPSBtX3Nsb3RzLnNpemUoKTsKICAgICBmb3Ig KHNpemVfdCBpbmRleCA9IDA7IGluZGV4IDwgc2xvdENvdW50OyArK2luZGV4KSB7CiAgICAgICAg IGlmICghbV9zbG90c1tpbmRleF0pIHsKICAgICAgICAgICAgIG1fc2xvdHNbaW5kZXhdID0gR2Ft ZXBhZERldmljZUVmbDo6Y3JlYXRlKFN0cmluZzo6ZnJvbVVURjgoZGV2aWNlRmlsZSkpOworICAg ICAgICAgICAgTE9HKEdhbWVwYWQsICJHYW1lcGFkIGRldmljZSBuYW1lIGlzICVzIiwgbV9zbG90 c1tpbmRleF0tPmlkKCkudXRmOCgpLmRhdGEoKSk7CiAgICAgICAgICAgICBtX2RldmljZU1hcC5h ZGQoc3lzcGF0aCwgbV9zbG90c1tpbmRleF0uZ2V0KCkpOwogICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgIH0KQEAgLTE5NSw2ICsyMDIsNyBAQCB2b2lkIEdhbWVwYWRzRWZsOjp1bnJlZ2lzdGVy RGV2aWNlKGNvbnN0IFN0cmluZyYgc3lzcGF0aCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgR2Ft ZXBhZERldmljZUVmbCogZ2FtZXBhZERldmljZSA9IG1fZGV2aWNlTWFwLnRha2Uoc3lzcGF0aCk7 CisgICAgTE9HKEdhbWVwYWQsICJVbnJlZ2lzdGVyaW5nIGdhbWVwYWQgYXQgJXMiLCBnYW1lcGFk RGV2aWNlLT5kZXZpY2VGaWxlKCkudXRmOCgpLmRhdGEoKSk7CiAgICAgY29uc3Qgc2l6ZV90IGlu ZGV4ID0gbV9zbG90cy5maW5kKGdhbWVwYWREZXZpY2UpOwogICAgIEFTU0VSVChpbmRleCAhPSBu b3RGb3VuZCk7CiAK