90590 2012-07-05 01:07:27 -0700 [WK2][EFL] Ewk_View should provide API to set/get device pixel ratio 2012-07-05 18:48:16 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 1 cdumez cdumez gyuyoung.kim kenneth ryuan.choi tonikitoo webkit.review.bot oldest_to_newest 663379 0 cdumez 2012-07-05 01:07:27 -0700 There is currently no way to retrieve or set the device pixel ratio for the Ewk_View. We need to support it. 663414 1 150901 cdumez 2012-07-05 02:28:53 -0700 Created attachment 150901 Patch 663824 2 150901 kenneth 2012-07-05 18:40:30 -0700 Comment on attachment 150901 Patch Nice! 663825 3 150901 webkit.review.bot 2012-07-05 18:48:10 -0700 Comment on attachment 150901 Patch Clearing flags on attachment: 150901 Committed r121934: <http://trac.webkit.org/changeset/121934> 663826 4 webkit.review.bot 2012-07-05 18:48:16 -0700 All reviewed patches have been landed. Closing bug. 150901 2012-07-05 02:28:53 -0700 2012-07-05 18:48:10 -0700 Patch 90590_device_pixel_ratio.patch text/plain 4172 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlZWUyOTVjLi43OTNiZTY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTItMDctMDUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KIAorICAgICAgICBbV0syXVtFRkxdIEV3a19WaWV3IHNob3VsZCBwcm92aWRlIEFQSSB0 byBzZXQvZ2V0IGRldmljZSBwaXhlbCByYXRpbworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA1OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgQVBJIHRvIEV3a19WaWV3IHNvIHJldHJpZXZlIGFuZCBz ZXQgdGhlIGRldmljZQorICAgICAgICBwaXhlbCByYXRpby4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAgICAgKGV3a192aWV3X2RldmljZV9waXhlbF9y YXRpb19zZXQpOgorICAgICAgICAoZXdrX3ZpZXdfZGV2aWNlX3BpeGVsX3JhdGlvX2dldCk6Cisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaDoKKworMjAxMi0wNy0wNSAgQ2hy aXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgorCiAgICAgICAgIFtX SzJdW0VGTF0gRXdrX1ZpZXcgbmVlZHMgdG8gcmVwb3J0IG5ldyByZXNvdXJjZSByZXF1ZXN0cwog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA1NzcKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCmluZGV4IGJk ZjJlZmUuLjZhYWMxNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9l d2tfdmlldy5jcHAKQEAgLTU5Myw2ICs1OTMsMjMgQEAgZG91YmxlIGV3a192aWV3X2xvYWRfcHJv Z3Jlc3NfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3KQogICAgIHJldHVybiBXS1BhZ2VH ZXRFc3RpbWF0ZWRQcm9ncmVzcyh0b0FQSShwcml2LT5wYWdlQ2xpZW50LT5wYWdlKCkpKTsKIH0K IAorRWluYV9Cb29sIGV3a192aWV3X2RldmljZV9waXhlbF9yYXRpb19zZXQoRXZhc19PYmplY3Qq IGV3a1ZpZXcsIGZsb2F0IHJhdGlvKQoreworICAgIEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4o ZXdrVmlldywgc21hcnREYXRhLCBmYWxzZSk7CisgICAgRVdLX1ZJRVdfUFJJVl9HRVRfT1JfUkVU VVJOKHNtYXJ0RGF0YSwgcHJpdiwgZmFsc2UpOworCisgICAgcHJpdi0+cGFnZUNsaWVudC0+cGFn ZSgpLT5zZXRDdXN0b21EZXZpY2VTY2FsZUZhY3RvcihyYXRpbyk7CisgICAgcmV0dXJuIHRydWU7 Cit9CisKK2Zsb2F0IGV3a192aWV3X2RldmljZV9waXhlbF9yYXRpb19nZXQoY29uc3QgRXZhc19P YmplY3QqIGV3a1ZpZXcpCit7CisgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihld2tWaWV3 LCBzbWFydERhdGEsIDEpOworICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JFVFVSTihzbWFydERh dGEsIHByaXYsIDEpOworCisgICAgcmV0dXJuIHByaXYtPnBhZ2VDbGllbnQtPnBhZ2UoKS0+ZGV2 aWNlU2NhbGVGYWN0b3IoKTsKK30KKwogLyoqCiAgKiBAaW50ZXJuYWwKICAqIFJlcG9ydHMgbG9h ZCBwcm9ncmVzcyBjaGFuZ2VkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvZXdrX3ZpZXcuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3 a192aWV3LmgKaW5kZXggZGM1NDMwYy4uZmVjZmVjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oCkBAIC0yODMsNiArMjgzLDU0IEBAIEVBUEkgY29uc3Qg Y2hhciAqZXdrX3ZpZXdfdGl0bGVfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0ICpvKTsKICAqLwogRUFQ SSBkb3VibGUgZXdrX3ZpZXdfbG9hZF9wcm9ncmVzc19nZXQoY29uc3QgRXZhc19PYmplY3QgKm8p OwogCisvKioKKyAqIFF1ZXJpZXMgdGhlIHJhdGlvIGJldHdlZW4gdGhlIENTUyB1bml0cyBhbmQg ZGV2aWNlIHBpeGVscyB3aGVuIHRoZSBjb250ZW50IGlzIHVuc2NhbGVkLgorICoKKyAqIFdoZW4g ZGVzaWduaW5nIHRvdWNoLWZyaWVuZGx5IGNvbnRlbnRzLCBrbm93aW5nIHRoZSBhcHByb3hpbWF0 ZWQgdGFyZ2V0IHNpemUgb24gYSBkZXZpY2UKKyAqIGlzIGltcG9ydGFudCBmb3IgY29udGVudHMg cHJvdmlkZXJzIGluIG9yZGVyIHRvIGdldCB0aGUgaW50ZW50ZWQgbGF5b3V0IGFuZCBlbGVtZW50 CisgKiBzaXplcy4KKyAqCisgKiBBcyBtb3N0IGZpcnN0IGdlbmVyYXRpb24gdG91Y2ggZGV2aWNl cyBoYWQgYSBQUEkgb2YgYXBwcm94aW1hdGVseSAxNjAsIHRoaXMgYmVjYW1lIGEKKyAqIGRlLWZh Y3RvIHZhbHVlLCB3aGVuIHVzZWQgaW4gY29uanVuY3Rpb24gd2l0aCB0aGUgdmlld3BvcnQgbWV0 YSB0YWcuCisgKgorICogRGV2aWNlcyB3aXRoIGEgaGlnaGVyIFBQSSBsZWFybmluZyB0b3dhcmRz IDI0MCBvciAzMjAsIGFwcGxpZXMgYSBwcmUtc2NhbGluZyBvbiBhbGwKKyAqIGNvbnRlbnQsIG9m IGVpdGhlciAxLjUgb3IgMi4wLCBub3QgYWZmZWN0aW5nIHRoZSBDU1Mgc2NhbGUgb3IgcGluY2gg em9vbWluZy4KKyAqCisgKiBUaGlzIHZhbHVlIGNhbiBiZSBzZXQgdXNpbmcgdGhpcyBwcm9wZXJ0 eSBhbmQgaXQgaXMgZXhwb3NlZCB0byBDU1MgbWVkaWEgcXVlcmllcyB1c2luZworICogdGhlIC13 ZWJraXQtZGV2aWNlLXBpeGVsLXJhdGlvIHF1ZXJ5LgorICoKKyAqIEZvciBpbnN0YW5jZSwgaWYg eW91IHdhbnQgdG8gbG9hZCBhbiBpbWFnZSB3aXRob3V0IGhhdmluZyBpdCB1cHNjYWxlZCBvbiBh IHdlYiB2aWV3CisgKiB1c2luZyBhIGRldmljZSBwaXhlbCByYXRpbyBvZiAyLjAgaXQgY2FuIGJl IGRvbmUgYnkgbG9hZGluZyBhbiBpbWFnZSBvZiBzYXkgMTAweDEwMAorICogcGl4ZWxzIGJ1dCBz aG93aW5nIGl0IGF0IGhhbGYgdGhlIHNpemUuCisgKgorICogQG1lZGlhICgtd2Via2l0LW1pbi1k ZXZpY2UtcGl4ZWwtcmF0aW86IDEuNSkgeworICogICAgIC5pY29uIHsKKyAqICAgICAgICAgd2lk dGg6IDUwcHg7CisgKiAgICAgICAgIGhlaWdodDogNTBweDsKKyAqICAgICAgICAgdXJsOiAiL2lt YWdlcy9pY29uQDJ4LnBuZyI7IC8vIFRoaXMgaXMgYWN0dWFsbHkgYSAxMDB4MTAwIGltYWdlCisg KiAgICAgfQorICogfQorICoKKyAqIElmIHRoZSBhYm92ZSBpcyB1c2VkIG9uIGEgZGV2aWNlIHdp dGggZGV2aWNlIHBpeGVsIHJhdGlvIG9mIDEuNSwgaXQgd2lsbCBiZSBzY2FsZWQKKyAqIGRvd24g YnV0IHN0aWxsIHByb3ZpZGUgYSBiZXR0ZXIgbG9va2luZyBpbWFnZS4KKyAqCisgKiBAcGFyYW0g byB2aWV3IG9iamVjdCB0byBnZXQgZGV2aWNlIHBpeGVsIHJhdGlvCisgKgorICogQHJldHVybiB0 aGUgcmF0aW8gYmV0d2VlbiB0aGUgQ1NTIHVuaXRzIGFuZCBkZXZpY2UgcGl4ZWxzLgorICovCitF QVBJIGZsb2F0IGV3a192aWV3X2RldmljZV9waXhlbF9yYXRpb19nZXQoY29uc3QgRXZhc19PYmpl Y3QgKm8pOworCisvKioKKyAqIFNldHMgdGhlIHJhdGlvIGJldHdlZW4gdGhlIENTUyB1bml0cyBh bmQgZGV2aWNlIHBpeGVscyB3aGVuIHRoZSBjb250ZW50IGlzIHVuc2NhbGVkLgorICoKKyAqIEBw YXJhbSBvIHZpZXcgb2JqZWN0IHRvIHNldCBkZXZpY2UgcGl4ZWwgcmF0aW8KKyAqCisgKiBAcmV0 dXJuIEBjIEVJTkFfVFJVRSBpZiB0aGUgZGV2aWNlIHBpeGVsIHJhdGlvIHdhcyBzZXQsIEBjIEVJ TkFfRkFMU0Ugb3RoZXJ3aXNlCisgKgorICogQHNlZSBld2tfdmlld19kZXZpY2VfcGl4ZWxfcmF0 aW9fZ2V0KCkKKyAqLworRUFQSSBFaW5hX0Jvb2wgZXdrX3ZpZXdfZGV2aWNlX3BpeGVsX3JhdGlv X3NldChFdmFzX09iamVjdCAqbywgZmxvYXQgcmF0aW8pOworCiAjaWZkZWYgX19jcGx1c3BsdXMK IH0KICNlbmRpZgo=